Skip to contentSkip to conversation

infiniband: calling PTR_ERR() on wrong variable in create_file()

PATCH Applied Dan Carpenter 3 participants 3 messages Jan 26, 2012 – Jan 27, 2012 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 infiniband: calling PTR_ERR() on wrong variable in create_file()

"dentry" is a valid pointer. "*dentry" was intended.

drivers/infiniband/hw/ipath/ipath_fs.c +1 -1
index b7d4216..a4de9d5 100644
@@ -89,7 +89,7 @@ static int create_file(const char *name, umode_t mode,
 		error = ipathfs_mknod(parent->d_inode, *dentry,
 				      mode, fops, data);
 	else
-		error = PTR_ERR(dentry);
+		error = PTR_ERR(*dentry);
 	mutex_unlock(&parent->d_inode->i_mutex);
 
 	return error;

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 5 lines

From: Dan Carpenter [mailto:[email protected]]
Subject: [patch] infiniband: calling PTR_ERR() on wrong variable in

I double checked the qib driver, and the equivalent code is ok there.

Thanks for the patch!

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

A message that is not in the archive (sent off-list or not yet received): 35AAF1E4A771E142979F27B51793A4888885B23834-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org