Skip to contentSkip to conversation

GPMC: fix device size setup

PATCH New Yegor Yefremov 2 participants 2 messages Jan 23, 2012 – Jan 26, 2012

Subsystems (5)
Arm (32-bit) Arm sub-architectures OMAP2+ support OMAP power management support +1 more subsystems
lore
Share & tools
lore

Yegor Yefremov

author
#0 lore raw

PATCH v2 1/1 GPMC: fix device size setup

following statement can only change device size from 8-bit(0) to 16-bit(1), but not vice versa:

regval |= GPMC_CONFIG1_DEVICESIZE(wval);

so as this field has 1 reserved bit, that could be used in future, just clear both bits and then OR with the desired value

Signed-off-by Yegor Yefremov <[email protected]>

---
v2: cc linux-arm-kernel mailing list

 arch/arm/mach-omap2/gpmc.c |    6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/mach-omap2/gpmc.c +6 -0
Index: b/arch/arm/mach-omap2/gpmc.c
===================================================================
@@ -528,7 +528,13 @@
 
 	case GPMC_CONFIG_DEV_SIZE:
 		regval  = gpmc_cs_read_reg(cs, GPMC_CS_CONFIG1);
+
+		/* clear 2 target bits */
+		regval &= ~GPMC_CONFIG1_DEVICESIZE(3);
+
+		/* set the proper value */
 		regval |= GPMC_CONFIG1_DEVICESIZE(wval);
+
 		gpmc_cs_write_reg(cs, GPMC_CS_CONFIG1, regval);
 		break;
maintainer
#1 lore raw

PATCH v2 1/1 GPMC: fix device size setup

Quoted 7 lines · Yegor Yefremov

following statement can only change device size from 8-bit(0) to 16-bit(1), but not vice versa:

regval |= GPMC_CONFIG1_DEVICESIZE(wval);

so as this field has 1 reserved bit, that could be used in future, just clear both bits and then OR with the desired value

Thanks applying into fixes.

Tony