Skip to contentSkip to conversation

S3C24XX DMA resume regression fix

PATCH Superseded Gusakov Andrey 3 participants 3 messages Jan 20, 2012 – Jan 31, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Gusakov Andrey

author
#0 lore raw

PATCH v2 1/1 S3C24XX DMA resume regression fix

In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b (Use struct syscore_ops for "core" power management) suspend/resume hooks for each DMA channels were replaced with hooks that suspend/resume all channels. s3c2410_dma_suspend suspends channels from 0 to dma_channels. s3c2410_dma_resume resumes channels in reverse order. So pointer should be decremented insted of being incremented.

Signed-off-by Gusakov Andrey <[email protected]>
---
 arch/arm/plat-s3c24xx/dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

v2: updated commit message with original commit summary

arch/arm/plat-s3c24xx/dma.c +1 -1
index 57abec9..16510d5 100644
@@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void)
 	struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1;
 	int channel;
 
-	for (channel = dma_channels - 1; channel >= 0; cp++, channel--)
+	for (channel = dma_channels - 1; channel >= 0; cp--, channel--)
 		s3c2410_dma_resume_chan(cp);
 }
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH v2 1/1 S3C24XX DMA resume regression fix

Quoted 7 lines · Gusakov Andrey

In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b (Use struct syscore_ops for "core" power management) suspend/resume hooks for each DMA channels were replaced with hooks that suspend/resume all channels. s3c2410_dma_suspend suspends channels from 0 to dma_channels. s3c2410_dma_resume resumes channels in reverse order. So pointer should be decremented insted of being incremented.

Any news regarding this patch?

Quoted 8 lines
Signed-off-by Gusakov Andrey <[email protected]>
---
 arch/arm/plat-s3c24xx/dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

v2: updated commit message with original commit summary

All the best,
S.

#2 lore raw

PATCH v2 1/1 S3C24XX DMA resume regression fix

Quoted 3 lines · Sergey Lapin
Quoted 1 line · Gusakov Andrey

In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b

Just the first 12 hex digits of the commit id is enough now as Linus said?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Quoted 18 lines
Quoted 6 lines

(Use struct syscore_ops for "core" power management) suspend/resume hooks for each DMA channels were replaced with hooks that suspend/resume all channels. s3c2410_dma_suspend suspends channels from 0 to dma_channels. s3c2410_dma_resume resumes channels in reverse order. So pointer should be decremented insted of being incremented.

Any news regarding this patch?

Quoted 8 lines
Signed-off-by Gusakov Andrey <[email protected]>
---
 arch/arm/plat-s3c24xx/dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

v2: updated commit message with original commit summary

All the best,
S.