Skip to contentSkip to conversation

intelfb: remove some dead code

PATCH Applied Dan Carpenter 2 participants 2 messages Jan 27, 2012 – Jan 30, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 intelfb: remove some dead code

The goto on the line before means the return is unreachable. The goto also returns -ENODEV so no changes are needed there.

---
v2: fixed a typo in the commit message

drivers/video/intelfb/intelfbdrv.c +0 -1
index c6afa33..02fd226 100644
@@ -529,7 +529,6 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
 	if (fb_alloc_cmap(&info->cmap, 256, 1) < 0) {
 		ERR_MSG("Could not allocate cmap for intelfb_info.\n");
 		goto err_out_cmap;
-		return -ENODEV;
 	}
 
 	dinfo = info->par;
#1 lore raw
Quoted 4 lines · Dan Carpenter

The goto on the line before means the return is unreachable. The goto also returns -ENODEV so no changes are needed there.

Applied.

Thanks,

Florian Tobias Schandinat

Quoted 16 lines

---
v2: fixed a typo in the commit message

drivers/video/intelfb/intelfbdrv.c +0 -1
index c6afa33..02fd226 100644
@@ -529,7 +529,6 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
 	if (fb_alloc_cmap(&info->cmap, 256, 1) < 0) {
 		ERR_MSG("Could not allocate cmap for intelfb_info.\n");
 		goto err_out_cmap;
-		return -ENODEV;
 	}
 
 	dinfo = info->par;