(RESEND #2) i2c: prevent spurious interrupt
Subsystems (3)
PATCH 1/1 (RESEND #2) i2c: prevent spurious interrupt
From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/[email protected]>
Don't call i2c_enable on resume because it causes a spurious interrupt.
---
drivers/i2c/busses/i2c-designware-pcidrv.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/i2c/busses/i2c-designware-pcidrv.c +0 -1
@@ -182,7 +182,6 @@ static int i2c_dw_pci_resume(struct device *dev)pci_restore_state (pdev);i2c_dw_init (i2c); -i2c_dw_enable (i2c);return 0 ; }
A message that is not in the archive (sent off-list or not yet received): 20120126161319.22798.6071.stgit-Z/[email protected]
Hi Alan,
Quoted 5 lines · Alan Cox
From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/[email protected]>
Don't call
i2c_enableon resume because it causes a spurious interrupt.
Quoted 7 lines
Signed-off-by Alan Cox <alan-VuQAYsv1563Yd54FQh9/[email protected]>---
drivers/i2c/busses/i2c-designware-pcidrv.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
Please come up with a decent subject line for this patch. Currently it sounds very generic so Ben will never look at it, assuming I will take care of it. But it is actually driver-specific, and that's a driver Ben is responsible for, so I won't pick it.
Quoted 12 lines
drivers/i2c/busses/i2c-designware-pcidrv.c +0
-1@@ -182,7 +182,6 @@ static int i2c_dw_pci_resume(struct device *dev)pci_restore_state (pdev);i2c_dw_init (i2c); -i2c_dw_enable (i2c);return 0 ; }
Signature · 1 line
Jean Delvare
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 13 lines · Jean Delvare
Hi Alan,
Quoted 10 lines · Alan Cox
From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/[email protected]>
Don't call
i2c_enableon resume because it causes a spurious interrupt.Signed-off-by Alan Cox <alan-VuQAYsv1563Yd54FQh9/[email protected]>---
Quoted 6 lines
Quoted 2 lines
drivers/i2c/busses/i2c-designware-pcidrv.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)Please come up with a decent subject line for this patch. Currently it sounds very generic so Ben will never look at it, assuming I will take care of it. But it is actually driver-specific, and that's a driver Ben
I agreee, the subject needs to be more specific to the driver it is modifying. I would accept i2c-dw or i2c-designware as the start of the subject.
Jean, thanks for clairfying ownership,
Signature · 3 lines
Ben Dooks, [email protected], http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear.
Quoted 9 lines · Alan Cox
From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/[email protected]>
Don't call
i2c_enableon resume because it causes a spurious interrupt.Signed-off-by Alan Cox <alan-VuQAYsv1563Yd54FQh9/[email protected]>---
No-one seems to have decided to fix the title of this patch. If there's nothing received before the end of the week then I will decide to arbitrarily do something about it.
Signature · 1 line
Ben
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 6 lines · On Mon, 13 Feb 2012 23:28:57 +0000 Ben Dooks…
Quoted 5 lines · Alan Cox
From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/[email protected]>
Don't call
i2c_enableon resume because it causes a spurious interrupt.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Alan Cox <alan-VuQAYsv1563Yd54FQh9/[email protected]>---
No-one seems to have decided to fix the title of this patch.
What wants fixing ?