Skip to contentSkip to conversation

gma500: Fix leak of uncached page

PATCH In review Alan Cox 2 participants 4 messages Feb 2, 2012 – Feb 3, 2012

Subsystems (3)
DRM drivers DRM misc DRM drivers for GMA500 (Poulsbo, Moorestown and derivative chipsets)
lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/2 gma500: Fix leak of uncached page

(Resending in two bits to avoid stgit breakage)

From: Alan Cox <[email protected]>

This was reported a long time ago (and I apologize to whoever it was that reported it as I've lost the original report).

Signed-off-by Alan Cox <[email protected]>

---

 drivers/gpu/drm/gma500/psb_drv.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/gpu/drm/gma500/psb_drv.c +1 -0
index f14768f..653f439 100644
@@ -239,6 +239,7 @@ static int psb_driver_unload(struct drm_device *dev)
 		}
 		psb_gtt_takedown(dev);
 		if (dev_priv->scratch_page) {
+			set_pages_wb(dev_priv->scratch_page, 1);
 			__free_page(dev_priv->scratch_page);
 			dev_priv->scratch_page = NULL;
 		}
author
#1 lore raw

PATCH 2/2 gma500: plug in more of the gamma functionality

From: Alan Cox <[email protected]>

Signed-off-by Alan Cox <[email protected]>

---

 drivers/gpu/drm/gma500/framebuffer.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
drivers/gpu/drm/gma500/framebuffer.c +10 -0
index 791c0ef..97d5b80 100644
@@ -560,11 +560,21 @@ static struct drm_framebuffer *psb_user_framebuffer_create
 static void psbfb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green,
 							u16 blue, int regno)
 {
+	struct psb_intel_crtc *intel_crtc = to_psb_intel_crtc(crtc);
+
+	intel_crtc->lut_r[regno] = red >> 8;
+	intel_crtc->lut_g[regno] = green >> 8;
+	intel_crtc->lut_b[regno] = blue >> 8;
 }
 
 static void psbfb_gamma_get(struct drm_crtc *crtc, u16 *red,
 					u16 *green, u16 *blue, int regno)
 {
+	struct psb_intel_crtc *intel_crtc = to_psb_intel_crtc(crtc);
+
+	*red = intel_crtc->lut_r[regno] << 8;
+	*green = intel_crtc->lut_g[regno] << 8;
+	*blue = intel_crtc->lut_b[regno] << 8;
 }
 
 static int psbfb_probe(struct drm_fb_helper *helper,
maintainer
#2 lore raw
In reply to Alan Cox
Quoted 1 line · Alan Cox

(Resending in two bits to avoid stgit breakage)

Hi Alan,

Any of these important enough for -fixes? or -next good enough?

Dave.

author
#3 lore raw
Quoted 6 lines · On Fri, 3 Feb 2012 10:15:41 +0000 Dave Airlie <[email protected]> wrote:
Quoted 1 line · Alan Cox

(Resending in two bits to avoid stgit breakage)

Hi Alan,

Any of these important enough for -fixes? or -next good enough?

The cache one maybe the others can wait. Both though are minor things that only occur if you build it as module and unload it - which is pretty much never going to happen.