namespace conflict - struct node
PATCH 1/1 namespace conflict - struct node
include/linux/node.h vs. drivers/md/persistent-data; IMO the former should be the one to keep name, since it's less local.
Signed-off-by Al Viro <[email protected]>
drivers/md/persistent-data/dm-btree-internal.h +8 -8
@@ -36,13 +36,13 @@ struct node_header {__le32 padding; } __packed; -struct node { +struct btree_node {struct node_header header;__le64 keys[0 ]; } __packed; -void inc_children (struct dm_transaction_manager *tm,struct node *n, +void inc_children (struct dm_transaction_manager *tm,struct btree_node *n,struct dm_btree_value_type *vt);int new_block (struct dm_btree_info *info,struct dm_block **result);
@@ -64,7 +64,7 @@ struct ro_spine {void init_ro_spine (struct ro_spine *s,struct dm_btree_info *info);int exit_ro_spine (struct ro_spine *s);int ro_step (struct ro_spine *s,dm_block_t new_child); -struct node *ro_node (struct ro_spine *s); +struct btree_node *ro_node (struct ro_spine *s);struct shadow_spine {struct dm_btree_info *info;
@@ -98,12 +98,12 @@ int shadow_root(struct shadow_spine *s);/* * Some inlines. */ -static inline __le64 *key_ptr (struct node *n,uint32_t index) +static inline __le64 *key_ptr (struct btree_node *n,uint32_t index) {return n->keys + index; } -static inline void *value_base (struct node *n) +static inline void *value_base (struct btree_node *n) {return &n->keys[le32_to_cpu (n->header.max_entries)]; }
@@ -111,7 +111,7 @@ static inline void *value_base(struct node *n)/* * FIXME: Now that value size is stored in node we don't need the third parm. */ -static inline void *value_ptr (struct node *n,uint32_t index,size_t value_size) +static inline void *value_ptr (struct btree_node *n,uint32_t index,size_t value_size) {BUG_ON (value_size !=le32_to_cpu (n->header.value_size));return value_base (n) + (value_size * index);
@@ -120,7 +120,7 @@ static inline void *value_ptr(struct node *n, uint32_t index, size_t value_size)/* * Assumes the values are suitably-aligned and converts to core format. */ -static inline uint64_t value64 (struct node *n,uint32_t index) +static inline uint64_t value64 (struct btree_node *n,uint32_t index) {__le64 *values_le =value_base (n);
@@ -130,7 +130,7 @@ static inline uint64_t value64(struct node *n, uint32_t index)/* * Searching for a key within a single node. */ -int lower_bound (struct node *n,uint64_t key); +int lower_bound (struct btree_node *n,uint64_t key);extern struct dm_block_validator btree_node_validator;
drivers/md/persistent-data/dm-btree-remove.c +22 -22
148 lines not on this page · raw message
drivers/md/persistent-data/dm-btree-spine.c +3 -3
@@ -23,7 +23,7 @@ static void node_prepare_for_write(struct dm_block_validator *v, struct dm_block *b, size_t block_size) { -struct node *n =dm_block_data (b); +struct btree_node *n =dm_block_data (b);struct node_header *h = &n->header; h->blocknr =cpu_to_le64 (dm_block_location (b));
@@ -38,7 +38,7 @@ static int node_check(struct dm_block_validator *v, struct dm_block *b, size_t block_size) { -struct node *n =dm_block_data (b); +struct btree_node *n =dm_block_data (b);struct node_header *h = &n->header;size_t value_size;__le32 csum_disk;
@@ -164,7 +164,7 @@ int ro_step(struct ro_spine *s, dm_block_t new_child)return r; } -struct node *ro_node (struct ro_spine *s) +struct btree_node *ro_node (struct ro_spine *s) {struct dm_block *block;
drivers/md/persistent-data/dm-btree.c +11 -11
@@ -38,7 +38,7 @@ static void array_insert(void *base, size_t elt_size, unsigned nr_elts,/*----------------------------------------------------------------*/ /* makes the assumption that no two keys are the same. */ -static int bsearch (struct node *n,uint64_t key,int want_hi) +static int bsearch (struct btree_node *n,uint64_t key,int want_hi) {int lo =-1 , hi =le32_to_cpu (n->header.nr_entries);
@@ -58,12 +58,12 @@ static int bsearch(struct node *n, uint64_t key, int want_hi)return want_hi ? hi : lo; } -int lower_bound (struct node *n,uint64_t key) +int lower_bound (struct btree_node *n,uint64_t key) {return bsearch (n, key,0 ); } -void inc_children (struct dm_transaction_manager *tm,struct node *n, +void inc_children (struct dm_transaction_manager *tm,struct btree_node *n,struct dm_btree_value_type *vt) {unsigned i;
@@ -78,7 +78,7 @@ void inc_children(struct dm_transaction_manager *tm, struct node *n, value_ptr(n, i, vt->size)); } -static int insert_at (size_t value_size,struct node *node,unsigned index, +static int insert_at (size_t value_size,struct btree_node *node,unsigned index,uint64_t key,void *value)__dm_written_to_disk (value) {
@@ -123,7 +123,7 @@ int dm_btree_empty(struct dm_btree_info *info, dm_block_t *root) {int r;struct dm_block *b; -struct node *n; +struct btree_node *n;size_t block_size;uint32_t max_entries;
@@ -155,7 +155,7 @@ EXPORT_SYMBOL_GPL(dm_btree_empty);#define MAX_SPINE_DEPTH 64struct frame {struct dm_block *b; -struct node *n; +struct btree_node *n;unsigned level;unsigned nr_children;unsigned current_child;
@@ -296,7 +296,7 @@ EXPORT_SYMBOL_GPL(dm_btree_del);/*----------------------------------------------------------------*/ static int btree_lookup_raw (struct ro_spine *s,dm_block_t block,uint64_t key, -int (*search_fn)(struct node *,uint64_t ), +int (*search_fn)(struct btree_node *,uint64_t ),uint64_t *result_key,void *v,size_t value_size) {int i, r;
@@ -407,7 +407,7 @@ static int btree_split_sibling(struct shadow_spine *s, dm_block_t root,size_t size;unsigned nr_left, nr_right;struct dm_block *left, *right, *parent; -struct node *ln, *rn, *pn; +struct btree_node *ln, *rn, *pn;__le64 location; left =shadow_current (s);
@@ -492,7 +492,7 @@ static int btree_split_beneath(struct shadow_spine *s, uint64_t key)size_t size;unsigned nr_left, nr_right;struct dm_block *left, *right, *new_parent; -struct node *pn, *ln, *rn; +struct btree_node *pn, *ln, *rn;__le64 val; new_parent =shadow_current (s);
@@ -577,7 +577,7 @@ static int btree_insert_raw(struct shadow_spine *s, dm_block_t root, uint64_t key, unsigned *index) { int r, i = *index, top = 1; -struct node *node; +struct btree_node *node;for (;;) { r =shadow_step (s, root, vt);
@@ -644,7 +644,7 @@ static int insert(struct dm_btree_info *info, dm_block_t root,unsigned level, index =-1 , last_level = info->levels -1 ;dm_block_t block = root;struct shadow_spine spine; -struct node *n; +struct btree_node *n;struct dm_btree_value_type le64_type; le64_type.context =NULL ;