Skip to contentSkip to conversation

move page-types.c from Documentation to tools/vm

PATCH In review Dave Young 2 participants 2 messages Feb 5, 2012 – Feb 6, 2012

Subsystems (2)
Memory management Documentation
lore
Share & tools
lore

Dave Young

author
#0 lore raw

PATCH 1/3 move page-types.c from Documentation to tools/vm

tools/ is the better place for vm tools which are used by many people. Moving them to tools also make them open to more users instead of hide in Documentation folder.

This patch move page-types.c to tools/vm/page-types.c
Also add Makefile in tools/vm and fix two coding style problems of below:
a. change const arrary to 'const char * const'
b. change a space to tab for indent

Signed-off-by Dave Young <[email protected]>
---
 Documentation/vm/Makefile                |    2 +-
 tools/vm/Makefile                        |   11 +++++++++++
 {Documentation => tools}/vm/page-types.c |    6 +++---
 3 files changed, 15 insertions(+), 4 deletions(-)
 create mode 100644 tools/vm/Makefile
 rename {Documentation => tools}/vm/page-types.c (99%)
Documentation/vm/Makefile +1 -1
index 3fa4d06..e538864 100644
@@ -2,7 +2,7 @@
 obj- := dummy.o
 
 # List of programs to build
-hostprogs-y := page-types hugepage-mmap hugepage-shm map_hugetlb
+hostprogs-y := hugepage-mmap hugepage-shm map_hugetlb
 
 # Tell kbuild to always build the programs
 always := $(hostprogs-y)
tools/vm/Makefile new file +11 -0
new file mode 100644
index 0000000..3823d4b
@@ -0,0 +1,11 @@
+# Makefile for vm tools
+
+CC = $(CROSS_COMPILE)gcc
+CFLAGS = -Wall -Wextra
+
+all: page-types
+%: %.c
+	$(CC) $(CFLAGS) -o $@ $^
+
+clean:
+	$(RM) page-types
tools/vm/page-types.c renamed from Documentation/vm/page-types.c +3 -3
similarity index 99%
rename from Documentation/vm/page-types.c
rename to tools/vm/page-types.c
index 7445caa..89dd173 100644
@@ -123,7 +123,7 @@
 #define BIT(name)		(1ULL << KPF_##name)
 #define BITS_COMPOUND		(BIT(COMPOUND_HEAD) | BIT(COMPOUND_TAIL))
 
-static const char *page_flag_names[] = {
+static const char * const page_flag_names[] = {
 	[KPF_LOCKED]		= "L:locked",
 	[KPF_ERROR]		= "E:error",
 	[KPF_REFERENCED]	= "R:referenced",

@@ -164,7 +164,7 @@ static const char *page_flag_names[] = {
 };
 
 
-static const char *debugfs_known_mountpoints[] = {
+static const char * const debugfs_known_mountpoints[] = {
 	"/sys/kernel/debug",
 	"/debug",
 	0,

@@ -213,7 +213,7 @@ static int		hwpoison_forget_fd;
 
 static unsigned long	total_pages;
 static unsigned long	nr_pages[HASH_SIZE];
-static uint64_t 	page_flags[HASH_SIZE];
+static uint64_t		page_flags[HASH_SIZE];
 
 
 /*
Signature · 8 lines
1.7.4.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Acked-by on v1 1/3
#1 lore raw
Quoted 10 lines · Dave Young

tools/ is the better place for vm tools which are used by many people. Moving them to tools also make them open to more users instead of hide in Documentation folder.

This patch move page-types.c to tools/vm/page-types.c
Also add Makefile in tools/vm and fix two coding style problems of below:
a. change const arrary to 'const char * const'
b. change a space to tab for indent

Signed-off-by Dave Young <[email protected]>
Acked-by Wu Fengguang <[email protected]>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>