Skip to contentSkip to conversation

staging: android/ram_console: Don't build on arches w/o ioremap

PATCH In review Anton Vorontsov 2 participants 2 messages Feb 7, 2012 – Apr 8, 2012 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: android/ram_console: Don't build on arches w/o ioremap

This patch fixes UML build:

CC drivers/staging/android/ram_console.o
drivers/staging/android/ram_console.c: In function 'ram_console_driver_probe':
drivers/staging/android/ram_console.c:358:2: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[3]: *** [drivers/staging/android/ram_console.o] Error 1

---
 drivers/staging/android/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/staging/android/Kconfig +1 -0
index becf711..2054ccb 100644
@@ -27,6 +27,7 @@ config ANDROID_LOGGER
 
 config ANDROID_RAM_CONSOLE
 	bool "Android RAM buffer console"
+	depends on !S390 && !UML
 	default n
 
 config ANDROID_RAM_CONSOLE_ENABLE_VERBOSE
Signature · 1 line
1.7.7.6
#1 lore raw
Quoted 21 lines · Anton Vorontsov

This patch fixes UML build:

   CC      drivers/staging/android/ram_console.o drivers/staging/android/ram_console.c: In function 'ram_console_driver_probe':
 drivers/staging/android/ram_console.c:358:2: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration]
 cc1: some warnings being treated as errors
 make[3]: *** [drivers/staging/android/ram_console.o] Error 1

---
 drivers/staging/android/Kconfig |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/staging/android/Kconfig +0 -0
index becf711..2054ccb 100644
@@ -27,6 +27,7 @@ config ANDROID_LOGGER
 
Quoted 3 lines

 config ANDROID_RAM_CONSOLE
       bool "Android RAM buffer console"
+       depends on !S390 && !UML

Shouldn't that be "depends on HAS_IOMEM" instead?
I guess it also break on tile, which is the third NO_IOMEM arch?

Quoted 1 line

       default n

Superfluous, "n" is the default.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds