Skip to contentSkip to conversation

MX27: add missing get_tbclk()

PATCH New Stefano Babic 2 participants 4 messages Feb 7, 2012 – Feb 8, 2012 Arm (32-bit)

lore
Share & tools
lore

Stefano Babic

author
#0 lore raw

PATCH 1/1 MX27: add missing get_tbclk()

Signed-off-by Stefano Babic <[email protected]>
---
 arch/arm/cpu/arm926ejs/mx27/timer.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
arch/arm/cpu/arm926ejs/mx27/timer.c +8 -0
index 5af9359..226c0a5 100644
@@ -171,3 +171,11 @@ void __udelay(unsigned long usec)
 	while (get_ticks() < tmp)	/* loop till event */
 		 /*NOP*/;
 }
+
+ulong get_tbclk(void)
+{
+	ulong tbclk;
+
+	tbclk = CONFIG_MX27_CLK32;
+	return tbclk;
+}
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 MX27: add missing get_tbclk()

Quoted 11 lines
Signed-off-by Stefano Babic <[email protected]>
---
 arch/arm/cpu/arm926ejs/mx27/timer.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/arch/arm/cpu/arm926ejs/mx27/timer.c index 5af9359..226c0a5 100644

arch/arm/cpu/arm926ejs/mx27/timer.c +0 -0
@@ -171,3 +171,11 @@ void __udelay(unsigned long usec)
 	while (get_ticks() < tmp)	/* loop till event */

arch/arm/cpu/arm926ejs/mx27/timer.c void __udelay(unsigned long usec) · line 181

Quoted 10 lines
arch/arm/cpu/arm926ejs/mx27/timer.c +8 -0
 		 /*NOP*/;
 }
+
+ulong get_tbclk(void)
+{
+	ulong tbclk;
+
+	tbclk = CONFIG_MX27_CLK32;
+	return tbclk;
+}

Why not simply ... return CONFIG... ?
M

author
#2 lore raw

PATCH 1/1 MX27: add missing get_tbclk()

Quoted 15 lines · Marek Vasut
Quoted 15 lines
Signed-off-by Stefano Babic <[email protected]>
---
 arch/arm/cpu/arm926ejs/mx27/timer.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/arch/arm/cpu/arm926ejs/mx27/timer.c index 5af9359..226c0a5 100644

arch/arm/cpu/arm926ejs/mx27/timer.c +2 -0
@@ -171,3 +171,11 @@ void __udelay(unsigned long usec)
 	while (get_ticks() < tmp)	/* loop till event */
 		 /*NOP*/;
 }
+
+ulong get_tbclk(void)
Quoted 8 lines

arch/arm/cpu/arm926ejs/mx27/timer.c void __udelay(unsigned long usec) · line 181

Quoted 6 lines
arch/arm/cpu/arm926ejs/mx27/timer.c +6 -0
+{
+	ulong tbclk;
+
+	tbclk = CONFIG_MX27_CLK32;
+	return tbclk;
+}

Why not simply ... return CONFIG... ?

Yes, right, as I already did for the other i.MX....

Fixed in V2

Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
author
#3 lore raw

PATCH v2 1/1 MX27: add missing get_tbclk()

In reply to Stefano Babic
Signed-off-by Stefano Babic <[email protected]>

---
Changes since V1:
- return directly CONFIG_MX27_CLK32 instead using temporary variable (Marek Vasut)

 arch/arm/cpu/arm926ejs/mx27/timer.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
arch/arm/cpu/arm926ejs/mx27/timer.c +5 -0
index 5af9359..a5dd684 100644
@@ -171,3 +171,8 @@ void __udelay(unsigned long usec)
 	while (get_ticks() < tmp)	/* loop till event */
 		 /*NOP*/;
 }
+
+ulong get_tbclk(void)
+{
+	return CONFIG_MX27_CLK32;
+}
Signature · 1 line
1.7.5.4