Skip to contentSkip to conversation

xfstests: 068: run fsstress in read/write mode

PATCH In review Eric Sandeen 2 participants 2 messages Feb 7, 2012 – Feb 8, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: 068: run fsstress in read/write mode

Jan Kara was testing filesystem freeze, and was consistently locking up, although my tests of 068 were passing. He pointed out that he was running in read/write mode, and it was atime updates causing the trouble. Sure enough, dropping "-w" from fsstress locked me up too. Change this so we get better (and more realistic) coverage.

---

068 +3 -2
index 6f08f18..b15409e 100755
@@ -79,8 +79,9 @@ touch $tmp.running
     nops=200
     while [ -f "$tmp.running" ]
       do
-      #	-w ensures that the only ops are ones which cause write I/O
-      $FSSTRESS_PROG -d $STRESS_DIR -w -p $procs -n $nops $FSSTRESS_AVOID \
+      # We do both read & write IO - not only is this more realistic,
+      # but it also potentially tests atime updates
+      $FSSTRESS_PROG -d $STRESS_DIR -p $procs -n $nops $FSSTRESS_AVOID \
 	  > /dev/null 2>&1
     done
 

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Eric Sandeen

Jan Kara was testing filesystem freeze, and was consistently locking up, although my tests of 068 were passing. He pointed out that he was running in read/write mode, and it was atime updates causing the trouble. Sure enough, dropping "-w" from fsstress locked me up too. Change this so we get better (and more realistic) coverage.

Good idea.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs