Skip to contentSkip to conversation

netxen_nic: signedness bug in netxen_md_entry_err_chk()

PATCH Applied Dan Carpenter 3 participants 3 messages Feb 8, 2012 – Feb 9, 2012

Subsystems (4)
Networking Network drivers Kernel janitors Netxen (1/10) GbE support
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 netxen_nic: signedness bug in netxen_md_entry_err_chk()

"esize" should be signed because it can be negative here. For example, when we call it in netxen_parse_md_template(), it could be -1 from the return value of netxen_md_L2Cache().

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c +1 -1
index 0a81228..6f37470 100644
@@ -2354,7 +2354,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter,
 */
 
 static int netxen_md_entry_err_chk(struct netxen_adapter *adapter,
-				struct netxen_minidump_entry *entry, u32 esize)
+				struct netxen_minidump_entry *entry, int esize)
 {
 	if (esize < 0) {
 		entry->hdr.driver_flags |= NX_DUMP_SKIP;
maintainer Applied
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Wed, 8 Feb 2012 12:23:36 +0300

Quoted 5 lines

"esize" should be signed because it can be negative here. For example, when we call it in netxen_parse_md_template(), it could be -1 from the return value of netxen_md_L2Cache().

Signed-off-by Dan Carpenter <[email protected]>

Applied.

#2 lore raw
In reply to Dan Carpenter

Thanks Dan for fixing this.

Rajesh
________________________________________
From: Dan Carpenter [[email protected]]
Sent: Wednesday, February 08, 2012 2:53 PM
To: Sony Chacko
Cc: Rajesh Borundia; netdev; [email protected]
Subject: [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk()

"esize" should be signed because it can be negative here. For example, when we call it in netxen_parse_md_template(), it could be -1 from the return value of netxen_md_L2Cache().

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c +1 -1
index 0a81228..6f37470 100644
@@ -2354,7 +2354,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter,
 */
 
 static int netxen_md_entry_err_chk(struct netxen_adapter *adapter,
-                               struct netxen_minidump_entry *entry, u32 esize)
+                               struct netxen_minidump_entry *entry, int esize)
 {
        if (esize < 0) {
                entry->hdr.driver_flags |= NX_DUMP_SKIP;