c2port: class_create() returns an ERR_PTR

PATCH New Dan Carpenter 1 participant 1 message Feb 8, 2012

Subsystems (2)

Kernel janitors Char and misc drivers

lore

Share & tools

lore

Dan Carpenter

author

2012-02-08 09:26 UTC #0 lore raw

PATCH 1/1 c2port: class_create() returns an ERR_PTR

class_create() doesn't return a NULL, it only returns ERR_PTRs.

Signed-off-by Dan Carpenter <[email protected]>

drivers/misc/c2port/core.c +2 -2

index 19fc7c1..f428d86 100644
@@ -984,9 +984,9 @@ static int __init c2port_init(void)
 		" - (C) 2007 Rodolfo Giometti\n");
 
 	c2port_class = class_create(THIS_MODULE, "c2port");
-	if (!c2port_class) {
+	if (IS_ERR(c2port_class)) {
 		printk(KERN_ERR "c2port: failed to allocate class\n");
-		return -ENOMEM;
+		return PTR_ERR(c2port_class);
 	}
 	c2port_class->dev_attrs = c2port_attrs;