Skip to contentSkip to conversation

+ proc-clean-up-proc-pid-environ-handling.patch added to -mm tree

DISCUSSION Oleg Nesterov 2 participants 2 messages Feb 8, 2012 – Feb 10, 2012

lore
Share & tools
lore
#0 lore raw
Quoted 5 lines

From: Cong Wang <[email protected]>
Subject: proc: clean up /proc/<pid>/environ handling

Similar to e268337dfe2 ("proc: clean up and fix /proc/<pid>/mem handling"),

and has the same problem,

Quoted 2 lines

move the check of permission to open(), this will simplify read() code.

but allows to kill the system trivially.

Please look at 6d08f2c7139790c268820a2e590795cb8333181a "proc: make sure mem_open() doesn't pin the target's memory"

Oleg.

#1 lore raw
Quoted 8 lines · Oleg Nesterov
Quoted 5 lines

From: Cong Wang<[email protected]>
Subject: proc: clean up /proc/<pid>/environ handling

Similar to e268337dfe2 ("proc: clean up and fix /proc/<pid>/mem handling"),

and has the same problem,

Quoted 8 lines
Quoted 2 lines

move the check of permission to open(), this will simplify read() code.

but allows to kill the system trivially.

Please look at 6d08f2c7139790c268820a2e590795cb8333181a "proc: make sure mem_open() doesn't pin the target's memory"

Thanks, I wasn't aware of that commit. I will send an updated patch soon.