Random updates
cover Random updates
Hi,
Here's a bunch of updates. The first one can be consiered a fix, the second one is convenient, and the third one makes more proper usage of .gitignore.
Cheers.
Felipe Contreras (3):
gst-dsp: add dependency to pkg-config
gst-plugins-base: add option to select 'alsa'
.gitignore: remove wrong entries
.gitignore | 7 ------- package/multimedia/gst-dsp/gst-dsp.mk | 2 +- package/multimedia/gst-plugins-base/Config.in | 7 ++++++- 3 files changed, 7 insertions(+), 9 deletions(-)
Signature · 1 line
1.7.9.1.g97f7d
PATCH 1/3 gst-dsp: add dependency to pkg-config
It's used in the Makefile.
--- package/multimedia/gst-dsp/gst-dsp.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
package/multimedia/gst-dsp/gst-dsp.mk +1 -1
@@ -13,6 +13,6 @@ define GST_DSP_UNINSTALL_TARGET_CMDS $(RM) $(TARGET_DIR)/usr/lib/gstreamer-0.10/libgstdsp.so endef -GST_DSP_DEPENDENCIES = gstreamer tidsp-binaries +GST_DSP_DEPENDENCIES = gstreamer tidsp-binaries host-pkg-config $(eval $(call GENTARGETS))
Signature · 1 line
1.7.9.1.g97f7d
PATCH 1/3 gst-dsp: add dependency to pkg-config
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Felipe" == Felipe Contreras <[email protected]> writes:
Felipe> It's used in the Makefile.
Felipe> Signed-off-by: Felipe Contreras <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 2/3 gst-plugins-base: add option to select 'alsa'
In reply to Felipe ContrerasIt's nice to go straight to GStreamer, and enable all the plug-in elements without having to go back through the menus to select the dependencies.
--- package/multimedia/gst-plugins-base/Config.in | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
package/multimedia/gst-plugins-base/Config.in +6 -1
@@ -94,5 +94,10 @@ config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_VORBIS bool "vorbis (*.ogg audio)" select BR2_PACKAGE_LIBVORBIS -endif +config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_ALSA + bool "alsa" + select BR2_PACKAGE_ALSA_LIB + select BR2_PACKAGE_ALSA_LIB_MIXER + select BR2_PACKAGE_ALSA_LIB_PCM +endif
Signature · 1 line
1.7.9.1.g97f7d
PATCH 2/3 gst-plugins-base: add option to select 'alsa'
Quoted 15 lines · On Saturday 11 February 2012 01:04:35 Felipe Contreras wrote:
It's nice to go straight to GStreamer, and enable all the plug-in elements without having to go back through the menus to select the dependencies.
Signed-off-by Felipe Contreras <[email protected]>--- package/multimedia/gst-plugins-base/Config.in | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)package/multimedia/gst-plugins-base/Config.in +0
-0@@ -94,5 +94,10 @@ config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_VORBIS bool "vorbis (*.ogg audio)"
package/multimedia/gst-plugins-base/Config.in config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_VORBIS · line 103
Quoted 10 lines
package/multimedia/gst-plugins-base/Config.in +6
-1select BR2_PACKAGE_LIBVORBIS -endif +config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_ALSA + bool "alsa" + select BR2_PACKAGE_ALSA_LIB + select BR2_PACKAGE_ALSA_LIB_MIXER + select BR2_PACKAGE_ALSA_LIB_PCM +endif
Keep the config options ordered alphabetically, so put it before OGG.
Also, if the option exists, it should be used in the mk-file. So add:
ifeq ($(BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_ALSA),y) GST_PLUGINS_BASE_CONF_OPT += --enable-alsa elseGST_PLUGINS_BASE_CONF_OPT += --disable-alsa endif
(again alphabetically).
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 2/3 gst-plugins-base: add option to select 'alsa'
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle <[email protected]> writes:
Hi,
Arnout> Keep the config options ordered alphabetically, so put it before OGG.
Arnout> Also, if the option exists, it should be used in the mk-file. So add:
Arnout> ifeq ($(BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_ALSA),y) Arnout> GST_PLUGINS_BASE_CONF_OPT += --enable-alsa Arnout> else
Arnout> GST_PLUGINS_BASE_CONF_OPT += --disable-alsa Arnout> endif
Indeed, people expect to be able to disable that option and not have the alsa plugin built.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 3/3 .gitignore: remove wrong entries
In reply to Felipe ContrerasThese should go into a personal file, like:
core.excludesfile=/home/felipec/.gitignore
.*.sw[nop]
Some people might prefer to see patches, rejects and other files in the output of 'git status' (e.g. me).
--- .gitignore | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-)
.gitignore +0 -7
@@ -5,10 +5,3 @@ /.config.old /..config.tmp /.config -*.depend -*.o -/*.patch -/*.diff -*.orig -*.rej -*~
Signature · 1 line
1.7.9.1.g97f7d
PATCH 3/3 .gitignore: remove wrong entries
Quoted 6 lines · On Saturday 11 February 2012 01:04:36 Felipe Contreras wrote:
These should go into a personal file, like:
core.excludesfile=/home/felipec/.gitignore
.*.sw[nop]Some people might prefer to see patches, rejects and other files in the output of 'git status' (e.g. me).
Agreed on most parts, except for the /*.patch. It was added because git
format-patch creates them. If they are not ignored, than git add -A won't work properly anymore.
While we're talking about gitignore: I have two more things I'd like to
add to it:
/output* (because I often use parallel output dirs within the buildroot directory, as it gives me access to git).
/defconfig (since it's a generated file).
What do the others think?
Regards,
Arnout
Quoted 22 lines
Signed-off-by Felipe Contreras <[email protected]>--- .gitignore | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-).gitignore +0
-7@@ -5,10 +5,3 @@ /.config.old /..config.tmp /.config -*.depend -*.o -/*.patch -/*.diff -*.orig -*.rej -*~
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 3/3 .gitignore: remove wrong entries
Quoted 11 lines · Arnout Vandecappelle
Quoted 6 lines · On Saturday 11 February 2012 01:04:36 Felipe Contreras wrote:
These should go into a personal file, like:
core.excludesfile=/home/felipec/.gitignore
? .*.sw[nop]Some people might prefer to see patches, rejects and other files in the output of 'git status' (e.g. me).
?Agreed on most parts, except for the /*.patch. ?It was added because git format-patch creates them. ?If they are not ignored, than git add -A won't work properly anymore.
Well, I usually do 'git status' to see remnants I would like to remove, including *.patch.
I wonder why you would want to store those patches in the directory. You could specify a specific output directory. Moreover, 'git send-email' can generate the patches and send them at the same time... So you don't need to call 'git format-patch' directly.
Quoted 9 lines
?While we're talking about gitignore: I have two more things I'd like to add to it:
/output* (because I often use parallel output dirs within the buildroot directory, as it gives me access to git).
/defconfig (since it's a generated file).
?What do the others think?
I agree on those above. And actually, I removed *.o by mistake... I think they should be there.
Signature · 1 line
Felipe Contreras
A message that is not in the archive (sent off-list or not yet received): CAAXf6LXsQCsdwswHGa=Ei-+DkB7OyJbKnz7MhatTeEgCk5MMWw@mail.gmail.com
PATCH 3/3 .gitignore: remove wrong entries
Quoted 30 lines · Thomas De Schampheleire
Op 11 feb. 2012 01:05 schreef "Felipe Contreras"
<[email protected]> het volgende:Quoted 25 lines
These should go into a personal file, like:
core.excludesfile=/home/felipec/.gitignore
?.*.sw[nop]Some people might prefer to see patches, rejects and other files in the output of 'git status' (e.g. me).
Signed-off-by Felipe Contreras <[email protected]>---
?.gitignore | ? ?7 -------
?1 files changed, 0 insertions(+), 7 deletions(-).gitignore +0
-0@@ -5,10 +5,3 @@?/.config.old
?/..config.tmp
?/.config.gitignore +0
-4-*.depend -*.o -/*.patch -/*.diff
Quoted 8 lines
.gitignore line 14
Quoted 3 lines
.gitignore +0
-3-*.orig -*.rej -*~I personally don't agree. I don't think such ignores can be in a personal gitignore file. Such a personal file will be used for all git repositories, and you simply cannot state that no single project will use files with e.g. a .orig extension. In my opinion this is project specific.
You can have personal per-project ignore files as well.
Quoted 2 lines
I'm neutral on the .patch and .diff change, but I think that .depend, .o, .orig, .rej and ~ backups should remain in .gitignore.
*.o and *.depend should be there, as they are the output of the build system.
*.orig and *.reject and *~ should not, as they depend on the tools.
I suspect *~ comes from vim backups, which many people have disabled, and many people don't even use vi. Say, I have configured my editor to save backups with *.bak, should that be on the list? No, that's _personal_. If you want *~, or *.bak, to be ignored, you can put that in your global gitignore.
*.orig and *.reject are also not particular to busybox, they can be on the global gitignore. And some people, like me, want to be able to see then when typing 'git status'. So this is a _personal_ choice.
Cheers.
Signature · 1 line
Felipe Contreras
PATCH 3/3 .gitignore: remove wrong entries
Quoted 4 lines · On Sunday 12 February 2012 00:01:51 Felipe Contreras wrote:
Quoted 2 lines
I'm neutral on the .patch and .diff change, but I think that .depend, .o, .orig, .rej and ~ backups should remain in .gitignore.
*.o and *.depend should be there, as they are the output of the build system.
No they're not. Maybe in a far and distant past, but now (almost) all
output is in the output directory.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 3/3 .gitignore: remove wrong entries
Quoted 8 lines · Arnout Vandecappelle
Quoted 4 lines · On Sunday 12 February 2012 00:01:51 Felipe Contreras wrote:
Quoted 2 lines
I'm neutral on the .patch and .diff change, but I think that .depend, .o, .orig, .rej and ~ backups should remain in .gitignore.
*.o and *.depend should be there, as they are the output of the build system.
?No they're not. ?Maybe in a far and distant past, but now (almost) all output is in the output directory.
Oh, in that case they should be removed then :)
Signature · 1 line
Felipe Contreras
PATCH 3/3 .gitignore: remove wrong entries
In reply to Felipe Contreras[resend correctly to the list]
Hi,
Quoted 41 lines · Felipe Contreras
Quoted 30 lines · Thomas De Schampheleire
Op 11 feb. 2012 01:05 schreef "Felipe Contreras"
<[email protected]> het volgende:Quoted 25 lines
These should go into a personal file, like:
core.excludesfile=/home/felipec/.gitignore
?.*.sw[nop]Some people might prefer to see patches, rejects and other files in the output of 'git status' (e.g. me).
Signed-off-by Felipe Contreras <[email protected]>---
?.gitignore | ? ?7 -------
?1 files changed, 0 insertions(+), 7 deletions(-).gitignore +0
-0@@ -5,10 +5,3 @@?/.config.old
?/..config.tmp
?/.config.gitignore +0
-4-*.depend -*.o -/*.patch -/*.diffQuoted 8 lines
.gitignore line 14
Quoted 3 lines
.gitignore +0
-3-*.orig -*.rej -*~I personally don't agree. I don't think such ignores can be in a personal gitignore file. Such a personal file will be used for all git repositories, and you simply cannot state that no single project will use files with e.g. a .orig extension. In my opinion this is project specific.
Quoted 1 line
You can have personal per-project ignore files as well.
Ok, I wasn't aware of that (not using git).
Quoted 10 lines
Quoted 3 lines
I'm neutral on the .patch and .diff change, but I think that .depend, .o, .orig, .rej and ~ backups should remain in .gitignore.
*.o and *.depend should be there, as they are the output of the build system.
*.orig and *.reject and *~ should not, as they depend on the tools.
I suspect *~ comes from vim backups, which many people have disabled, and many people don't even use vi.
It's difficult to quantify 'many' here. I can just as safely say that many people do use vi and many people have not disabled ~ backups.
Quoted 8 lines
Say, I have configured my editor to
save backups with *.bak, should that be on the list? No, that's _personal_. If you want *~, or *.bak, to be ignored, you can put that in your global gitignore.*.orig and *.reject are also not particular to busybox, they can be on the global gitignore. And some people, like me, want to be able to see then when typing 'git status'. So this is a _personal_ choice.
I'm sure you mean buildroot here.
If you are to remove all these entries from the .gitignore file, you are basically forcing people to create such a personal .gitignore file. The defaults of the buildroot project are no longer sane.
To be honest, I'm not sure if your use case of seeing all files with plain 'git status' is a common one, and thus whether it's worth changing the experience for all other people just for that. In my opinion, the default should be ok for most people.
Doesn't git provide an option to git-status to see ignored files? I know Mercurial does. One could argue that it'd be better to submit a patch to git for such an option.
Alternatively, you are free the gitignore file on a branch in your repository.
Note that this is just my view on this. I have no authority whatsoever. I'm looking forward to input from other developers...
Best regards,
Thomas
A message that is not in the archive (sent off-list or not yet received): CAAXf6LVq7X9-W7syJKUyaz+VyC3+tzGq6A4XMz96ZUqsrR77=w@mail.gmail.com
PATCH 3/3 .gitignore: remove wrong entries
Quoted 55 lines · Thomas De Schampheleire
Hi,
Quoted 41 lines · Felipe Contreras
Quoted 30 lines · Thomas De Schampheleire
Op 11 feb. 2012 01:05 schreef "Felipe Contreras"
<[email protected]> het volgende:Quoted 25 lines
These should go into a personal file, like:
core.excludesfile=/home/felipec/.gitignore
?.*.sw[nop]Some people might prefer to see patches, rejects and other files in the output of 'git status' (e.g. me).
Signed-off-by Felipe Contreras <[email protected]>---
?.gitignore | ? ?7 -------
?1 files changed, 0 insertions(+), 7 deletions(-).gitignore +0
-0@@ -5,10 +5,3 @@?/.config.old
?/..config.tmp
?/.config.gitignore +0
-4-*.depend -*.o -/*.patch -/*.diffQuoted 8 lines
.gitignore line 14
Quoted 3 lines
.gitignore +0
-3-*.orig -*.rej -*~I personally don't agree. I don't think such ignores can be in a personal gitignore file. Such a personal file will be used for all git repositories, and you simply cannot state that no single project will use files with e.g. a .orig extension. In my opinion this is project specific.
Quoted 1 line
You can have personal per-project ignore files as well.
Ok, I wasn't aware of that (not using git).
Quoted 6 lines
Quoted 3 lines
I'm neutral on the .patch and .diff change, but I think that .depend, .o, .orig, .rej and ~ backups should remain in .gitignore.
*.o and *.depend should be there, as they are the output of the build system.
Quoted 7 lines
Quoted 4 lines
*.orig and *.reject and *~ should not, as they depend on the tools.
I suspect *~ comes from vim backups, which many people have disabled, and many people don't even use vi.
It's difficult to quantify 'many' here. I can just as safely say that many people do use vi and many people have not disabled ~ backups.
It doesn't matter, what matters is that they are *personal*.
Quoted 9 lines
Quoted 8 lines
Say, I have configured my editor to
save backups with *.bak, should that be on the list? No, that's _personal_. If you want *~, or *.bak, to be ignored, you can put that in your global gitignore.*.orig and *.reject are also not particular to busybox, they can be on the global gitignore. And some people, like me, want to be able to see then when typing 'git status'. So this is a _personal_ choice.
Quoted 5 lines
I'm sure you mean buildroot here.
If you are to remove all these entries from the .gitignore file, you are basically forcing people to create such a personal .gitignore file. The defaults of the buildroot project are no longer sane.
No, they don't have to.
Quoted 4 lines
To be honest, I'm not sure if your use case of seeing all files with plain 'git status' is a common one, and thus whether it's worth changing the experience for all other people just for that. In my opinion, the default should be ok for most people.
You would be hacking .gitignore for something it wasn't meant to be then:
man gitignore
---
Which file to place a pattern in depends on how the pattern is meant to be used. Patterns which should be version-controlled and distributed to other repositories via clone (i.e., files that all developers will want to ignore) should go into a .gitignore file.
---
Notice the phrase *all developers*.
---
Patterns which are specific to a particular repository but which do not need to be shared with other related repositories (e.g., auxiliary files that live inside the repository but are specific to one user's workflow) should go into the $GIT_DIR/info/exclude file. Patterns which a user wants git to ignore in all situations (e.g., backup or temporary files generated by the user's editor of choice) generally go into a file specified by core.excludesfile in the user's ~/.gitconfig.
---
Notice the phrase *user's*.
If you contribute to more than one project, you should not be pushing for all those projects to have *~ in the project's .gitignore, or *.patch, which will affect other users. You should just add it to your global gitignore file and be done with it.
Cheers.
Signature · 1 line
Felipe Contreras