Skip to contentSkip to conversation

Make 'Thermal Table has changed' a debug message.

PATCH In review Bill Nottingham 2 participants 2 messages Feb 14, 2012 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Make 'Thermal Table has changed' a debug message.

If the recommended action is "do nothing", we shouldn't be cluttering the logs with it.

---
 drivers/platform/x86/thinkpad_acpi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/platform/x86/thinkpad_acpi.c +1 -1
index ea0c607..a96983e 100644
@@ -3605,7 +3605,7 @@ static bool hotkey_notify_6xxx(const u32 hkey,
 
 	switch (hkey) {
 	case TP_HKEY_EV_THM_TABLE_CHANGED:
-		pr_info("EC reports that Thermal Table has changed\n");
+		pr_debug("EC reports that Thermal Table has changed\n");
 		/* recommended action: do nothing, we don't have
 		 * Lenovo ATM information */
 		return true;
Signature · 1 line
1.7.7.6
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Bill Nottingham

If the recommended action is "do nothing", we shouldn't be cluttering the logs with it.

We never figured out what interesting hint the thinkpad was trying to give us.

Quoted 13 lines
drivers/platform/x86/thinkpad_acpi.c +1 -1
index ea0c607..a96983e 100644
@@ -3605,7 +3605,7 @@ static bool hotkey_notify_6xxx(const u32 hkey,
 
 	switch (hkey) {
 	case TP_HKEY_EV_THM_TABLE_CHANGED:
-		pr_info("EC reports that Thermal Table has changed\n");
+		pr_debug("EC reports that Thermal Table has changed\n");
 		/* recommended action: do nothing, we don't have
 		 * Lenovo ATM information */
 		return true;
Signature · 4 lines
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh