Skip to contentSkip to conversation

shpc with acpi=off?

DISCUSSION Michael S. Tsirkin 2 participants 2 messages Feb 16, 2012 – Feb 23, 2012

Subsystems (2)
ACPI PCI
lore
Share & tools
lore

Michael S. Tsirkin

author
#0 lore raw

I have a box where shpc works fine with acpi,
as well as when acpi is not built into kernel,
but fails with acpi=off
Some debugging seems to indicate that
acpi_get_hp_hw_control_from_firmware
fails with acpi=off.

Is this a bug or is there a reason to prevent shpc from working in this setup?
Do we even care about acpi=off?
Assuming we want to make acpi_get_hp_hw_control_from_firmware succeed with acpi=off, what is the best way to do this? Check acpi_pci_disabled?

Thoughts?

Signature · 1 line
MST
#1 lore raw
Quoted 7 lines · On Thu, 16 Feb 2012 17:04:22 +0200 "Michael S. Tsirkin" <[email protected]> wrote:

I have a box where shpc works fine with acpi,
as well as when acpi is not built into kernel,
but fails with acpi=off
Some debugging seems to indicate that
acpi_get_hp_hw_control_from_firmware
fails with acpi=off.

Quoted 6 lines

Is this a bug or is there a reason to prevent shpc from working in this setup?
Do we even care about acpi=off?
Assuming we want to make acpi_get_hp_hw_control_from_firmware succeed with acpi=off, what is the best way to do this? Check acpi_pci_disabled?

Yeah not sure it's important to have SHPC work with acpi=off. Disabling ACPI prevents us from getting all sorts of important info these days...

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center