arm:fix:cleanup: Volatile keyword removal
Subsystems (2)
PATCH 1/1 arm:fix:cleanup: Volatile keyword removal
Volatile keyword removal from./arch/arm/include/asm/bitops.h
--- arch/arm/include/asm/bitops.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/include/asm/bitops.h +3 -3
@@ -25,11 +25,11 @@/* * Function prototypes to keep gcc -Wall happy. */ -extern void set_bit (int nr,volatile void * addr); +extern void set_bit (int nr,void *addr); -extern void clear_bit (int nr,volatile void * addr); +extern void clear_bit (int nr,void *addr); -extern void change_bit (int nr,volatile void * addr); +extern void change_bit (int nr,void *addr);static inline void __change_bit (int nr,volatile void *addr) {
Signature · 1 line
1.7.2.3
PATCH 1/1 arm:fix:cleanup: Volatile keyword removal
Hi Lukasz,
Le 18/10/2011 16:25, Lukasz Majewski a ?crit :
Quoted 18 lines
Volatile keyword removal from
./arch/arm/include/asm/bitops.hSigned-off-by Lukasz Majewski<[email protected]>Signed-off-by Kyungmin Park<[email protected]>--- arch/arm/include/asm/bitops.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)arch/arm/include/asm/bitops.h +0
-1@@ -25,11 +25,11 @@/* * Function prototypes to keep gcc -Wall happy. */ -extern void set_bit (int nr,volatile void * addr);
arch/arm/include/asm/bitops.h line 35
Quoted 10 lines
arch/arm/include/asm/bitops.h +3
-2+extern void set_bit (int nr,void *addr); -extern void clear_bit (int nr,volatile void * addr); +extern void clear_bit (int nr,void *addr); -extern void change_bit (int nr,volatile void * addr); +extern void change_bit (int nr,void *addr);static inline void __change_bit (int nr,volatile void *addr) {
Going through backlogged patches adelegated to me, I found this one. I'm fine with it, however I notice there is absolutely no call to set_bit, change_bit or clear_bit in the whole ARM subtree... What is the point of removing only the volatile qualifier vs removing the function definitions?
Amicalement,
Signature · 1 line
Albert.
PATCH 1/1 arm:fix:cleanup: Volatile keyword removal
Quoted 38 lines · On Sat, 18 Feb 2012 12:19:23 +0100 Albert ARIBAUD <[email protected]>…
Hi Lukasz,
Le 18/10/2011 16:25, Lukasz Majewski a ?crit :
Quoted 18 lines
Volatile keyword removal from
./arch/arm/include/asm/bitops.hSigned-off-by Lukasz Majewski<[email protected]>Signed-off-by Kyungmin Park<[email protected]>--- arch/arm/include/asm/bitops.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)(quoted diff) +0
-0
b/arch/arm/include/asm/bitops.hindex 879e20e..b00ae30 100644arch/arm/include/asm/bitops.h +0
-1@@ -25,11 +25,11 @@/* * Function prototypes to keep gcc -Wall happy. */ -extern void set_bit (int nr,volatile void * addr);arch/arm/include/asm/bitops.h line 35
Quoted 10 lines
arch/arm/include/asm/bitops.h +3
-2+extern void set_bit (int nr,void *addr); -extern void clear_bit (int nr,volatile void * addr); +extern void clear_bit (int nr,void *addr); -extern void change_bit (int nr,volatile void * addr); +extern void change_bit (int nr,void *addr);static inline void __change_bit (int nr,volatile void *addr) {Going through backlogged patches adelegated to me, I found this one. I'm fine with it, however I notice there is absolutely no call to
set_bit,change_bitorclear_bitin the whole ARM subtree... What is the point of removing only the volatile qualifier vs removing the function definitions?
Quoted 1 line
Amicalement,
Hi Albert,
This patch was a supplement (to quiet compiler warnings) to the USB gadget infrastructure.
But as we know, usb:gadget hasn't been added to the u-boot mainline.
However, I'm working on this, so I predict, that in the (near) future I would need those changes to suppress compiler warnings :-).
For now, the commit can be discarded, I will resubmit it if needed.
Signature · 6 lines
Best regards, Lukasz Majewski Samsung Poland R&D Center Platform Group