Skip to contentSkip to conversation

More build errors and warnings

PATCH New Russell King - ARM Linux 3 participants 4 messages Feb 20, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Errors:

arch/arm/mach-omap2/built-in.o: In function n8x0_mmc_callback': twl-common.c:(.text+0x108a0): undefined reference to omap_mmc_notify_cover_event'</pre><h2>Warnings

Warnings:

drivers/iommu/omap-iommu-debug.c:271: warning: passing argument 1 of 'omap_find_iovm_area' from incompatible pointer type drivers/iommu/omap-iommu-debug.c:308: warning: passing argument 1 of 'omap_find_iovm_area' from incompatible pointer type

These two are a serious problem, which needs fixing for -rc:

omap-iommu-debug.c:

        struct omap_iommu *obj = file->private_data;

        area = omap_find_iovm_area(obj, (u32)ppos);

arch/arm/plat-omap/include/plat/iovmm.h:extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da);

Config file (for the next 7 days):
http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=170

maintainer
#1 lore raw

Hi Russell & Ohad,

Quoted 3 lines · Russell King - ARM Linux

Errors:

arch/arm/mach-omap2/built-in.o: In function n8x0_mmc_callback': twl-common.c:(.text+0x108a0): undefined reference to omap_mmc_notify_cover_event'</pre><h2>Warnings

I'll post a fix to do a warning here if the cover events are unavailable. The long term fix is to let the MMC driver register the callback with the PMIC to do this.

Quoted 8 lines

Warnings:

drivers/iommu/omap-iommu-debug.c:271: warning: passing argument 1 of 'omap_find_iovm_area' from incompatible pointer type drivers/iommu/omap-iommu-debug.c:308: warning: passing argument 1 of 'omap_find_iovm_area' from incompatible pointer type

These two are a serious problem, which needs fixing for -rc:

omap-iommu-debug.c:

Quoted 8 lines
        struct omap_iommu *obj = file->private_data;

        area = omap_find_iovm_area(obj, (u32)ppos);

arch/arm/plat-omap/include/plat/iovmm.h:extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da);

Config file (for the next 7 days):
http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=170

Ohad, care to look into fixing these for the -rc series?

Regards,

Tony

#2 lore raw
Quoted 1 line · Tony Lindgren

Ohad, care to look into fixing these for the -rc series?

Sure thing, will do.

Ohad.

maintainer
#3 lore raw

PATCH 1/1 ARM: OMAP: Fix build error when mmc_omap is built as module

In reply to Tony Lindgren

Otherwise we get the following error:

arch/arm/mach-omap2/built-in.o: In function `n8x0_mmc_callback':
twl-common.c:(.text+0x108a0): undefined reference to `omap_mmc_notify_cover_event'

Fix this by warning about unusable MMC cover events.

The long term fix needs to change the MMC drivers to register board specific callbacks directly with PMIC.

arch/arm/mach-omap2/board-n8x0.c +4 -0
@@ -371,7 +371,11 @@ static void n8x0_mmc_callback(void *data, u8 card_mask)
 	else
 		*openp = 0;
 
+#ifdef CONFIG_MMC_OMAP
 	omap_mmc_notify_cover_event(mmc_device, index, *openp);
+#else
+	pr_warn("MMC: notify cover event not available\n");
+#endif
 }
 
 static int n8x0_mmc_late_init(struct device *dev)