Skip to contentSkip to conversation

ARM i.MX5/6: Add dt support for generic boards

PATCH New Sascha Hauer 2 participants 5 messages Feb 17, 2012 – Feb 27, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape
lore
Share & tools
lore

Sascha Hauer

author maintainer
#0 lore raw

PATCH 1/1 ARM i.MX5/6: Add dt support for generic boards

Apart from the iomux setup which may not be needed on custom boards the kernel starts fine using the devicetree, so add generic boards to the dt_compat entries.

Signed-off-by Sascha Hauer <[email protected]>
---
 arch/arm/mach-imx/imx51-dt.c   |    1 +
 arch/arm/mach-imx/imx53-dt.c   |    1 +
 arch/arm/mach-imx/mach-imx6q.c |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-imx/imx51-dt.c +1 -0
index e6bad17..b0d830f 100644
@@ -104,6 +104,7 @@ static struct sys_timer imx51_timer = {
 
 static const char *imx51_dt_board_compat[] __initdata = {
 	"fsl,imx51-babbage",
+	"fsl,imx51",
 	NULL
 };
arch/arm/mach-imx/imx53-dt.c +1 -0
index 05ebb3e..d75a267 100644
@@ -114,6 +114,7 @@ static const char *imx53_dt_board_compat[] __initdata = {
 	"fsl,imx53-evk",
 	"fsl,imx53-qsb",
 	"fsl,imx53-smd",
+	"fsl,imx53",
 	NULL
 };
arch/arm/mach-imx/mach-imx6q.c +1 -0
index c257281..f3adf2f 100644
@@ -128,6 +128,7 @@ static struct sys_timer imx6q_timer = {
 static const char *imx6q_dt_compat[] __initdata = {
 	"fsl,imx6q-arm2",
 	"fsl,imx6q-sabrelite",
+	"fsl,imx6q",
 	NULL,
 };
Signature · 1 line
1.7.9
#1 lore raw

PATCH 1/1 ARM i.MX5/6: Add dt support for generic boards

Quoted 11 lines · Sascha Hauer

Apart from the iomux setup which may not be needed on custom boards the kernel starts fine using the devicetree, so add generic boards to the dt_compat entries.

Signed-off-by Sascha Hauer <[email protected]>
---
 arch/arm/mach-imx/imx51-dt.c   |    1 +
 arch/arm/mach-imx/imx53-dt.c   |    1 +
 arch/arm/mach-imx/mach-imx6q.c |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)

I guess the point that the patch is trying to make is that we do not need to touch these files whenever we add a new board booting with device tree, if the board does not need any special handling there with its compatible string.

But we may still need a specific compatible string for the board in its .dts file rather than just specific common like "fsl,imx6q". That said, Documentation/devicetree/bindings/arm/fsl.txt needs an update anyway whenever a new board support is added.

Also, isn't it a good thing to have the dt_compat list explicitly show all the boards that the dt file supports?

Regards,
Shawn

Quoted 39 lines
arch/arm/mach-imx/imx51-dt.c +1 -0
index e6bad17..b0d830f 100644
@@ -104,6 +104,7 @@ static struct sys_timer imx51_timer = {
 
 static const char *imx51_dt_board_compat[] __initdata = {
 	"fsl,imx51-babbage",
+	"fsl,imx51",
 	NULL
 };
arch/arm/mach-imx/imx53-dt.c +1 -0
index 05ebb3e..d75a267 100644
@@ -114,6 +114,7 @@ static const char *imx53_dt_board_compat[] __initdata = {
 	"fsl,imx53-evk",
 	"fsl,imx53-qsb",
 	"fsl,imx53-smd",
+	"fsl,imx53",
 	NULL
 };
arch/arm/mach-imx/mach-imx6q.c +1 -0
index c257281..f3adf2f 100644
@@ -128,6 +128,7 @@ static struct sys_timer imx6q_timer = {
 static const char *imx6q_dt_compat[] __initdata = {
 	"fsl,imx6q-arm2",
 	"fsl,imx6q-sabrelite",
+	"fsl,imx6q",
 	NULL,
 };
Signature · 1 line
1.7.9
author maintainer
#2 lore raw

PATCH 1/1 ARM i.MX5/6: Add dt support for generic boards

Hi Shawn,

Quoted 12 lines · Shawn Guo
Quoted 11 lines · Sascha Hauer

Apart from the iomux setup which may not be needed on custom boards the kernel starts fine using the devicetree, so add generic boards to the dt_compat entries.

Signed-off-by Sascha Hauer <[email protected]>
---
 arch/arm/mach-imx/imx51-dt.c   |    1 +
 arch/arm/mach-imx/imx53-dt.c   |    1 +
 arch/arm/mach-imx/mach-imx6q.c |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)
Quoted 4 lines

I guess the point that the patch is trying to make is that we do not need to touch these files whenever we add a new board booting with device tree, if the board does not need any special handling there with its compatible string.

Yes.

Quoted 3 lines

But we may still need a specific compatible string for the board in its .dts file rather than just specific common like "fsl,imx6q".

Yes, a dts file should definitely have a more specific compatible string with fsl,imx6q just being the fallback.

Quoted 6 lines

That
said, Documentation/devicetree/bindings/arm/fsl.txt needs an update anyway whenever a new board support is added.

Also, isn't it a good thing to have the dt_compat list explicitly show all the boards that the dt file supports?

When we add the dts file to the kernel we can update Doc/../fsl.txt accordingly. I find it very useful to be able to run an unpatched kernel on various custom boards which are (not yet) in mainline.

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#3 lore raw

PATCH 1/1 ARM i.MX5/6: Add dt support for generic boards

On 21 February 2012 02:28, Sascha Hauer <[email protected]> wrote:
...

Quoted 4 lines

When we add the dts file to the kernel we can update Doc/../fsl.txt accordingly. I find it very useful to be able to run an unpatched kernel on various custom boards which are (not yet) in mainline.

Fair enough. If you plan to send it to arm-soc,

Acked-by Shawn Guo <[email protected]>

Or I will pick it up.

Regards,
Shawn

#4 lore raw

PATCH 1/1 ARM i.MX5/6: Add dt support for generic boards

In reply to Sascha Hauer
Quoted 5 lines · Sascha Hauer

Apart from the iomux setup which may not be needed on custom boards the kernel starts fine using the devicetree, so add generic boards to the dt_compat entries.

Signed-off-by Sascha Hauer <[email protected]>

I queued this up together with other DT patches, and will send them to arm-soc soon.

Signature · 2 lines
Regards,
Shawn