Skip to contentSkip to conversation

ARM: mach-shmobile: sh73a0 IRQ sparse alloc fix

PATCH In review Magnus Damm 1 participant 1 message Feb 23, 2012

Subsystems (4)
Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

PATCH 4/5 ARM: mach-shmobile: sh73a0 IRQ sparse alloc fix

From: Magnus Damm <[email protected]>

Fix the sh73a0 external IRQ pin code to properly support CONFIG_SPARSE_IRQ=y by allocating IRQ descriptors for the cascaded IRQs associated with external IRQ pins.

Without this fix it is impossible to request IRQ0->IRQ31 on the Kota2 board when sparse IRQs are enabled.

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/intc-sh73a0.c |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-shmobile/intc-sh73a0.c +2 -0
@@ -19,6 +19,7 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
 #include <linux/irq.h>
 #include <linux/io.h>
 #include <linux/sh_intc.h>

@@ -445,6 +446,7 @@ void __init sh73a0_init_irq(void)
 		setup_irq(gic_spi(1 + k), &sh73a0_irq_pin_cascade[k]);
 
 		n = intcs_evt2irq(to_intc_vect(gic_spi(1 + k)));
+		WARN_ON(irq_alloc_desc_at(n, numa_node_id()) != n);
 		irq_set_chip_and_handler_name(n, &intca_gic_irq_chip,
 					      handle_level_irq, "level");
 		set_irq_flags(n, IRQF_VALID); /* yuck */