Skip to contentSkip to conversation

hda - add id for Atom Cedar Trail HDMI codec

PATCH Applied Wu Fengguang 3 participants 5 messages Feb 23, 2012 – Feb 24, 2012 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hda - add id for Atom Cedar Trail HDMI codec

---
 sound/pci/hda/patch_hdmi.c |    2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/patch_hdmi.c +2 -0
@@ -1913,6 +1913,7 @@ static const struct hda_codec_preset snd
 { .id = 0x80862805, .name = "CougarPoint HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862806, .name = "PantherPoint HDMI", .patch = patch_generic_hdmi },
 { .id = 0x808629fb, .name = "Crestline HDMI",	.patch = patch_generic_hdmi },
+{ .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
 {} /* terminator */
 };
 
@@ -1959,6 +1960,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862804"
 MODULE_ALIAS("snd-hda-codec-id:80862805");
 MODULE_ALIAS("snd-hda-codec-id:80862806");
 MODULE_ALIAS("snd-hda-codec-id:808629fb");
+MODULE_ALIAS("snd-hda-codec-id:80862880");
 
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("HDMI HD-audio codec");
Applied
#1 lore raw

At Thu, 23 Feb 2012 15:07:44 +0800,

Quoted 3 lines · Wu Fengguang

Applied, but I sorted the order. CedarTrail's id is less than Crestline's id number.

thanks,

Takashi

Quoted 23 lines
---
 sound/pci/hda/patch_hdmi.c |    2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/patch_hdmi.c +2 -0
@@ -1913,6 +1913,7 @@ static const struct hda_codec_preset snd
 { .id = 0x80862805, .name = "CougarPoint HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862806, .name = "PantherPoint HDMI", .patch = patch_generic_hdmi },
 { .id = 0x808629fb, .name = "Crestline HDMI",	.patch = patch_generic_hdmi },
+{ .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
 {} /* terminator */
 };
 
@@ -1959,6 +1960,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862804"
 MODULE_ALIAS("snd-hda-codec-id:80862805");
 MODULE_ALIAS("snd-hda-codec-id:80862806");
 MODULE_ALIAS("snd-hda-codec-id:808629fb");
+MODULE_ALIAS("snd-hda-codec-id:80862880");
 
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("HDMI HD-audio codec");
#2 lore raw
Quoted 8 lines · Takashi Iwai

At Thu, 23 Feb 2012 15:07:44 +0800,

Quoted 3 lines · Wu Fengguang

Applied, but I sorted the order. CedarTrail's id is less than Crestline's id number.

Thank you, that's obviously good change.

#3 lore raw
In reply to Wu Fengguang

Dear Fengguang,

Am Donnerstag, den 23.02.2012, 15:07 +0800 schrieb Wu Fengguang:

Quoted 1 line

as always I am confused what is your first name and what is the surname.

Intel email messages seem to be <[email protected]>. So if Wu is your last name you should put a »,« behind Wu in your Mutt configuration and adapt your Git configuration with the following command.

    git config --global user.name "Fengguang Wu"
Quoted 15 lines
---
 sound/pci/hda/patch_hdmi.c |    2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/patch_hdmi.c +1 -0
@@ -1913,6 +1913,7 @@ static const struct hda_codec_preset snd
 { .id = 0x80862805, .name = "CougarPoint HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862806, .name = "PantherPoint HDMI", .patch = patch_generic_hdmi },
 { .id = 0x808629fb, .name = "Crestline HDMI",	.patch = patch_generic_hdmi },
+{ .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
 {} /* terminator */
 };
 

sound/pci/hda/patch_hdmi.c MODULE_ALIAS("snd-hda-codec-id:80862804" · line 1966

Quoted 7 lines
sound/pci/hda/patch_hdmi.c +1 -0
@@ -1959,6 +1960,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862804"
 MODULE_ALIAS("snd-hda-codec-id:80862805");
 MODULE_ALIAS("snd-hda-codec-id:80862806");
 MODULE_ALIAS("snd-hda-codec-id:808629fb");
+MODULE_ALIAS("snd-hda-codec-id:80862880");
 
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("HDMI HD-audio codec");

Thank you for your patch.

Next time it would be nice, if you could add some test information to the commit message.

Thanks,

Paul

[1] http://cn.linkedin.com/pub/fengguang-wu/2b/587/b18
[2] http://www.igi-global.com/chapter/advanced-operating-systems-kernel-applications/37951

#4 lore raw

Dear Paul,

Quoted 7 lines · Paul Menzel

Dear Fengguang,

Am Donnerstag, den 23.02.2012, 15:07 +0800 schrieb Wu Fengguang:

Quoted 1 line

as always I am confused what is your first name and what is the surname.

Sorry about that... It's sure confusing. According to

https://en.wikipedia.org/wiki/Chinese_name#Chinese_names_in_English

"Chinese people, except for those traveling or living outside of China, rarely reverse their names to the western naming order (given name, then family name). Western publications usually preserve the Chinese naming order, with the family name first, followed by the given name."

However it does look worthwhile to fit the western order in English since the majority LKML readers are accustomed to that. The good news is, whether or not "Fengguang Wu" or "Wu Fengguang" is used, Chinese people can always recognize "Wu" as my family name, instantly.

Quoted 6 lines

Intel email messages seem to be <[email protected]>. So if Wu is your last name you should put a »,« behind Wu in your Mutt configuration and adapt your Git configuration with the following command.

    git config --global user.name "Fengguang Wu"

Done. Thanks for the tip!

Fengguang Wu
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel