Skip to contentSkip to conversation

openocd: fetch package from git repository and update version

PATCH Superseded Alexandre Pereira da Silva 6 participants 16 messages Feb 24, 2012 – Mar 5, 2012

lore
Share & tools
lore

Alexandre Pereira da Silva

author
#0 lore raw

PATCH 1/1 openocd: fetch package from git repository and update version

This overrided the DOWNLOAD_GIT method to also fetch the submodules used by openocd.
Removed patches that are not needed anymore by the new version. Updated the gnu99 patch to use configure.ac instead of configure.in. Fix a build problem in the stm32_stlink.c file.

Signed-off-by Alexandre Pereira da Silva <[email protected]>
---
 ...s-compilation-host-libsub-was-used-before.patch |   33 -----------------
 ...001-smt32_stlink-Workaround-build-warning.patch |   32 +++++++++++++++++
 ...002-fix-xscale-uninitialise-breakpoint_pc.patch |   20 -----------
 package/openocd/openocd-0003-force-gnu99.patch     |   24 +++++++-----
 .../openocd/openocd-0005-dont-force-ldflags.patch  |   37 --------------------
 package/openocd/openocd.mk                         |   28 ++++++++++++---
 6 files changed, 69 insertions(+), 105 deletions(-)
 delete mode 100644 package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch
 create mode 100644 package/openocd/openocd-0001-smt32_stlink-Workaround-build-warning.patch
 delete mode 100644 package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch
 delete mode 100644 package/openocd/openocd-0005-dont-force-ldflags.patch
package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch deleted +0 -33
deleted file mode 100644
index caf1a8b..0000000
@@ -1,33 +0,0 @@
-From 3728c4af7f6303ccedab56ec220797f8f290580e Mon Sep 17 00:00:00 2001
-From: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
-Date: Wed, 10 Aug 2011 00:17:29 +0800
-Subject: [PATCH] fix cross compilation: host libsub was used before
-
-tested in buildroot
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
----
- configure.in |    7 +++++--
- 1 files changed, 5 insertions(+), 2 deletions(-)
-
-diff --git a/configure.in b/configure.in
-index dfa1e8f..cfe2218 100644
---- a/configure.in
-+++ b/configure.in
-@@ -1046,8 +1046,11 @@ build_usb=no
- if test $build_jlink = yes -o $build_vsllink = yes -o $build_usbprog = yes -o \
-   $build_rlink = yes -o $build_ulink = yes -o $build_armjtagew = yes
- then
--  AC_CHECK_HEADERS([usb.h],[],
--  [AC_MSG_ERROR([usb.h is required to build some OpenOCD driver(s)])])
-+  dnl check for libusb
-+  PKG_CHECK_MODULES(LIBUSB, libusb >= 0.1.11)
-+  CFLAGS="$CFLAGS $LIBUSB_CFLAGS"
-+  LDFLAGS="$LDFLAGS $LIBUSB_LDFLAGS"
-+  LIBS="$LIBS $LIBUSB_LIBS"
-   build_usb=yes
- fi
- 
--- 
-1.7.5.4
-
package/openocd/openocd-0001-smt32_stlink-Workaround-build-warning.patch new file +32 -0
new file mode 100644
index 0000000..a497f08
@@ -0,0 +1,32 @@
+smt32_stlink: workaround build warning
+
+Signed-off-by: Alexandre Pereira da Silva <[email protected]>
+---
+ src/target/stm32_stlink.c |    4 ++--
+ 1 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/target/stm32_stlink.c b/src/target/stm32_stlink.c
+index 32896cc..e7e5891 100644
+--- a/src/target/stm32_stlink.c
++++ b/src/target/stm32_stlink.c
+@@ -651,7 +651,7 @@ static int stm32_stlink_read_memory(struct target *target, uint32_t address,
+ 					address, c, dst);
+ 		else
+ 			res = stlink_if->layout->api->read_mem32(stlink_if->fd,
+-					address, c, (uint32_t *)dst);
++					address, c, (uint32_t *)(void *)dst);
+ 
+ 		if (res != ERROR_OK)
+ 			return res;
+@@ -700,7 +700,7 @@ static int stm32_stlink_write_memory(struct target *target, uint32_t address,
+ 					address, c, dst);
+ 		else
+ 			res = stlink_if->layout->api->write_mem32(stlink_if->fd,
+-					address, c, (uint32_t *)dst);
++					address, c, (uint32_t *)(void *)dst);
+ 
+ 		if (res != ERROR_OK)
+ 			return res;
+-- 
+1.7.9
+
package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch deleted +0 -20
deleted file mode 100644
index 328241e..0000000
@@ -1,20 +0,0 @@
-xscale: fix uninitialise breakpoint_pc
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
----
- src/target/xscale.c |    2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-Index: b/src/target/xscale.c
-===================================================================
---- a/src/target/xscale.c
-+++ b/src/target/xscale.c
-@@ -2811,7 +2811,7 @@ static int xscale_analyze_trace(struct t
-    struct xscale_common *xscale = target_to_xscale(target);
-    struct xscale_trace_data *trace_data = xscale->trace.data;
-    int i, retval;
--   uint32_t breakpoint_pc;
-+   uint32_t breakpoint_pc = 0;
-    struct arm_instruction instruction;
-    uint32_t current_pc = 0;  /* initialized when address determined */
-
package/openocd/openocd-0003-force-gnu99.patch +14 -10
index 106d112..5511f09 100644
@@ -1,19 +1,23 @@
 force gnu99
 
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
+Signed-off-by: Alexandre Pereira da Silva <[email protected]>
 ---
- configure.in |    1 +
- 1 file changed, 1 insertion(+)
+ configure.ac |    2 ++
+ 1 files changed, 2 insertions(+), 0 deletions(-)
 
-Index: b/configure.in
-===================================================================
---- a/configure.in
-+++ b/configure.in
-@@ -28,6 +28,7 @@ AC_DISABLE_SHARED
+diff --git a/configure.ac b/configure.ac
+index ffab637..60fe4ab 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -28,6 +28,8 @@ AC_DISABLE_SHARED
  AC_PROG_LIBTOOL
- AC_SUBST(LIBTOOL_DEPS)
+ AC_SUBST([LIBTOOL_DEPS])
  
 +CFLAGS="$CFLAGS -std=gnu99"
- 
++
  dnl configure checks required for Jim files (these are obsolete w/ C99)
  AC_C_CONST
+ AC_TYPE_LONG_LONG_INT
+-- 
+1.7.9
+
package/openocd/openocd-0005-dont-force-ldflags.patch deleted +0 -37
deleted file mode 100644
index 1880e00..0000000
@@ -1,37 +0,0 @@
-[PATCH] don't force library search path / rpath settings
-
-openocd adds -L$exec_prefix/lib -Wl,rpath,$exec_prefix/lib to the compile
-LDFLAGS if it isn't installed into /usr/local, which breaks cross compilation
-as the compiler ends up using host libraries.
----
- configure.in |   17 -----------------
- 1 file changed, 17 deletions(-)
-
-Index: openocd-0.5.0/configure.in
-===================================================================
---- openocd-0.5.0.orig/configure.in
-+++ openocd-0.5.0/configure.in
-@@ -174,23 +174,6 @@
- # Let make expand exec_prefix.
- test x"$OCDxprefix" = xNONE && OCDxprefix="$OCDprefix"
- 
--# what matters is the "exec-prefix"
--if test "$OCDxprefix" != "$ac_default_prefix"
--then
--    # We are installing in a non-standard place
--    # Nonstandard --prefix and/or --exec-prefix
--    # We have an override of some sort.
--    # use build specific install library dir
--
--    LDFLAGS="$LDFLAGS -L$OCDxprefix/lib"
--    # RPATH becomes an issue on Linux only
--    if test $host_os = linux-gnu || test $host_os = linux ; then
--      LDFLAGS="$LDFLAGS -Wl,-rpath,$OCDxprefix/lib"
--    fi
--    # The "INCDIR" is also usable
--    CFLAGS="$CFLAGS -I$includedir"
--fi
--
- AC_ARG_WITH(ftd2xx,
-    AS_HELP_STRING([--with-ftd2xx=<PATH>],[This option has been removed.]),
-   [
package/openocd/openocd.mk +23 -5
index a12ba6c..2796e81 100644
@@ -3,16 +3,18 @@
 # openocd
 #
 #############################################################
-OPENOCD_VERSION:=0.5.0
-OPENOCD_SOURCE = openocd-$(OPENOCD_VERSION).tar.bz2
-OPENOCD_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/openocd/openocd/$(OPENOCD_VERSION)
+#OPENOCD_VERSION = master
+OPENOCD_VERSION = dec6b913809bd3f857af31be178ffde65e42dbab
+OPENOCD_SITE = git://openocd.git.sourceforge.net/gitroot/openocd/openocd
+OPENOCD_SITE_METHOD = git
 
 OPENOCD_AUTORECONF = YES
 OPENOCD_CONF_OPT = \
 	--oldincludedir=$(STAGING_DIR)/usr/include \
 	--includedir=$(STAGING_DIR)/usr/include \
 	--disable-doxygen-html \
-	--enable-dummy
+	--enable-dummy \
+    --enable-maintainer-mode
 
 OPENOCD_DEPENDENCIES = libusb-compat
 

@@ -32,12 +34,28 @@ endif
 
 HOST_OPENOCD_DEPENDENCIES = host-libusb-compat host-libftdi
 
+HOST_OPENOCD_AUTORECONF = YES
 HOST_OPENOCD_CONF_OPT = 	\
 	--disable-doxygen-html 	\
 	--enable-dummy 		\
 	--enable-ft2232_libftdi \
 	--enable-jlink 		\
-	--enable-vsllink
+	--enable-vsllink \
+	--enable-maintainer-mode 
+
+define DOWNLOAD_GIT
+	test -e $(DL_DIR)/$($(PKG)_SOURCE) || \
+	(pushd $(DL_DIR) > /dev/null && \
+	$(GIT) clone $($(PKG)_SITE) $($(PKG)_BASE_NAME) && \
+	pushd $($(PKG)_BASE_NAME) > /dev/null && \
+	$(GIT) checkout $($(PKG)_VERSION) && \
+	$(GIT) submodule init && \
+	$(GIT) submodule update && \
+	$(TAR) czf $(DL_DIR)/$($(PKG)_SOURCE) . &&\
+	popd > /dev/null && \
+	rm -rf $($(PKG)_DL_DIR) && \
+	popd > /dev/null)    
+endef
 
 $(eval $(call AUTOTARGETS))
 $(eval $(call AUTOTARGETS,host))
Signature · 1 line
1.7.9
NAK
#1 lore raw

PATCH 1/1 openocd: fetch package from git repository and update version

Quoted 7 lines · Alexandre Pereira da Silva

This overrided the DOWNLOAD_GIT method to also fetch the submodules used by openocd.
Removed patches that are not needed anymore by the new version. Updated the gnu99 patch to use configure.ac instead of configure.in. Fix a build problem in the stm32_stlink.c file.

Signed-off-by Alexandre Pereira da Silva <[email protected]>

NACK

please add a patch to fix the stm32_stlink

Best Regards,
J.

Quoted 261 lines
---
 ...s-compilation-host-libsub-was-used-before.patch |   33 -----------------
 ...001-smt32_stlink-Workaround-build-warning.patch |   32 +++++++++++++++++
 ...002-fix-xscale-uninitialise-breakpoint_pc.patch |   20 -----------
 package/openocd/openocd-0003-force-gnu99.patch     |   24 +++++++-----
 .../openocd/openocd-0005-dont-force-ldflags.patch  |   37 --------------------
 package/openocd/openocd.mk                         |   28 ++++++++++++---
 6 files changed, 69 insertions(+), 105 deletions(-)
 delete mode 100644 package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch
 create mode 100644 package/openocd/openocd-0001-smt32_stlink-Workaround-build-warning.patch
 delete mode 100644 package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch
 delete mode 100644 package/openocd/openocd-0005-dont-force-ldflags.patch
package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch deleted +0 -33
deleted file mode 100644
index caf1a8b..0000000
@@ -1,33 +0,0 @@
-From 3728c4af7f6303ccedab56ec220797f8f290580e Mon Sep 17 00:00:00 2001
-From: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
-Date: Wed, 10 Aug 2011 00:17:29 +0800
-Subject: [PATCH] fix cross compilation: host libsub was used before
-
-tested in buildroot
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
----
- configure.in |    7 +++++--
- 1 files changed, 5 insertions(+), 2 deletions(-)
-
-diff --git a/configure.in b/configure.in
-index dfa1e8f..cfe2218 100644
---- a/configure.in
-+++ b/configure.in
-@@ -1046,8 +1046,11 @@ build_usb=no
- if test $build_jlink = yes -o $build_vsllink = yes -o $build_usbprog = yes -o \
-   $build_rlink = yes -o $build_ulink = yes -o $build_armjtagew = yes
- then
--  AC_CHECK_HEADERS([usb.h],[],
--  [AC_MSG_ERROR([usb.h is required to build some OpenOCD driver(s)])])
-+  dnl check for libusb
-+  PKG_CHECK_MODULES(LIBUSB, libusb >= 0.1.11)
-+  CFLAGS="$CFLAGS $LIBUSB_CFLAGS"
-+  LDFLAGS="$LDFLAGS $LIBUSB_LDFLAGS"
-+  LIBS="$LIBS $LIBUSB_LIBS"
-   build_usb=yes
- fi
- 
--- 
-1.7.5.4
-
package/openocd/openocd-0001-smt32_stlink-Workaround-build-warning.patch new file +32 -0
new file mode 100644
index 0000000..a497f08
@@ -0,0 +1,32 @@
+smt32_stlink: workaround build warning
+
+Signed-off-by: Alexandre Pereira da Silva <[email protected]>
+---
+ src/target/stm32_stlink.c |    4 ++--
+ 1 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/target/stm32_stlink.c b/src/target/stm32_stlink.c
+index 32896cc..e7e5891 100644
+--- a/src/target/stm32_stlink.c
++++ b/src/target/stm32_stlink.c
+@@ -651,7 +651,7 @@ static int stm32_stlink_read_memory(struct target *target, uint32_t address,
+ 					address, c, dst);
+ 		else
+ 			res = stlink_if->layout->api->read_mem32(stlink_if->fd,
+-					address, c, (uint32_t *)dst);
++					address, c, (uint32_t *)(void *)dst);
+ 
+ 		if (res != ERROR_OK)
+ 			return res;
+@@ -700,7 +700,7 @@ static int stm32_stlink_write_memory(struct target *target, uint32_t address,
+ 					address, c, dst);
+ 		else
+ 			res = stlink_if->layout->api->write_mem32(stlink_if->fd,
+-					address, c, (uint32_t *)dst);
++					address, c, (uint32_t *)(void *)dst);
+ 
+ 		if (res != ERROR_OK)
+ 			return res;
+-- 
+1.7.9
+
package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch deleted +0 -20
deleted file mode 100644
index 328241e..0000000
@@ -1,20 +0,0 @@
-xscale: fix uninitialise breakpoint_pc
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
----
- src/target/xscale.c |    2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-Index: b/src/target/xscale.c
-===================================================================
---- a/src/target/xscale.c
-+++ b/src/target/xscale.c
-@@ -2811,7 +2811,7 @@ static int xscale_analyze_trace(struct t
-    struct xscale_common *xscale = target_to_xscale(target);
-    struct xscale_trace_data *trace_data = xscale->trace.data;
-    int i, retval;
--   uint32_t breakpoint_pc;
-+   uint32_t breakpoint_pc = 0;
-    struct arm_instruction instruction;
-    uint32_t current_pc = 0;  /* initialized when address determined */
-
package/openocd/openocd-0003-force-gnu99.patch +14 -10
index 106d112..5511f09 100644
@@ -1,19 +1,23 @@
 force gnu99
 
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
+Signed-off-by: Alexandre Pereira da Silva <[email protected]>
 ---
- configure.in |    1 +
- 1 file changed, 1 insertion(+)
+ configure.ac |    2 ++
+ 1 files changed, 2 insertions(+), 0 deletions(-)
 
-Index: b/configure.in
-===================================================================
---- a/configure.in
-+++ b/configure.in
-@@ -28,6 +28,7 @@ AC_DISABLE_SHARED
+diff --git a/configure.ac b/configure.ac
+index ffab637..60fe4ab 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -28,6 +28,8 @@ AC_DISABLE_SHARED
  AC_PROG_LIBTOOL
- AC_SUBST(LIBTOOL_DEPS)
+ AC_SUBST([LIBTOOL_DEPS])
 
 +CFLAGS="$CFLAGS -std=gnu99"
- 
++
  dnl configure checks required for Jim files (these are obsolete w/ C99)
  AC_C_CONST
+ AC_TYPE_LONG_LONG_INT
+-- 
+1.7.9
+
package/openocd/openocd-0005-dont-force-ldflags.patch deleted +0 -37
deleted file mode 100644
index 1880e00..0000000
@@ -1,37 +0,0 @@
-[PATCH] don't force library search path / rpath settings
-
-openocd adds -L$exec_prefix/lib -Wl,rpath,$exec_prefix/lib to the compile
-LDFLAGS if it isn't installed into /usr/local, which breaks cross compilation
-as the compiler ends up using host libraries.
----
- configure.in |   17 -----------------
- 1 file changed, 17 deletions(-)
-
-Index: openocd-0.5.0/configure.in
-===================================================================
---- openocd-0.5.0.orig/configure.in
-+++ openocd-0.5.0/configure.in
-@@ -174,23 +174,6 @@
- # Let make expand exec_prefix.
- test x"$OCDxprefix" = xNONE && OCDxprefix="$OCDprefix"
- 
--# what matters is the "exec-prefix"
--if test "$OCDxprefix" != "$ac_default_prefix"
--then
--    # We are installing in a non-standard place
--    # Nonstandard --prefix and/or --exec-prefix
--    # We have an override of some sort.
--    # use build specific install library dir
--
--    LDFLAGS="$LDFLAGS -L$OCDxprefix/lib"
--    # RPATH becomes an issue on Linux only
--    if test $host_os = linux-gnu || test $host_os = linux ; then
--      LDFLAGS="$LDFLAGS -Wl,-rpath,$OCDxprefix/lib"
--    fi
--    # The "INCDIR" is also usable
--    CFLAGS="$CFLAGS -I$includedir"
--fi
--
- AC_ARG_WITH(ftd2xx,
-    AS_HELP_STRING([--with-ftd2xx=<PATH>],[This option has been removed.]),
-   [
package/openocd/openocd.mk +23 -5
index a12ba6c..2796e81 100644
@@ -3,16 +3,18 @@
 # openocd
 #
 #############################################################
-OPENOCD_VERSION:=0.5.0
-OPENOCD_SOURCE = openocd-$(OPENOCD_VERSION).tar.bz2
-OPENOCD_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/openocd/openocd/$(OPENOCD_VERSION)
+#OPENOCD_VERSION = master
+OPENOCD_VERSION = dec6b913809bd3f857af31be178ffde65e42dbab
+OPENOCD_SITE = git://openocd.git.sourceforge.net/gitroot/openocd/openocd
+OPENOCD_SITE_METHOD = git
 
 OPENOCD_AUTORECONF = YES
 OPENOCD_CONF_OPT = \
 	--oldincludedir=$(STAGING_DIR)/usr/include \
 	--includedir=$(STAGING_DIR)/usr/include \
 	--disable-doxygen-html \
-	--enable-dummy
+	--enable-dummy \
+    --enable-maintainer-mode
 
 OPENOCD_DEPENDENCIES = libusb-compat
 

@@ -32,12 +34,28 @@ endif
 
 HOST_OPENOCD_DEPENDENCIES = host-libusb-compat host-libftdi
 
+HOST_OPENOCD_AUTORECONF = YES
 HOST_OPENOCD_CONF_OPT = 	\
 	--disable-doxygen-html 	\
 	--enable-dummy 		\
 	--enable-ft2232_libftdi \
 	--enable-jlink 		\
-	--enable-vsllink
+	--enable-vsllink \
+	--enable-maintainer-mode 
+
+define DOWNLOAD_GIT
+	test -e $(DL_DIR)/$($(PKG)_SOURCE) || \
+	(pushd $(DL_DIR) > /dev/null && \
+	$(GIT) clone $($(PKG)_SITE) $($(PKG)_BASE_NAME) && \
+	pushd $($(PKG)_BASE_NAME) > /dev/null && \
+	$(GIT) checkout $($(PKG)_VERSION) && \
+	$(GIT) submodule init && \
+	$(GIT) submodule update && \
+	$(TAR) czf $(DL_DIR)/$($(PKG)_SOURCE) . &&\
+	popd > /dev/null && \
+	rm -rf $($(PKG)_DL_DIR) && \
+	popd > /dev/null)    
+endef
 
 $(eval $(call AUTOTARGETS))
 $(eval $(call AUTOTARGETS,host))
Signature · 6 lines
1.7.9

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
author
#2 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

This overrided the DOWNLOAD_GIT method to also fetch the submodules used by openocd.
Removed patches that are not needed anymore by the new version. Updated the gnu99 patch to use configure.ac instead of configure.in. Fix a build problem in the stm32_stlink.c file.

Signed-off-by Alexandre Pereira da Silva <[email protected]>
---
 ...s-compilation-host-libsub-was-used-before.patch |   33 --------
 ...d-0001-stlink-fix-alignment-build-warning.patch |   83 ++++++++++++++++++++
 ...002-fix-xscale-uninitialise-breakpoint_pc.patch |   20 -----
 package/openocd/openocd-0003-force-gnu99.patch     |   24 ++++---
 .../openocd/openocd-0005-dont-force-ldflags.patch  |   37 ---------
 package/openocd/openocd.mk                         |   28 ++++++-
 6 files changed, 120 insertions(+), 105 deletions(-)
 delete mode 100644 package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch
 create mode 100644 package/openocd/openocd-0001-stlink-fix-alignment-build-warning.patch
 delete mode 100644 package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch
 delete mode 100644 package/openocd/openocd-0005-dont-force-ldflags.patch
package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch deleted +0 -33
deleted file mode 100644
index caf1a8b..0000000
@@ -1,33 +0,0 @@
-From 3728c4af7f6303ccedab56ec220797f8f290580e Mon Sep 17 00:00:00 2001
-From: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
-Date: Wed, 10 Aug 2011 00:17:29 +0800
-Subject: [PATCH] fix cross compilation: host libsub was used before
-
-tested in buildroot
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
----
- configure.in |    7 +++++--
- 1 files changed, 5 insertions(+), 2 deletions(-)
-
-diff --git a/configure.in b/configure.in
-index dfa1e8f..cfe2218 100644
---- a/configure.in
-+++ b/configure.in
-@@ -1046,8 +1046,11 @@ build_usb=no
- if test $build_jlink = yes -o $build_vsllink = yes -o $build_usbprog = yes -o \
-   $build_rlink = yes -o $build_ulink = yes -o $build_armjtagew = yes
- then
--  AC_CHECK_HEADERS([usb.h],[],
--  [AC_MSG_ERROR([usb.h is required to build some OpenOCD driver(s)])])
-+  dnl check for libusb
-+  PKG_CHECK_MODULES(LIBUSB, libusb >= 0.1.11)
-+  CFLAGS="$CFLAGS $LIBUSB_CFLAGS"
-+  LDFLAGS="$LDFLAGS $LIBUSB_LDFLAGS"
-+  LIBS="$LIBS $LIBUSB_LIBS"
-   build_usb=yes
- fi
- 
--- 
-1.7.5.4
-
package/openocd/openocd-0001-stlink-fix-alignment-build-warning.patch new file +83 -0

83 lines not on this page · raw message

package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch deleted +0 -20
deleted file mode 100644
index 328241e..0000000
@@ -1,20 +0,0 @@
-xscale: fix uninitialise breakpoint_pc
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
----
- src/target/xscale.c |    2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-Index: b/src/target/xscale.c
-===================================================================
---- a/src/target/xscale.c
-+++ b/src/target/xscale.c
-@@ -2811,7 +2811,7 @@ static int xscale_analyze_trace(struct t
-    struct xscale_common *xscale = target_to_xscale(target);
-    struct xscale_trace_data *trace_data = xscale->trace.data;
-    int i, retval;
--   uint32_t breakpoint_pc;
-+   uint32_t breakpoint_pc = 0;
-    struct arm_instruction instruction;
-    uint32_t current_pc = 0;  /* initialized when address determined */
-
package/openocd/openocd-0003-force-gnu99.patch +14 -10
index 106d112..5511f09 100644
@@ -1,19 +1,23 @@
 force gnu99
 
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
+Signed-off-by: Alexandre Pereira da Silva <[email protected]>
 ---
- configure.in |    1 +
- 1 file changed, 1 insertion(+)
+ configure.ac |    2 ++
+ 1 files changed, 2 insertions(+), 0 deletions(-)
 
-Index: b/configure.in
-===================================================================
---- a/configure.in
-+++ b/configure.in
-@@ -28,6 +28,7 @@ AC_DISABLE_SHARED
+diff --git a/configure.ac b/configure.ac
+index ffab637..60fe4ab 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -28,6 +28,8 @@ AC_DISABLE_SHARED
  AC_PROG_LIBTOOL
- AC_SUBST(LIBTOOL_DEPS)
+ AC_SUBST([LIBTOOL_DEPS])
  
 +CFLAGS="$CFLAGS -std=gnu99"
- 
++
  dnl configure checks required for Jim files (these are obsolete w/ C99)
  AC_C_CONST
+ AC_TYPE_LONG_LONG_INT
+-- 
+1.7.9
+
package/openocd/openocd-0005-dont-force-ldflags.patch deleted +0 -37
deleted file mode 100644
index 1880e00..0000000
@@ -1,37 +0,0 @@
-[PATCH] don't force library search path / rpath settings
-
-openocd adds -L$exec_prefix/lib -Wl,rpath,$exec_prefix/lib to the compile
-LDFLAGS if it isn't installed into /usr/local, which breaks cross compilation
-as the compiler ends up using host libraries.
----
- configure.in |   17 -----------------
- 1 file changed, 17 deletions(-)
-
-Index: openocd-0.5.0/configure.in
-===================================================================
---- openocd-0.5.0.orig/configure.in
-+++ openocd-0.5.0/configure.in
-@@ -174,23 +174,6 @@
- # Let make expand exec_prefix.
- test x"$OCDxprefix" = xNONE && OCDxprefix="$OCDprefix"
- 
--# what matters is the "exec-prefix"
--if test "$OCDxprefix" != "$ac_default_prefix"
--then
--    # We are installing in a non-standard place
--    # Nonstandard --prefix and/or --exec-prefix
--    # We have an override of some sort.
--    # use build specific install library dir
--
--    LDFLAGS="$LDFLAGS -L$OCDxprefix/lib"
--    # RPATH becomes an issue on Linux only
--    if test $host_os = linux-gnu || test $host_os = linux ; then
--      LDFLAGS="$LDFLAGS -Wl,-rpath,$OCDxprefix/lib"
--    fi
--    # The "INCDIR" is also usable
--    CFLAGS="$CFLAGS -I$includedir"
--fi
--
- AC_ARG_WITH(ftd2xx,
-    AS_HELP_STRING([--with-ftd2xx=<PATH>],[This option has been removed.]),
-   [
package/openocd/openocd.mk +23 -5
index a12ba6c..2796e81 100644
@@ -3,16 +3,18 @@
 # openocd
 #
 #############################################################
-OPENOCD_VERSION:=0.5.0
-OPENOCD_SOURCE = openocd-$(OPENOCD_VERSION).tar.bz2
-OPENOCD_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/openocd/openocd/$(OPENOCD_VERSION)
+#OPENOCD_VERSION = master
+OPENOCD_VERSION = dec6b913809bd3f857af31be178ffde65e42dbab
+OPENOCD_SITE = git://openocd.git.sourceforge.net/gitroot/openocd/openocd
+OPENOCD_SITE_METHOD = git
 
 OPENOCD_AUTORECONF = YES
 OPENOCD_CONF_OPT = \
 	--oldincludedir=$(STAGING_DIR)/usr/include \
 	--includedir=$(STAGING_DIR)/usr/include \
 	--disable-doxygen-html \
-	--enable-dummy
+	--enable-dummy \
+    --enable-maintainer-mode
 
 OPENOCD_DEPENDENCIES = libusb-compat
 

@@ -32,12 +34,28 @@ endif
 
 HOST_OPENOCD_DEPENDENCIES = host-libusb-compat host-libftdi
 
+HOST_OPENOCD_AUTORECONF = YES
 HOST_OPENOCD_CONF_OPT = 	\
 	--disable-doxygen-html 	\
 	--enable-dummy 		\
 	--enable-ft2232_libftdi \
 	--enable-jlink 		\
-	--enable-vsllink
+	--enable-vsllink \
+	--enable-maintainer-mode 
+
+define DOWNLOAD_GIT
+	test -e $(DL_DIR)/$($(PKG)_SOURCE) || \
+	(pushd $(DL_DIR) > /dev/null && \
+	$(GIT) clone $($(PKG)_SITE) $($(PKG)_BASE_NAME) && \
+	pushd $($(PKG)_BASE_NAME) > /dev/null && \
+	$(GIT) checkout $($(PKG)_VERSION) && \
+	$(GIT) submodule init && \
+	$(GIT) submodule update && \
+	$(TAR) czf $(DL_DIR)/$($(PKG)_SOURCE) . &&\
+	popd > /dev/null && \
+	rm -rf $($(PKG)_DL_DIR) && \
+	popd > /dev/null)    
+endef
 
 $(eval $(call AUTOTARGETS))
 $(eval $(call AUTOTARGETS,host))
Signature · 1 line
1.7.9
#3 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

Quoted 8 lines · Alexandre Pereira da Silva

This overrided the DOWNLOAD_GIT method to also fetch the submodules used by openocd.
Removed patches that are not needed anymore by the new version. Updated the gnu99 patch to use configure.ac instead of configure.in. Fix a build problem in the stm32_stlink.c file.

Signed-off-by Alexandre Pereira da Silva <[email protected]>

---

again NACK

DO NOT USE GIT in the release

and did you try to build it for the target as ARM?

Best Regards,
J.

Quoted 311 lines
 ...s-compilation-host-libsub-was-used-before.patch |   33 --------
 ...d-0001-stlink-fix-alignment-build-warning.patch |   83 ++++++++++++++++++++
 ...002-fix-xscale-uninitialise-breakpoint_pc.patch |   20 -----
 package/openocd/openocd-0003-force-gnu99.patch     |   24 ++++---
 .../openocd/openocd-0005-dont-force-ldflags.patch  |   37 ---------
 package/openocd/openocd.mk                         |   28 ++++++-
 6 files changed, 120 insertions(+), 105 deletions(-)
 delete mode 100644 package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch
 create mode 100644 package/openocd/openocd-0001-stlink-fix-alignment-build-warning.patch
 delete mode 100644 package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch
 delete mode 100644 package/openocd/openocd-0005-dont-force-ldflags.patch
package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch deleted +0 -33
deleted file mode 100644
index caf1a8b..0000000
@@ -1,33 +0,0 @@
-From 3728c4af7f6303ccedab56ec220797f8f290580e Mon Sep 17 00:00:00 2001
-From: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
-Date: Wed, 10 Aug 2011 00:17:29 +0800
-Subject: [PATCH] fix cross compilation: host libsub was used before
-
-tested in buildroot
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
----
- configure.in |    7 +++++--
- 1 files changed, 5 insertions(+), 2 deletions(-)
-
-diff --git a/configure.in b/configure.in
-index dfa1e8f..cfe2218 100644
---- a/configure.in
-+++ b/configure.in
-@@ -1046,8 +1046,11 @@ build_usb=no
- if test $build_jlink = yes -o $build_vsllink = yes -o $build_usbprog = yes -o \
-   $build_rlink = yes -o $build_ulink = yes -o $build_armjtagew = yes
- then
--  AC_CHECK_HEADERS([usb.h],[],
--  [AC_MSG_ERROR([usb.h is required to build some OpenOCD driver(s)])])
-+  dnl check for libusb
-+  PKG_CHECK_MODULES(LIBUSB, libusb >= 0.1.11)
-+  CFLAGS="$CFLAGS $LIBUSB_CFLAGS"
-+  LDFLAGS="$LDFLAGS $LIBUSB_LDFLAGS"
-+  LIBS="$LIBS $LIBUSB_LIBS"
-   build_usb=yes
- fi
- 
--- 
-1.7.5.4
-
package/openocd/openocd-0001-stlink-fix-alignment-build-warning.patch new file +83 -0
new file mode 100644
index 0000000..2d8e521
@@ -0,0 +1,83 @@
+From 94228f37f54ace3040bea1e5c2ccee895d854859 Mon Sep 17 00:00:00 2001
+From: Alexandre Pereira da Silva <[email protected]>
+Date: Fri, 24 Feb 2012 18:51:48 -0200
+Subject: [PATCH] stlink: fix alignment build warning
+
+The {read,write}_mem32 interface functions was asking a 32 bits buffer but
+they don't need 32 bits alignment.
+This will change the interface to a 8 bits buffer to remove the alignment
+mismatch warning. This was causing build errors on platforms with strict
+aliasing rules.
+
+Change-Id: I338be8df5686f07a64ddb4f17c1bb494af583999
+Signed-off-by: Alexandre Pereira da Silva <[email protected]>
+---
+ src/jtag/drivers/stlink_usb.c   |    4 ++--
+ src/jtag/stlink/stlink_layout.h |    4 ++--
+ src/target/stm32_stlink.c       |    4 ++--
+ 3 files changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/src/jtag/drivers/stlink_usb.c b/src/jtag/drivers/stlink_usb.c
+index 3cb2434..4604716 100644
+--- a/src/jtag/drivers/stlink_usb.c
++++ b/src/jtag/drivers/stlink_usb.c
+@@ -968,7 +968,7 @@ static int stlink_usb_write_mem8(void *handle, uint32_t addr, uint16_t len,
+ 
+ /** */
+ static int stlink_usb_read_mem32(void *handle, uint32_t addr, uint16_t len,
+-			  uint32_t *buffer)
++			  uint8_t *buffer)
+ {
+ 	int res;
+ 	struct stlink_usb_handle_s *h;
+@@ -998,7 +998,7 @@ static int stlink_usb_read_mem32(void *handle, uint32_t addr, uint16_t len,
+ 
+ /** */
+ static int stlink_usb_write_mem32(void *handle, uint32_t addr, uint16_t len,
+-			   const uint32_t *buffer)
++			   const uint8_t *buffer)
+ {
+ 	int res;
+ 	struct stlink_usb_handle_s *h;
+diff --git a/src/jtag/stlink/stlink_layout.h b/src/jtag/stlink/stlink_layout.h
+index c0c89f5..59e6174 100644
+--- a/src/jtag/stlink/stlink_layout.h
++++ b/src/jtag/stlink/stlink_layout.h
+@@ -56,10 +56,10 @@ struct stlink_layout_api_s {
+ 			    const uint8_t *buffer);
+ 	/** */
+ 	int (*read_mem32) (void *handle, uint32_t addr, uint16_t len,
+-			   uint32_t *buffer);
++			   uint8_t *buffer);
+ 	/** */
+ 	int (*write_mem32) (void *handle, uint32_t addr, uint16_t len,
+-			    const uint32_t *buffer);
++			    const uint8_t *buffer);
+ 	/** */
+ 	int (*idcode) (void *fd, uint32_t *idcode);
+ 	/** */
+diff --git a/src/target/stm32_stlink.c b/src/target/stm32_stlink.c
+index 32896cc..fc97188 100644
+--- a/src/target/stm32_stlink.c
++++ b/src/target/stm32_stlink.c
+@@ -651,7 +651,7 @@ static int stm32_stlink_read_memory(struct target *target, uint32_t address,
+ 					address, c, dst);
+ 		else
+ 			res = stlink_if->layout->api->read_mem32(stlink_if->fd,
+-					address, c, (uint32_t *)dst);
++					address, c, dst);
+ 
+ 		if (res != ERROR_OK)
+ 			return res;
+@@ -700,7 +700,7 @@ static int stm32_stlink_write_memory(struct target *target, uint32_t address,
+ 					address, c, dst);
+ 		else
+ 			res = stlink_if->layout->api->write_mem32(stlink_if->fd,
+-					address, c, (uint32_t *)dst);
++					address, c, dst);
+ 
+ 		if (res != ERROR_OK)
+ 			return res;
+-- 
+1.7.9
+
package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch deleted +0 -20
deleted file mode 100644
index 328241e..0000000
@@ -1,20 +0,0 @@
-xscale: fix uninitialise breakpoint_pc
-
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
----
- src/target/xscale.c |    2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-Index: b/src/target/xscale.c
-===================================================================
---- a/src/target/xscale.c
-+++ b/src/target/xscale.c
-@@ -2811,7 +2811,7 @@ static int xscale_analyze_trace(struct t
-    struct xscale_common *xscale = target_to_xscale(target);
-    struct xscale_trace_data *trace_data = xscale->trace.data;
-    int i, retval;
--   uint32_t breakpoint_pc;
-+   uint32_t breakpoint_pc = 0;
-    struct arm_instruction instruction;
-    uint32_t current_pc = 0;  /* initialized when address determined */
-
package/openocd/openocd-0003-force-gnu99.patch +14 -10
index 106d112..5511f09 100644
@@ -1,19 +1,23 @@
 force gnu99
 
-Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
+Signed-off-by: Alexandre Pereira da Silva <[email protected]>
 ---
- configure.in |    1 +
- 1 file changed, 1 insertion(+)
+ configure.ac |    2 ++
+ 1 files changed, 2 insertions(+), 0 deletions(-)
 
-Index: b/configure.in
-===================================================================
---- a/configure.in
-+++ b/configure.in
-@@ -28,6 +28,7 @@ AC_DISABLE_SHARED
+diff --git a/configure.ac b/configure.ac
+index ffab637..60fe4ab 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -28,6 +28,8 @@ AC_DISABLE_SHARED
  AC_PROG_LIBTOOL
- AC_SUBST(LIBTOOL_DEPS)
+ AC_SUBST([LIBTOOL_DEPS])
 
 +CFLAGS="$CFLAGS -std=gnu99"
- 
++
  dnl configure checks required for Jim files (these are obsolete w/ C99)
  AC_C_CONST
+ AC_TYPE_LONG_LONG_INT
+-- 
+1.7.9
+
package/openocd/openocd-0005-dont-force-ldflags.patch deleted +0 -37
deleted file mode 100644
index 1880e00..0000000
@@ -1,37 +0,0 @@
-[PATCH] don't force library search path / rpath settings
-
-openocd adds -L$exec_prefix/lib -Wl,rpath,$exec_prefix/lib to the compile
-LDFLAGS if it isn't installed into /usr/local, which breaks cross compilation
-as the compiler ends up using host libraries.
----
- configure.in |   17 -----------------
- 1 file changed, 17 deletions(-)
-
-Index: openocd-0.5.0/configure.in
-===================================================================
---- openocd-0.5.0.orig/configure.in
-+++ openocd-0.5.0/configure.in
-@@ -174,23 +174,6 @@
- # Let make expand exec_prefix.
- test x"$OCDxprefix" = xNONE && OCDxprefix="$OCDprefix"
- 
--# what matters is the "exec-prefix"
--if test "$OCDxprefix" != "$ac_default_prefix"
--then
--    # We are installing in a non-standard place
--    # Nonstandard --prefix and/or --exec-prefix
--    # We have an override of some sort.
--    # use build specific install library dir
--
--    LDFLAGS="$LDFLAGS -L$OCDxprefix/lib"
--    # RPATH becomes an issue on Linux only
--    if test $host_os = linux-gnu || test $host_os = linux ; then
--      LDFLAGS="$LDFLAGS -Wl,-rpath,$OCDxprefix/lib"
--    fi
--    # The "INCDIR" is also usable
--    CFLAGS="$CFLAGS -I$includedir"
--fi
--
- AC_ARG_WITH(ftd2xx,
-    AS_HELP_STRING([--with-ftd2xx=<PATH>],[This option has been removed.]),
-   [
package/openocd/openocd.mk +23 -5
index a12ba6c..2796e81 100644
@@ -3,16 +3,18 @@
 # openocd
 #
 #############################################################
-OPENOCD_VERSION:=0.5.0
-OPENOCD_SOURCE = openocd-$(OPENOCD_VERSION).tar.bz2
-OPENOCD_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/openocd/openocd/$(OPENOCD_VERSION)
+#OPENOCD_VERSION = master
+OPENOCD_VERSION = dec6b913809bd3f857af31be178ffde65e42dbab
+OPENOCD_SITE = git://openocd.git.sourceforge.net/gitroot/openocd/openocd
+OPENOCD_SITE_METHOD = git
 
 OPENOCD_AUTORECONF = YES
 OPENOCD_CONF_OPT = \
 	--oldincludedir=$(STAGING_DIR)/usr/include \
 	--includedir=$(STAGING_DIR)/usr/include \
 	--disable-doxygen-html \
-	--enable-dummy
+	--enable-dummy \
+    --enable-maintainer-mode
 
 OPENOCD_DEPENDENCIES = libusb-compat
 

@@ -32,12 +34,28 @@ endif
 
 HOST_OPENOCD_DEPENDENCIES = host-libusb-compat host-libftdi
 
+HOST_OPENOCD_AUTORECONF = YES
 HOST_OPENOCD_CONF_OPT = 	\
 	--disable-doxygen-html 	\
 	--enable-dummy 		\
 	--enable-ft2232_libftdi \
 	--enable-jlink 		\
-	--enable-vsllink
+	--enable-vsllink \
+	--enable-maintainer-mode 
+
+define DOWNLOAD_GIT
+	test -e $(DL_DIR)/$($(PKG)_SOURCE) || \
+	(pushd $(DL_DIR) > /dev/null && \
+	$(GIT) clone $($(PKG)_SITE) $($(PKG)_BASE_NAME) && \
+	pushd $($(PKG)_BASE_NAME) > /dev/null && \
+	$(GIT) checkout $($(PKG)_VERSION) && \
+	$(GIT) submodule init && \
+	$(GIT) submodule update && \
+	$(TAR) czf $(DL_DIR)/$($(PKG)_SOURCE) . &&\
+	popd > /dev/null && \
+	rm -rf $($(PKG)_DL_DIR) && \
+	popd > /dev/null)    
+endef
 
 $(eval $(call AUTOTARGETS))
 $(eval $(call AUTOTARGETS,host))
Signature · 6 lines
1.7.9

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
#4 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

Quoted 7 lines · On Saturday 25 February 2012 04:33:01 Jean-Christophe PLAGNIOL-VILLARD wrote:
Quoted 6 lines · Alexandre Pereira da Silva

This overrided the DOWNLOAD_GIT method to also fetch the submodules used by openocd.
Removed patches that are not needed anymore by the new version. Updated the gnu99 patch to use configure.ac instead of configure.in. Fix a build problem in the stm32_stlink.c file.

Quoted 5 lines
Quoted 2 lines
Signed-off-by Alexandre Pereira da Silva <[email protected]>

---

again NACK

DO NOT USE GIT in the release

Instead of just shouting at Alexandre, perhaps you can explain why it's
a bad idea to use the git version for openocd...

Alexandre, why do you need a more recent version than the official
release?

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
author
#5 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

Quoted 9 lines
Quoted 3 lines

again NACK

DO NOT USE GIT in the release

?Instead of just shouting at Alexandre, perhaps you can explain why it's a bad idea to use the git version for openocd...

?Alexandre, why do you need a more recent version than the official release?

The openocd release is 6 months old and they made many improvements since then. And I don't see any plans for them to release a new version any time soon.

Openocd git head is usually more stable than their latest released version. Specially if the support for the target you are using is new. I have had issues connecting one of my cortex-m3 targets with openocd 0.5.0.

This is a special package like u-boot and the kernel because in many occasions you have to tweak the package to suit your own hardware.

Other option would be to use 0.5.0 version from git, so people who run into this kind of issue, can override the version more easily.

Another comment on this issue is about git submodule fetching. Do you think that could be useful to other packages? If so, I can prepare a new patch to fetch all submodules, if any.

NAK
#6 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

Quoted 7 lines · Alexandre Pereira da Silva
Quoted 7 lines
Quoted 3 lines

again NACK

DO NOT USE GIT in the release

?Instead of just shouting at Alexandre, perhaps you can explain why it's a bad idea to use the git version for openocd...

Quoted 6 lines
Quoted 2 lines

?Alexandre, why do you need a more recent version than the official release?

The openocd release is 6 months old and they made many improvements since then. And I don't see any plans for them to release a new version any time soon.

I will release a new version of openocd in time, today the current version is not stable enough

Quoted 8 lines

Openocd git head is usually more stable than their latest released version. Specially if the support for the target you are using is new. I have had issues connecting one of my cortex-m3 targets with openocd 0.5.0.

This is a special package like u-boot and the kernel because in many occasions you have to tweak the package to suit your own hardware.

The NACK stand

You can do it for your local but for mainline no, barebox/ u-boot, linux are based on release

Quoted 3 lines

Other option would be to use 0.5.0 version from git, so people who run into this kind of issue, can override the version more easily.

NACK

git is very slow to download it's NOT an option at all for default version

Quoted 4 lines

Another comment on this issue is about git submodule fetching. Do you think that could be useful to other packages? If so, I can prepare a new patch to fetch all submodules, if any.

this is yes

Best Regards,
J.

#7 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

Quoted 1 line · On Sunday 26 February 2012 04:37:06 Jean-Christophe PLAGNIOL-VILLARD wrote:

On 00:06 Sun 26 Feb , Alexandre Pereira da Silva wrote:

[snip]

Quoted 5 lines
Quoted 3 lines

The openocd release is 6 months old and they made many improvements since then. And I don't see any plans for them to release a new version any time soon.

I will release a new version of openocd in time, today the current version is not stable enough

That's a good reason to NACK the use of the git commit. Thank you for
the explanation, Jean-Christophe.

Quoted 6 lines
Quoted 2 lines

This is a special package like u-boot and the kernel because in many occasions you have to tweak the package to suit your own hardware.

The NACK stand

You can do it for your local but for mainline no, barebox/ u-boot, linux are based on release

Difference being that all of those release quite frequently :-)

Quoted 5 lines
Quoted 2 lines

Other option would be to use 0.5.0 version from git, so people who run into this kind of issue, can override the version more easily.

NACK

git is very slow to download it's NOT an option at all for default version

Good point as well.

With the need for local patches and the occasional local need for a git
version rather than a release, you could consider adding git and patches support to openocd's Config.in, like is the case for U-Boot and linux.

Quoted 3 lines
Quoted 3 lines

Another comment on this issue is about git submodule fetching. Do you think that could be useful to other packages? If so, I can prepare a new patch to fetch all submodules, if any.

I'm not too keen on that. Although I could be convinced. Such a
feature would definitely have to be verified with all current git-based packages.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#8 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

In reply to Arnout Vandecappelle
Quoted 8 lines · Arnout Vandecappelle
Quoted 7 lines · On Saturday 25 February 2012 04:33:01 Jean-Christophe PLAGNIOL-VILLARD wrote:
Quoted 6 lines · Alexandre Pereira da Silva

This overrided the DOWNLOAD_GIT method to also fetch the submodules used by openocd.
Removed patches that are not needed anymore by the new version. Updated the gnu99 patch to use configure.ac instead of configure.in. Fix a build problem in the stm32_stlink.c file.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Alexandre Pereira da Silva <[email protected]>

---

again NACK

DO NOT USE GIT in the release

Instead of just shouting at Alexandre, perhaps you can explain why it's
a bad idea to use the git version for openocd...

I known when I'm shuting someeone and why and how to do it so please never resend such comment

Best Regards,
J.

#9 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 10 lines · Arnout Vandecappelle
Quoted 9 lines · On Saturday 25 February 2012 04:33:01 Jean-Christophe PLAGNIOL-VILLARD wrote:
Quoted 8 lines · Alexandre Pereira da Silva

This overrided the DOWNLOAD_GIT method to also fetch the submodules used by openocd.
Removed patches that are not needed anymore by the new version. Updated the gnu99 patch to use configure.ac instead of configure.in. Fix a build problem in the stm32_stlink.c file.

Signed-off-by Alexandre Pereira da Silva <[email protected]>

---

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

again NACK

DO NOT USE GIT in the release

Instead of just shouting at Alexandre, perhaps you can explain why it's
a bad idea to use the git version for openocd...

I known when I'm shuting someeone and why and how to do it so please never resend such comment

and here it's not the case

Best Regards,
J.

#10 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

In reply to Jean-Christophe PLAGNIOL-VILLARD

Le Sun, 26 Feb 2012 05:39:01 +0100,
Jean-Christophe PLAGNIOL-VILLARD <[email protected]> a ?crit :

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

DO NOT USE GIT in the release

Instead of just shouting at Alexandre, perhaps you can explain why
it's a bad idea to use the git version for openocd...

I known when I'm shuting someeone and why and how to do it so please never resend such comment

Sorry Jean-Christophe, but you're sending really disrespectful comments to both Alexandre and Arnout and this is not acceptable.

Arnout's comment asking you to stop shouting at Alexandre was absolutely correct, and I fully support Arnout here.

If you don't like the fact that we, as a community, try to maintain a nice, welcoming and respectful atmosphere, then it's up to you to move away. It's definitely not Arnout who should stop sending comments which aim at maintaining this nice, welcoming and respectful atmosphere.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#11 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Thomas> If you don't like the fact that we, as a community, try to Thomas> maintain a nice, welcoming and respectful atmosphere, then it's Thomas> up to you to move away. It's definitely not Arnout who should Thomas> stop sending comments which aim at maintaining this nice, Thomas> welcoming and respectful atmosphere.

Thomas> Best regards,

I completely agree.

Signature · 1 line
Bye, Peter Korsgaard
#12 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

In reply to Thomas Petazzoni
Quoted 13 lines · Thomas Petazzoni

Le Sun, 26 Feb 2012 05:39:01 +0100,
Jean-Christophe PLAGNIOL-VILLARD <[email protected]> a ?crit :

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

DO NOT USE GIT in the release

Instead of just shouting at Alexandre, perhaps you can explain why
it's a bad idea to use the git version for openocd...

I known when I'm shuting someeone and why and how to do it so please never resend such comment

Sorry Jean-Christophe, but you're sending really disrespectful comments to both Alexandre and Arnout and this is not acceptable.

Quoted 7 lines

Arnout's comment asking you to stop shouting at Alexandre was absolutely correct, and I fully support Arnout here.

If you don't like the fact that we, as a community, try to maintain a nice, welcoming and respectful atmosphere, then it's up to you to move away. It's definitely not Arnout who should stop sending comments which aim at maintaining this nice, welcoming and respectful atmosphere.

Except I'm not shooting Alexandre, so I'll said my mind about someone saying I'm shooting someone.

I Nack a patch. When you ask somone to do not do something and in the V2 he redo the same you get an highlight. It's normal.
We are in text email the "DO NOT USE...." is normal also, it's an highlight. I did not send a full e-mail in Capitul letter

If you want to see shooting read someone of the e-mail on the kernel ML, here it's not.

And I'm a Opensource Maintainer for years, I known the difference between shooting or not.

Best Regrds,
J.

author
#13 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

Quoted 4 lines

I Nack a patch. When you ask somone to do not do something and in the V2 he redo the same you get an highlight. It's normal.
We are in text email the "DO NOT USE...." is normal also, it's an highlight. I did not send a full e-mail in Capitul letter

My only problem with this whole situation is the lost time because of the misleading response:

Jean> please add a patch to fix the stm32_stlink

From that I can only deduce that everything is OK besides one of the package patches.

If your first response clearly stated that this kind of patch was not going to be accepted anyhow, I would stop there and look for other alternatives.

This is Lost time that could be used on the project and in my own products to add other useful features.

#14 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

Hello Alexandre,

Le Wed, 29 Feb 2012 14:20:34 -0300,
Alexandre Pereira da Silva <[email protected]> a ?crit :

Quoted 8 lines

My only problem with this whole situation is the lost time because of the misleading response:

Jean> please add a patch to fix the stm32_stlink

From that I can only deduce that everything is OK besides one of the package patches.

Quoted 6 lines

If your first response clearly stated that this kind of patch was not going to be accepted anyhow, I would stop there and look for other alternatives.

This is Lost time that could be used on the project and in my own products to add other useful features.

Jean-Christophe is sometimes a bit strong in his replies, and it's definitely not the kind of attitude we want in the Buildroot community.

Alexandre, your contributions are more than welcome. We may of course sometimes have comments on them, but in general, but really welcome your contributions.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#15 lore raw

PATCH v2 1/1 openocd: fetch package from git repository and update version

In reply to Jean-Christophe PLAGNIOL-VILLARD

Jean-Christophe, All,

Quoted 1 line · On Wednesday 29 February 2012 15:42:25 Jean-Christophe PLAGNIOL-VILLARD wrote:

We are in text email the "DO NOT USE...." is normal also, it's an highlight.

For the records:
This is SHOUTING.
This is *bold text*
This is _underlined text_
This is /italic text/
This is "quoted text"
This is a _/*MIX OF THE ABOVE*/_

Highlight (or better yet: emphasise) is to use *bold* markings.

This has been thus for ages now. For reference, see the netiquette, especially sections 2.1.1 and 3.0 for email discussions:

    https://tools.ietf.org/html/rfc1855

Exerpt:
---8<---
- Use mixed case. UPPER CASE LOOKS AS IF YOU'RE SHOUTING.

- Use symbols for emphasis. That *is* what I meant. Use underscores for underlining. _War and Peace_ is my favorite book.
---8<---

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'