ARM: mx51: Fix build error due to missing include of <linux/bug.h>

Fix the following build error:

arch/arm/mach-imx/cpu_op-mx51.c: In function 'mx51_get_cpu_op':
arch/arm/mach-imx/cpu_op-mx51.c:27: error: implicit declaration of function 'BUILD_BUG_ON_ZERO'

Signed-off-by Fabio Estevam <[email protected]>

---
This applies against linux-next

 arch/arm/mach-imx/cpu_op-mx51.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/mach-imx/cpu_op-mx51.c +1 -0

index 9d34c3d..9a4f77a 100644
@@ -14,6 +14,7 @@
 #include <linux/types.h>
 #include <mach/hardware.h>
 #include <linux/kernel.h>
+#include <linux/bug.h>
 
 static struct cpu_op mx51_cpu_op[] = {
 	{

Signature · 8 lines

1.7.1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

I think having the asm/bug.h replaced with linux/bug.h in linux/kernel.h would be a better solution.

Quoted 2 lines · Russell King - ARM Linux

I think having the asm/bug.h replaced with linux/bug.h in linux/kernel.h would be a better solution.

commit 6f863554 (kernel.h: doesn't explicitly use bug.h, so don't include it. ), which appears in linux-next, has removed asm/debug.h from linux/kernel.h.

I should have pointed this commit ID in my commit log.

Quoted 11 lines · Fabio Estevam

Quoted 2 lines · Russell King - ARM Linux

I think having the asm/bug.h replaced with linux/bug.h in linux/kernel.h would be a better solution.

commit 6f863554 (kernel.h: doesn't explicitly use bug.h, so don't include it. ), which appears in linux-next, has removed asm/debug.h from linux/kernel.h.

I should have pointed this commit ID in my commit log.

No, this is not a fix, and it probably makes things worse.

linux/kernel.h _does_ use bug stuff - in ARRAY_SIZE().

ARRAY_SIZE() uses __must_be_array(), which is defined in linux/compiler-gcc.h,
which is obtained via linux/compiler.h and linux/linkage.h.

linux/compiler-gcc.h defines __must_be_array() to be:
#define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))

and BUILD_BUG_ON_ZERO used to be in linux/kernel.h but got moved to linux/bug.h.

Hence why people are seeing build breakage with ARRAY_SIZE().

The answer is not to start scattering lots of .c files with linux/bug.h includes, but to fix linux/kernel.h.

The answer is not to start scattering lots of .c files with linux/bug.h includes, but to fix linux/kernel.h.

[Re: [PATCH] ARM: mx51: Fix build error due to missing include of <linux/bug.h>] On 28/02/2012 (Tue 13:21) Russell King - ARM Linux wrote:

[...]

Quoted 2 lines

The answer is not to start scattering lots of .c files with linux/bug.h includes, but to fix linux/kernel.h.

Hi Russell,

I understand your concerns, and had I found myself "buggering" lots of .c files, I would have backed away and said to myself, "OK, this really isn't going to work - we really can't do this."

But to put some metrics to it, after building for about 10 different arch and all their defconfigs, I only had to change about twenty[1] of the approximately sixteen thousand .c files in the kernel.