Skip to contentSkip to conversation

USB: reevaluate iomux stdin on USB kbd detect

PATCH New Allen Martin 3 participants 7 messages Dec 23, 2011 – Feb 29, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: reevaluate iomux stdin on USB kbd detect

If CONSOLE_MUX is enabled, reevaluate console stdin when USB keyboard device is detected.

---
 common/usb_kbd.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
common/usb_kbd.c +6 -0
index e94bb7e..577a1eb 100644
@@ -493,6 +493,11 @@ int drv_usb_kbd_init(void)
 		if (error)
 			return error;
 
+#ifdef CONFIG_CONSOLE_MUX
+		error = iomux_doenv(stdin, stdinname);
+		if (error)
+			return error;
+#else
 		/* Check if this is the standard input device. */
 		if (strcmp(stdinname, DEVNAME))
 			return 1;
@@ -504,6 +509,7 @@ int drv_usb_kbd_init(void)
 		error = console_assign(stdin, DEVNAME);
 		if (error)
 			return error;
+#endif
 
 		return 1;
 	}
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 USB: reevaluate iomux stdin on USB kbd detect

Quoted 4 lines

If CONSOLE_MUX is enabled, reevaluate console stdin when USB keyboard device is detected.

ping, anyone have any comments/feedback?

-Allen

nvpublic

#2 lore raw

PATCH 1/1 USB: reevaluate iomux stdin on USB kbd detect

Quoted 7 lines
Quoted 4 lines

If CONSOLE_MUX is enabled, reevaluate console stdin when USB keyboard device is detected.

ping, anyone have any comments/feedback?

Hi, anyone want to give this patch some love so USB keyboard can work on EHCI again?

-Allen

nvpublic

#5 lore raw

PATCH 1/1 USB: reevaluate iomux stdin on USB kbd detect

Quoted 6 lines

Subject: Re: [U-Boot] [PATCH] USB: reevaluate iomux stdin on USB kbd detect

Quoted 3 lines

If CONSOLE_MUX is enabled, reevaluate console stdin when USB keyboard device is detected.

Quoted 7 lines
Quoted 2 lines

---

Hi,

what's the status of this patch/patchset?

Both this and the keyboard polling patch have been accepted into u-boot-usb.git:

$ git log -2 u-boot-usb/master
commit b27c7b2e19a6c211d0ddca5bb62685685a36498b
Author: Allen Martin <[email protected]>
Date:   Tue Dec 20 16:56:16 2011 -0800

USB: move keyboard polling into kbd driver

This moves keyboard polling logic from USB HCD drivers into USB keyboard driver. Remove usb_event_poll() as keyboard polling was the only user of this API. With this patch USB keyboard works with EHCI controllers again. Tested on a tegra2 seaboard.

commit ce9da24a92707f0e84da901eaaa896c17c8b5630

Author: Allen Martin <[email protected]>
Date:   Fri Dec 23 12:29:48 2011 -0800

USB: reevaluate iomux stdin on USB kbd detect

If CONSOLE_MUX is enabled, reevaluate console stdin when USB keyboard device is detected.

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

#6 lore raw

PATCH 1/1 USB: reevaluate iomux stdin on USB kbd detect

Quoted 9 lines
Quoted 9 lines

Subject: Re: [U-Boot] [PATCH] USB: reevaluate iomux stdin on USB kbd detect

Quoted 5 lines

If CONSOLE_MUX is enabled, reevaluate console stdin when USB keyboard device is detected.

---

Quoted 7 lines
Quoted 3 lines

Hi,

what's the status of this patch/patchset?

Both this and the keyboard polling patch have been accepted into u-boot-usb.git:

Which is now in quite weird state, so I picked them up too and will push them up once things settle.

Thanks for your fine contribution and I hope you're produce more!

M