ARM: OMAP: id: Add missing break statement in omap3xxx_check_revision

PATCH New Vaibhav Hiremath 2 participants 5 messages Jan 23, 2012 – Feb 29, 2012

Subsystems (3)

Arm (32-bit) Arm sub-architectures OMAP2+ support

lore

Share & tools

lore

Vaibhav Hiremath

author

2012-01-23 07:56 UTC #0 lore raw

PATCH 1/1 ARM: OMAP: id: Add missing break statement in omap3xxx_check_revision

Add missing break statement in the function omap3xxx_check_revision.

The commit id 4390f5b2cb1f56 [ARM: OMAP: TI814X: Add cpu type macros and detection support], removed the 'break' statement from the function omap3xxx_check_revision(), resulting into wrong omap/cpu_revision initialization for AM335x devices.

Signed-off-by Vaibhav Hiremath <[email protected]>

Cc Tony Lindgren <[email protected]>

---
 arch/arm/mach-omap2/id.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/mach-omap2/id.c +1 -0

index 325e12e..32cf203 100644
@@ -395,6 +395,7 @@ void __init omap3xxx_check_revision(void)
 	case 0xb944:
 		omap_revision = AM335X_REV_ES1_0;
 		cpu_rev = "1.0";
+		break;
 	case 0xb8f2:
 		switch (rev) {
 		case 0:

--
1.7.0.4

Tony Lindgren

maintainer

2012-01-27 00:25 UTC #1 lore raw

PATCH 1/1 ARM: OMAP: id: Add missing break statement in omap3xxx_check_revision

Quoted 6 lines · Vaibhav Hiremath

Add missing break statement in the function omap3xxx_check_revision.
The commit id 4390f5b2cb1f56 [ARM: OMAP: TI814X: Add cpu type macros and detection support], removed the 'break' statement from the function omap3xxx_check_revision(), resulting into wrong omap/cpu_revision initialization for AM335x devices.

Looks like this is already fixed, can you please verify with v3.3-rc1?

Regards,

Tony

Quoted 21 lines

Signed-off-by Vaibhav Hiremath <[email protected]>

Cc Tony Lindgren <[email protected]>

---
 arch/arm/mach-omap2/id.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/mach-omap2/id.c +1 -1

index 325e12e..32cf203 100644
@@ -395,6 +395,7 @@ void __init omap3xxx_check_revision(void)
 	case 0xb944:
 		omap_revision = AM335X_REV_ES1_0;
 		cpu_rev = "1.0";
+		break;
 	case 0xb8f2:
 		switch (rev) {
 		case 0:
--

1.7.0.4

Hiremath, Vaibhav

author

2012-01-27 05:32 UTC #2 lore raw

PATCH 1/1 ARM: OMAP: id: Add missing break statement in omap3xxx_check_revision

Quoted 11 lines · Tony Lindgren

Quoted 6 lines · Vaibhav Hiremath
Add missing break statement in the function omap3xxx_check_revision.
The commit id 4390f5b2cb1f56 [ARM: OMAP: TI814X: Add cpu type macros and detection support], removed the 'break' statement from the function omap3xxx_check_revision(), resulting into wrong omap/cpu_revision initialization for AM335x devices.
Looks like this is already fixed, can you please verify with v3.3-rc1?

Tony,

I just looked at your linux-omap/master branch and 'break' statement is missing. So this patch is still required.

I can still see,

394 }
395 break;
396 case 0xb944:
397 omap_revision = AM335X_REV_ES1_0;
398 cpu_rev = "1.0";
399 case 0xb8f2:
400 switch (rev) {

Thanks,
Vaibhav

Quoted 26 lines

Regards,

Tony

Quoted 21 lines

Signed-off-by Vaibhav Hiremath <[email protected]>

Cc Tony Lindgren <[email protected]>

---
 arch/arm/mach-omap2/id.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/mach-omap2/id.c +1 -1

index 325e12e..32cf203 100644
@@ -395,6 +395,7 @@ void __init omap3xxx_check_revision(void)
 	case 0xb944:
 		omap_revision = AM335X_REV_ES1_0;
 		cpu_rev = "1.0";
+		break;
 	case 0xb8f2:
 		switch (rev) {
 		case 0:
--

1.7.0.4

Hiremath, Vaibhav

author

2012-01-30 08:30 UTC #3 lore raw

PATCH 1/1 ARM: OMAP: id: Add missing break statement in omap3xxx_check_revision

Quoted 18 lines · Vaibhav

Quoted 11 lines · Tony Lindgren
Quoted 6 lines · Vaibhav Hiremath
Add missing break statement in the function omap3xxx_check_revision.
The commit id 4390f5b2cb1f56 [ARM: OMAP: TI814X: Add cpu type macros and detection support], removed the 'break' statement from the function omap3xxx_check_revision(), resulting into wrong omap/cpu_revision initialization for AM335x devices.
Looks like this is already fixed, can you please verify with v3.3-rc1?
Tony,
I just looked at your linux-omap/master branch and 'break' statement is missing. So this patch is still required.
I can still see,

Quoted 9 lines

394 }
395 break;
396 case 0xb944:
397 omap_revision = AM335X_REV_ES1_0;
398 cpu_rev = "1.0";
399 case 0xb8f2:
400 switch (rev) {

Tony,

Can this be merged? I can still see "break" statement missing in the latest linux-omap/master branch.

Thanks,
Vaibhav

Quoted 36 lines

Thanks,
Vaibhav
Quoted 10 lines
Regards,
Tony
Quoted 6 lines
Signed-off-by Vaibhav Hiremath <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/id.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 16 lines
Quoted 13 lines
arch/arm/mach-omap2/id.c +1 -1
index 325e12e..32cf203 100644
@@ -395,6 +395,7 @@ void __init omap3xxx_check_revision(void)
 	case 0xb944:
 		omap_revision = AM335X_REV_ES1_0;
 		cpu_rev = "1.0";
+		break;
 	case 0xb8f2:
 		switch (rev) {
 		case 0:
--
Quoted 2 lines
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Tony Lindgren

maintainer

2012-02-29 22:42 UTC #4 lore raw

PATCH 1/1 ARM: OMAP: id: Add missing break statement in omap3xxx_check_revision

Quoted 28 lines · Hiremath, Vaibhav

Quoted 18 lines · Vaibhav
Quoted 11 lines · Tony Lindgren
Quoted 6 lines · Vaibhav Hiremath
Add missing break statement in the function omap3xxx_check_revision.
The commit id 4390f5b2cb1f56 [ARM: OMAP: TI814X: Add cpu type macros and detection support], removed the 'break' statement from the function omap3xxx_check_revision(), resulting into wrong omap/cpu_revision initialization for AM335x devices.
Looks like this is already fixed, can you please verify with v3.3-rc1?
Tony,
I just looked at your linux-omap/master branch and 'break' statement is missing. So this patch is still required.
I can still see,
Quoted 9 lines
394 }
395 break;
396 case 0xb944:
397 omap_revision = AM335X_REV_ES1_0;
398 cpu_rev = "1.0";
399 case 0xb8f2:
400 switch (rev) {

Quoted 4 lines

Tony,
Can this be merged? I can still see "break" statement missing in the latest linux-omap/master branch.

OK thanks applying into fixes for the -rc cycle.

Tony