megaraid: cleanup type issue in mega_build_cmd()

PATCH New Dan Carpenter 1 participant 1 message Mar 2, 2012

Subsystems (3)

SCSI Kernel janitors Megaraid SCSI/SAS drivers

lore

Share & tools

lore

Dan Carpenter

author

2012-03-02 06:57 UTC #0 lore raw

PATCH 1/1 megaraid: cleanup type issue in mega_build_cmd()

On 64 bit systems the current code sets 32 bits of "seg" and leaves the other 32 uninitialized. It doesn't matter since the variable is never used. But it's still messy and we should fix it.

Signed-off-by Dan Carpenter <[email protected]>

drivers/scsi/megaraid.c +2 -2

index 4d39a9f..97825f1 100644
@@ -524,7 +524,7 @@ mega_build_cmd(adapter_t *adapter, Scsi_Cmnd *cmd, int *busy)
 	mega_passthru	*pthru;
 	scb_t	*scb;
 	mbox_t	*mbox;
-	long	seg;
+	u32	seg;
 	char	islogical;
 	int	max_ldrv_num;
 	int	channel = 0;

@@ -858,7 +858,7 @@ mega_build_cmd(adapter_t *adapter, Scsi_Cmnd *cmd, int *busy)
 
 			/* Calculate Scatter-Gather info */
 			mbox->m_out.numsgelements = mega_build_sglist(adapter, scb,
-					(u32 *)&mbox->m_out.xferaddr, (u32 *)&seg);
+					(u32 *)&mbox->m_out.xferaddr, &seg);
 
 			return scb;