post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU

PATCH New Kumar Gala 3 participants 6 messages Jan 12, 2012 – Mar 12, 2012

lore

Share & tools

lore

Kumar Gala

author

2012-01-12 19:30 UTC #0 lore raw

PATCH 1/1 post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU

Signed-off-by Kumar Gala <[email protected]>

---
 post/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

post/Makefile +1 -1

index 200e2f1..55b7d21 100644
@@ -32,7 +32,7 @@ COBJS-$(CONFIG_POST_STD_LIST)	+= tests.o
 SPLIB-$(CONFIG_HAS_POST) = drivers/libpostdrivers.o
 SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH) ]; then echo \
 			    "lib_$(ARCH)/libpost$(ARCH).o"; fi)
-SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
+SPLIB-$(CONFIG_SYS_POST_FPU) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
 			    "lib_$(ARCH)/fpu/libpost$(ARCH)fpu.o"; fi)
 SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d cpu/$(CPU) ]; then echo \
 			    "cpu/$(CPU)/libpost$(CPU).o"; fi)

Signature · 1 line

1.7.3.4

Wolfgang Denk

Applied

2012-01-13 19:42 UTC #1 lore raw

PATCH 1/1 post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU

Dear Kumar Gala,

Quoted 4 lines · In message <[email protected]> you…

Signed-off-by Kumar Gala <[email protected]>
---
 post/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Insults are effective only where emotion is present.
	-- Spock, "Who Mourns for Adonais?"  stardate 3468.1

Wolfgang Denk

2012-01-13 23:13 UTC #2 lore raw

PATCH 1/1 post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU

In reply to Kumar Gala

Dear Kumar Gala,

Quoted 10 lines · In message <[email protected]> you…

Signed-off-by Kumar Gala <[email protected]>
---
 post/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
post/Makefile +0 -0
index 200e2f1..55b7d21 100644

post/Makefile COBJS-$(CONFIG_POST_STD_LIST) += tests.o · line 38

Quoted 8 lines

post/Makefile +1 -1

@@ -32,7 +32,7 @@ COBJS-$(CONFIG_POST_STD_LIST)	+= tests.o
 SPLIB-$(CONFIG_HAS_POST) = drivers/libpostdrivers.o
 SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH) ]; then echo \
 			    "lib_$(ARCH)/libpost$(ARCH).o"; fi)
-SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
+SPLIB-$(CONFIG_SYS_POST_FPU) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
 			    "lib_$(ARCH)/fpu/libpost$(ARCH)fpu.o"; fi)
 SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d cpu/$(CPU) ]; then echo \
 			    "cpu/$(CPU)/libpost$(CPU).o"; fi)

Unfortunately I applied this patch without sufficient tesing. It breaks a number of boards:

Configuring for korat board...
post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for korat_perm - Board: korat, Options: KORAT_PERMANENT
post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for lwmon5 board...
post/libpost.o:(.data.rel.post_list+0xf0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia - Board: sequoia, Options: SEQUOIA
post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia_nand - Board: sequoia, Options: SEQUOIA,NAND_U_BOOT,SYS_TEXT_BASE=0x01000000 post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia_ramboot - Board: sequoia, Options: SEQUOIA,SYS_RAMBOOT,SYS_TEXT_BASE=0x01000000,SYS_LDSCRIPT=board/amcc/sequoia/u-boot-ram.lds post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for PMC440 board...
post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file

Please provide a fix. Alternatively I can revert that patch.

Thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Life. Don't talk to me about life.      - Marvin the Paranoid Android

Wolfgang Denk

2012-03-04 00:04 UTC #3 lore raw

PATCH 1/1 post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU

Dear Andy,

Quoted 55 lines · In message <[email protected]> I wrote:

Dear Kumar Gala,
Quoted 10 lines · In message <[email protected]> you…
Signed-off-by Kumar Gala <[email protected]>
---
 post/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
post/Makefile +0 -0
index 200e2f1..55b7d21 100644
post/Makefile COBJS-$(CONFIG_POST_STD_LIST) += tests.o · line 38
Quoted 8 lines
post/Makefile +1 -1
@@ -32,7 +32,7 @@ COBJS-$(CONFIG_POST_STD_LIST)	+= tests.o
 SPLIB-$(CONFIG_HAS_POST) = drivers/libpostdrivers.o
 SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH) ]; then echo \
 			    "lib_$(ARCH)/libpost$(ARCH).o"; fi)
-SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
+SPLIB-$(CONFIG_SYS_POST_FPU) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
 			    "lib_$(ARCH)/fpu/libpost$(ARCH)fpu.o"; fi)
 SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d cpu/$(CPU) ]; then echo \
 			    "cpu/$(CPU)/libpost$(CPU).o"; fi)
Unfortunately I applied this patch without sufficient tesing. It breaks a number of boards:
Configuring for korat board...
post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for korat_perm - Board: korat, Options: KORAT_PERMANENT
post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for lwmon5 board...
post/libpost.o:(.data.rel.post_list+0xf0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia - Board: sequoia, Options: SEQUOIA
post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia_nand - Board: sequoia, Options: SEQUOIA,NAND_U_BOOT,SYS_TEXT_BASE=0x01000000 post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia_ramboot - Board: sequoia, Options: SEQUOIA,SYS_RAMBOOT,SYS_TEXT_BASE=0x01000000,SYS_LDSCRIPT=board/amcc/sequoia/u-boot-ram.lds post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for PMC440 board...
post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file

Quoted 1 line

Please provide a fix. Alternatively I can revert that patch.

Kumar never replied, and nobody else picked this up either. Do you feel you "inherit" such stuff from Kumar?

Or should I just revert the commit?

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Without freedom of choice there is no creativity.
	-- Kirk, "The return of the Archons", stardate 3157.4

Marek Vasut

2012-03-05 05:56 UTC #4 lore raw

PATCH 1/1 post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU

Dear Wolfgang Denk,

Quoted 6 lines

Dear Andy,
Quoted 3 lines · In message <[email protected]> I wrote:
Dear Kumar Gala,
In message <[email protected]> you

Quoted 5 lines · wrote:

Quoted 5 lines
Quoted 5 lines
Signed-off-by Kumar Gala <[email protected]>
---
 post/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

[...]

Quoted 10 lines

Quoted 1 line
Please provide a fix. Alternatively I can revert that patch.
Kumar never replied, and nobody else picked this up either. Do you feel you "inherit" such stuff from Kumar?
Or should I just revert the commit?
Best regards,
Wolfgang Denk

please revert until fixed, it causes bleeps on the jenk-radar.

Best regards,
Marek Vasut

Wolfgang Denk

2012-03-12 14:04 UTC #5 lore raw

PATCH 1/1 post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU

In reply to Kumar Gala

Dear Kumar & Andy,

Quoted 4 lines · In message <[email protected]> you…

Signed-off-by Kumar Gala <[email protected]>
---
 post/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

As this patch breaks a number of boards and I get neithe ra fix nor even a reply, I hereby revert it.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As of 1992, they're called European Economic Community fries.