Skip to contentSkip to conversation

RM: OMAP4: board-4430sdp: don't initialize value that is never used

PATCH New Uwe Kleine-König 2 participants 2 messages Feb 9, 2012 – Mar 5, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RM: OMAP4: board-4430sdp: don't initialize value that is never used

sdp4430_spi_board_info.irq was initialized to ETH_KS8851_IRQ and in omap_4430sdp_init() overwritten with gpio_to_irq(ETH_KS8851_IRQ) before sdp4430_spi_board_info was registered. This is a bit confusing, so better don't initialize .irq and document that it is set later.

---
 arch/arm/mach-omap2/board-4430sdp.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-4430sdp.c +4 -1
index 39fba9d..991a289 100644
@@ -321,7 +321,10 @@ static struct spi_board_info sdp4430_spi_board_info[] __initdata = {
 		.bus_num                = 1,
 		.chip_select            = 0,
 		.max_speed_hz           = 24000000,
-		.irq                    = ETH_KS8851_IRQ,
+		/*
+		 * .irq is set to gpio_to_irq(ETH_KS8851_IRQ)
+		 * in omap_4430sdp_init
+		 */
 	},
 };
 
Signature · 1 line
1.7.9
maintainer
#1 lore raw

PATCH 1/1 RM: OMAP4: board-4430sdp: don't initialize value that is never used

Quoted 4 lines · Uwe Kleine-K?nig

sdp4430_spi_board_info.irq was initialized to ETH_KS8851_IRQ and in omap_4430sdp_init() overwritten with gpio_to_irq(ETH_KS8851_IRQ) before sdp4430_spi_board_info was registered. This is a bit confusing, so better don't initialize .irq and document that it is set later.

Thanks applying into board branch.

Regards,

Tony