Skip to contentSkip to conversation

mmc: omap_hsmmc: Fix Unbalanced pm_runtime_enable warning

PATCH New Tony Lindgren 3 participants 4 messages Mar 5, 2012 – Mar 9, 2012

Subsystems (2)
MMC, SD and SDIO OMAP hs MMC support
lore
Share & tools
lore

Tony Lindgren

author
#0 lore raw

PATCH 1/1 mmc: omap_hsmmc: Fix Unbalanced pm_runtime_enable warning

mmc: omap_hsmmc: Fix Unbalanced pm_runtime_enable warning

Otherwise we can get following warning when re-loading the omap_hsmmc driver module when gpio_twl4030 module is not loaded:

omap_hsmmc omap_hsmmc.0: Unbalanced pm_runtime_enable! omap_hsmmc omap_hsmmc.0: Unable to grab MMC CD IRQ
omap_hsmmc: probe of omap_hsmmc.0 failed with error -22

Signed-off-by Tony Lindgren <[email protected]>

---

Kevin, maybe take a look and see if this is correct and fits into your PM branches?

Tony

drivers/mmc/host/omap_hsmmc.c +1 -0
@@ -2146,6 +2146,7 @@ err_irq_cd_init:
 err_irq:
 	pm_runtime_mark_last_busy(host->dev);
 	pm_runtime_put_autosuspend(host->dev);
+	pm_runtime_disable(host->dev);
 	clk_put(host->fclk);
 	if (host->got_dbclk) {
 		clk_disable(host->dbclk);
#1 lore raw

PATCH 1/1 mmc: omap_hsmmc: Fix Unbalanced pm_runtime_enable warning

Quoted 10 lines · Tony Lindgren

mmc: omap_hsmmc: Fix Unbalanced pm_runtime_enable warning

Otherwise we can get following warning when re-loading the omap_hsmmc driver module when gpio_twl4030 module is not loaded:

omap_hsmmc omap_hsmmc.0: Unbalanced pm_runtime_enable! omap_hsmmc omap_hsmmc.0: Unable to grab MMC CD IRQ
omap_hsmmc: probe of omap_hsmmc.0 failed with error -22

Quoted 5 lines
Signed-off-by Tony Lindgren <[email protected]>

---

Kevin, maybe take a look and see if this is correct and fits into your PM branches?

Looks right to me:

Acked-by Kevin Hilman <[email protected]>

But this is a fix to the driver itself, so Chris should queue this in mmc-next.

Chris, can you take this one?

Kevin

Quoted 17 lines

Tony

drivers/mmc/host/omap_hsmmc.c +1 -1
@@ -2146,6 +2146,7 @@ err_irq_cd_init:
 err_irq:
 	pm_runtime_mark_last_busy(host->dev);
 	pm_runtime_put_autosuspend(host->dev);
+	pm_runtime_disable(host->dev);
 	clk_put(host->fclk);
 	if (host->got_dbclk) {
 		clk_disable(host->dbclk);
--

To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw

PATCH 1/1 mmc: omap_hsmmc: Fix Unbalanced pm_runtime_enable warning

Chris,

Quoted 18 lines · Kevin Hilman
Quoted 10 lines · Tony Lindgren

mmc: omap_hsmmc: Fix Unbalanced pm_runtime_enable warning

Otherwise we can get following warning when re-loading the omap_hsmmc driver module when gpio_twl4030 module is not loaded:

omap_hsmmc omap_hsmmc.0: Unbalanced pm_runtime_enable! omap_hsmmc omap_hsmmc.0: Unable to grab MMC CD IRQ
omap_hsmmc: probe of omap_hsmmc.0 failed with error -22

Quoted 5 lines
Signed-off-by Tony Lindgren<[email protected]>

---

Kevin, maybe take a look and see if this is correct and fits into your PM branches?

Quoted 9 lines

Looks right to me:

Acked-by Kevin Hilman<[email protected]>

But this is a fix to the driver itself, so Chris should queue this in mmc-next.

Chris, can you take this one?

just checking on this to be sure it can make it for v3.4.

Kevin

#3 lore raw

PATCH 1/1 mmc: omap_hsmmc: Fix Unbalanced pm_runtime_enable warning

Hi,

Quoted 20 lines · Kevin Hilman
Quoted 20 lines
Quoted 10 lines · Tony Lindgren

mmc: omap_hsmmc: Fix Unbalanced pm_runtime_enable warning

Otherwise we can get following warning when re-loading the omap_hsmmc driver module when gpio_twl4030 module is not loaded:

omap_hsmmc omap_hsmmc.0: Unbalanced pm_runtime_enable! omap_hsmmc omap_hsmmc.0: Unable to grab MMC CD IRQ
omap_hsmmc: probe of omap_hsmmc.0 failed with error -22

Quoted 5 lines
Signed-off-by Tony Lindgren<[email protected]>

---

Kevin, maybe take a look and see if this is correct and fits into your PM branches?

Looks right to me:

Quoted 8 lines
Quoted 6 lines
Acked-by Kevin Hilman<[email protected]>

But this is a fix to the driver itself, so Chris should queue this in mmc-next.

Chris, can you take this one?

just checking on this to be sure it can make it for v3.4.

Thanks, I've pushed this to mmc-next for 3.4 now.

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child