Skip to contentSkip to conversation

Make libmicrohttpd version configurable

PATCH New rolandu at gmail.com 2 participants 4 messages Mar 6, 2012 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Make libmicrohttpd version configurable

From: Roland Uuesoo <[email protected]>

---
 package/libmicrohttpd/Config.in        |    7 +++++++
 package/libmicrohttpd/libmicrohttpd.mk |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)
package/libmicrohttpd/Config.in +7 -0
index cfedc8f..96cd408 100644
@@ -6,6 +6,13 @@ config BR2_PACKAGE_LIBMICROHTTPD
 
 	  http://www.gnu.org/software/libmicrohttpd/
 
+config BR2_PACKAGE_LIBMICROHTTPD_VERSION
+	string "libmicrohttpd version"
+	depends on BR2_PACKAGE_LIBMICROHTTPD
+	default 0.4.6
+	help
+	  Specify libmicrohttpd version
+
 config BR2_PACKAGE_LIBMICROHTTPD_SSL
        bool "https support"
        depends on BR2_PACKAGE_LIBMICROHTTPD
package/libmicrohttpd/libmicrohttpd.mk +1 -1
index ff2b55d..739d779 100644
@@ -3,7 +3,7 @@
 # libmicrohttpd
 #
 #############################################################
-LIBMICROHTTPD_VERSION = 0.4.6
+LIBMICROHTTPD_VERSION = $(BR2_PACKAGE_LIBMICROHTTPD_VERSION)
 LIBMICROHTTPD_SOURCE = libmicrohttpd-$(LIBMICROHTTPD_VERSION).tar.gz
 LIBMICROHTTPD_SITE = $(BR2_GNU_MIRROR)/libmicrohttpd
 LIBMICROHTTPD_INSTALL_STAGING = YES
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 Make libmicrohttpd version configurable

Le Tue, 6 Mar 2012 19:18:48 +0200,
rolandu at gmail.com a ?crit :

Quoted 1 line

From: Roland Uuesoo <[email protected]>

Except for some particular packages such as U-Boot or the kernel, which are highly hardware-dependent, we generally don't like having multiple version support for userspace libraries/applications.

Could you give us details as to why this would be needed specifically for libmicrohttpd?

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

A message that is not in the archive (sent off-list or not yet received): CAG0mjpva6VP1u7EK9oOXUqeYYypCiC2yuE7ag4UtBqCkgc52UA@mail.gmail.com

#3 lore raw

PATCH 1/1 Make libmicrohttpd version configurable

Hello Roland,

Please don't reply just to me: keep the list in Cc.

Le Tue, 6 Mar 2012 19:38:39 +0200,
Roland Uuesoo <[email protected]> a ?crit :

Quoted 5 lines

Version 0.4.6 is 2 years old (13 march 2010).

A lot of bugs/security problems have been fixed.

And there are new features added.

Ok.

Quoted 1 line

Made it configurable because someone might need the old version.

Then just bump the version to whatever more recent version is available. We don't support multiple versions per package in Buildroot, because it would be a maintenance nightmare. For example: each version will need different patches, different configuration options, etc.

So we have decided to keep things simple and support only one version at a time, except for U-Boot, Barebox, kernel, and critical things like that. People doing a project with Buildroot are anyway forking a particular version of Buildroot to ensure that they are fixed on a given version of all the components they are using in their system.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#4 lore raw

PATCH 1/1 Make libmicrohttpd version configurable

Ok, didn't know about the 'one version only policy'.

Le Tue, 6 Mar 2012 19:38:39 +0200, Roland Uuesoo <[email protected]> a ?crit :

Quoted 22 lines
Quoted 5 lines

Version 0.4.6 is 2 years old (13 march 2010).

A lot of bugs/security problems have been fixed.

And there are new features added.

Ok.

Quoted 1 line

Made it configurable because someone might need the old version.

Then just bump the version to whatever more recent version is available. We don't support multiple versions per package in Buildroot, because it would be a maintenance nightmare. For example: each version will need different patches, different configuration options, etc.

So we have decided to keep things simple and support only one version at a time, except for U-Boot, Barebox, kernel, and critical things like that. People doing a project with Buildroot are anyway forking a particular version of Buildroot to ensure that they are fixed on a given version of all the components they are using in their system.

Best regards,

Thomas