Skip to contentSkip to conversation

input: add MAX8997-haptic driver

PATCH Superseded Chanwoo Choi 2 participants 5 messages Mar 7, 2012 – Mar 13, 2012 HID

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover input: add MAX8997-haptic driver

MAX8997 has several features in a single chip,
This patchset supports unimplemented haptic driver of MAX8997.

v2
- code clean and remove unnecessary code according to comment of Dmitry Torokhov

Donggeun Kim (2):
mfd: add platform data for MAX8997 haptic driver
input: add driver support for MAX8997-haptic

 drivers/input/misc/Kconfig          |   12 ++
 drivers/input/misc/Makefile         |    1 +
 drivers/input/misc/max8997_haptic.c |  371
+++++++++++++++++++++++++++++++++++
 include/linux/mfd/max8997.h         |   53 +++++-
 4 files changed, 436 insertions(+), 1 deletions(-)
 create mode 100644 drivers/input/misc/max8997_haptic.c
#1 lore raw

Hi Chanwoo,

Quoted 6 lines · Chanwoo Choi

MAX8997 has several features in a single chip,
This patchset supports unimplemented haptic driver of MAX8997.

v2
- code clean and remove unnecessary code according to comment of Dmitry Torokhov

Could you please tell me if the version of the patch I sent to you worked or not?

Thanks.

Signature · 1 line
Dmitry
#2 lore raw

Hi Dmitry,

Quoted 7 lines · Dmitry Torokhov

Hi Chanwoo,

Quoted 3 lines · Chanwoo Choi

MAX8997 has several features in a single chip,
This patchset supports unimplemented haptic driver of MAX8997.

Quoted 6 lines
Quoted 3 lines

v2
- code clean and remove unnecessary code according to comment of Dmitry Torokhov

Could you please tell me if the version of the patch I sent to you worked or not?

It isn't worked because it use the mutex lock in irq handler stack. so, I resend v3 patch of max8997-haptic driver after modifying it.

Best Regards,
Chanwoo Choi

#3 lore raw
Quoted 14 lines · Chanwoo Choi

Hi Dmitry,

Quoted 11 lines · Dmitry Torokhov

Hi Chanwoo,

Quoted 6 lines · Chanwoo Choi

MAX8997 has several features in a single chip,
This patchset supports unimplemented haptic driver of MAX8997.

v2
- code clean and remove unnecessary code according to comment of Dmitry Torokhov

Quoted 5 lines
Quoted 2 lines

Could you please tell me if the version of the patch I sent to you worked or not?

It isn't worked because it use the mutex lock in irq handler stack. so, I resend v3 patch of max8997-haptic driver after modifying it.

Hmm, my patch did not add taking mutex in irq context, I presume you are talking about max8997->iolock that is taken in max8997_write_reg... OK, I see...

Signature · 1 line
Dmitry
#4 lore raw
Quoted 18 lines · Dmitry Torokhov
Quoted 17 lines · Chanwoo Choi

Hi Dmitry,

Quoted 13 lines · Dmitry Torokhov

Hi Chanwoo,

Quoted 6 lines · Chanwoo Choi

MAX8997 has several features in a single chip,
This patchset supports unimplemented haptic driver of MAX8997.

v2
- code clean and remove unnecessary code according to comment of Dmitry Torokhov

Could you please tell me if the version of the patch I sent to you worked or not?

Quoted 7 lines
Quoted 2 lines

It isn't worked because it use the mutex lock in irq handler stack. so, I resend v3 patch of max8997-haptic driver after modifying it.

Hmm, my patch did not add taking mutex in irq context, I presume you are talking about max8997->iolock that is taken in max8997_write_reg... OK, I see...

You're right. I'm sorry about my ambiguous reply for you.

Best Regards,
Chanwoo Choi