Skip to contentSkip to conversation

linux-next broken by "ARM: S3C2440: move mach-s3c2440/* into mach-s3c24xx/"

DISCUSSION Paul Gortmaker 3 participants 5 messages Mar 8, 2012 – Mar 9, 2012 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Something bad happened in this commit (dd6f01b5cc). It looks like the moved file is truncated, causing this failure:

http://kisskb.ellerman.id.au/kisskb/buildresult/5818815/

I believe it came in via the fix/asoc tree.

Paul.
--

paul@yow-lpgnfs-02:~/git/linux-head$ git show `git rev-list --merges dd6f01b5cc..mar8|tail -n1`
commit 79ad0a5e9210b165c62e269eb48ade9361c630f3
Merge: 94a8d5c 539d3d8
Author: Takashi Iwai <[email protected]>
Date:   Thu Sep 24 09:16:15 2009 +0200

Merge branch 'fix/asoc' into for-next

paul@yow-lpgnfs-02:~/git/linux-head$

#1 lore raw
Quoted 6 lines · Paul Gortmaker

Something bad happened in this commit (dd6f01b5cc). It looks like the moved file is truncated, causing this failure:

http://kisskb.ellerman.id.au/kisskb/buildresult/5818815/

I believe it came in via the fix/asoc tree.

Hrm? What is "it" in this context, and what was your analysis here? Nothing in the page you're linking to above suggests something audio related...

#2 lore raw
Quoted 11 lines · Mark Brown
Quoted 6 lines · Paul Gortmaker

Something bad happened in this commit (dd6f01b5cc). It looks like the moved file is truncated, causing this failure:

http://kisskb.ellerman.id.au/kisskb/buildresult/5818815/

I believe it came in via the fix/asoc tree.

Hrm? What is "it" in this context, and what was your analysis here? Nothing in the page you're linking to above suggests something audio related...

The "it" was the commit in the subject, and the ID in the above text. That was the last commit to have touched this file (via moving it).

What I took as a relation to fix/asoc was shown in the text you've gone and deleted here in the follow up.

In any case, it does appear the file was broken before it was moved. The offending commit is actually c1ba544f81544ed9613ad5d058968533dbcef4b2

	"ARM: S3C24XX: Fix restart on S3C2442"

It appears that a closing brace was dropped when it was integrated.

Paul.

#3 lore raw

Am Donnerstag 08 März 2012, 20:58:44 schrieb Paul Gortmaker:

Quoted 19 lines · Mark Brown
Quoted 11 lines · Paul Gortmaker
Quoted 6 lines

Something bad happened in this commit (dd6f01b5cc). It looks like the moved file is truncated, causing this failure:

http://kisskb.ellerman.id.au/kisskb/buildresult/5818815/

I believe it came in via the fix/asoc tree.

Hrm? What is "it" in this context, and what was your analysis here? Nothing in the page you're linking to above suggests something audio related...

The "it" was the commit in the subject, and the ID in the above text. That was the last commit to have touched this file (via moving it).

What I took as a relation to fix/asoc was shown in the text you've gone and deleted here in the follow up.

Quoted 6 lines

In any case, it does appear the file was broken before it was moved. The offending commit is actually c1ba544f81544ed9613ad5d058968533dbcef4b2

	"ARM: S3C24XX: Fix restart on S3C2442"

It appears that a closing brace was dropped when it was integrated.

kgene wrote in "[PATCH] ARM: S3C2440: Fixed build error for s3c244x":

Quoted 2 lines

This happened when I applied Heiko's 'Fix restart on S3C2442'. It was my fault :( and this should be sent before release v3.3.

and was applied by Olof today.

Heiko

#4 lore raw
In reply to Paul Gortmaker
Quoted 5 lines · Paul Gortmaker

The "it" was the commit in the subject, and the ID in the above text. That was the last commit to have touched this file (via moving it).

What I took as a relation to fix/asoc was shown in the text you've gone and deleted here in the follow up.

You'd written some text but the text wasn't teribly clear - nothing about the code looks at all audio bug fix related. Are you sure the error wasn't just in Linus' tree?

Quoted 6 lines

In any case, it does appear the file was broken before it was moved. The offending commit is actually c1ba544f81544ed9613ad5d058968533dbcef4b2

	"ARM: S3C24XX: Fix restart on S3C2442"

It appears that a closing brace was dropped when it was integrated.

Right, and that commit doesn't appear to be in the ASoC bugfix branch which is why I was mystified.