ARM: OMAP2+: Fix compile error when FB_OMAP2 is not set

PATCH New Tony Lindgren 2 participants 5 messages Mar 8, 2012 – Mar 9, 2012

Subsystems (2)

Arm (32-bit) Arm sub-architectures

lore

Share & tools

lore

Tony Lindgren

author

2012-03-08 20:43 UTC #0 lore raw

PATCH 1/1 ARM: OMAP2+: Fix compile error when FB_OMAP2 is not set

Otherwise we will get:

arch/arm/plat-omap/fb.c:101: error: expected ?)? before ?*? token

Signed-off-by Tony Lindgren <[email protected]>

---

Tomi, you need something like this for what you have in for-next.

arch/arm/plat-omap/fb.c +3 -1

@@ -98,6 +98,8 @@ arch_initcall(omap_init_fb);
 
 #else
 
-void __init omapfb_set_lcd_config(omap_lcd_config *config) { }
+void __init omapfb_set_lcd_config(const struct omap_lcd_config *config)
+{
+}
 
 #endif

Tony Lindgren

author

2012-03-08 20:46 UTC #1 lore raw

PATCH 1/1 ARM: OMAP2+: Fix compile error when FB_OMAP2 is not set

Quoted 13 lines · Tony Lindgren

Otherwise we will get:
arch/arm/plat-omap/fb.c:101: error: expected ?)? before ?*? token
Signed-off-by Tony Lindgren <[email protected]>
---
Tomi, you need something like this for what you have in for-next.

arch/arm/plat-omap/fb.c arch_initcall(omap_init_fb); · line 105

Quoted 9 lines

arch/arm/plat-omap/fb.c +3 -1

@@ -98,6 +98,8 @@ arch_initcall(omap_init_fb);
 
 #else
 
-void __init omapfb_set_lcd_config(omap_lcd_config *config) { }
+void __init omapfb_set_lcd_config(const struct omap_lcd_config *config)
+{
+}
 
 #endif

Also now seeing the following with what you have in for-next:

drivers/video/omap2/displays/panel-taal.c: In function ?taal_num_errors_show?:
drivers/video/omap2/displays/panel-taal.c:605: warning: ?errors? may be used uninitialized in this function

Tony

Tomi Valkeinen

2012-03-09 08:11 UTC #2 lore raw

PATCH 1/1 ARM: OMAP2+: Fix compile error when FB_OMAP2 is not set

Quoted 22 lines · Tony Lindgren

Quoted 21 lines · Tony Lindgren
Otherwise we will get:
arch/arm/plat-omap/fb.c:101: error: expected ?)? before ?*? token
Signed-off-by Tony Lindgren <[email protected]>
---
Tomi, you need something like this for what you have in for-next.
arch/arm/plat-omap/fb.c +3 -1
@@ -98,6 +98,8 @@ arch_initcall(omap_init_fb);
 
 #else
 
-void __init omapfb_set_lcd_config(omap_lcd_config *config) { }
+void __init omapfb_set_lcd_config(const struct omap_lcd_config *config)
+{
+}
 

Quoted 6 lines

arch/arm/plat-omap/fb.c arch_initcall(omap_init_fb); · line 105
Quoted 1 line
arch/arm/plat-omap/fb.c +0 -0
 #endif
Also now seeing the following with what you have in for-next:
drivers/video/omap2/displays/panel-taal.c: In function ?taal_num_errors_show?:
drivers/video/omap2/displays/panel-taal.c:605: warning: ?errors? may be used uninitialized in this function

Hmm, my compiler doesn't complain (codesourcery 2010.09-50), so I didn't notice that. Which compiler version reports the warning?

I'm not 100% sure, but I think it's a false warning, the code path that uses "errors" should only be ran when "errors" has been set.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120309/bf151e56/attachment-0001.sig>

Tony Lindgren

author

2012-03-09 18:26 UTC #3 lore raw

PATCH 1/1 ARM: OMAP2+: Fix compile error when FB_OMAP2 is not set

Quoted 27 lines · Tomi Valkeinen

Quoted 26 lines · Tony Lindgren
Quoted 13 lines · Tony Lindgren
Otherwise we will get:
arch/arm/plat-omap/fb.c:101: error: expected ?)? before ?*? token
Signed-off-by Tony Lindgren <[email protected]>
---
Tomi, you need something like this for what you have in for-next.
arch/arm/plat-omap/fb.c arch_initcall(omap_init_fb); · line 105
Quoted 9 lines
arch/arm/plat-omap/fb.c +3 -1
@@ -98,6 +98,8 @@ arch_initcall(omap_init_fb);
 
 #else
 
-void __init omapfb_set_lcd_config(omap_lcd_config *config) { }
+void __init omapfb_set_lcd_config(const struct omap_lcd_config *config)
+{
+}
 
 #endif
Also now seeing the following with what you have in for-next:

Quoted 8 lines

Quoted 2 lines
drivers/video/omap2/displays/panel-taal.c: In function ?taal_num_errors_show?:
drivers/video/omap2/displays/panel-taal.c:605: warning: ?errors? may be used uninitialized in this function
Hmm, my compiler doesn't complain (codesourcery 2010.09-50), so I didn't notice that. Which compiler version reports the warning?
I'm not 100% sure, but I think it's a false warning, the code path that uses "errors" should only be ran when "errors" has been set.

This seems to depend on the .config options somehow. Not getting it with omap2plus_defconfig, but getting it at least with Russell's omap4430-sdp seed config from:

http://www.arm.linux.org.uk/developer/build/

Using now emdebian 4.3.5-4 as there seems to be some issues showing all the section warnings with CodeSourcery and Linaro toolchains.

Regards,

Tony

Tomi Valkeinen

2012-03-09 07:55 UTC #4 lore raw

PATCH 1/1 ARM: OMAP2+: Fix compile error when FB_OMAP2 is not set

In reply to Tony Lindgren

Quoted 5 lines · Tony Lindgren

Otherwise we will get:
arch/arm/plat-omap/fb.c:101: error: expected ?)? before ?*? token
Signed-off-by Tony Lindgren <[email protected]>

Thanks. It seems I need to improve my testing practices to include non-FB builds also...

Tomi