3.2.10-stable review
Subsystems (71)
Greg KH
maintainercover 3.2.10-stable review
This is the start of the stable review cycle for the 3.2.10 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Mar 11 19:00:00 UTC 2012. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v3.0/stable-review/patch-3.2.10-rc1.gz
and the diffstat can be found below.
thanks,
greg k-h
-------------
Documentation/hwmon/jc42 | 26 ++- Makefile | 4 +- arch/alpha/include/asm/futex.h | 2 +- arch/arm/Kconfig | 2 +- arch/arm/include/asm/pmu.h | 2 +- arch/arm/kernel/perf_event.c | 22 +- arch/arm/kernel/perf_event_v6.c | 22 +-- arch/arm/kernel/perf_event_v7.c | 11 +- arch/arm/kernel/perf_event_xscale.c | 20 ++- arch/arm/mach-dove/common.c | 3 +- arch/arm/mach-kirkwood/common.c | 3 +- arch/arm/mach-kirkwood/mpp.h | 320 +++++++++++++------------- arch/arm/mach-lpc32xx/include/mach/irqs.h | 2 +- arch/arm/mach-lpc32xx/irq.c | 25 ++- arch/arm/mach-lpc32xx/serial.c | 20 ++- arch/arm/mach-mv78xx0/common.c | 3 +- arch/arm/mach-mv78xx0/mpp.h | 226 ++++++++++---------- arch/arm/mach-omap2/board-4430sdp.c | 22 ++- arch/arm/mach-omap2/board-omap4panda.c | 22 ++- arch/arm/mach-omap2/mailbox.c | 3 +- arch/arm/mach-orion5x/common.c | 4 +- arch/arm/mm/proc-v7.S | 4 +- arch/arm/plat-orion/common.c | 9 +- arch/arm/plat-orion/include/plat/common.h | 3 +- arch/arm/plat-orion/mpp.c | 3 +- arch/arm/plat-s3c24xx/dma.c | 2 +- arch/avr32/Kconfig | 1 + arch/s390/Kconfig | 3 + arch/s390/include/asm/compat.h | 7 - arch/s390/kernel/process.c | 1 - arch/s390/kernel/ptrace.c | 2 +- arch/s390/kernel/setup.c | 2 +- arch/s390/kernel/signal.c | 1 - arch/s390/mm/fault.c | 1 - arch/s390/mm/mmap.c | 2 +- arch/x86/include/asm/perf_event.h | 8 + arch/x86/kernel/cpu/perf_event.h | 8 +- arch/x86/kernel/cpu/perf_event_amd.c | 37 +++- arch/x86/kvm/svm.c | 5 + block/bsg.c | 3 +- drivers/acpi/sleep.c | 16 ++ drivers/crypto/mv_cesa.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 15 ++ drivers/gpu/drm/i915/intel_display.c | 32 +++- drivers/gpu/drm/radeon/r600_blit_shaders.c | 8 + drivers/hid/hid-ids.h | 3 + drivers/hid/usbhid/hid-quirks.c | 1 + drivers/hwmon/Kconfig | 5 +- drivers/hwmon/jc42.c | 30 +++- drivers/hwmon/pmbus/pmbus_core.c | 3 +- drivers/hwmon/pmbus/zl6100.c | 10 +- drivers/i2c/busses/i2c-mxs.c | 13 +- drivers/input/mouse/alps.c | 7 +- drivers/iommu/amd_iommu_init.c | 2 +- drivers/iommu/omap-iommu.c | 3 +- drivers/md/dm-flakey.c | 2 +- drivers/md/dm-io.c | 23 ++- drivers/md/dm-ioctl.c | 2 +- drivers/md/dm-raid.c | 17 +- drivers/md/dm-thin-metadata.c | 25 ++- drivers/mfd/cs5535-mfd.c | 6 +- drivers/mfd/mfd-core.c | 2 +- drivers/mfd/wm8994-core.c | 14 ++ drivers/misc/cs5535-mfgpt.c | 2 +- drivers/mmc/host/atmel-mci.c | 21 +- drivers/mmc/host/sdhci-esdhc-imx.c | 5 +- drivers/net/usb/cdc_ether.c | 7 + drivers/net/usb/usbnet.c | 2 + drivers/net/usb/zaurus.c | 7 + drivers/net/wireless/ath/ath9k/ar5008_phy.c | 25 +-- drivers/net/wireless/ath/ath9k/ar9002_hw.c | 19 ++ drivers/net/wireless/ath/ath9k/hw.h | 1 - drivers/net/wireless/ath/carl9170/tx.c | 9 +- drivers/net/wireless/iwlwifi/iwl-agn-sta.c | 10 +- drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 36 +++- drivers/rapidio/devices/tsi721.c | 5 +- drivers/regulator/88pm8607.c | 6 +- drivers/s390/block/dasd_eckd.c | 2 +- drivers/s390/block/dasd_ioctl.c | 1 + drivers/s390/char/fs3270.c | 1 + drivers/s390/char/vmcp.c | 1 + drivers/s390/cio/chsc_sch.c | 1 + drivers/s390/cio/qdio_main.c | 4 +- drivers/s390/scsi/zfcp_cfdc.c | 1 + drivers/scsi/osd/osd_uld.c | 4 +- drivers/spi/spi-topcliff-pch.c | 6 +- drivers/staging/media/lirc/lirc_serial.c | 100 ++++----- drivers/tty/Kconfig | 2 +- drivers/video/omap2/dss/hdmi.c | 3 + drivers/video/omap2/dss/ti_hdmi.h | 4 + drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c | 77 ++++++- drivers/video/via/hw.c | 4 + drivers/watchdog/hpwdt.c | 5 +- fs/aio.c | 2 + fs/autofs4/autofs_i.h | 1 + fs/autofs4/dev-ioctl.c | 1 + fs/autofs4/inode.c | 2 + fs/autofs4/waitq.c | 22 ++- fs/binfmt_elf.c | 2 +- fs/cifs/dir.c | 20 ++- include/linux/compat.h | 4 + include/linux/regset.h | 10 +- include/video/omapdss.h | 5 + kernel/irq/manage.c | 44 ++++- kernel/kprobes.c | 12 +- mm/huge_memory.c | 6 +- mm/memcontrol.c | 5 +- mm/nommu.c | 2 - net/mac80211/rate.c | 2 +- sound/pci/hda/hda_codec.c | 8 +- sound/pci/hda/hda_codec.h | 3 + sound/pci/hda/patch_conexant.c | 22 ++- sound/pci/hda/patch_realtek.c | 2 +- sound/pci/hda/patch_sigmatel.c | 2 +- sound/soc/imx/imx-ssi.c | 2 +- sound/soc/soc-dapm.c | 12 +- 116 files changed, 1082 insertions(+), 586 deletions(-)
Greg KH
maintainerPATCH 1/95 ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp
3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ohad Ben-Cohen <[email protected]>
commit 435792d93410f008120c4dbab148019a3cc31dbc upstream.
omap3isp depends on omap's iommu and will fail to probe if initialized before it (which always happen if they are builtin).
Make omap's iommu subsys_initcall as an interim solution until the probe deferral mechanism is merged.
--- arch/arm/mach-omap2/mailbox.c | 3 ++- drivers/iommu/omap-iommu.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/mailbox.c +2 -1
@@ -412,7 +412,8 @@ static void __exit omap2_mbox_exit(void)platform_driver_unregister (&omap2_mbox_driver); } -module_init (omap2_mbox_init); +/* must be ready before omap3isp is probed */ +subsys_initcall (omap2_mbox_init);module_exit (omap2_mbox_exit);MODULE_LICENSE ("GPL v2" );
drivers/iommu/omap-iommu.c +2 -1
@@ -1229,7 +1229,8 @@ static int __init omap_iommu_init(void)return platform_driver_register (&omap_iommu_driver); } -module_init (omap_iommu_init); +/* must be ready before omap3isp is probed */ +subsys_initcall (omap_iommu_init); static void __exit omap_iommu_exit(void) {
Re: [ 01/95] ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp
Hi Greg,
Quoted 7 lines · Greg KH
3.2-stable review patch. �If anyone has any objections, please let me know.
------------------
From: Ohad Ben-Cohen <[email protected]>
commit
435792d93410f008120c4dbab148019a3cc31dbcupstream.
Can you please also take commit 134d12f "ARM: OMAP: fix iommu, not mailbox" ?
commit 435792d "ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp" had a typo, which was fixed by 134d12f "ARM: OMAP: fix iommu, not mailbox" (and the latter wasn't flagged for stable, sorry).
Thanks,
Ohad.
Greg KH
maintainerRe: [ 01/95] ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp
Quoted 9 lines · Ohad Ben-Cohen
Hi Greg,
Quoted 6 lines · Greg KH
3.2-stable review patch. �If anyone has any objections, please let me know.
------------------
From: Ohad Ben-Cohen <[email protected]>
Quoted 7 lines
Quoted 1 line
commit
435792d93410f008120c4dbab148019a3cc31dbcupstream.Can you please also take commit 134d12f "ARM: OMAP: fix iommu, not mailbox" ?
commit 435792d "ARM: OMAP: make iommu
subsys_initcallto fix builtin omap3isp" had a typo, which was fixed by 134d12f "ARM: OMAP: fix iommu, not mailbox" (and the latter wasn't flagged for stable, sorry).
Ok, I'll queue this up, thanks for letting me know.
greg k-h
Greg KH
maintainerPATCH 2/95 autofs: work around unhappy compat problem on x86-64
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ian Kent <[email protected]>
commit a32744d4abae24572eff7269bc17895c41bd0085 upstream.
When the autofs protocol version 5 packet type was added in commit 5c0a32fc2cd0 ("autofs4: add new packet type for v5 communications"), it obvously tried quite hard to be word-size agnostic, and uses explicitly sized fields that are all correctly aligned.
However, with the final "char name[NAME_MAX+1]" array at the end, the actual size of the structure ends up being not very well defined:
because the struct isn't marked 'packed', doing a "sizeof()" on it will align the size of the struct up to the biggest alignment of the members it has.
And despite all the members being the same, the alignment of them is
different: a "__u64" has 4-byte alignment on x86-32, but native 8-byte alignment on x86-64. And while 'NAME_MAX+1' ends up being a nice round number (256), the name[] array starts out a 4-byte aligned.
End result: the "packed" size of the structure is 300 bytes: 4-byte, but not 8-byte aligned.
As a result, despite all the fields being in the same place on all architectures, sizeof() will round up that size to 304 bytes on architectures that have 8-byte alignment for u64.
Note that this is *not* a problem for 32-bit compat mode on POWER, since there __u64 is 8-byte aligned even in 32-bit mode. But on x86, 32-bit and 64-bit alignment is different for 64-bit entities, and as a result the structure that has exactly the same layout has different sizes.
So on x86-64, but no other architecture, we will just subtract 4 from the size of the structure when running in a compat task. That way we will write the properly sized packet that user mode expects.
Not pretty. Sadly, this very subtle, and unnecessary, size difference has been encoded in user space that wants to read packets of *exactly* the right size, and will refuse to touch anything else.
--- fs/autofs4/autofs_i.h | 1 + fs/autofs4/dev-ioctl.c | 1 + fs/autofs4/inode.c | 2 ++ fs/autofs4/waitq.c | 22 +++++++++++++++++++--- 4 files changed, 23 insertions(+), 3 deletions(-)
fs/autofs4/autofs_i.h +1 -0
@@ -110,6 +110,7 @@ struct autofs_sb_info {int sub_version;int min_proto;int max_proto; +int compat_daemon;unsigned long exp_timeout;unsigned int type;int reghost_enabled;
fs/autofs4/dev-ioctl.c +1 -0
@@ -385,6 +385,7 @@ static int autofs_dev_ioctl_setpipefd(st sbi->pipefd = pipefd; sbi->pipe = pipe; sbi->catatonic =0 ; + sbi->compat_daemon =is_compat_task (); } out:mutex_unlock (&sbi->wq_mutex);
fs/autofs4/inode.c +2 -0
@@ -19,6 +19,7 @@#include <linux/parser.h> #include <linux/bitops.h> #include <linux/magic.h> +#include <linux/compat.h> #include "autofs_i.h" #include <linux/module.h>
@@ -224,6 +225,7 @@ int autofs4_fill_super(struct super_blocset_autofs_type_indirect (&sbi->type); sbi->min_proto =0 ; sbi->max_proto =0 ; + sbi->compat_daemon =is_compat_task ();mutex_init (&sbi->wq_mutex);spin_lock_init (&sbi->fs_lock); sbi->queues =NULL ;
fs/autofs4/waitq.c +19 -3
@@ -90,7 +90,24 @@ static int autofs4_write(struct file *fireturn (bytes >0 ); } - + +/* +* The autofs_v5 packet was misdesigned. +* +* The packets are identical on x86-32 and x86-64, but have different +* alignment. Which means that 'sizeof()' will give different results. +* Fix it up for the case of running 32-bit user mode on a 64-bit kernel. +*/ +static noinline size_t autofs_v5_packet_size(struct autofs_sb_info *sbi) +{ +size_t pktsz =sizeof (struct autofs_v5_packet ); +#if defined(CONFIG_X86_64 ) && defined(CONFIG_COMPAT ) +if (sbi->compat_daemon >0 ) + pktsz -=4 ; +#endif +return pktsz; +} +static void autofs4_notify_daemon (struct autofs_sb_info *sbi,struct autofs_wait_queue *wq,int type)
@@ -147,8 +164,7 @@ static void autofs4_notify_daemon(struct {struct autofs_v5_packet *packet = &pkt.v5_pkt.v5_packet; - pktsz =sizeof (*packet); - + pktsz =autofs_v5_packet_size (sbi); packet->wait_queue_token = wq->wait_queue_token; packet->len = wq->name.len;memcpy (packet->name, wq->name.name, wq->name.len);
Greg KH
maintainerPATCH 3/95 Fix autofs compile without CONFIG_COMPAT
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Linus Torvalds <[email protected]>
commit 3c761ea05a8900a907f32b628611873f6bef24b2 upstream.
The autofs compat handling fix caused a compile failure when CONFIG_COMPAT isn't defined.
Instead of adding random #ifdef'fery in autofs, let's just make the compat helpers earlier to use: without CONFIG_COMPAT, is_compat_task() just hardcodes to zero.
We could probably do something similar for a number of other cases where we have #ifdef's in code, but this is the low-hanging fruit.
--- include/linux/compat.h | 4 ++++ 1 file changed, 4 insertions(+)
include/linux/compat.h +4 -0
@@ -561,5 +561,9 @@ asmlinkage ssize_t compat_sys_process_vm unsigned long liovcnt, const struct compat_iovec __user *rvec, unsigned long riovcnt, unsigned long flags); +#else + +#define is_compat_task () (0) +#endif /* CONFIG_COMPAT */ #endif /* _LINUX_COMPAT_H */
Greg KH
maintainerPATCH 4/95 compat: fix compile breakage on s390
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Heiko Carstens <[email protected]>
commit 048cd4e51d24ebf7f3552226d03c769d6ad91658 upstream.
The new is_compat_task() define for the !COMPAT case in include/linux/compat.h conflicts with a similar define in arch/s390/include/asm/compat.h.
This is the minimal patch which fixes the build issues.
--- arch/s390/include/asm/compat.h | 7 ------- arch/s390/kernel/process.c | 1 - arch/s390/kernel/ptrace.c | 2 +- arch/s390/kernel/setup.c | 2 +- arch/s390/kernel/signal.c | 1 - arch/s390/mm/fault.c | 1 - arch/s390/mm/mmap.c | 2 +- drivers/s390/block/dasd_eckd.c | 2 +- drivers/s390/block/dasd_ioctl.c | 1 + drivers/s390/char/fs3270.c | 1 + drivers/s390/char/vmcp.c | 1 + drivers/s390/cio/chsc_sch.c | 1 + drivers/s390/scsi/zfcp_cfdc.c | 1 + 13 files changed, 9 insertions(+), 14 deletions(-)
arch/s390/include/asm/compat.h +0 -7
@@ -172,13 +172,6 @@ static inline int is_compat_task(void) return is_32bit_task(); } -#else - -static inline int is_compat_task (void ) -{ -return 0 ; -} -#endif static inline void __user *arch_compat_alloc_user_space (long len)
arch/s390/kernel/process.c +0 -1
@@ -29,7 +29,6 @@#include <asm/irq.h> #include <asm/timer.h> #include <asm/nmi.h> -#include <asm/compat.h> #include <asm/smp.h> #include "entry.h"
arch/s390/kernel/ptrace.c +1 -1
@@ -20,8 +20,8 @@#include <linux/regset.h> #include <linux/tracehook.h> #include <linux/seccomp.h> +#include <linux/compat.h> #include <trace/syscall.h> -#include <asm/compat.h> #include <asm/segment.h> #include <asm/page.h> #include <asm/pgtable.h>
arch/s390/kernel/setup.c +1 -1
@@ -45,6 +45,7 @@#include <linux/kexec.h> #include <linux/crash_dump.h> #include <linux/memory.h> +#include <linux/compat.h> #include <asm/ipl.h> #include <asm/uaccess.h>
@@ -58,7 +59,6 @@#include <asm/ptrace.h> #include <asm/sections.h> #include <asm/ebcdic.h> -#include <asm/compat.h> #include <asm/kvm_virtio.h> #include <asm/diag.h>
arch/s390/kernel/signal.c +0 -1
@@ -30,7 +30,6 @@#include <asm/ucontext.h> #include <asm/uaccess.h> #include <asm/lowcore.h> -#include <asm/compat.h> #include "entry.h" #define _BLOCKABLE (~(sigmask(SIGKILL) | sigmask(SIGSTOP)))
arch/s390/mm/fault.c +0 -1
@@ -36,7 +36,6 @@#include <asm/pgtable.h> #include <asm/irq.h> #include <asm/mmu_context.h> -#include <asm/compat.h> #include "../kernel/entry.h" #ifndef CONFIG_64BIT
arch/s390/mm/mmap.c +1 -1
@@ -29,8 +29,8 @@#include <linux/mman.h> #include <linux/module.h> #include <linux/random.h> +#include <linux/compat.h> #include <asm/pgalloc.h> -#include <asm/compat.h> static unsigned long stack_maxrandom_size (void ) {
drivers/s390/block/dasd_eckd.c +1 -1
@@ -18,12 +18,12 @@#include <linux/hdreg.h> /* HDIO_GETGEO */ #include <linux/bio.h> #include <linux/module.h> +#include <linux/compat.h> #include <linux/init.h> #include <asm/debug.h> #include <asm/idals.h> #include <asm/ebcdic.h> -#include <asm/compat.h> #include <asm/io.h> #include <asm/uaccess.h> #include <asm/cio.h>
drivers/s390/block/dasd_ioctl.c +1 -0
@@ -13,6 +13,7 @@#define KMSG_COMPONENT "dasd"#include <linux/interrupt.h> +#include <linux/compat.h> #include <linux/major.h> #include <linux/fs.h> #include <linux/blkpg.h>
drivers/s390/char/fs3270.c +1 -0
@@ -11,6 +11,7 @@#include <linux/console.h> #include <linux/init.h> #include <linux/interrupt.h> +#include <linux/compat.h> #include <linux/module.h> #include <linux/list.h> #include <linux/slab.h>
drivers/s390/char/vmcp.c +1 -0
@@ -13,6 +13,7 @@#include <linux/fs.h> #include <linux/init.h> +#include <linux/compat.h> #include <linux/kernel.h> #include <linux/miscdevice.h> #include <linux/slab.h>
drivers/s390/cio/chsc_sch.c +1 -0
@@ -8,6 +8,7 @@*/ #include <linux/slab.h> +#include <linux/compat.h> #include <linux/device.h> #include <linux/module.h> #include <linux/uaccess.h>
drivers/s390/scsi/zfcp_cfdc.c +1 -0
@@ -11,6 +11,7 @@#define KMSG_COMPONENT "zfcp"#define pr_fmt (fmt) KMSG_COMPONENT ": " fmt +#include <linux/compat.h> #include <linux/slab.h> #include <linux/types.h> #include <linux/miscdevice.h>
Greg KH
maintainerPATCH 5/95 drm/i915: Prevent a machine hang by checking crtc->active before loading lut
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alban Browaeys <[email protected]>
commit aed3f09db39596e539f90b11a5016aea4d8442e1 upstream.
Before loading the lut (gamma), check the active state of intel_crtc, otherwise at least on gen2 hang ensue.
This is reproducible in Xorg via:
xset dpms force off
then
xgamma -rgamma 2.0 # freeze.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44505
--- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
@@ -5965,7 +5965,7 @@ void intel_crtc_load_lut(struct drm_crtcint i;/* The clocks have to be on to load the palette. */ -if (!crtc->enabled) +if (!crtc->enabled || !intel_crtc->active)return ;/* use legacy palette for Ironlake */
Greg KH
maintainerPATCH 6/95 ARM: LPC32xx: serial.c: HW bug workaround
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Roland Stigge <[email protected]>
commit 2707208ee8a80dbbd5426f5aa1a934f766825bb5 upstream.
This patch fixes a HW bug by flushing RX FIFOs of the UARTs on init. It was ported from NXP's git.lpclinux.com tree.
--- arch/arm/mach-lpc32xx/serial.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
arch/arm/mach-lpc32xx/serial.c +18 -0
@@ -88,6 +88,7 @@ struct uartinit {char *uart_ck_name;u32 ck_mode_mask;void __iomem *pdiv_clk_reg; +resource_size_t mapbase; };static struct uartinit uartinit_data[]__initdata = {
@@ -97,6 +98,7 @@ static struct uartinit uartinit_data[] _ .ck_mode_mask = LPC32XX_UART_CLKMODE_LOAD(LPC32XX_UART_CLKMODE_ON, 5), .pdiv_clk_reg = LPC32XX_CLKPWR_UART5_CLK_CTRL, + .mapbase = LPC32XX_UART5_BASE, },#endif #ifdef CONFIG_ARCH_LPC32XX_UART3_SELECT
@@ -105,6 +107,7 @@ static struct uartinit uartinit_data[] _ .ck_mode_mask = LPC32XX_UART_CLKMODE_LOAD(LPC32XX_UART_CLKMODE_ON, 3), .pdiv_clk_reg = LPC32XX_CLKPWR_UART3_CLK_CTRL, + .mapbase = LPC32XX_UART3_BASE, },#endif #ifdef CONFIG_ARCH_LPC32XX_UART4_SELECT
@@ -113,6 +116,7 @@ static struct uartinit uartinit_data[] _ .ck_mode_mask = LPC32XX_UART_CLKMODE_LOAD(LPC32XX_UART_CLKMODE_ON, 4), .pdiv_clk_reg = LPC32XX_CLKPWR_UART4_CLK_CTRL, + .mapbase = LPC32XX_UART4_BASE, },#endif #ifdef CONFIG_ARCH_LPC32XX_UART6_SELECT
@@ -121,6 +125,7 @@ static struct uartinit uartinit_data[] _ .ck_mode_mask = LPC32XX_UART_CLKMODE_LOAD(LPC32XX_UART_CLKMODE_ON, 6), .pdiv_clk_reg = LPC32XX_CLKPWR_UART6_CLK_CTRL, + .mapbase = LPC32XX_UART6_BASE, },#endif };
@@ -165,6 +170,19 @@ void __init lpc32xx_serial_init(void)/* pre-UART clock divider set to 1 */ __raw_writel (0x0101 , uartinit_data[i].pdiv_clk_reg); + +/* +* Force a flush of the RX FIFOs to work around a +* HW bug +*/ + puart = uartinit_data[i].mapbase; +__raw_writel (0xC1 ,LPC32XX_UART_IIR_FCR (puart)); +__raw_writel (0x00 ,LPC32XX_UART_DLL_FIFO (puart)); + j =LPC32XX_SUART_FIFO_SIZE ; +while (j--) + tmp =__raw_readl ( +LPC32XX_UART_DLL_FIFO (puart)); +__raw_writel (0 ,LPC32XX_UART_IIR_FCR (puart)); }/* This needs to be done after all UART clocks are setup */
Greg KH
maintainerPATCH 7/95 ARM: LPC32xx: serial.c: Fixed loop limit
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Roland Stigge <[email protected]>
commit ff424aa4c89d19082e8ae5a3351006bc8a4cd91b upstream.
This patch fixes a wrong loop limit on UART init.
--- arch/arm/mach-lpc32xx/serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-lpc32xx/serial.c +1 -1
@@ -187,7 +187,7 @@ void __init lpc32xx_serial_init(void)/* This needs to be done after all UART clocks are setup */ __raw_writel (clkmodes,LPC32XX_UARTCTL_CLKMODE ); -for (i =0 ; i <ARRAY_SIZE (uartinit_data) -1 ; i++) { +for (i =0 ; i <ARRAY_SIZE (uartinit_data); i++) {/* Force a flush of the RX FIFOs to work around a HW bug */ puart = serial_std_platform_data[i].mapbase;__raw_writel (0xC1 ,LPC32XX_UART_IIR_FCR (puart));
Greg KH
maintainerPATCH 8/95 ARM: LPC32xx: irq.c: Clear latched event
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Roland Stigge <[email protected]>
commit 94ed7830cba4dce57b18a2926b5d826bfd184bd6 upstream.
This patch fixes the wakeup disable function by clearing latched events.
--- arch/arm/mach-lpc32xx/irq.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
arch/arm/mach-lpc32xx/irq.c +10 -1
@@ -305,9 +305,18 @@ static int lpc32xx_irq_wake(struct irq_dif (state) eventreg |= lpc32xx_events[d->irq].mask; -else +else { eventreg &= ~lpc32xx_events[d->irq].mask; +/* +* When disabling the wakeup, clear the latched +* event +*/ +__raw_writel (lpc32xx_events[d->irq].mask, + lpc32xx_events[d->irq]. + event_group->rawstat_reg); + } +__raw_writel (eventreg, lpc32xx_events[d->irq].event_group->enab_reg);
Greg KH
maintainerPATCH 9/95 ARM: LPC32xx: Fix interrupt controller init
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Roland Stigge <[email protected]>
commit 35dd0a75d4a382e7f769dd0277732e7aa5235718 upstream.
This patch fixes the initialization of the interrupt controller of the LPC32xx by correctly setting up SIC1 and SIC2 instead of (wrongly) using the same value as for the Main Interrupt Controller (MIC).
--- arch/arm/mach-lpc32xx/irq.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
arch/arm/mach-lpc32xx/irq.c +6 -4
@@ -389,13 +389,15 @@ void __init lpc32xx_init_irq(void)/* Setup SIC1 */ __raw_writel (0 ,LPC32XX_INTC_MASK (LPC32XX_SIC1_BASE )); -__raw_writel (MIC_APR_DEFAULT ,LPC32XX_INTC_POLAR (LPC32XX_SIC1_BASE )); -__raw_writel (MIC_ATR_DEFAULT ,LPC32XX_INTC_ACT_TYPE (LPC32XX_SIC1_BASE )); +__raw_writel (SIC1_APR_DEFAULT ,LPC32XX_INTC_POLAR (LPC32XX_SIC1_BASE )); +__raw_writel (SIC1_ATR_DEFAULT , +LPC32XX_INTC_ACT_TYPE (LPC32XX_SIC1_BASE ));/* Setup SIC2 */ __raw_writel (0 ,LPC32XX_INTC_MASK (LPC32XX_SIC2_BASE )); -__raw_writel (MIC_APR_DEFAULT ,LPC32XX_INTC_POLAR (LPC32XX_SIC2_BASE )); -__raw_writel (MIC_ATR_DEFAULT ,LPC32XX_INTC_ACT_TYPE (LPC32XX_SIC2_BASE )); +__raw_writel (SIC2_APR_DEFAULT ,LPC32XX_INTC_POLAR (LPC32XX_SIC2_BASE )); +__raw_writel (SIC2_ATR_DEFAULT , +LPC32XX_INTC_ACT_TYPE (LPC32XX_SIC2_BASE ));/* Configure supported IRQ's */ for (i =0 ; i <NR_IRQS ; i++) {
Greg KH
maintainerPATCH 10/95 ARM: LPC32xx: Fix irq on GPI_28
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Roland Stigge <[email protected]>
commit f6737055c1c432a9628a9a731f9881ad8e0a9eee upstream.
The GPI_28 IRQ was not registered properly. The registration of IRQ_LPC32XX_GPI_28 was added and the (wrong) IRQ_LPC32XX_GPI_11 at LPC32XX_SIC1_IRQ(4) was replaced by IRQ_LPC32XX_GPI_28 (see manual of LPC32xx / interrupt controller).
--- arch/arm/mach-lpc32xx/include/mach/irqs.h | 2 +- arch/arm/mach-lpc32xx/irq.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-)
arch/arm/mach-lpc32xx/include/mach/irqs.h +1 -1
@@ -61,7 +61,7 @@*/ #define IRQ_LPC32XX_JTAG_COMM_TX LPC32XX_SIC1_IRQ(1)#define IRQ_LPC32XX_JTAG_COMM_RX LPC32XX_SIC1_IRQ(2) -#define IRQ_LPC32XX_GPI_11 LPC32XX_SIC1_IRQ(4) +#define IRQ_LPC32XX_GPI_28 LPC32XX_SIC1_IRQ(4)#define IRQ_LPC32XX_TS_P LPC32XX_SIC1_IRQ(6)#define IRQ_LPC32XX_TS_IRQ LPC32XX_SIC1_IRQ(7)#define IRQ_LPC32XX_TS_AUX LPC32XX_SIC1_IRQ(8)
arch/arm/mach-lpc32xx/irq.c +4 -0
@@ -118,6 +118,10 @@ static const struct lpc32xx_event_info l .event_group = &lpc32xx_event_pin_regs, .mask = LPC32XX_CLKPWR_EXTSRC_GPI_06_BIT, }, + [IRQ_LPC32XX_GPI_28] = { + .event_group = &lpc32xx_event_pin_regs, + .mask = LPC32XX_CLKPWR_EXTSRC_GPI_28_BIT, + }, [IRQ_LPC32XX_GPIO_00] = { .event_group = &lpc32xx_event_int_regs, .mask = LPC32XX_CLKPWR_INTSRC_GPIO_00_BIT,
Greg KH
maintainerPATCH 11/95 watchdog: hpwdt: clean up set_memory_x call for 32 bit
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Maxim Uvarov <[email protected]>
commit 97d2a10d5804d585ab0b58efbd710948401b886a upstream.
1. address has to be page aligned.
2. set_memory_x uses page size argument, not size. Bug causes with following commit:
commit da28179b4e90dda56912ee825c7eaa62fc103797
Author: Mingarelli, Thomas <[email protected]>
Date: Mon Nov 7 10:59:00 2011 +0100
watchdog: hpwdt: Changes to handle NX secure bit in 32bit path
commit e67d668e147c3b4fec638c9e0ace04319f5ceccd upstream.
This patch makes use of the set_memory_x() kernel API in order to make necessary BIOS calls to source NMIs.
--- drivers/watchdog/hpwdt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/watchdog/hpwdt.c +3 -2
@@ -231,7 +231,7 @@ static int __devinit cru_detect(unsigned cmn_regs.u1.reax =CRU_BIOS_SIGNATURE_VALUE ; -set_memory_x ((unsigned long )bios32_entrypoint, (2 *PAGE_SIZE )); +set_memory_x ((unsigned long )bios32_map,2 );asminline_call (&cmn_regs, bios32_entrypoint);if (cmn_regs.u1.ral !=0 ) {
@@ -250,7 +250,8 @@ static int __devinit cru_detect(unsigned cru_rom_addr =ioremap (cru_physical_address, cru_length);if (cru_rom_addr) { -set_memory_x ((unsigned long )cru_rom_addr, cru_length); +set_memory_x ((unsigned long )cru_rom_addr &PAGE_MASK , + (cru_length +PAGE_SIZE -1 ) >>PAGE_SHIFT ); retval =0 ; } }
Greg KH
maintainerPATCH 12/95 i2c: mxs: only flag completion when queue is completely done
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Wolfram Sang <[email protected]>
commit 844990daa2e69a4258049ba9c2bae1180657dac3 upstream.
The hardware generates an interrupt for every completed command in the queue while the code assumed that it will only generate one interrupt when the queue is empty. So, explicitly check if the queue is really empty. This patch fixed problems which occurred due to high traffic on the bus. While we are here, move the completion-initialization after the parameter error checking.
--- drivers/i2c/busses/i2c-mxs.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-mxs.c +10 -3
@@ -72,6 +72,7 @@#define MXS_I2C_QUEUESTAT (0x70)#define MXS_I2C_QUEUESTAT_RD_QUEUE_EMPTY 0x00002000 +#define MXS_I2C_QUEUESTAT_WRITE_QUEUE_CNT_MASK 0x0000001F#define MXS_I2C_QUEUECMD (0x80)
@@ -219,14 +220,14 @@ static int mxs_i2c_xfer_msg(struct i2c_aint ret;int flags; -init_completion (&i2c->cmd_complete); -dev_dbg (i2c->dev,"addr: 0x%04x, len: %d, flags: 0x%x, stop: %d\n" , msg->addr, msg->len, msg->flags, stop);if (msg->len ==0 )return -EINVAL ; +init_completion (&i2c->cmd_complete); + flags = stop ?MXS_I2C_CTRL0_POST_SEND_STOP :0 ;if (msg->flags &I2C_M_RD )
@@ -286,6 +287,7 @@ static irqreturn_t mxs_i2c_isr(int this_ {struct mxs_i2c_dev *i2c = dev_id;u32 stat =readl (i2c->regs +MXS_I2C_CTRL1 ) &MXS_I2C_IRQ_MASK ; +bool is_last_cmd;if (!stat)return IRQ_NONE ;
@@ -300,9 +302,14 @@ static irqreturn_t mxs_i2c_isr(int this_else i2c->cmd_err =0 ; -complete (&i2c->cmd_complete); + is_last_cmd = (readl (i2c->regs +MXS_I2C_QUEUESTAT ) & +MXS_I2C_QUEUESTAT_WRITE_QUEUE_CNT_MASK ) ==0 ; + +if (is_last_cmd || i2c->cmd_err) +complete (&i2c->cmd_complete);writel (stat, i2c->regs +MXS_I2C_CTRL1_CLR ); +return IRQ_HANDLED ; }
Greg KH
maintainerPATCH 13/95 regulator: fix the ldo configure according to 88pm860x spec
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Jett.Zhou" <[email protected]>
commit 3380643b0eaa7ecf99c4f095bdfcb6e5df471616 upstream.
--- drivers/regulator/88pm8607.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/regulator/88pm8607.c +3 -3
@@ -196,7 +196,7 @@ static const unsigned int LDO12_suspend_ };static const unsigned int LDO13_table[] = { -1300000 ,1800000 ,2000000 ,2500000 ,2800000 ,3000000 ,0 ,0 , +1200000 ,1300000 ,1800000 ,2000000 ,2500000 ,2800000 ,3000000 ,0 , };static const unsigned int LDO13_suspend_table[] = {
@@ -389,10 +389,10 @@ static struct pm8607_regulator_info pm86PM8607_LDO (7 ,LDO7 ,0 ,3 ,SUPPLIES_EN12 ,1 ),PM8607_LDO (8 ,LDO8 ,0 ,3 ,SUPPLIES_EN12 ,2 ),PM8607_LDO (9 ,LDO9 ,0 ,3 ,SUPPLIES_EN12 ,3 ), -PM8607_LDO (10 ,LDO10 ,0 ,3 ,SUPPLIES_EN12 ,4 ), +PM8607_LDO (10 ,LDO10 ,0 ,4 ,SUPPLIES_EN12 ,4 ),PM8607_LDO (12 ,LDO12 ,0 ,4 ,SUPPLIES_EN12 ,5 ),PM8607_LDO (13 ,VIBRATOR_SET ,1 ,3 ,VIBRATOR_SET ,0 ), - PM8607_LDO(14, LDO14, 0, 4, SUPPLIES_EN12, 6), + PM8607_LDO(14, LDO14, 0, 3, SUPPLIES_EN12, 6), };static int __devinit pm8607_regulator_probe (struct platform_device *pdev)
Greg KH
maintainerPATCH 14/95 S390: KEYS: Enable the compat keyctl wrapper on s390x
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Howells <[email protected]>
commit 1d057720609ed052a6371fe1d53300e5e6328e94 upstream.
Enable the compat keyctl wrapper on s390x so that 32-bit s390 userspace can call the keyctl() syscall.
There's an s390x assembly wrapper that truncates all the register values to 32-bits and this then calls compat_sys_keyctl() - but the latter only exists if CONFIG_KEYS_COMPAT is enabled, and the s390 Kconfig doesn't enable it.
Without this patch, 32-bit calls to the keyctl() syscall are given an ENOSYS error:
[root@devel4 ~]# keyctl show
Session Keyring
-3: key inaccessible (Function not implemented)
--- arch/s390/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
arch/s390/Kconfig +3 -0
@@ -230,6 +230,9 @@ config COMPAT config SYSVIPC_COMPAT def_bool y if COMPAT && SYSVIPC +config KEYS_COMPAT + def_bool y if COMPAT && KEYS + config AUDIT_ARCH def_bool y
Greg KH
maintainerPATCH 15/95 perf/x86/kvm: Fix Host-Only/Guest-Only counting with SVM disabled
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Joerg Roedel <[email protected]>
commit 1018faa6cf23b256bf25919ef203cd7c129f06f2 upstream.
It turned out that a performance counter on AMD does not count at all when the GO or HO bit is set in the control register and SVM is disabled in EFER.
This patch works around this issue by masking out the HO bit in the performance counter control register when SVM is not enabled.
The GO bit is not touched because it is only set when the user wants to count in guest-mode only. So when SVM is disabled the counter should not run at all and the not-counting is the intended behaviour.
--- arch/x86/include/asm/perf_event.h | 8 +++++++ arch/x86/kernel/cpu/perf_event.h | 8 +++++-- arch/x86/kernel/cpu/perf_event_amd.c | 37 +++++++++++++++++++++++++++++++++-- arch/x86/kvm/svm.c | 5 ++++ 4 files changed, 54 insertions(+), 4 deletions(-)
arch/x86/include/asm/perf_event.h +8 -0
@@ -212,4 +212,12 @@ static inline perf_guest_switch_msr *perstatic inline void perf_events_lapic_init (void ) { }#endif +#if defined(CONFIG_PERF_EVENTS ) && defined(CONFIG_CPU_SUP_AMD ) +extern void amd_pmu_enable_virt (void ); +extern void amd_pmu_disable_virt (void ); +#else +static inline void amd_pmu_enable_virt (void ) { } +static inline void amd_pmu_disable_virt (void ) { } +#endif +#endif /* _ASM_X86_PERF_EVENT_H */
arch/x86/kernel/cpu/perf_event.h +6 -2
@@ -146,7 +146,9 @@ struct cpu_hw_events {/* * AMD specific bits */ -struct amd_nb *amd_nb; +struct amd_nb *amd_nb; +/* Inverted mask of bits to clear in the perf_ctr ctrl registers */ +u64 perf_ctr_virt_mask;void *kfree_on_online; };
@@ -372,9 +374,11 @@ void x86_pmu_disable_all(void);static inline void __x86_pmu_enable_event (struct hw_perf_event *hwc,u64 enable_mask) { +u64 disable_mask =__this_cpu_read (cpu_hw_events.perf_ctr_virt_mask); +if (hwc->extra_reg.reg)wrmsrl (hwc->extra_reg.reg, hwc->extra_reg.config); -wrmsrl (hwc->config_base, hwc->config | enable_mask); +wrmsrl (hwc->config_base, (hwc->config | enable_mask) & ~disable_mask); }void x86_pmu_enable_all (int added);
arch/x86/kernel/cpu/perf_event_amd.c +35 -2
@@ -1,4 +1,5 @@#include <linux/perf_event.h> +#include <linux/export.h> #include <linux/types.h> #include <linux/init.h> #include <linux/slab.h>
@@ -357,7 +358,9 @@ static void amd_pmu_cpu_starting(int cpustruct amd_nb *nb;int i, nb_id; -if (boot_cpu_data.x86_max_cores <2 ) + cpuc->perf_ctr_virt_mask =AMD_PERFMON_EVENTSEL_HOSTONLY ; + +if (boot_cpu_data.x86_max_cores <2 || boot_cpu_data.x86 ==0x15 )return ; nb_id =amd_get_nb_id (cpu);
@@ -587,9 +590,9 @@ static __initconst const struct x86_pmu .put_event_constraints = amd_put_event_constraints, .cpu_prepare = amd_pmu_cpu_prepare, - .cpu_starting = amd_pmu_cpu_starting, .cpu_dead = amd_pmu_cpu_dead, #endif + .cpu_starting = amd_pmu_cpu_starting, };__init int amd_pmu_init (void )
@@ -621,3 +624,33 @@ __init int amd_pmu_init(void)return 0 ; } + +void amd_pmu_enable_virt (void ) +{ +struct cpu_hw_events *cpuc = &__get_cpu_var (cpu_hw_events); + + cpuc->perf_ctr_virt_mask =0 ; + +/* Reload all events */ +x86_pmu_disable_all (); +x86_pmu_enable_all (0 ); +} +EXPORT_SYMBOL_GPL (amd_pmu_enable_virt); + +void amd_pmu_disable_virt (void ) +{ +struct cpu_hw_events *cpuc = &__get_cpu_var (cpu_hw_events); + +/* +* We only mask out the Host-only bit so that host-only counting works +* when SVM is disabled. If someone sets up a guest-only counter when +* SVM is disabled the Guest-only bits still gets set and the counter +* will not count anything. +*/ + cpuc->perf_ctr_virt_mask =AMD_PERFMON_EVENTSEL_HOSTONLY ; + +/* Reload all events */ +x86_pmu_disable_all (); +x86_pmu_enable_all (0 ); +} +EXPORT_SYMBOL_GPL (amd_pmu_disable_virt);
arch/x86/kvm/svm.c +5 -0
@@ -29,6 +29,7 @@#include <linux/ftrace_event.h> #include <linux/slab.h> +#include <asm/perf_event.h> #include <asm/tlbflush.h> #include <asm/desc.h> #include <asm/kvm_para.h>
@@ -575,6 +576,8 @@ static void svm_hardware_disable(void *gwrmsrl (MSR_AMD64_TSC_RATIO ,TSC_RATIO_DEFAULT );cpu_svm_disable (); + +amd_pmu_disable_virt (); }static int svm_hardware_enable (void *garbage)
@@ -622,6 +625,8 @@ static int svm_hardware_enable(void *garsvm_init_erratum_383 (); +amd_pmu_enable_virt (); +return 0 ; }
Greg KH
maintainerPATCH 16/95 ALSA: hda/realtek - Fix resume of multiple input sources
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Takashi Iwai <[email protected]>
commit 068b939431486f524438330b0848a8222e33d421 upstream.
When there are multiple input sources, the driver wrongly overwrites with the value of the last input source on other slots at resume. Thus the primary input source may be shown wrongly.
--- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/patch_realtek.c +1 -1
@@ -3695,7 +3695,7 @@ static void alc_auto_init_input_src(struelse nums = spec->num_adc_nids;for (c =0 ; c < nums; c++) -alc_mux_select (codec,0 , spec->cur_mux[c], true); +alc_mux_select (codec, c, spec->cur_mux[c], true); }/* add mic boosts if needed */
Greg KH
maintainerPATCH 17/95 ALSA: hda - Add a fake mute feature
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Takashi Iwai <[email protected]>
commit 3868137ea41866773e75d9ac4b9988dcc361ff1d upstream.
Some codecs don't supply the mute amp-capabilities although the lowest volume gives the mute. It'd be handy if the parser provides the mute mixers in such a case.
This patch adds an extension amp-cap bit (which is used only in the driver) to represent the min volume = mute state. Also modified the amp cache code to support the fake mute feature when this bit is set but the real mute bit is unset.
In addition, conexant cx5051 parser uses this new feature to implement the missing mute controls.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=42825
--- sound/pci/hda/hda_codec.c | 8 ++++++-- sound/pci/hda/hda_codec.h | 3 +++ sound/pci/hda/patch_conexant.c | 22 +++++++++++++++++++++- 3 files changed, 30 insertions(+), 3 deletions(-)
sound/pci/hda/hda_codec.c +6 -2
@@ -1795,7 +1795,11 @@ static void put_vol_mute(struct hda_code parm = ch ?AC_AMP_SET_RIGHT :AC_AMP_SET_LEFT ; parm |= direction ==HDA_OUTPUT ?AC_AMP_SET_OUTPUT :AC_AMP_SET_INPUT ; parm |= index <<AC_AMP_SET_INDEX_SHIFT ; - parm |= val; +if ((val &HDA_AMP_MUTE ) && !(info->amp_caps &AC_AMPCAP_MUTE ) && + (info->amp_caps &AC_AMPCAP_MIN_MUTE )) + ;/* set the zero value as a fake mute */ +else + parm |= val;snd_hda_codec_write (codec, nid,0 ,AC_VERB_SET_AMP_GAIN_MUTE , parm); info->vol[ch] = val; }
@@ -2062,7 +2066,7 @@ int snd_hda_mixer_amp_tlv(struct snd_kco val1 = -((caps &AC_AMPCAP_OFFSET ) >>AC_AMPCAP_OFFSET_SHIFT ); val1 += ofs; val1 = ((int )val1) * ((int )val2); -if (min_mute) +if (min_mute || (caps &AC_AMPCAP_MIN_MUTE )) val2 |=TLV_DB_SCALE_MUTE ;if (put_user (SNDRV_CTL_TLVT_DB_SCALE , _tlv))return -EFAULT ;
sound/pci/hda/hda_codec.h +3 -0
@@ -298,6 +298,9 @@ enum {#define AC_AMPCAP_MUTE (1<<31)/* mute capable */ #define AC_AMPCAP_MUTE_SHIFT 31 +/* driver-specific amp-caps: using bits 24-30 */ +#define AC_AMPCAP_MIN_MUTE (1 << 30)/* min-volume = mute */ +/* Connection list */ #define AC_CLIST_LENGTH (0x7f<<0)#define AC_CLIST_LONG (1<<7)
sound/pci/hda/patch_conexant.c +21 -1
@@ -4132,7 +4132,8 @@ static int cx_auto_add_volume_idx(struct err =snd_hda_ctl_add (codec, nid, kctl);if (err <0 )return err; -if (!(query_amp_caps (codec, nid, hda_dir) &AC_AMPCAP_MUTE )) +if (!(query_amp_caps (codec, nid, hda_dir) & + (AC_AMPCAP_MUTE |AC_AMPCAP_MIN_MUTE )))break ; }return 0 ;
@@ -4425,6 +4426,22 @@ static const struct snd_pci_quirk cxt_fi {} }; +/* add "fake" mute amp-caps to DACs on cx5051 so that mixer mute switches +* can be created (bko#42825) +*/ +static void add_cx5051_fake_mutes (struct hda_codec *codec) +{ +static hda_nid_t out_nids[] = { +0x10 ,0x11 ,0 + }; +hda_nid_t *p; + +for (p = out_nids; *p; p++) +snd_hda_override_amp_caps (codec, *p,HDA_OUTPUT , +AC_AMPCAP_MIN_MUTE | +query_amp_caps (codec, *p,HDA_OUTPUT )); +} +static int patch_conexant_auto (struct hda_codec *codec) {struct conexant_spec *spec;
@@ -4443,6 +4460,9 @@ static int patch_conexant_auto(struct hdcase 0x14f15045 : spec->single_adc_amp =1 ;break ; +case 0x14f15051 : +add_cx5051_fake_mutes (codec); +break ; }apply_pin_fixup (codec, cxt_fixups, cxt_pincfg_tbl);
Greg KH
maintainerPATCH 18/95 ALSA: hda - Always set HP pin in unsol handler for STAC/IDT codecs
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Takashi Iwai <[email protected]>
commit 7bff172a352a2fbe9856bba517d71a2072aab041 upstream.
A bug report with an old Sony laptop showed that we can't rely on BIOS setting the pins of headphones but the driver should set always by itself.
--- sound/pci/hda/patch_sigmatel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/patch_sigmatel.c +1 -1
@@ -4719,7 +4719,7 @@ static void stac92xx_hp_detect(struct hdunsigned int val =AC_PINCTL_OUT_EN |AC_PINCTL_HP_EN ;if (no_hp_sensing (spec, i))continue ; -if (presence) +if (1 /*presence*/ )stac92xx_set_pinctl (codec, cfg->hp_pins[i], val);#if 0 /* FIXME */ /* Resetting the pinctl like below may lead to (a sort of) regressions
Greg KH
maintainerPATCH 19/95 regset: Prevent null pointer reference on readonly regsets
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: "H. Peter Anvin" <[email protected]>
commit c8e252586f8d5de906385d8cf6385fee289a825e upstream.
The regset common infrastructure assumed that regsets would always have .get and .set methods, but not necessarily .active methods. Unfortunately people have since written regsets without .set methods.
Rather than putting in stub functions everywhere, handle regsets with null .get or .set methods explicitly.
--- fs/binfmt_elf.c | 2 +- include/linux/regset.h | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-)
fs/binfmt_elf.c +1 -1
@@ -1421,7 +1421,7 @@ static int fill_thread_core_info(structfor (i =1 ; i < view->n; ++i) {const struct user_regset *regset = &view->regsets[i];do_thread_regset_writeback (t->task, regset); -if (regset->core_note_type && +if (regset->core_note_type && regset->get && (!regset->active || regset->active (t->task, regset))) {int ret;size_t size = regset->n * regset->size;
include/linux/regset.h +6 -0
@@ -335,6 +335,9 @@ static inline int copy_regset_to_user(st {const struct user_regset *regset = &view->regsets[setno]; +if (!regset->get) +return -EOPNOTSUPP ; +if (!access_ok (VERIFY_WRITE , data, size))return -EIO ;
@@ -358,6 +361,9 @@ static inline int copy_regset_from_user( {const struct user_regset *regset = &view->regsets[setno]; +if (!regset->set) +return -EOPNOTSUPP ; +if (!access_ok (VERIFY_READ , data, size))return -EIO ;
Greg KH
maintainerPATCH 20/95 regset: Return -EFAULT, not -EIO, on host-side memory fault
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: "H. Peter Anvin" <[email protected]>
commit 5189fa19a4b2b4c3bec37c3a019d446148827717 upstream.
There is only one error code to return for a bad user-space buffer pointer passed to a system call in the same address space as the system call is executed, and that is EFAULT. Furthermore, the low-level access routines, which catch most of the faults, return EFAULT already.
--- include/linux/regset.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/regset.h +2 -2
@@ -339,7 +339,7 @@ static inline int copy_regset_to_user(streturn -EOPNOTSUPP ;if (!access_ok (VERIFY_WRITE , data, size)) -return -EIO ; +return -EFAULT ;return regset->get (target, regset, offset, size,NULL , data); }
@@ -365,7 +365,7 @@ static inline int copy_regset_from_user(return -EOPNOTSUPP ;if (!access_ok (VERIFY_READ , data, size)) -return -EIO ; +return -EFAULT ;return regset->set (target, regset, offset, size,NULL , data); }
Greg KH
maintainerPATCH 21/95 mfd: Fix ACPI conflict check
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jean Delvare <[email protected]>
commit 81b5482c32769abb6dfb979560dab2f952ba86fa upstream.
The code is currently always checking the first resource of every device only (several times.) This has been broken since the ACPI check was added in February 2010 in commit 91fedede0338eb6203cdd618d8ece873fdb7c22c.
Fix the check to run on each resource individually, once.
--- drivers/mfd/mfd-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/mfd-core.c +1 -1
@@ -123,7 +123,7 @@ static int mfd_add_device(struct device }if (!cell->ignore_resource_conflicts) { - ret =acpi_check_resource_conflict (res); + ret =acpi_check_resource_conflict (&res[r]);if (ret) goto fail_res; }
Greg KH
maintainerPATCH 22/95 mfd: Test for jack detection when deciding if wm8994 should suspend
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mark Brown <[email protected]>
commit e7c248a049c2aac21bded0b0722caee6f0e57256 upstream.
The jack detection on WM1811 is often required during system suspend, add it as another check when deciding if we should suspend.
--- drivers/mfd/wm8994-core.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/mfd/wm8994-core.c +14 -0
@@ -252,6 +252,20 @@ static int wm8994_suspend(struct devicebreak ; } +switch (wm8994->type) { +case WM1811 : + ret =wm8994_reg_read (wm8994,WM8994_ANTIPOP_2 ); +if (ret <0 ) { +dev_err (dev,"Failed to read jackdet: %d\n" , ret); + }else if (ret &WM1811_JACKDET_MODE_MASK ) { +dev_dbg (dev,"CODEC still active, ignoring suspend\n" ); +return 0 ; + } +break ; +default : +break ; + } +/* Disable LDO pulldowns while the device is suspended if we * don't know that something will be driving them. */ if (!wm8994->ldo_ena_always_driven)
Greg KH
maintainerPATCH 23/95 genirq: Clear action->thread_mask if IRQ_ONESHOT is not set
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Thomas Gleixner <[email protected]>
commit 52abb700e16a9aa4cbc03f3d7f80206cbbc80680 upstream.
Xommit ac5637611(genirq: Unmask oneshot irqs when thread was not woken) fails to unmask when a !IRQ_ONESHOT threaded handler is handled by handle_level_irq.
This happens because thread_mask is or'ed unconditionally in irq_wake_thread(), but for !IRQ_ONESHOT interrupts never cleared. So the check for !desc->thread_active fails and keeps the interrupt disabled.
Keep the thread_mask zero for !IRQ_ONESHOT interrupts.
Document the thread_mask magic while at it.
--- kernel/irq/manage.c | 44 ++++++++++++++++++++++++++++++++++++++------ 1 file changed, 38 insertions(+), 6 deletions(-)
kernel/irq/manage.c +38 -6
@@ -985,6 +985,11 @@ __setup_irq(unsigned int irq, struct irq/* add new interrupt at end of irq queue */ do { + /* + * Or all existing action->thread_mask bits, + * so we can find the next zero bit for this + * new action. + */ thread_mask |= old->thread_mask; old_ptr = &old->next; old = *old_ptr;
@@ -993,14 +998,41 @@ __setup_irq(unsigned int irq, struct irq }/* -* Setup the thread mask for this irqaction. Unlikely to have -* 32 resp 64 irqs sharing one line, but who knows. +* Setup the thread mask for this irqaction for ONESHOT. For +* !ONESHOT irqs the thread mask is 0 so we can avoid a +* conditional in irq_wake_thread(). */ -if (new->flags &IRQF_ONESHOT && thread_mask == ~0UL ) { - ret = -EBUSY ; - goto out_mask; +if (new->flags &IRQF_ONESHOT ) { +/* +* Unlikely to have 32 resp 64 irqs sharing one line, +* but who knows. +*/ +if (thread_mask == ~0UL ) { + ret = -EBUSY ; + goto out_mask; + } +/* +* The thread_mask for the action is or'ed to +* desc->thread_active to indicate that the +* IRQF_ONESHOT thread handler has been woken, but not +* yet finished. The bit is cleared when a thread +* completes. When all threads of a shared interrupt +* line have completed desc->threads_active becomes +* zero and the interrupt line is unmasked. See +* handle.c:irq_wake_thread() for further information. +* +* If no thread is woken by primary (hard irq context) +* interrupt handlers, then desc->threads_active is +* also checked for zero to unmask the irq line in the +* affected hard irq flow handlers +* (handle_[fasteoi|level]_irq). +* +* The new action gets the first zero bit of +* thread_mask assigned. See the loop above which or's +* all existing action->thread_mask bits. +*/ + new->thread_mask =1 <<ffz (thread_mask); } - new->thread_mask =1 <<ffz (thread_mask);if (!shared) {init_waitqueue_head (&desc->wait_for_threads);
Greg KH
maintainerPATCH 24/95 ARM: S3C24XX: DMA resume regression fix
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Gusakov Andrey <[email protected]>
commit e39d40c65dfd8390b50c03482ae9e289b8a8f351 upstream.
s3c2410_dma_suspend suspends channels from 0 to dma_channels. s3c2410_dma_resume resumes channels in reverse order. So pointer should be decremented instead of being incremented.
--- arch/arm/plat-s3c24xx/dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/plat-s3c24xx/dma.c +1 -1
@@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void)struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels -1 ;int channel; -for (channel = dma_channels -1 ; channel >=0 ; cp++, channel--) +for (channel = dma_channels -1 ; channel >=0 ; cp--, channel--)s3c2410_dma_resume_chan (cp); }
Greg KH
maintainerPATCH 25/95 Move Logitech Harmony 900 from cdc_ether to zaurus
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Scott Talbert <[email protected]>
commit ee932bf9acb2e2c6a309e808000f24856330e3f9 upstream.
In the current kernel implementation, the Logitech Harmony 900 remote control is matched to the cdc_ether driver through the generic USB_CDC_SUBCLASS_MDLM entry. However, this device appears to be of the pseudo-MDLM (Belcarra) type, rather than the standard one. This patch blacklists the Harmony 900 from the cdc_ether driver and whitelists it for the pseudo-MDLM driver in zaurus.
--- drivers/net/usb/cdc_ether.c | 7 +++++++ drivers/net/usb/zaurus.c | 7 +++++++ 2 files changed, 14 insertions(+)
drivers/net/usb/cdc_ether.c +7 -0
@@ -570,6 +570,13 @@ static const struct usb_device_id produc .driver_info = 0, }, +/* Logitech Harmony 900 - uses the pseudo-MDLM (BLAN) driver */ +{ +USB_DEVICE_AND_INTERFACE_INFO (0x046d ,0xc11f ,USB_CLASS_COMM , + USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), + .driver_info = 0, +}, +/* * WHITELIST!!! *
drivers/net/usb/zaurus.c +7 -0
@@ -349,6 +349,13 @@ static const struct usb_device_id produc ZAURUS_MASTER_INTERFACE, .driver_info = OLYMPUS_MXL_INFO, }, + +/* Logitech Harmony 900 - uses the pseudo-MDLM (BLAN) driver */ +{ +USB_DEVICE_AND_INTERFACE_INFO (0x046d ,0xc11f ,USB_CLASS_COMM , + USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), + .driver_info = (unsigned long) &bogus_mdlm_info, +}, { }, // END };MODULE_DEVICE_TABLE (usb, products);
Greg KH
maintainerPATCH 26/95 alpha: fix 32/64-bit bug in futex support
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andrew Morton <[email protected]>
commit 62aca403657fe30e5235c5331e9871e676d9ea0a upstream.
Michael Cree said:
: : I have noticed some user space problems (pulseaudio crashes in pthread : : code, glibc/nptl test suite failures, java compiler freezes on SMP alpha : : systems) that arise when using a 2.6.39 or later kernel on Alpha. : : Bisecting between 2.6.38 and 2.6.39 (using glibc/nptl test suite as : : criterion for good/bad kernel) eventually leads to:
: :
: : 8d7718aa082aaf30a0b4989e1f04858952f941bc is the first bad commit : : commit 8d7718aa082aaf30a0b4989e1f04858952f941bc
: : Author: Michel Lespinasse <[email protected]>
: : Date: Thu Mar 10 18:50:58 2011 -0800
: :
: : futex: Sanitize futex ops argument types
: :
: : Change futex_atomic_op_inuser and futex_atomic_cmpxchg_inatomic : : prototypes to use u32 types for the futex as this is the data type the : : futex core code uses all over the place.
: :
: : Looking at the commit I see there is a change of the uaddr argument in : : the Alpha architecture specific code for futexes from int to u32, but I : : don't see why this should cause a problem.
Richard Henderson said:
: futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,
: u32 oldval, u32 newval)
: ...
: : "r"(uaddr), "r"((long)oldval), "r"(newval)
:
:
: There is no 32-bit compare instruction. These are implemented by : consistently extending the values to a 64-bit type. Since the : load instruction sign-extends, we want to sign-extend the other : quantity as well (despite the fact it's logically unsigned). :
: So:
:
: - : "r"(uaddr), "r"((long)oldval), "r"(newval) : + : "r"(uaddr), "r"((long)(int)oldval), "r"(newval)
:
: should do the trick.
Michael said:
: This fixes the glibc test suite failures and the pulseaudio related : crashes, but it does not fix the java compiiler lockups that I was (and : are still) observing. That is some other problem.
--- arch/alpha/include/asm/futex.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/alpha/include/asm/futex.h +1 -1
@@ -108,7 +108,7 @@ futex_atomic_cmpxchg_inatomic(u32 *uval," lda $31,3b-2b(%0)\n" " .previous\n" : "+r"(ret), "=&r"(prev), "=&r"(cmp) - : "r"(uaddr), "r"((long)oldval), "r"(newval) + : "r"(uaddr), "r"((long)(int)oldval), "r"(newval) : "memory"); *uval = prev;
Greg KH
maintainerPATCH 27/95 mmc: atmel-mci: dont use dma features when using DMA with no chan available
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ludovic Desroches <[email protected]>
commit ef8781989a1bcd05aa47e853917c37df44917194 upstream.
Some callbacks are set too early -- i.e. we can have dma capabilities but we can't get a dma channel. So wait to get the dma channel before setting callbacks and change logs consequently.
--- drivers/mmc/host/atmel-mci.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-)
drivers/mmc/host/atmel-mci.c +10 -11
@@ -1944,12 +1944,12 @@ static bool atmci_filter(struct dma_chan } } -static void atmci_configure_dma (struct atmel_mci *host) +static bool atmci_configure_dma (struct atmel_mci *host) {struct mci_platform_data *pdata;if (host ==NULL ) -return ; +return false; pdata = host->pdev->dev.platform_data;
@@ -1966,12 +1966,15 @@ static void atmci_configure_dma(struct a host->dma.chan =dma_request_channel (mask, atmci_filter, pdata->dma_slave); } -if (!host->dma.chan) -dev_notice (&host->pdev->dev,"DMA not available, using PIO\n" ); -else +if (!host->dma.chan) { +dev_warn (&host->pdev->dev,"no DMA channel available\n" ); +return false; + }else {dev_info (&host->pdev->dev,"Using %s for DMA transfers\n" ,dma_chan_name (host->dma.chan)); +return true; + } }static inline unsigned int atmci_get_version (struct atmel_mci *host)
@@ -2081,8 +2084,7 @@ static int __init atmci_probe(struct pla/* Get MCI capabilities and set operations according to it */ atmci_get_cap (host); -if (host->caps.has_dma) { -dev_info (&pdev->dev,"using DMA\n" ); +if (host->caps.has_dma &&atmci_configure_dma (host)) { host->prepare_data = &atmci_prepare_data_dma; host->submit_data = &atmci_submit_data_dma; host->stop_transfer = &atmci_stop_transfer_dma;
@@ -2092,15 +2094,12 @@ static int __init atmci_probe(struct pla host->submit_data = &atmci_submit_data_pdc; host->stop_transfer = &atmci_stop_transfer_pdc; }else { -dev_info (&pdev->dev,"no DMA, no PDC\n" ); +dev_info (&pdev->dev,"using PIO\n" ); host->prepare_data = &atmci_prepare_data; host->submit_data = &atmci_submit_data; host->stop_transfer = &atmci_stop_transfer; } -if (host->caps.has_dma) -atmci_configure_dma (host); -platform_set_drvdata (pdev, host);/* We need at least one slot to succeed */
Greg KH
maintainerPATCH 28/95 mmc: sdhci-esdhc-imx: fix for mmc cards on i.MX5
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sascha Hauer <[email protected]>
commit 5b6b0ad6e572b32a641116aaa5f897ffebe31e44 upstream.
On i.MX53 we have to write a special SDHCI_CMD_ABORTCMD to the SDHCI_TRANSFER_MODE register during a MMC_STOP_TRANSMISSION command. This works for SD cards. However, with MMC cards the MMC_SET_BLOCK_COUNT command is used instead, but this needs the same handling. Fix MMC cards by testing for the MMC_SET_BLOCK_COUNT command aswell. Tested on a custom i.MX53 board with a Transcend MMC+ card and eMMC.
The kernel started used MMC_SET_BLOCK_COUNT in 3.0, so this is a regression for these boards introduced in 3.0; it should go to 3.0/3.1/3.2-stable.
--- drivers/mmc/host/sdhci-esdhc-imx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +3 -2
@@ -269,8 +269,9 @@ static void esdhc_writew_le(struct sdhci imx_data->scratchpad = val;return ;case SDHCI_COMMAND : -if ((host->cmd->opcode ==MMC_STOP_TRANSMISSION ) - && (imx_data->flags &ESDHC_FLAG_MULTIBLK_NO_INT )) +if ((host->cmd->opcode ==MMC_STOP_TRANSMISSION || + host->cmd->opcode ==MMC_SET_BLOCK_COUNT ) && + (imx_data->flags &ESDHC_FLAG_MULTIBLK_NO_INT )) val |=SDHCI_CMD_ABORTCMD ;if (is_imx6q_usdhc (imx_data)) {
Greg KH
maintainerPATCH 29/95 aio: wake up waiters when freeing unused kiocbs
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jeff Moyer <[email protected]>
commit 880641bb9da2473e9ecf6c708d993b29928c1b3c upstream.
Bart Van Assche reported a hung fio process when either hot-removing storage or when interrupting the fio process itself. The (pruned) call trace for the latter looks like so:
fio D 0000000000000001 0 6849 6848 0x00000004
ffff880092541b88 0000000000000046 ffff880000000000 ffff88012fa11dc0 ffff88012404be70 ffff880092541fd8 ffff880092541fd8 ffff880092541fd8 ffff880128b894d0 ffff88012404be70 ffff880092541b88 000000018106f24d
Call Trace:
schedule+0x3f/0x60
io_schedule+0x8f/0xd0
wait_for_all_aios+0xc0/0x100
exit_aio+0x55/0xc0
mmput+0x2d/0x110
exit_mm+0x10d/0x130
do_exit+0x671/0x860
do_group_exit+0x44/0xb0
get_signal_to_deliver+0x218/0x5a0
do_signal+0x65/0x700
do_notify_resume+0x65/0x80
int_signal+0x12/0x17The problem lies with the allocation batching code. It will opportunistically allocate kiocbs, and then trim back the list of iocbs when there is not enough room in the completion ring to hold all of the events.
In the case above, what happens is that the pruning back of events ends up freeing up the last active request and the context is marked as dead, so it is thus responsible for waking up waiters. Unfortunately, the code does not check for this condition, so we end up with a hung task.
--- fs/aio.c | 2 ++ 1 file changed, 2 insertions(+)
fs/aio.c +2 -0
@@ -490,6 +490,8 @@ static void kiocb_batch_free(struct kiockmem_cache_free (kiocb_cachep, req); ctx->reqs_active--; } +if (unlikely (!ctx->reqs_active && ctx->dead)) +wake_up_all (&ctx->wait);spin_unlock_irq (&ctx->ctx_lock); }
Greg KH
maintainerPATCH 30/95 mm: memcg: Correct unregistring of events attached to the same eventfd
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Anton Vorontsov <[email protected]>
commit 371528caec553785c37f73fa3926ea0de84f986f upstream.
There is an issue when memcg unregisters events that were attached to the same eventfd:
- On the first call mem_cgroup_usage_unregister_event() removes all events attached to a given eventfd, and if there were no events left, thresholds->primary would become NULL;
- Since there were several events registered, cgroups core will call mem_cgroup_usage_unregister_event() again, but now kernel will oops, as the function doesn't expect that threshold->primary may be NULL.
That's a good question whether mem_cgroup_usage_unregister_event() should actually remove all events in one go, but nowadays it can't do any better as cftype->unregister_event callback doesn't pass any private event-associated cookie. So, let's fix the issue by simply checking for threshold->primary.
FWIW, w/o the patch the following oops may be observed:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000004 IP: [<ffffffff810be32c>] mem_cgroup_usage_unregister_event+0x9c/0x1f0 Pid: 574, comm: kworker/0:2 Not tainted 3.3.0-rc4+ #9 Bochs Bochs RIP: 0010:[<ffffffff810be32c>] [<ffffffff810be32c>] mem_cgroup_usage_unregister_event+0x9c/0x1f0 RSP: 0018:ffff88001d0b9d60 EFLAGS: 00010246 Process kworker/0:2 (pid: 574, threadinfo ffff88001d0b8000, task ffff88001de91cc0) Call Trace: [<ffffffff8107092b>] cgroup_event_remove+0x2b/0x60 [<ffffffff8103db94>] process_one_work+0x174/0x450 [<ffffffff8103e413>] worker_thread+0x123/0x2d0
--- mm/memcontrol.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
mm/memcontrol.c +4 -1
@@ -4502,6 +4502,9 @@ static void mem_cgroup_usage_unregister_*/ BUG_ON (!thresholds); +if (!thresholds->primary) + goto unlock; + usage =mem_cgroup_usage (memcg, type == _MEMSWAP);/* Check if a threshold crossed before removing */
@@ -4550,7 +4553,7 @@ swap_buffers:/* To be sure that nobody uses thresholds */ synchronize_rcu (); - +unlock:mutex_unlock (&memcg->thresholds_lock); }
Greg KH
maintainerPATCH 31/95 NOMMU: Dont need to clear vm_mm when deleting a VMA
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Howells <[email protected]>
commit b94cfaf6685d691dc3fab023cf32f65e9b7be09c upstream.
Don't clear vm_mm in a deleted VMA as it's unnecessary and might conceivably break the filesystem or driver VMA close routine.
--- mm/nommu.c | 2 -- 1 file changed, 2 deletions(-)
mm/nommu.c +0 -2
@@ -779,8 +779,6 @@ static void delete_vma_from_mm(struct vmif (vma->vm_next) vma->vm_next->vm_prev = vma->vm_prev; - - vma->vm_mm =NULL ; }/*
Greg KH
maintainerPATCH 32/95 cifs: fix dentry refcount leak when opening a FIFO on lookup
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jeff Layton <[email protected]>
commit 5bccda0ebc7c0331b81ac47d39e4b920b198b2cd upstream.
The cifs code will attempt to open files on lookup under certain circumstances. What happens though if we find that the file we opened was actually a FIFO or other special file?
Currently, the open filehandle just ends up being leaked leading to a dentry refcount mismatch and oops on umount. Fix this by having the code close the filehandle on the server if it turns out not to be a regular file. While we're at it, change this spaghetti if statement into a switch too.
--- fs/cifs/dir.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)
fs/cifs/dir.c +18 -2
@@ -584,10 +584,26 @@ cifs_lookup(struct inode *parent_dir_ino* If either that or op not supported returned, follow * the normal lookup. */ -if ((rc ==0 ) || (rc == -ENOENT )) +switch (rc) { +case 0 : +/* +* The server may allow us to open things like +* FIFOs, but the client isn't set up to deal +* with that. If it's not a regular file, just +* close it and proceed as if it were a normal +* lookup. +*/ +if (newInode && !S_ISREG (newInode->i_mode)) { +CIFSSMBClose (xid, pTcon, fileHandle); +break ; + } +case -ENOENT : posix_open = true; -else if ((rc == -EINVAL ) || (rc != -EOPNOTSUPP )) +case -EOPNOTSUPP : +break ; +default : pTcon->broken_posix_open = true; + } }if (!posix_open) rc = cifs_get_inode_info_unix(&newInode, full_path,
Greg KH
maintainerPATCH 33/95 mac80211: zero initialize count field in ieee80211_tx_rate
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mohammed Shafi Shajakhan <[email protected]>
commit 8617b093d0031837a7be9b32bc674580cfb5f6b5 upstream.
rate control algorithms concludes the rate as invalid
with rate[i].idx < -1 , while they do also check for rate[i].count is non-zero. it would be safer to zero initialize the 'count' field. recently we had a ath9k rate control crash where the ath9k rate control in ath_tx_status assumed to check only for rate[i].count being non-zero in one instance and ended up in using invalid rate index for 'connection monitoring NULL func frames' which eventually lead to the crash. thanks to Pavel Roskin for fixing it and finding the root cause.
https://bugzilla.redhat.com/show_bug.cgi?id=768639
--- net/mac80211/rate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/mac80211/rate.c +1 -1
@@ -344,7 +344,7 @@ void rate_control_get_rate(struct ieee80for (i =0 ; i <IEEE80211_TX_MAX_RATES ; i++) { info->control.rates[i].idx =-1 ; info->control.rates[i].flags =0 ; - info->control.rates[i].count =1 ; + info->control.rates[i].count =0 ; }if (sdata->local->hw.flags &IEEE80211_HW_HAS_RATE_CONTROL )
Greg KH
maintainerPATCH 34/95 ath9k_hw: prevent writes to const data on AR9160
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Felix Fietkau <[email protected]>
commit 9bbb8168ed3d8b946f9c1901a63a675012de88f2 upstream.
Duplicate the data for iniAddac early on, to avoid having to do redundant memcpy calls later. While we're at it, make AR5416 < v2.2 use the same codepath. Fixes a reported crash on x86.
--- drivers/net/wireless/ath/ath9k/ar5008_phy.c | 25 +------------------------ drivers/net/wireless/ath/ath9k/ar9002_hw.c | 19 +++++++++++++++++++ drivers/net/wireless/ath/ath9k/hw.h | 1 - 3 files changed, 20 insertions(+), 25 deletions(-)
drivers/net/wireless/ath/ath9k/ar5008_phy.c +1 -24
@@ -489,8 +489,6 @@ static int ar5008_hw_rf_alloc_ext_banks(ATH_ALLOC_BANK (ah->analogBank6Data, ah->iniBank6.ia_rows);ATH_ALLOC_BANK (ah->analogBank6TPCData, ah->iniBank6TPC.ia_rows);ATH_ALLOC_BANK (ah->analogBank7Data, ah->iniBank7.ia_rows); -ATH_ALLOC_BANK (ah->addac5416_21, - ah->iniAddac.ia_rows * ah->iniAddac.ia_columns);ATH_ALLOC_BANK (ah->bank6Temp, ah->iniBank6.ia_rows);return 0 ;
@@ -519,7 +517,6 @@ static void ar5008_hw_rf_free_ext_banks(ATH_FREE_BANK (ah->analogBank6Data);ATH_FREE_BANK (ah->analogBank6TPCData);ATH_FREE_BANK (ah->analogBank7Data); -ATH_FREE_BANK (ah->addac5416_21);ATH_FREE_BANK (ah->bank6Temp);#undef ATH_FREE_BANK
@@ -805,27 +802,7 @@ static int ar5008_hw_process_ini(structif (ah->eep_ops->set_addac) ah->eep_ops->set_addac (ah, chan); -if (AR_SREV_5416_22_OR_LATER (ah)) { -REG_WRITE_ARRAY (&ah->iniAddac,1 , regWrites); - }else { -struct ar5416IniArray temp; -u32 addacSize = -sizeof (u32) * ah->iniAddac.ia_rows * - ah->iniAddac.ia_columns; - -/* For AR5416 2.0/2.1 */ -memcpy (ah->addac5416_21, - ah->iniAddac.ia_array, addacSize); - -/* override CLKDRV value at [row, column] = [31, 1] */ - (ah->addac5416_21)[31 * ah->iniAddac.ia_columns +1 ] =0 ; - - temp.ia_array = ah->addac5416_21; - temp.ia_columns = ah->iniAddac.ia_columns; - temp.ia_rows = ah->iniAddac.ia_rows; -REG_WRITE_ARRAY (&temp,1 , regWrites); - } - +REG_WRITE_ARRAY (&ah->iniAddac,1 , regWrites);REG_WRITE (ah,AR_PHY_ADC_SERIAL_CTL ,AR_PHY_SEL_INTERNAL_ADDAC );ENABLE_REGWRITE_BUFFER (ah);
drivers/net/wireless/ath/ath9k/ar9002_hw.c +19 -0
@@ -180,6 +180,25 @@ static void ar9002_hw_init_mode_regs(strINIT_INI_ARRAY (&ah->iniAddac, ar5416Addac,ARRAY_SIZE (ar5416Addac),2 ); } + +/* iniAddac needs to be modified for these chips */ +if (AR_SREV_9160 (ah) || !AR_SREV_5416_22_OR_LATER (ah)) { +struct ar5416IniArray *addac = &ah->iniAddac; +u32 size =sizeof (u32) * addac->ia_rows * addac->ia_columns; +u32 *data; + + data =kmalloc (size,GFP_KERNEL ); +if (!data) +return ; + +memcpy (data, addac->ia_array, size); + addac->ia_array = data; + +if (!AR_SREV_5416_22_OR_LATER (ah)) { +/* override CLKDRV value */ +INI_RA (addac,31 ,1 ) =0 ; + } + } }/* Support for Japan ch.14 (2484) spread */
drivers/net/wireless/ath/ath9k/hw.h +0 -1
@@ -772,7 +772,6 @@ struct ath_hw {u32 *analogBank6Data;u32 *analogBank6TPCData;u32 *analogBank7Data; -u32 *addac5416_21;u32 *bank6Temp;u8 txpower_limit;
Greg KH
maintainerPATCH 35/95 kprobes: return proper error code from register_kprobe()
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Prashanth Nageshappa <[email protected]>
commit f986a499ef6f317d906e6f6f281be966e1237a10 upstream.
register_kprobe() aborts if the address of the new request falls in a prohibited area (such as ftrace pouch, __kprobes annotated functions, non-kernel text addresses, jump label text). We however don't return the right error on this abort, resulting in a silent failure - incorrect adding/reporting of kprobes ('perf probe do_fork+18' or 'perf probe mcount' for instance).
In V2 we are incorporating Masami Hiramatsu's feedback.
This patch fixes it by returning -EINVAL upon failure.
While we are here, rename the label used for exit to be more appropriate.
--- kernel/kprobes.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
kernel/kprobes.c +7 -5
@@ -1334,8 +1334,10 @@ int __kprobes register_kprobe(struct kprif (!kernel_text_address ((unsigned long ) p->addr) ||in_kprobes_functions ((unsigned long ) p->addr) ||ftrace_text_reserved (p->addr, p->addr) || -jump_label_text_reserved (p->addr, p->addr)) - goto fail_with_jump_label; +jump_label_text_reserved (p->addr, p->addr)) { + ret = -EINVAL ; + goto cannot_probe; + }/* User can pass only KPROBE_FLAG_DISABLED to register_kprobe */ p->flags &=KPROBE_FLAG_DISABLED ;
@@ -1352,7 +1354,7 @@ int __kprobes register_kprobe(struct kpr* its code to prohibit unexpected unloading. */ if (unlikely (!try_module_get (probed_mod))) - goto fail_with_jump_label; + goto cannot_probe;/* * If the module freed .init.text, we couldn't insert
@@ -1361,7 +1363,7 @@ int __kprobes register_kprobe(struct kprif (within_module_init ((unsigned long )p->addr, probed_mod) && probed_mod->state !=MODULE_STATE_COMING ) {module_put (probed_mod); - goto fail_with_jump_label; + goto cannot_probe; }/* ret will be updated by following code */ }
@@ -1409,7 +1411,7 @@ out:return ret; -fail_with_jump_label: +cannot_probe:preempt_enable ();jump_label_unlock ();return ret;
Greg KH
maintainerPATCH 36/95 mm: thp: fix BUG on mm->nr_ptes
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andrea Arcangeli <[email protected]>
commit 1c641e84719429bbfe62a95ed3545ee7fe24408f upstream.
Dave Jones reports a few Fedora users hitting the BUG_ON(mm->nr_ptes...) in exit_mmap() recently.
Quoting Hugh's discovery and explanation of the SMP race condition:
"mm->nr_ptes had unusual locking: down_read mmap_sem plus
page_table_lock when incrementing, down_write mmap_sem (or mm_users
0) when decrementing; whereas THP is careful to increment and decrement it under page_table_lock.
Now most of those paths in THP also hold mmap_sem for read or write (with appropriate checks on mm_users), but two do not: when split_huge_page() is called by hwpoison_user_mappings(), and when called by add_to_swap().
It's conceivable that the latter case is responsible for the exit_mmap() BUG_ON mm->nr_ptes that has been reported on Fedora."
The simplest way to fix it without having to alter the locking is to make split_huge_page() a noop in nr_ptes terms, so by counting the preallocated pagetables that exists for every mapped hugepage. It was an arbitrary choice not to count them and either way is not wrong or right, because they are not used but they're still allocated.
--- mm/huge_memory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mm/huge_memory.c +3 -3
@@ -642,6 +642,7 @@ static int __do_huge_pmd_anonymous_page(set_pmd_at (mm, haddr, pmd, entry);prepare_pmd_huge_pte (pgtable, mm);add_mm_counter (mm,MM_ANONPAGES ,HPAGE_PMD_NR ); + mm->nr_ptes++;spin_unlock (&mm->page_table_lock); }
@@ -760,6 +761,7 @@ int copy_huge_pmd(struct mm_struct *dst_ pmd =pmd_mkold (pmd_wrprotect (pmd));set_pmd_at (dst_mm, addr, dst_pmd, pmd);prepare_pmd_huge_pte (pgtable, dst_mm); + dst_mm->nr_ptes++; ret =0 ; out_unlock:
@@ -858,7 +860,6 @@ static int do_huge_pmd_wp_page_fallback( }kfree (pages); - mm->nr_ptes++;smp_wmb ();/* make pte visible before pmd */ pmd_populate (mm, pmd, pgtable);page_remove_rmap (page);
@@ -1017,6 +1018,7 @@ int zap_huge_pmd(struct mmu_gather *tlb,VM_BUG_ON (page_mapcount (page) <0 );add_mm_counter (tlb->mm,MM_ANONPAGES , -HPAGE_PMD_NR );VM_BUG_ON (!PageHead (page)); + tlb->mm->nr_ptes--;spin_unlock (&tlb->mm->page_table_lock);tlb_remove_page (tlb, page);pte_free (tlb->mm, pgtable);
@@ -1356,7 +1358,6 @@ static int __split_huge_page_map(structpte_unmap (pte); } - mm->nr_ptes++;smp_wmb ();/* make pte visible before pmd */ /* * Up to this point the pmd is present and huge and
@@ -1969,7 +1970,6 @@ static void collapse_huge_page(struct mmset_pmd_at (mm, address, pmd, _pmd);update_mmu_cache (vma, address, _pmd);prepare_pmd_huge_pte (pgtable, mm); - mm->nr_ptes--;spin_unlock (&mm->page_table_lock);#ifndef CONFIG_NUMA
Greg KH
maintainerPATCH 37/95 iwlwifi: fix key removal
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Johannes Berg <[email protected]>
commit 5dcbf480473f6c3f06ad2426b7517038a2a18911 upstream.
When trying to remove a key, we always send key
flags just setting the key type, not including
the multicast flag and the key ID. As a result,
whenever any key was removed, the unicast key 0
would be removed, causing a complete connection
loss after the second rekey (the first doesn't
cause a key removal). Fix the key removal code
to include the key ID and multicast flag, thus
removing the correct key.
--- drivers/net/wireless/iwlwifi/iwl-agn-sta.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/net/wireless/iwlwifi/iwl-agn-sta.c +9 -1
@@ -1211,6 +1211,7 @@ int iwl_remove_dynamic_key(struct iwl_prunsigned long flags;struct iwl_addsta_cmd sta_cmd;u8 sta_id =iwlagn_key_sta_id (priv, ctx->vif, sta); +__le16 key_flags;/* if station isn't there, neither is the key */ if (sta_id ==IWL_INVALID_STATION )
@@ -1236,7 +1237,14 @@ int iwl_remove_dynamic_key(struct iwl_prIWL_ERR (priv,"offset %d not used in uCode key table.\n" , keyconf->hw_key_idx); - sta_cmd.key.key_flags =STA_KEY_FLG_NO_ENC |STA_KEY_FLG_INVALID ; + key_flags =cpu_to_le16 (keyconf->keyidx <<STA_KEY_FLG_KEYID_POS ); + key_flags |=STA_KEY_FLG_MAP_KEY_MSK |STA_KEY_FLG_NO_ENC | +STA_KEY_FLG_INVALID ; + +if (!(keyconf->flags &IEEE80211_KEY_FLAG_PAIRWISE )) + key_flags |=STA_KEY_MULTICAST_MSK ; + + sta_cmd.key.key_flags = key_flags; sta_cmd.key.key_offset =WEP_INVALID_OFFSET ; sta_cmd.sta.modify_mask =STA_MODIFY_KEY_MASK ; sta_cmd.mode =STA_CONTROL_MODIFY_MSK ;
Greg KH
maintainerPATCH 38/95 tty/powerpc: early udbg consoles cant be modules
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stephen Rothwell <[email protected]>
commit f21c6d4a49179f91fd70a41382382f08c780d425 upstream.
Fixes these build errors:
ERROR: ".udbg_printf" [drivers/tty/ehv_bytechan.ko] undefined!
ERROR: ".register_early_udbg_console" [drivers/tty/ehv_bytechan.ko] undefined!
ERROR: "udbg_putc" [drivers/tty/ehv_bytechan.ko] undefined!
--- drivers/tty/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/Kconfig +1 -1
@@ -365,7 +365,7 @@ config PPC_EPAPR_HV_BYTECHAN config PPC_EARLY_DEBUG_EHV_BC bool "Early console (udbg) support for ePAPR hypervisors" - depends on PPC_EPAPR_HV_BYTECHAN + depends on PPC_EPAPR_HV_BYTECHAN=y help Select this option to enable early console (a.k.a. "udbg") support via an ePAPR byte channel. You also need to choose the byte channel
Greg KH
maintainerPATCH 39/95 S390: qdio: fix handler function arguments for zfcp data router
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Steffen Maier <[email protected]>
commit 7b3cc67d4445995a025a4b55a7dc687b6829b4ca upstream.
Git commit 25f269f17316549e "[S390] qdio: EQBS retry after CCQ 96" introduced a regression in regard to the zfcp data router. Revoke the incorrect simplification of the function call arguments for the qdio handler to make the zfcp hardware data router working again.
This is applicable to 3.2+ kernels.
--- drivers/s390/cio/qdio_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/s390/cio/qdio_main.c +2 -2
@@ -167,7 +167,7 @@ again:DBF_ERROR ("%4x EQBS ERROR" ,SCH_NO (q));DBF_ERROR ("%3d%3d%2d" , count, tmp_count, nr); q->handler (q->irq_ptr->cdev,QDIO_ERROR_ACTIVATE_CHECK_CONDITION , -0 ,-1 ,-1 , q->irq_ptr->int_parm); + q->nr, q->first_to_kick, count, q->irq_ptr->int_parm);return 0 ; }
@@ -215,7 +215,7 @@ again:DBF_ERROR ("%4x SQBS ERROR" ,SCH_NO (q));DBF_ERROR ("%3d%3d%2d" , count, tmp_count, nr); q->handler (q->irq_ptr->cdev,QDIO_ERROR_ACTIVATE_CHECK_CONDITION , -0 ,-1 ,-1 , q->irq_ptr->int_parm); + q->nr, q->first_to_kick, count, q->irq_ptr->int_parm);return 0 ; }
Greg KH
maintainerPATCH 40/95 rapidio/tsi721: fix queue wrapping bug in inbound doorbell handler
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alexandre Bounine <[email protected]>
commit b24823e61bfd93d0e72088e4f5245287582ed289 upstream.
Fix a bug that causes a kernel panic when the number of received doorbells is larger than number of entries in the inbound doorbell queue (current default value = 512).
Another possible indication for this bug is large number of spurious doorbells reported by tsi721 driver after reaching the queue size maximum.
--- drivers/rapidio/devices/tsi721.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/rapidio/devices/tsi721.c +3 -2
@@ -410,13 +410,14 @@ static void tsi721_db_dpc(struct work_st*/ mport = priv->mport; - wr_ptr =ioread32 (priv->regs +TSI721_IDQ_WP (IDB_QUEUE )); - rd_ptr =ioread32 (priv->regs +TSI721_IDQ_RP (IDB_QUEUE )); + wr_ptr =ioread32 (priv->regs +TSI721_IDQ_WP (IDB_QUEUE )) %IDB_QSIZE ; + rd_ptr =ioread32 (priv->regs +TSI721_IDQ_RP (IDB_QUEUE )) %IDB_QSIZE ;while (wr_ptr != rd_ptr) { idb_entry = (u64 *)(priv->idb_base + (TSI721_IDB_ENTRY_SIZE * rd_ptr)); rd_ptr++; + rd_ptr %=IDB_QSIZE ; idb.msg = *idb_entry; *idb_entry =0 ;
Greg KH
maintainerPATCH 41/95 HID: usbhid: Add NOGET quirk for the AIREN Slim+ keyboard
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alan Stern <[email protected]>
commit 37891abc8464637964a26ae4b61d307fef831f80 upstream.
This patch (as1531) adds a NOGET quirk for the Slim+ keyboard marketed by AIREN. This keyboard seems to have a lot of bugs; NOGET works around only one of them.
--- drivers/hid/hid-ids.h | 3 +++ drivers/hid/usbhid/hid-quirks.c | 1 + 2 files changed, 4 insertions(+)
drivers/hid/hid-ids.h +3 -0
@@ -59,6 +59,9 @@#define USB_VENDOR_ID_AIRCABLE 0x16CA#define USB_DEVICE_ID_AIRCABLE1 0x1502 +#define USB_VENDOR_ID_AIREN 0x1a2c +#define USB_DEVICE_ID_AIREN_SLIMPLUS 0x0002 +#define USB_VENDOR_ID_ALCOR 0x058f#define USB_DEVICE_ID_ALCOR_USBRS232 0x9720
drivers/hid/usbhid/hid-quirks.c +1 -0
@@ -53,6 +53,7 @@ static const struct hid_blacklist { { USB_VENDOR_ID_PLAYDOTCOM, USB_DEVICE_ID_PLAYDOTCOM_EMS_USBII, HID_QUIRK_MULTI_INPUT }, { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT }, + { USB_VENDOR_ID_AIREN, USB_DEVICE_ID_AIREN_SLIMPLUS, HID_QUIRK_NOGET }, { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_UC100KM, HID_QUIRK_NOGET }, { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_CS124U, HID_QUIRK_NOGET }, { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_2PORTKVM, HID_QUIRK_NOGET },
Greg KH
maintainerPATCH 42/95 crypto: mv_cesa - fix final callback not ignoring input data
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Phil Sutter <[email protected]>
commit f8f54e190ddb4ed697036b60f5e2ae6dd45b801c upstream.
Broken by commit 6ef84509f3d439ed2d43ea40080643efec37f54f for users passing a request with non-zero 'nbytes' field, like e.g. testmgr.
--- drivers/crypto/mv_cesa.c | 1 + 1 file changed, 1 insertion(+)
drivers/crypto/mv_cesa.c +1 -0
@@ -714,6 +714,7 @@ static int mv_hash_final(struct ahash_re {struct mv_req_hash_ctx *ctx =ahash_request_ctx (req); +ahash_request_set_crypt (req,NULL , req->result,0 );mv_update_hash_req_ctx (ctx,1 ,0 );return mv_handle_req (&req->base); }
Greg KH
maintainerPATCH 43/95 osd_uld: Bump MAX_OSD_DEVICES from 64 to 1,048,576
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Boaz Harrosh <[email protected]>
commit 41f8ad76362e7aefe3a03949c43e23102dae6e0b upstream.
It used to be that minors where 8 bit. But now they are actually 20 bit. So the fix is simplicity itself.
I've tested with 300 devices and all user-mode utils work just fine. I have also mechanically added 10,000 to the ida (so devices are /dev/osd10000, /dev/osd10001 ...) and was able to mkfs an exofs filesystem and access osds from user-mode.
All the open-osd user-mode code uses the same library to access devices through their symbolic names in /dev/osdX so I'd say it's pretty safe. (Well tested)
This patch is very important because some of the systems that will be deploying the 3.2 pnfs-objects code are larger than 64 OSDs and will stop to work properly when reaching that number.
--- drivers/scsi/osd/osd_uld.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/osd/osd_uld.c +2 -2
@@ -69,10 +69,10 @@#ifndef SCSI_OSD_MAJOR # define SCSI_OSD_MAJOR 260#endif -#define SCSI_OSD_MAX_MINOR 64 +#define SCSI_OSD_MAX_MINOR MINORMASKstatic const char osd_name[] ="osd" ; -static const char *osd_version_string ="open-osd 0.2.0" ; +static const char *osd_version_string ="open-osd 0.2.1" ;MODULE_AUTHOR ("Boaz Harrosh <[email protected]>" );MODULE_DESCRIPTION ("open-osd Upper-Layer-Driver osd.ko" );
Greg KH
maintainerPATCH 44/95 viafb: select HW scaling on VX900 for IGA2
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Florian Tobias Schandinat <[email protected]>
commit 050f0e02c8dc38b2b4f2df345ac760d22ca5c7ba upstream.
VX900 can do hardware scaling for both IGAs in contrast to previous hardware which could do it only for IGA2. This patch ensures that we set the parameter for IGA2 and not for IGA1. This fixes hardware scaling on VX900 until we have the infrastructure to support it for both IGAs.
--- drivers/video/via/hw.c | 1 + 1 file changed, 1 insertion(+)
drivers/video/via/hw.c +1 -0
@@ -1811,6 +1811,7 @@ static void hw_init(void) }/* probably this should go to the scaling code one day */ +via_write_reg_mask (VIACR ,0xFD ,0 ,0x80 );/* VX900 hw scale on IGA2 */ viafb_write_regx (scaling_parameters,ARRAY_SIZE (scaling_parameters));/* Fill VPIT Parameters */
Greg KH
maintainerPATCH 45/95 viafb: fix IGA1 modesetting on VX900
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Florian Tobias Schandinat <[email protected]>
commit e29206381a1436e0f47c0f5b9a23159a03c57715 upstream.
Even if the documentation calls this bit "Reserved" it has to be set to 0 for correct modesetting on IGA1.
--- drivers/video/via/hw.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/video/via/hw.c +3 -0
@@ -1810,6 +1810,9 @@ static void hw_init(void)break ; } +/* magic required on VX900 for correct modesetting on IGA1 */ +via_write_reg_mask (VIACR ,0x45 ,0x00 ,0x01 ); +/* probably this should go to the scaling code one day */ via_write_reg_mask (VIACR ,0xFD ,0 ,0x80 );/* VX900 hw scale on IGA2 */ viafb_write_regx (scaling_parameters,ARRAY_SIZE (scaling_parameters));
Greg KH
maintainerPATCH 46/95 ASoC: dapm: Check for bias level when powering down
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mark Brown <[email protected]>
commit 7679e42ec833ed70aa34790a5f39dcb7e5bda4fe upstream.
Recent enhancements in the bias management means that we might not be in standby when the CODEC is idle and can have active widgets without being in full power mode but the shutdown functionality assumes these things. Add checks for the bias level at each stage so that we don't do transitions other than the ON->PREPARE->STANDBY->OFF ones that the drivers are expecting.
--- sound/soc/soc-dapm.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
sound/soc/soc-dapm.c +9 -3
@@ -2982,9 +2982,13 @@ static void soc_dapm_shutdown_codec(stru* standby. */ if (powerdown) { -snd_soc_dapm_set_bias_level (dapm,SND_SOC_BIAS_PREPARE ); +if (dapm->bias_level ==SND_SOC_BIAS_ON ) +snd_soc_dapm_set_bias_level (dapm, +SND_SOC_BIAS_PREPARE );dapm_seq_run (dapm, &down_list,0 , false); -snd_soc_dapm_set_bias_level (dapm,SND_SOC_BIAS_STANDBY ); +if (dapm->bias_level ==SND_SOC_BIAS_PREPARE ) +snd_soc_dapm_set_bias_level (dapm, +SND_SOC_BIAS_STANDBY ); } }
@@ -2997,7 +3001,9 @@ void snd_soc_dapm_shutdown(struct snd_solist_for_each_entry (codec, &card->codec_dev_list, list) {soc_dapm_shutdown_codec (&codec->dapm); -snd_soc_dapm_set_bias_level (&codec->dapm,SND_SOC_BIAS_OFF ); +if (codec->dapm.bias_level ==SND_SOC_BIAS_STANDBY ) +snd_soc_dapm_set_bias_level (&codec->dapm, +SND_SOC_BIAS_OFF ); } }
Greg KH
maintainerPATCH 47/95 ASoC: i.MX SSI: Fix DSP_A format.
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Javier Martin <[email protected]>
commit 5ed80a75b248bfaf840ea6b38f941edcf6ee7dc7 upstream.
According to i.MX27 Reference Manual (p 1593) TXBIT0 bit selects whether the most significant or the less significant part of the data word written to the FIFO is transmitted.
As DSP_A is the same as DSP_B with a data offset of 1 bit, it doesn't make any sense to remove TXBIT0 bit here.
--- sound/soc/imx/imx-ssi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/imx/imx-ssi.c +1 -1
@@ -112,7 +112,7 @@ static int imx_ssi_set_dai_fmt(struct snbreak ;case SND_SOC_DAIFMT_DSP_A :/* data on rising edge of bclk, frame high 1clk before data */ - strcr |=SSI_STCR_TFSL |SSI_STCR_TEFS ; + strcr |=SSI_STCR_TFSL |SSI_STCR_TXBIT0 |SSI_STCR_TEFS ;break ; }
Greg KH
maintainerPATCH 48/95 bsg: fix sysfs link remove warning
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stanislaw Gruszka <[email protected]>
commit 37b40adf2d1b4a5e51323be73ccf8ddcf3f15dd3 upstream.
We create "bsg" link if q->kobj.sd is not NULL, so remove it only when the same condition is true.
Fixes:
WARNING: at fs/sysfs/inode.c:323 sysfs_hash_and_remove+0x2b/0x77() sysfs: can not remove 'bsg', no directory Call Trace: [<c0429683>] warn_slowpath_common+0x6a/0x7f [<c0537a68>] ? sysfs_hash_and_remove+0x2b/0x77 [<c042970b>] warn_slowpath_fmt+0x2b/0x2f [<c0537a68>] sysfs_hash_and_remove+0x2b/0x77 [<c053969a>] sysfs_remove_link+0x20/0x23 [<c05d88f1>] bsg_unregister_queue+0x40/0x6d [<c0692263>] __scsi_remove_device+0x31/0x9d [<c069149f>] scsi_forget_host+0x41/0x52 [<c0689fa9>] scsi_remove_host+0x71/0xe0 [<f7de5945>] quiesce_and_remove_host+0x51/0x83 [usb_storage] [<f7de5a1e>] usb_stor_disconnect+0x18/0x22 [usb_storage] [<c06c29de>] usb_unbind_interface+0x4e/0x109 [<c067a80f>] __device_release_driver+0x6b/0xa6 [<c067a861>] device_release_driver+0x17/0x22 [<c067a46a>] bus_remove_device+0xd6/0xe6 [<c06785e2>] device_del+0xf2/0x137 [<c06c101f>] usb_disable_device+0x94/0x1a0
--- block/bsg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
block/bsg.c +2 -1
@@ -985,7 +985,8 @@ void bsg_unregister_queue(struct requestmutex_lock (&bsg_mutex);idr_remove (&bsg_minor_idr, bcd->minor); -sysfs_remove_link (&q->kobj,"bsg" ); +if (q->kobj.sd) +sysfs_remove_link (&q->kobj,"bsg" );device_unregister (bcd->class_dev); bcd->class_dev =NULL ;kref_put (&bcd->ref, bsg_kref_release_function);
Greg KH
maintainerPATCH 49/95 avr32: select generic atomic64_t support
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Fabio Baltieri <[email protected]>
commit 31e0017e6f6fb5cfdfaf932c1f98c9bef8d57688 upstream.
Enable use of the generic atomic64 implementation on AVR32 platforms. Without this the kernel fails to build as the architecture does not provide its version.
--- arch/avr32/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/avr32/Kconfig +1 -0
@@ -8,6 +8,7 @@ config AVR32 select HAVE_KPROBES select HAVE_GENERIC_HARDIRQS select GENERIC_IRQ_PROBE + select GENERIC_ATOMIC64 select HARDIRQS_SW_RESEND select GENERIC_IRQ_SHOW select ARCH_HAVE_NMI_SAFE_CMPXCHG
Greg KH
maintainerPATCH 50/95 ACPI / PM: Do not save/restore NVS on Asus K54C/K54HR
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Keng-Yu Lin <[email protected]>
commit 5a50a7c32d630d6cdb13d69afabb0cc81b2f379c upstream.
The models do not resume correctly without acpi_sleep=nonvs.
--- drivers/acpi/sleep.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/acpi/sleep.c +16 -0
@@ -476,6 +476,22 @@ static struct dmi_system_id __initdata a DMI_MATCH(DMI_PRODUCT_NAME, "VGN-FW520F"), }, }, + { + .callback = init_nvs_nosave, + .ident = "Asus K54C", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"ASUSTeK Computer Inc." ), + DMI_MATCH(DMI_PRODUCT_NAME, "K54C"), + }, + }, + { + .callback = init_nvs_nosave, + .ident = "Asus K54HR", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"ASUSTeK Computer Inc." ), + DMI_MATCH(DMI_PRODUCT_NAME, "K54HR"), + }, + }, {}, };#endif /* CONFIG_SUSPEND */
Greg KH
maintainerPATCH 51/95 rtl8192cu: Add new device IDs
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Larry Finger <[email protected]>
commit 6cddafab54e9a17b2efefe982547865955a5ff3a upstream.
The latest vendor (non-mac80211) driver of 9/22/2011 shows some new device IDs for rtl8192cu. In addition, some typos in the table are fixed and one duplicate is removed.
--- drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 36 ++++++++++++++++++++++++---- 1 file changed, 32 insertions(+), 4 deletions(-)
drivers/net/wireless/rtlwifi/rtl8192cu/sw.c +32 -4
@@ -275,6 +275,8 @@ static struct usb_device_id rtl8192c_usb {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8191, rtl92cu_hal_cfg)},/****** 8188CU ********/ +/* RTL8188CTV */ + {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x018a, rtl92cu_hal_cfg)},/* 8188CE-VAU USB minCard */ {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8170, rtl92cu_hal_cfg)},/* 8188cu 1*1 dongle */
@@ -291,14 +293,14 @@ static struct usb_device_id rtl8192c_usb {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x817e, rtl92cu_hal_cfg)},/* 8188RU in Alfa AWUS036NHR */ {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x817f, rtl92cu_hal_cfg)}, +/* RTL8188CUS-VL */ + {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x818a, rtl92cu_hal_cfg)},/* 8188 Combo for BC4 */ {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8754, rtl92cu_hal_cfg)},/****** 8192CU ********/ -/* 8191cu 1*2 */ - {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8177, rtl92cu_hal_cfg)},/* 8192cu 2*2 */ - {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x817b, rtl92cu_hal_cfg)}, + {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8178, rtl92cu_hal_cfg)},/* 8192CE-VAU USB minCard */ {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x817c, rtl92cu_hal_cfg)},
@@ -309,13 +311,17 @@ static struct usb_device_id rtl8192c_usb {RTL_USB_DEVICE(0x07b8, 0x8188, rtl92cu_hal_cfg)}, /*Abocom - Abocom*/ {RTL_USB_DEVICE(0x07b8, 0x8189, rtl92cu_hal_cfg)}, /*Funai - Abocom*/ {RTL_USB_DEVICE(0x0846, 0x9041, rtl92cu_hal_cfg)}, /*NetGear WNA1000M*/ - {RTL_USB_DEVICE(0x0Df6, 0x0052, rtl92cu_hal_cfg)}, /*Sitecom - Edimax*/ + {RTL_USB_DEVICE(0x0df6, 0x0052, rtl92cu_hal_cfg)}, /*Sitecom - Edimax*/ + {RTL_USB_DEVICE(0x0df6, 0x005c, rtl92cu_hal_cfg)}, /*Sitecom - Edimax*/ {RTL_USB_DEVICE(0x0eb0, 0x9071, rtl92cu_hal_cfg)}, /*NO Brand - Etop*//* HP - Lite-On ,8188CUS Slim Combo */ {RTL_USB_DEVICE(0x103c, 0x1629, rtl92cu_hal_cfg)}, {RTL_USB_DEVICE(0x13d3, 0x3357, rtl92cu_hal_cfg)}, /* AzureWave */ {RTL_USB_DEVICE(0x2001, 0x3308, rtl92cu_hal_cfg)}, /*D-Link - Alpha*/ + {RTL_USB_DEVICE(0x2019, 0x4902, rtl92cu_hal_cfg)}, /*Planex - Etop*/ {RTL_USB_DEVICE(0x2019, 0xab2a, rtl92cu_hal_cfg)}, /*Planex - Abocom*/ +/*SW-WF02-AD15 -Abocom*/ + {RTL_USB_DEVICE(0x2019, 0xab2e, rtl92cu_hal_cfg)}, {RTL_USB_DEVICE(0x2019, 0xed17, rtl92cu_hal_cfg)}, /*PCI - Edimax*/ {RTL_USB_DEVICE(0x20f4, 0x648b, rtl92cu_hal_cfg)}, /*TRENDnet - Cameo*/ {RTL_USB_DEVICE(0x7392, 0x7811, rtl92cu_hal_cfg)}, /*Edimax - Edimax*/
@@ -326,14 +332,36 @@ static struct usb_device_id rtl8192c_usb {RTL_USB_DEVICE(0x4855, 0x0091, rtl92cu_hal_cfg)}, /* NetweeN-Feixun */ {RTL_USB_DEVICE(0x9846, 0x9041, rtl92cu_hal_cfg)}, /* Netgear Cameo */ +/****** 8188 RU ********/ +/* Netcore */ + {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x317f, rtl92cu_hal_cfg)}, + +/****** 8188CUS Slim Solo********/ + {RTL_USB_DEVICE(0x04f2, 0xaff7, rtl92cu_hal_cfg)}, /*Xavi*/ + {RTL_USB_DEVICE(0x04f2, 0xaff9, rtl92cu_hal_cfg)}, /*Xavi*/ + {RTL_USB_DEVICE(0x04f2, 0xaffa, rtl92cu_hal_cfg)}, /*Xavi*/ + +/****** 8188CUS Slim Combo ********/ + {RTL_USB_DEVICE(0x04f2, 0xaff8, rtl92cu_hal_cfg)}, /*Xavi*/ + {RTL_USB_DEVICE(0x04f2, 0xaffb, rtl92cu_hal_cfg)}, /*Xavi*/ + {RTL_USB_DEVICE(0x04f2, 0xaffc, rtl92cu_hal_cfg)}, /*Xavi*/ + {RTL_USB_DEVICE(0x2019, 0x1201, rtl92cu_hal_cfg)}, /*Planex-Vencer*/ +/****** 8192CU ********/ + {RTL_USB_DEVICE(0x050d, 0x2102, rtl92cu_hal_cfg)}, /*Belcom-Sercomm*/ + {RTL_USB_DEVICE(0x050d, 0x2103, rtl92cu_hal_cfg)}, /*Belcom-Edimax*/ {RTL_USB_DEVICE(0x0586, 0x341f, rtl92cu_hal_cfg)}, /*Zyxel -Abocom*/ {RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)}, /*ATKK-Gemtek*/ {RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai -Abocom*/ + {RTL_USB_DEVICE(0x0846, 0x9021, rtl92cu_hal_cfg)}, /*Netgear-Sercomm*/ + {RTL_USB_DEVICE(0x0b05, 0x17ab, rtl92cu_hal_cfg)}, /*ASUS-Edimax*/ + {RTL_USB_DEVICE(0x0df6, 0x0061, rtl92cu_hal_cfg)}, /*Sitecom-Edimax*/ + {RTL_USB_DEVICE(0x0e66, 0x0019, rtl92cu_hal_cfg)}, /*Hawking-Edimax*/ {RTL_USB_DEVICE(0x2001, 0x3307, rtl92cu_hal_cfg)}, /*D-Link-Cameo*/ {RTL_USB_DEVICE(0x2001, 0x3309, rtl92cu_hal_cfg)}, /*D-Link-Alpha*/ {RTL_USB_DEVICE(0x2001, 0x330a, rtl92cu_hal_cfg)}, /*D-Link-Alpha*/ {RTL_USB_DEVICE(0x2019, 0xab2b, rtl92cu_hal_cfg)}, /*Planex -Abocom*/ + {RTL_USB_DEVICE(0x20f4, 0x624d, rtl92cu_hal_cfg)}, /*TRENDNet*/ {RTL_USB_DEVICE(0x7392, 0x7822, rtl92cu_hal_cfg)}, /*Edimax -Edimax*/ {} };
Greg KH
maintainerPATCH 52/95 drm/i915: gen7: implement rczunit workaround
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eugeni Dodonov <[email protected]>
commit eae66b50c760233fad526edf4a0d327be17a055d upstream.
This is yet another workaround related to clock gating which we need on Ivy Bridge.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44610
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_display.c | 5 +++++ 2 files changed, 6 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -3476,6 +3476,7 @@#define GT_FIFO_NUM_RESERVED_ENTRIES 20#define GEN6_UCGCTL2 0x9404 +# define GEN6_RCZUNIT_CLOCK_GATE_DISABLE (1 << 13)# define GEN6_RCPBUNIT_CLOCK_GATE_DISABLE (1 << 12)# define GEN6_RCCUNIT_CLOCK_GATE_DISABLE (1 << 11)
drivers/gpu/drm/i915/intel_display.c +5 -0
@@ -8248,6 +8248,11 @@ static void ivybridge_init_clock_gating(I915_WRITE (WM2_LP_ILK ,0 );I915_WRITE (WM1_LP_ILK ,0 ); +/* According to the spec, bit 13 (RCZUNIT) must be set on IVB. +* This implements the WaDisableRCZUnitClockGating workaround. +*/ +I915_WRITE (GEN6_UCGCTL2 ,GEN6_RCZUNIT_CLOCK_GATE_DISABLE ); +I915_WRITE (ILK_DSPCLK_GATE ,IVB_VRHUNIT_CLK_GATE );for_each_pipe (pipe) {
Greg KH
maintainerPATCH 53/95 drm/i915: gen7: Implement an L3 caching workaround.
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eugeni Dodonov <[email protected]>
commit e4e0c058a19c41150d12ad2d3023b3cf09c5de67 upstream.
This adds two cache-related workarounds for Ivy Bridge which can lead to 3D ring hangs and corruptions.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44610
--- drivers/gpu/drm/i915/i915_reg.h | 7 +++++++ drivers/gpu/drm/i915/intel_display.c | 6 ++++++ 2 files changed, 13 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +7 -0
@@ -2886,6 +2886,13 @@#define DISP_TILE_SURFACE_SWIZZLING (1<<13)#define DISP_FBC_WM_DIS (1<<15) +/* GEN7 chicken */ +#define GEN7_L3CNTLREG1 0xB01C +#define GEN7_WA_FOR_GEN7_L3_CONTROL 0x3C4FFF8C + +#define GEN7_L3_CHICKEN_MODE_REGISTER 0xB030 +#define GEN7_WA_L3_CHICKEN_MODE 0x20000000 +/* PCH */ /* south display engine interrupt */
drivers/gpu/drm/i915/intel_display.c +6 -0
@@ -8255,6 +8255,12 @@ static void ivybridge_init_clock_gating(I915_WRITE (ILK_DSPCLK_GATE ,IVB_VRHUNIT_CLK_GATE ); +/* WaApplyL3ControlAndL3ChickenMode requires those two on Ivy Bridge */ +I915_WRITE (GEN7_L3CNTLREG1 , +GEN7_WA_FOR_GEN7_L3_CONTROL ); +I915_WRITE (GEN7_L3_CHICKEN_MODE_REGISTER , +GEN7_WA_L3_CHICKEN_MODE ); +for_each_pipe (pipe) { I915_WRITE(DSPCNTR(pipe), I915_READ(DSPCNTR(pipe)) |
Greg KH
maintainerPATCH 54/95 drm/i915: gen7: work around a system hang on IVB
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eugeni Dodonov <[email protected]>
commit db099c8f963fe656108e0a068274c5580a17f69b upstream.
This adds the workaround for WaCatErrorRejectionIssue which could result in a system hang.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44610
--- drivers/gpu/drm/i915/i915_reg.h | 4 ++++ drivers/gpu/drm/i915/intel_display.c | 5 +++++ 2 files changed, 9 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +4 -0
@@ -2893,6 +2893,10 @@#define GEN7_L3_CHICKEN_MODE_REGISTER 0xB030#define GEN7_WA_L3_CHICKEN_MODE 0x20000000 +/* WaCatErrorRejectionIssue */ +#define GEN7_SQ_CHICKEN_MBCUNIT_CONFIG 0x9030 +#define GEN7_SQ_CHICKEN_MBCUNIT_SQINTMOB (1<<11) +/* PCH */ /* south display engine interrupt */
drivers/gpu/drm/i915/intel_display.c +5 -0
@@ -8261,6 +8261,11 @@ static void ivybridge_init_clock_gating(I915_WRITE (GEN7_L3_CHICKEN_MODE_REGISTER ,GEN7_WA_L3_CHICKEN_MODE ); +/* This is required by WaCatErrorRejectionIssue */ +I915_WRITE (GEN7_SQ_CHICKEN_MBCUNIT_CONFIG , +I915_READ (GEN7_SQ_CHICKEN_MBCUNIT_CONFIG ) | +GEN7_SQ_CHICKEN_MBCUNIT_SQINTMOB ); +for_each_pipe (pipe) { I915_WRITE(DSPCNTR(pipe), I915_READ(DSPCNTR(pipe)) |
Greg KH
maintainerPATCH 55/95 drm/i915: gen7: Disable the RHWO optimization as it can cause GPU hangs.
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kenneth Graunke <[email protected]>
commit d71de14ddf423ccc9a2e3f7e37553c99ead20d7c upstream.
The BSpec Workarounds page states that bits 10 and 26 must be set to avoid 3D ring hangs.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44610
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_display.c | 4 ++++ 2 files changed, 7 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -2887,6 +2887,9 @@#define DISP_FBC_WM_DIS (1<<15)/* GEN7 chicken */ +#define GEN7_COMMON_SLICE_CHICKEN1 0x7010 +# define GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC ((1<<10) | (1<<26)) +#define GEN7_L3CNTLREG1 0xB01C#define GEN7_WA_FOR_GEN7_L3_CONTROL 0x3C4FFF8C
drivers/gpu/drm/i915/intel_display.c +4 -0
@@ -8255,6 +8255,10 @@ static void ivybridge_init_clock_gating(I915_WRITE (ILK_DSPCLK_GATE ,IVB_VRHUNIT_CLK_GATE ); +/* Apply the WaDisableRHWOOptimizationForRenderHang workaround. */ +I915_WRITE (GEN7_COMMON_SLICE_CHICKEN1 , +GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC ); +/* WaApplyL3ControlAndL3ChickenMode requires those two on Ivy Bridge */ I915_WRITE (GEN7_L3CNTLREG1 ,GEN7_WA_FOR_GEN7_L3_CONTROL );
Greg KH
maintainerPATCH 56/95 drm/i915: fix ELD writing for SandyBridge
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Wu Fengguang <[email protected]>
commit b3f33cbf7ace8fc149993ee35e0d0fd57f41d6d8 upstream.
SandyBridge should be using the same register addresses as IvyBridge.
--- drivers/gpu/drm/i915/intel_display.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/intel_display.c +5 -5
@@ -5876,14 +5876,14 @@ static void ironlake_write_eld(struct drint aud_cntl_st;int aud_cntrl_st2; -if (IS_IVYBRIDGE (connector->dev)) { - hdmiw_hdmiedid =GEN7_HDMIW_HDMIEDID_A ; - aud_cntl_st =GEN7_AUD_CNTRL_ST_A ; - aud_cntrl_st2 =GEN7_AUD_CNTRL_ST2 ; - }else { +if (HAS_PCH_IBX (connector->dev)) { hdmiw_hdmiedid =GEN5_HDMIW_HDMIEDID_A ; aud_cntl_st =GEN5_AUD_CNTL_ST_A ; aud_cntrl_st2 =GEN5_AUD_CNTL_ST2 ; + }else { + hdmiw_hdmiedid =GEN7_HDMIW_HDMIEDID_A ; + aud_cntl_st =GEN7_AUD_CNTRL_ST_A ; + aud_cntrl_st2 =GEN7_AUD_CNTRL_ST2 ; } i =to_intel_crtc (crtc)->pipe;
Greg KH
maintainerPATCH 57/95 ARM: orion: Fix USB phy for orion5x.
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andrew Lunn <[email protected]>
commit 72053353583230952c4b187e110e9da00dfc3afb upstream.
The patch "ARM: orion: Consolidate USB platform setup code.", commit 4fcd3f374a928081d391cd9a570afe3b2c692fdc broke USB on TS-7800 and other orion5x boards, because the wrong type of PHY was being passed to the EHCI driver in the platform data. Orion5x needs EHCI_PHY_ORION and all the others want EHCI_PHY_NA.
Allow the mach- code to tell the generic plat-orion code which USB PHY enum to place into the platform data.
Version 2: Rebase to v3.3-rc2.
--- arch/arm/mach-dove/common.c | 3 ++- arch/arm/mach-kirkwood/common.c | 3 ++- arch/arm/mach-mv78xx0/common.c | 3 ++- arch/arm/mach-orion5x/common.c | 4 +++- arch/arm/plat-orion/common.c | 9 ++++----- arch/arm/plat-orion/include/plat/common.h | 3 ++- 6 files changed, 15 insertions(+), 10 deletions(-)
arch/arm/mach-dove/common.c +2 -1
@@ -29,6 +29,7 @@#include <asm/mach/arch.h> #include <linux/irq.h> #include <plat/time.h> +#include <plat/ehci-orion.h> #include <plat/common.h> #include "common.h"
@@ -72,7 +73,7 @@ void __init dove_map_io(void)void __init dove_ehci0_init (void ) {orion_ehci_init (&dove_mbus_dram_info, -DOVE_USB0_PHYS_BASE ,IRQ_DOVE_USB0 ); +DOVE_USB0_PHYS_BASE ,IRQ_DOVE_USB0 ,EHCI_PHY_NA ); }/*****************************************************************************
arch/arm/mach-kirkwood/common.c +2 -1
@@ -28,6 +28,7 @@#include <plat/cache-feroceon-l2.h> #include <plat/mvsdio.h> #include <plat/orion_nand.h> +#include <plat/ehci-orion.h> #include <plat/common.h> #include <plat/time.h> #include "common.h"
@@ -74,7 +75,7 @@ void __init kirkwood_ehci_init(void) { kirkwood_clk_ctrl |=CGC_USB0 ;orion_ehci_init (&kirkwood_mbus_dram_info, -USB_PHYS_BASE ,IRQ_KIRKWOOD_USB ); +USB_PHYS_BASE ,IRQ_KIRKWOOD_USB ,EHCI_PHY_NA ); }
arch/arm/mach-mv78xx0/common.c +2 -1
@@ -20,6 +20,7 @@#include <mach/mv78xx0.h> #include <mach/bridge-regs.h> #include <plat/cache-feroceon-l2.h> +#include <plat/ehci-orion.h> #include <plat/orion_nand.h> #include <plat/time.h> #include <plat/common.h>
@@ -170,7 +171,7 @@ void __init mv78xx0_map_io(void)void __init mv78xx0_ehci0_init (void ) {orion_ehci_init (&mv78xx0_mbus_dram_info, -USB0_PHYS_BASE ,IRQ_MV78XX0_USB_0 ); +USB0_PHYS_BASE ,IRQ_MV78XX0_USB_0 ,EHCI_PHY_NA ); }
arch/arm/mach-orion5x/common.c +3 -1
@@ -29,6 +29,7 @@#include <mach/hardware.h> #include <mach/orion5x.h> #include <plat/orion_nand.h> +#include <plat/ehci-orion.h> #include <plat/time.h> #include <plat/common.h> #include "common.h"
@@ -72,7 +73,8 @@ void __init orion5x_map_io(void)void __init orion5x_ehci0_init (void ) {orion_ehci_init (&orion5x_mbus_dram_info, -ORION5X_USB0_PHYS_BASE ,IRQ_ORION5X_USB0_CTRL ); +ORION5X_USB0_PHYS_BASE ,IRQ_ORION5X_USB0_CTRL , +EHCI_PHY_ORION ); }
arch/arm/plat-orion/common.c +4 -5
@@ -806,10 +806,7 @@ void __init orion_xor1_init(unsigned lon/***************************************************************************** * EHCI ****************************************************************************/ -static struct orion_ehci_data orion_ehci_data = { - .phy_version =EHCI_PHY_NA , -}; - +static struct orion_ehci_data orion_ehci_data;static u64 ehci_dmamask =DMA_BIT_MASK (32 );
@@ -830,9 +827,11 @@ static struct platform_device orion_ehcivoid __init orion_ehci_init (struct mbus_dram_target_info *mbus_dram_info,unsigned long mapbase, -unsigned long irq) +unsigned long irq, +enum orion_ehci_phy_ver phy_version) { orion_ehci_data.dram = mbus_dram_info; + orion_ehci_data.phy_version = phy_version;fill_resources (&orion_ehci, orion_ehci_resources, mapbase,SZ_4K -1 , irq);
arch/arm/plat-orion/include/plat/common.h +2 -1
@@ -95,7 +95,8 @@ void __init orion_xor1_init(unsigned lonvoid __init orion_ehci_init (struct mbus_dram_target_info *mbus_dram_info,unsigned long mapbase, -unsigned long irq); +unsigned long irq, +enum orion_ehci_phy_ver phy_version); void __init orion_ehci_1_init(struct mbus_dram_target_info *mbus_dram_info, unsigned long mapbase,
Greg KH
maintainerPATCH 58/95 ARM: orion: Fix Orion5x GPIO regression from MPP cleanup
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andrew Lunn <[email protected]>
commit b06540371063f0f07aafc1d1ac5e974da85c973c upstream.
Patchset "ARM: orion: Refactor the MPP code common in the orion platform" broke at least Orion5x based platforms. These platforms have pins configured as GPIO when the selector is not 0x0. However the common code assumes the selector is always 0x0 for a GPIO lines. It then ignores the GPIO bits in the MPP definitions, resulting in that Orion5x machines cannot correctly configure there GPIO lines.
The Fix removes the assumption that the selector is always 0x0. In order that none GPIO configurations are correctly blocked, Kirkwood and mv78xx0 MPP definitions are corrected to only set the GPIO bits for GPIO configurations.
This third version, which does not contain any whitespace changes, and is rebased on v3.3-rc2.
--- arch/arm/mach-kirkwood/mpp.h | 320 +++++++++++++++++++++---------------------- arch/arm/mach-mv78xx0/mpp.h | 226 +++++++++++++++--------------- arch/arm/plat-orion/mpp.c | 3 3 files changed, 274 insertions(+), 275 deletions(-)
arch/arm/mach-kirkwood/mpp.h +160 -160
@@ -31,313 +31,313 @@#define MPP_F6282_MASK MPP( 0, 0x0, 0, 0, 0, 0, 0, 0, 1 )#define MPP0_GPIO MPP( 0, 0x0, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP0_NF_IO2 MPP( 0, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP0_SPI_SCn MPP( 0, 0x2, 0, 1, 1, 1, 1, 1, 1 ) +#define MPP0_NF_IO2 MPP( 0, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP0_SPI_SCn MPP( 0, 0x2, 0, 0, 1, 1, 1, 1, 1 )#define MPP1_GPO MPP( 1, 0x0, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP1_NF_IO3 MPP( 1, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP1_SPI_MOSI MPP( 1, 0x2, 0, 1, 1, 1, 1, 1, 1 ) +#define MPP1_NF_IO3 MPP( 1, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP1_SPI_MOSI MPP( 1, 0x2, 0, 0, 1, 1, 1, 1, 1 )#define MPP2_GPO MPP( 2, 0x0, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP2_NF_IO4 MPP( 2, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP2_SPI_SCK MPP( 2, 0x2, 0, 1, 1, 1, 1, 1, 1 ) +#define MPP2_NF_IO4 MPP( 2, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP2_SPI_SCK MPP( 2, 0x2, 0, 0, 1, 1, 1, 1, 1 )#define MPP3_GPO MPP( 3, 0x0, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP3_NF_IO5 MPP( 3, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP3_SPI_MISO MPP( 3, 0x2, 1, 0, 1, 1, 1, 1, 1 ) +#define MPP3_NF_IO5 MPP( 3, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP3_SPI_MISO MPP( 3, 0x2, 0, 0, 1, 1, 1, 1, 1 )#define MPP4_GPIO MPP( 4, 0x0, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP4_NF_IO6 MPP( 4, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP4_UART0_RXD MPP( 4, 0x2, 1, 0, 1, 1, 1, 1, 1 ) -#define MPP4_SATA1_ACTn MPP( 4, 0x5, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP4_NF_IO6 MPP( 4, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP4_UART0_RXD MPP( 4, 0x2, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP4_SATA1_ACTn MPP( 4, 0x5, 0, 0, 0, 0, 1, 1, 1 )#define MPP4_LCD_VGA_HSYNC MPP( 4, 0xb, 0, 0, 0, 0, 0, 0, 1 ) -#define MPP4_PTP_CLK MPP( 4, 0xd, 1, 0, 1, 1, 1, 1, 0 ) +#define MPP4_PTP_CLK MPP( 4, 0xd, 0, 0, 1, 1, 1, 1, 0 )#define MPP5_GPO MPP( 5, 0x0, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP5_NF_IO7 MPP( 5, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP5_UART0_TXD MPP( 5, 0x2, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP5_PTP_TRIG_GEN MPP( 5, 0x4, 0, 1, 1, 1, 1, 1, 0 ) -#define MPP5_SATA0_ACTn MPP( 5, 0x5, 0, 1, 0, 1, 1, 1, 1 ) +#define MPP5_NF_IO7 MPP( 5, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP5_UART0_TXD MPP( 5, 0x2, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP5_PTP_TRIG_GEN MPP( 5, 0x4, 0, 0, 1, 1, 1, 1, 0 ) +#define MPP5_SATA0_ACTn MPP( 5, 0x5, 0, 0, 0, 1, 1, 1, 1 )#define MPP5_LCD_VGA_VSYNC MPP( 5, 0xb, 0, 0, 0, 0, 0, 0, 1 ) -#define MPP6_SYSRST_OUTn MPP( 6, 0x1, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP6_SPI_MOSI MPP( 6, 0x2, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP6_PTP_TRIG_GEN MPP( 6, 0x3, 0, 1, 1, 1, 1, 1, 0 ) +#define MPP6_SYSRST_OUTn MPP( 6, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP6_SPI_MOSI MPP( 6, 0x2, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP6_PTP_TRIG_GEN MPP( 6, 0x3, 0, 0, 1, 1, 1, 1, 0 )#define MPP7_GPO MPP( 7, 0x0, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP7_PEX_RST_OUTn MPP( 7, 0x1, 0, 1, 1, 1, 1, 1, 0 ) -#define MPP7_SPI_SCn MPP( 7, 0x2, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP7_PTP_TRIG_GEN MPP( 7, 0x3, 0, 1, 1, 1, 1, 1, 0 ) -#define MPP7_LCD_PWM MPP( 7, 0xb, 0, 1, 0, 0, 0, 0, 1 ) +#define MPP7_PEX_RST_OUTn MPP( 7, 0x1, 0, 0, 1, 1, 1, 1, 0 ) +#define MPP7_SPI_SCn MPP( 7, 0x2, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP7_PTP_TRIG_GEN MPP( 7, 0x3, 0, 0, 1, 1, 1, 1, 0 ) +#define MPP7_LCD_PWM MPP( 7, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP8_GPIO MPP( 8, 0x0, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP8_TW0_SDA MPP( 8, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP8_UART0_RTS MPP( 8, 0x2, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP8_UART1_RTS MPP( 8, 0x3, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP8_MII0_RXERR MPP( 8, 0x4, 1, 0, 0, 1, 1, 1, 1 ) -#define MPP8_SATA1_PRESENTn MPP( 8, 0x5, 0, 1, 0, 0, 1, 1, 1 ) -#define MPP8_PTP_CLK MPP( 8, 0xc, 1, 0, 1, 1, 1, 1, 0 ) -#define MPP8_MII0_COL MPP( 8, 0xd, 1, 0, 1, 1, 1, 1, 1 ) +#define MPP8_TW0_SDA MPP( 8, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP8_UART0_RTS MPP( 8, 0x2, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP8_UART1_RTS MPP( 8, 0x3, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP8_MII0_RXERR MPP( 8, 0x4, 0, 0, 0, 1, 1, 1, 1 ) +#define MPP8_SATA1_PRESENTn MPP( 8, 0x5, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP8_PTP_CLK MPP( 8, 0xc, 0, 0, 1, 1, 1, 1, 0 ) +#define MPP8_MII0_COL MPP( 8, 0xd, 0, 0, 1, 1, 1, 1, 1 )#define MPP9_GPIO MPP( 9, 0x0, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP9_TW0_SCK MPP( 9, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP9_UART0_CTS MPP( 9, 0x2, 1, 0, 1, 1, 1, 1, 1 ) -#define MPP9_UART1_CTS MPP( 9, 0x3, 1, 0, 1, 1, 1, 1, 1 ) -#define MPP9_SATA0_PRESENTn MPP( 9, 0x5, 0, 1, 0, 1, 1, 1, 1 ) -#define MPP9_PTP_EVENT_REQ MPP( 9, 0xc, 1, 0, 1, 1, 1, 1, 0 ) -#define MPP9_MII0_CRS MPP( 9, 0xd, 1, 0, 1, 1, 1, 1, 1 ) +#define MPP9_TW0_SCK MPP( 9, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP9_UART0_CTS MPP( 9, 0x2, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP9_UART1_CTS MPP( 9, 0x3, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP9_SATA0_PRESENTn MPP( 9, 0x5, 0, 0, 0, 1, 1, 1, 1 ) +#define MPP9_PTP_EVENT_REQ MPP( 9, 0xc, 0, 0, 1, 1, 1, 1, 0 ) +#define MPP9_MII0_CRS MPP( 9, 0xd, 0, 0, 1, 1, 1, 1, 1 )#define MPP10_GPO MPP( 10, 0x0, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP10_SPI_SCK MPP( 10, 0x2, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP10_UART0_TXD MPP( 10, 0X3, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP10_SATA1_ACTn MPP( 10, 0x5, 0, 1, 0, 0, 1, 1, 1 ) -#define MPP10_PTP_TRIG_GEN MPP( 10, 0xc, 0, 1, 1, 1, 1, 1, 0 ) +#define MPP10_SPI_SCK MPP( 10, 0x2, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP10_UART0_TXD MPP( 10, 0X3, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP10_SATA1_ACTn MPP( 10, 0x5, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP10_PTP_TRIG_GEN MPP( 10, 0xc, 0, 0, 1, 1, 1, 1, 0 )#define MPP11_GPIO MPP( 11, 0x0, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP11_SPI_MISO MPP( 11, 0x2, 1, 0, 1, 1, 1, 1, 1 ) -#define MPP11_UART0_RXD MPP( 11, 0x3, 1, 0, 1, 1, 1, 1, 1 ) -#define MPP11_PTP_EVENT_REQ MPP( 11, 0x4, 1, 0, 1, 1, 1, 1, 0 ) -#define MPP11_PTP_TRIG_GEN MPP( 11, 0xc, 0, 1, 1, 1, 1, 1, 0 ) -#define MPP11_PTP_CLK MPP( 11, 0xd, 1, 0, 1, 1, 1, 1, 0 ) -#define MPP11_SATA0_ACTn MPP( 11, 0x5, 0, 1, 0, 1, 1, 1, 1 ) +#define MPP11_SPI_MISO MPP( 11, 0x2, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP11_UART0_RXD MPP( 11, 0x3, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP11_PTP_EVENT_REQ MPP( 11, 0x4, 0, 0, 1, 1, 1, 1, 0 ) +#define MPP11_PTP_TRIG_GEN MPP( 11, 0xc, 0, 0, 1, 1, 1, 1, 0 ) +#define MPP11_PTP_CLK MPP( 11, 0xd, 0, 0, 1, 1, 1, 1, 0 ) +#define MPP11_SATA0_ACTn MPP( 11, 0x5, 0, 0, 0, 1, 1, 1, 1 )#define MPP12_GPO MPP( 12, 0x0, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP12_SD_CLK MPP( 12, 0x1, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP12_AU_SPDIF0 MPP( 12, 0xa, 0, 1, 0, 0, 0, 0, 1 ) -#define MPP12_SPI_MOSI MPP( 12, 0xb, 0, 1, 0, 0, 0, 0, 1 ) -#define MPP12_TW1_SDA MPP( 12, 0xd, 1, 0, 0, 0, 0, 0, 1 ) +#define MPP12_SD_CLK MPP( 12, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP12_AU_SPDIF0 MPP( 12, 0xa, 0, 0, 0, 0, 0, 0, 1 ) +#define MPP12_SPI_MOSI MPP( 12, 0xb, 0, 0, 0, 0, 0, 0, 1 ) +#define MPP12_TW1_SDA MPP( 12, 0xd, 0, 0, 0, 0, 0, 0, 1 )#define MPP13_GPIO MPP( 13, 0x0, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP13_SD_CMD MPP( 13, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP13_UART1_TXD MPP( 13, 0x3, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP13_AU_SPDIFRMCLK MPP( 13, 0xa, 0, 1, 0, 0, 0, 0, 1 ) -#define MPP13_LCDPWM MPP( 13, 0xb, 0, 1, 0, 0, 0, 0, 1 ) +#define MPP13_SD_CMD MPP( 13, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP13_UART1_TXD MPP( 13, 0x3, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP13_AU_SPDIFRMCLK MPP( 13, 0xa, 0, 0, 0, 0, 0, 0, 1 ) +#define MPP13_LCDPWM MPP( 13, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP14_GPIO MPP( 14, 0x0, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP14_SD_D0 MPP( 14, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP14_UART1_RXD MPP( 14, 0x3, 1, 0, 1, 1, 1, 1, 1 ) -#define MPP14_SATA1_PRESENTn MPP( 14, 0x4, 0, 1, 0, 0, 1, 1, 1 ) -#define MPP14_AU_SPDIFI MPP( 14, 0xa, 1, 0, 0, 0, 0, 0, 1 ) -#define MPP14_AU_I2SDI MPP( 14, 0xb, 1, 0, 0, 0, 0, 0, 1 ) -#define MPP14_MII0_COL MPP( 14, 0xd, 1, 0, 1, 1, 1, 1, 1 ) +#define MPP14_SD_D0 MPP( 14, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP14_UART1_RXD MPP( 14, 0x3, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP14_SATA1_PRESENTn MPP( 14, 0x4, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP14_AU_SPDIFI MPP( 14, 0xa, 0, 0, 0, 0, 0, 0, 1 ) +#define MPP14_AU_I2SDI MPP( 14, 0xb, 0, 0, 0, 0, 0, 0, 1 ) +#define MPP14_MII0_COL MPP( 14, 0xd, 0, 0, 1, 1, 1, 1, 1 )#define MPP15_GPIO MPP( 15, 0x0, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP15_SD_D1 MPP( 15, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP15_UART0_RTS MPP( 15, 0x2, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP15_UART1_TXD MPP( 15, 0x3, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP15_SATA0_ACTn MPP( 15, 0x4, 0, 1, 0, 1, 1, 1, 1 ) -#define MPP15_SPI_CSn MPP( 15, 0xb, 0, 1, 0, 0, 0, 0, 1 ) +#define MPP15_SD_D1 MPP( 15, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP15_UART0_RTS MPP( 15, 0x2, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP15_UART1_TXD MPP( 15, 0x3, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP15_SATA0_ACTn MPP( 15, 0x4, 0, 0, 0, 1, 1, 1, 1 ) +#define MPP15_SPI_CSn MPP( 15, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP16_GPIO MPP( 16, 0x0, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP16_SD_D2 MPP( 16, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP16_UART0_CTS MPP( 16, 0x2, 1, 0, 1, 1, 1, 1, 1 ) -#define MPP16_UART1_RXD MPP( 16, 0x3, 1, 0, 1, 1, 1, 1, 1 ) -#define MPP16_SATA1_ACTn MPP( 16, 0x4, 0, 1, 0, 0, 1, 1, 1 ) -#define MPP16_LCD_EXT_REF_CLK MPP( 16, 0xb, 1, 0, 0, 0, 0, 0, 1 ) -#define MPP16_MII0_CRS MPP( 16, 0xd, 1, 0, 1, 1, 1, 1, 1 ) +#define MPP16_SD_D2 MPP( 16, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP16_UART0_CTS MPP( 16, 0x2, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP16_UART1_RXD MPP( 16, 0x3, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP16_SATA1_ACTn MPP( 16, 0x4, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP16_LCD_EXT_REF_CLK MPP( 16, 0xb, 0, 0, 0, 0, 0, 0, 1 ) +#define MPP16_MII0_CRS MPP( 16, 0xd, 0, 0, 1, 1, 1, 1, 1 )#define MPP17_GPIO MPP( 17, 0x0, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP17_SD_D3 MPP( 17, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP17_SATA0_PRESENTn MPP( 17, 0x4, 0, 1, 0, 1, 1, 1, 1 ) -#define MPP17_SATA1_ACTn MPP( 17, 0xa, 0, 1, 0, 0, 0, 0, 1 ) -#define MPP17_TW1_SCK MPP( 17, 0xd, 1, 1, 0, 0, 0, 0, 1 ) +#define MPP17_SD_D3 MPP( 17, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP17_SATA0_PRESENTn MPP( 17, 0x4, 0, 0, 0, 1, 1, 1, 1 ) +#define MPP17_SATA1_ACTn MPP( 17, 0xa, 0, 0, 0, 0, 0, 0, 1 ) +#define MPP17_TW1_SCK MPP( 17, 0xd, 0, 0, 0, 0, 0, 0, 1 )#define MPP18_GPO MPP( 18, 0x0, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP18_NF_IO0 MPP( 18, 0x1, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP18_PEX0_CLKREQ MPP( 18, 0x2, 0, 1, 0, 0, 0, 0, 1 ) +#define MPP18_NF_IO0 MPP( 18, 0x1, 0, 0, 1, 1, 1, 1, 1 ) +#define MPP18_PEX0_CLKREQ MPP( 18, 0x2, 0, 0, 0, 0, 0, 0, 1 )#define MPP19_GPO MPP( 19, 0x0, 0, 1, 1, 1, 1, 1, 1 ) -#define MPP19_NF_IO1 MPP( 19, 0x1, 1, 1, 1, 1, 1, 1, 1 ) +#define MPP19_NF_IO1 MPP( 19, 0x1, 0, 0, 1, 1, 1, 1, 1 )#define MPP20_GPIO MPP( 20, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP20_TSMP0 MPP( 20, 0x1, 1, 1, 0, 0, 1, 1, 1 ) -#define MPP20_TDM_CH0_TX_QL MPP( 20, 0x2, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP20_TSMP0 MPP( 20, 0x1, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP20_TDM_CH0_TX_QL MPP( 20, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP20_GE1_TXD0 MPP( 20, 0x3, 0, 0, 0, 1, 1, 1, 1 ) -#define MPP20_AU_SPDIFI MPP( 20, 0x4, 1, 0, 0, 0, 1, 1, 1 ) -#define MPP20_SATA1_ACTn MPP( 20, 0x5, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP20_AU_SPDIFI MPP( 20, 0x4, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP20_SATA1_ACTn MPP( 20, 0x5, 0, 0, 0, 0, 1, 1, 1 )#define MPP20_LCD_D0 MPP( 20, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP21_GPIO MPP( 21, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP21_TSMP1 MPP( 21, 0x1, 1, 1, 0, 0, 1, 1, 1 ) -#define MPP21_TDM_CH0_RX_QL MPP( 21, 0x2, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP21_TSMP1 MPP( 21, 0x1, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP21_TDM_CH0_RX_QL MPP( 21, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP21_GE1_TXD1 MPP( 21, 0x3, 0, 0, 0, 1, 1, 1, 1 ) -#define MPP21_AU_SPDIFO MPP( 21, 0x4, 0, 1, 0, 0, 1, 1, 1 ) -#define MPP21_SATA0_ACTn MPP( 21, 0x5, 0, 1, 0, 1, 1, 1, 1 ) +#define MPP21_AU_SPDIFO MPP( 21, 0x4, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP21_SATA0_ACTn MPP( 21, 0x5, 0, 0, 0, 1, 1, 1, 1 )#define MPP21_LCD_D1 MPP( 21, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP22_GPIO MPP( 22, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP22_TSMP2 MPP( 22, 0x1, 1, 1, 0, 0, 1, 1, 1 ) -#define MPP22_TDM_CH2_TX_QL MPP( 22, 0x2, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP22_TSMP2 MPP( 22, 0x1, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP22_TDM_CH2_TX_QL MPP( 22, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP22_GE1_TXD2 MPP( 22, 0x3, 0, 0, 0, 1, 1, 1, 1 ) -#define MPP22_AU_SPDIFRMKCLK MPP( 22, 0x4, 0, 1, 0, 0, 1, 1, 1 ) -#define MPP22_SATA1_PRESENTn MPP( 22, 0x5, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP22_AU_SPDIFRMKCLK MPP( 22, 0x4, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP22_SATA1_PRESENTn MPP( 22, 0x5, 0, 0, 0, 0, 1, 1, 1 )#define MPP22_LCD_D2 MPP( 22, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP23_GPIO MPP( 23, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP23_TSMP3 MPP( 23, 0x1, 1, 1, 0, 0, 1, 1, 1 ) -#define MPP23_TDM_CH2_RX_QL MPP( 23, 0x2, 1, 0, 0, 0, 1, 1, 1 ) +#define MPP23_TSMP3 MPP( 23, 0x1, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP23_TDM_CH2_RX_QL MPP( 23, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP23_GE1_TXD3 MPP( 23, 0x3, 0, 0, 0, 1, 1, 1, 1 ) -#define MPP23_AU_I2SBCLK MPP( 23, 0x4, 0, 1, 0, 0, 1, 1, 1 ) -#define MPP23_SATA0_PRESENTn MPP( 23, 0x5, 0, 1, 0, 1, 1, 1, 1 ) +#define MPP23_AU_I2SBCLK MPP( 23, 0x4, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP23_SATA0_PRESENTn MPP( 23, 0x5, 0, 0, 0, 1, 1, 1, 1 )#define MPP23_LCD_D3 MPP( 23, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP24_GPIO MPP( 24, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP24_TSMP4 MPP( 24, 0x1, 1, 1, 0, 0, 1, 1, 1 ) -#define MPP24_TDM_SPI_CS0 MPP( 24, 0x2, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP24_TSMP4 MPP( 24, 0x1, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP24_TDM_SPI_CS0 MPP( 24, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP24_GE1_RXD0 MPP( 24, 0x3, 0, 0, 0, 1, 1, 1, 1 ) -#define MPP24_AU_I2SDO MPP( 24, 0x4, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP24_AU_I2SDO MPP( 24, 0x4, 0, 0, 0, 0, 1, 1, 1 )#define MPP24_LCD_D4 MPP( 24, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP25_GPIO MPP( 25, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP25_TSMP5 MPP( 25, 0x1, 1, 1, 0, 0, 1, 1, 1 ) -#define MPP25_TDM_SPI_SCK MPP( 25, 0x2, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP25_TSMP5 MPP( 25, 0x1, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP25_TDM_SPI_SCK MPP( 25, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP25_GE1_RXD1 MPP( 25, 0x3, 0, 0, 0, 1, 1, 1, 1 ) -#define MPP25_AU_I2SLRCLK MPP( 25, 0x4, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP25_AU_I2SLRCLK MPP( 25, 0x4, 0, 0, 0, 0, 1, 1, 1 )#define MPP25_LCD_D5 MPP( 25, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP26_GPIO MPP( 26, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP26_TSMP6 MPP( 26, 0x1, 1, 1, 0, 0, 1, 1, 1 ) -#define MPP26_TDM_SPI_MISO MPP( 26, 0x2, 1, 0, 0, 0, 1, 1, 1 ) +#define MPP26_TSMP6 MPP( 26, 0x1, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP26_TDM_SPI_MISO MPP( 26, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP26_GE1_RXD2 MPP( 26, 0x3, 0, 0, 0, 1, 1, 1, 1 ) -#define MPP26_AU_I2SMCLK MPP( 26, 0x4, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP26_AU_I2SMCLK MPP( 26, 0x4, 0, 0, 0, 0, 1, 1, 1 )#define MPP26_LCD_D6 MPP( 26, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP27_GPIO MPP( 27, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP27_TSMP7 MPP( 27, 0x1, 1, 1, 0, 0, 1, 1, 1 ) -#define MPP27_TDM_SPI_MOSI MPP( 27, 0x2, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP27_TSMP7 MPP( 27, 0x1, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP27_TDM_SPI_MOSI MPP( 27, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP27_GE1_RXD3 MPP( 27, 0x3, 0, 0, 0, 1, 1, 1, 1 ) -#define MPP27_AU_I2SDI MPP( 27, 0x4, 1, 0, 0, 0, 1, 1, 1 ) +#define MPP27_AU_I2SDI MPP( 27, 0x4, 0, 0, 0, 0, 1, 1, 1 )#define MPP27_LCD_D7 MPP( 27, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP28_GPIO MPP( 28, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP28_TSMP8 MPP( 28, 0x1, 1, 1, 0, 0, 1, 1, 1 ) +#define MPP28_TSMP8 MPP( 28, 0x1, 0, 0, 0, 0, 1, 1, 1 )#define MPP28_TDM_CODEC_INTn MPP( 28, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP28_GE1_COL MPP( 28, 0x3, 0, 0, 0, 1, 1, 1, 1 ) -#define MPP28_AU_EXTCLK MPP( 28, 0x4, 1, 0, 0, 0, 1, 1, 1 ) +#define MPP28_AU_EXTCLK MPP( 28, 0x4, 0, 0, 0, 0, 1, 1, 1 )#define MPP28_LCD_D8 MPP( 28, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP29_GPIO MPP( 29, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP29_TSMP9 MPP( 29, 0x1, 1, 1, 0, 0, 1, 1, 1 ) +#define MPP29_TSMP9 MPP( 29, 0x1, 0, 0, 0, 0, 1, 1, 1 )#define MPP29_TDM_CODEC_RSTn MPP( 29, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP29_GE1_TCLK MPP( 29, 0x3, 0, 0, 0, 1, 1, 1, 1 )#define MPP29_LCD_D9 MPP( 29, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP30_GPIO MPP( 30, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP30_TSMP10 MPP( 30, 0x1, 1, 1, 0, 0, 1, 1, 1 ) -#define MPP30_TDM_PCLK MPP( 30, 0x2, 1, 1, 0, 0, 1, 1, 1 ) +#define MPP30_TSMP10 MPP( 30, 0x1, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP30_TDM_PCLK MPP( 30, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP30_GE1_RXCTL MPP( 30, 0x3, 0, 0, 0, 1, 1, 1, 1 )#define MPP30_LCD_D10 MPP( 30, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP31_GPIO MPP( 31, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP31_TSMP11 MPP( 31, 0x1, 1, 1, 0, 0, 1, 1, 1 ) -#define MPP31_TDM_FS MPP( 31, 0x2, 1, 1, 0, 0, 1, 1, 1 ) +#define MPP31_TSMP11 MPP( 31, 0x1, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP31_TDM_FS MPP( 31, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP31_GE1_RXCLK MPP( 31, 0x3, 0, 0, 0, 1, 1, 1, 1 )#define MPP31_LCD_D11 MPP( 31, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP32_GPIO MPP( 32, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP32_TSMP12 MPP( 32, 0x1, 1, 1, 0, 0, 1, 1, 1 ) -#define MPP32_TDM_DRX MPP( 32, 0x2, 1, 0, 0, 0, 1, 1, 1 ) +#define MPP32_TSMP12 MPP( 32, 0x1, 0, 0, 0, 0, 1, 1, 1 ) +#define MPP32_TDM_DRX MPP( 32, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP32_GE1_TCLKOUT MPP( 32, 0x3, 0, 0, 0, 1, 1, 1, 1 )#define MPP32_LCD_D12 MPP( 32, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP33_GPO MPP( 33, 0x0, 0, 1, 0, 1, 1, 1, 1 ) -#define MPP33_TDM_DTX MPP( 33, 0x2, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP33_TDM_DTX MPP( 33, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP33_GE1_TXCTL MPP( 33, 0x3, 0, 0, 0, 1, 1, 1, 1 )#define MPP33_LCD_D13 MPP( 33, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP34_GPIO MPP( 34, 0x0, 1, 1, 0, 1, 1, 1, 1 ) -#define MPP34_TDM_SPI_CS1 MPP( 34, 0x2, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP34_TDM_SPI_CS1 MPP( 34, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP34_GE1_TXEN MPP( 34, 0x3, 0, 0, 0, 1, 1, 1, 1 ) -#define MPP34_SATA1_ACTn MPP( 34, 0x5, 0, 1, 0, 0, 0, 1, 1 ) +#define MPP34_SATA1_ACTn MPP( 34, 0x5, 0, 0, 0, 0, 0, 1, 1 )#define MPP34_LCD_D14 MPP( 34, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP35_GPIO MPP( 35, 0x0, 1, 1, 1, 1, 1, 1, 1 ) -#define MPP35_TDM_CH0_TX_QL MPP( 35, 0x2, 0, 1, 0, 0, 1, 1, 1 ) +#define MPP35_TDM_CH0_TX_QL MPP( 35, 0x2, 0, 0, 0, 0, 1, 1, 1 )#define MPP35_GE1_RXERR MPP( 35, 0x3, 0, 0, 0, 1, 1, 1, 1 ) -#define MPP35_SATA0_ACTn MPP( 35, 0x5, 0, 1, 0, 1, 1, 1, 1 ) +#define MPP35_SATA0_ACTn MPP( 35, 0x5, 0, 0, 0, 1, 1, 1, 1 )#define MPP35_LCD_D15 MPP( 22, 0xb, 0, 0, 0, 0, 0, 0, 1 ) -#define MPP35_MII0_RXERR MPP( 35, 0xc, 1, 0, 1, 1, 1, 1, 1 ) +#define MPP35_MII0_RXERR MPP( 35, 0xc, 0, 0, 1, 1, 1, 1, 1 )#define MPP36_GPIO MPP( 36, 0x0, 1, 1, 1, 0, 0, 1, 1 ) -#define MPP36_TSMP0 MPP( 36, 0x1, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP36_TDM_SPI_CS1 MPP( 36, 0x2, 0, 1, 0, 0, 0, 1, 1 ) -#define MPP36_AU_SPDIFI MPP( 36, 0x4, 1, 0, 1, 0, 0, 1, 1 ) -#define MPP36_TW1_SDA MPP( 36, 0xb, 1, 1, 0, 0, 0, 0, 1 ) +#define MPP36_TSMP0 MPP( 36, 0x1, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP36_TDM_SPI_CS1 MPP( 36, 0x2, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP36_AU_SPDIFI MPP( 36, 0x4, 0, 0, 1, 0, 0, 1, 1 ) +#define MPP36_TW1_SDA MPP( 36, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP37_GPIO MPP( 37, 0x0, 1, 1, 1, 0, 0, 1, 1 ) -#define MPP37_TSMP1 MPP( 37, 0x1, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP37_TDM_CH2_TX_QL MPP( 37, 0x2, 0, 1, 0, 0, 0, 1, 1 ) -#define MPP37_AU_SPDIFO MPP( 37, 0x4, 0, 1, 1, 0, 0, 1, 1 ) -#define MPP37_TW1_SCK MPP( 37, 0xb, 1, 1, 0, 0, 0, 0, 1 ) +#define MPP37_TSMP1 MPP( 37, 0x1, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP37_TDM_CH2_TX_QL MPP( 37, 0x2, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP37_AU_SPDIFO MPP( 37, 0x4, 0, 0, 1, 0, 0, 1, 1 ) +#define MPP37_TW1_SCK MPP( 37, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP38_GPIO MPP( 38, 0x0, 1, 1, 1, 0, 0, 1, 1 ) -#define MPP38_TSMP2 MPP( 38, 0x1, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP38_TDM_CH2_RX_QL MPP( 38, 0x2, 0, 1, 0, 0, 0, 1, 1 ) -#define MPP38_AU_SPDIFRMLCLK MPP( 38, 0x4, 0, 1, 1, 0, 0, 1, 1 ) +#define MPP38_TSMP2 MPP( 38, 0x1, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP38_TDM_CH2_RX_QL MPP( 38, 0x2, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP38_AU_SPDIFRMLCLK MPP( 38, 0x4, 0, 0, 1, 0, 0, 1, 1 )#define MPP38_LCD_D18 MPP( 38, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP39_GPIO MPP( 39, 0x0, 1, 1, 1, 0, 0, 1, 1 ) -#define MPP39_TSMP3 MPP( 39, 0x1, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP39_TDM_SPI_CS0 MPP( 39, 0x2, 0, 1, 0, 0, 0, 1, 1 ) -#define MPP39_AU_I2SBCLK MPP( 39, 0x4, 0, 1, 1, 0, 0, 1, 1 ) +#define MPP39_TSMP3 MPP( 39, 0x1, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP39_TDM_SPI_CS0 MPP( 39, 0x2, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP39_AU_I2SBCLK MPP( 39, 0x4, 0, 0, 1, 0, 0, 1, 1 )#define MPP39_LCD_D19 MPP( 39, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP40_GPIO MPP( 40, 0x0, 1, 1, 1, 0, 0, 1, 1 ) -#define MPP40_TSMP4 MPP( 40, 0x1, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP40_TDM_SPI_SCK MPP( 40, 0x2, 0, 1, 0, 0, 0, 1, 1 ) -#define MPP40_AU_I2SDO MPP( 40, 0x4, 0, 1, 1, 0, 0, 1, 1 ) +#define MPP40_TSMP4 MPP( 40, 0x1, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP40_TDM_SPI_SCK MPP( 40, 0x2, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP40_AU_I2SDO MPP( 40, 0x4, 0, 0, 1, 0, 0, 1, 1 )#define MPP40_LCD_D20 MPP( 40, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP41_GPIO MPP( 41, 0x0, 1, 1, 1, 0, 0, 1, 1 ) -#define MPP41_TSMP5 MPP( 41, 0x1, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP41_TDM_SPI_MISO MPP( 41, 0x2, 1, 0, 0, 0, 0, 1, 1 ) -#define MPP41_AU_I2SLRCLK MPP( 41, 0x4, 0, 1, 1, 0, 0, 1, 1 ) +#define MPP41_TSMP5 MPP( 41, 0x1, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP41_TDM_SPI_MISO MPP( 41, 0x2, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP41_AU_I2SLRCLK MPP( 41, 0x4, 0, 0, 1, 0, 0, 1, 1 )#define MPP41_LCD_D21 MPP( 41, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP42_GPIO MPP( 42, 0x0, 1, 1, 1, 0, 0, 1, 1 ) -#define MPP42_TSMP6 MPP( 42, 0x1, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP42_TDM_SPI_MOSI MPP( 42, 0x2, 0, 1, 0, 0, 0, 1, 1 ) -#define MPP42_AU_I2SMCLK MPP( 42, 0x4, 0, 1, 1, 0, 0, 1, 1 ) +#define MPP42_TSMP6 MPP( 42, 0x1, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP42_TDM_SPI_MOSI MPP( 42, 0x2, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP42_AU_I2SMCLK MPP( 42, 0x4, 0, 0, 1, 0, 0, 1, 1 )#define MPP42_LCD_D22 MPP( 42, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP43_GPIO MPP( 43, 0x0, 1, 1, 1, 0, 0, 1, 1 ) -#define MPP43_TSMP7 MPP( 43, 0x1, 1, 1, 0, 0, 0, 1, 1 ) +#define MPP43_TSMP7 MPP( 43, 0x1, 0, 0, 0, 0, 0, 1, 1 )#define MPP43_TDM_CODEC_INTn MPP( 43, 0x2, 0, 0, 0, 0, 0, 1, 1 ) -#define MPP43_AU_I2SDI MPP( 43, 0x4, 1, 0, 1, 0, 0, 1, 1 ) +#define MPP43_AU_I2SDI MPP( 43, 0x4, 0, 0, 1, 0, 0, 1, 1 )#define MPP43_LCD_D23 MPP( 22, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP44_GPIO MPP( 44, 0x0, 1, 1, 1, 0, 0, 1, 1 ) -#define MPP44_TSMP8 MPP( 44, 0x1, 1, 1, 0, 0, 0, 1, 1 ) +#define MPP44_TSMP8 MPP( 44, 0x1, 0, 0, 0, 0, 0, 1, 1 )#define MPP44_TDM_CODEC_RSTn MPP( 44, 0x2, 0, 0, 0, 0, 0, 1, 1 ) -#define MPP44_AU_EXTCLK MPP( 44, 0x4, 1, 0, 1, 0, 0, 1, 1 ) +#define MPP44_AU_EXTCLK MPP( 44, 0x4, 0, 0, 1, 0, 0, 1, 1 )#define MPP44_LCD_CLK MPP( 44, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP45_GPIO MPP( 45, 0x0, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP45_TSMP9 MPP( 45, 0x1, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP45_TDM_PCLK MPP( 45, 0x2, 1, 1, 0, 0, 0, 1, 1 ) +#define MPP45_TSMP9 MPP( 45, 0x1, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP45_TDM_PCLK MPP( 45, 0x2, 0, 0, 0, 0, 0, 1, 1 )#define MPP245_LCD_E MPP( 45, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP46_GPIO MPP( 46, 0x0, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP46_TSMP10 MPP( 46, 0x1, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP46_TDM_FS MPP( 46, 0x2, 1, 1, 0, 0, 0, 1, 1 ) +#define MPP46_TSMP10 MPP( 46, 0x1, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP46_TDM_FS MPP( 46, 0x2, 0, 0, 0, 0, 0, 1, 1 )#define MPP46_LCD_HSYNC MPP( 46, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP47_GPIO MPP( 47, 0x0, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP47_TSMP11 MPP( 47, 0x1, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP47_TDM_DRX MPP( 47, 0x2, 1, 0, 0, 0, 0, 1, 1 ) +#define MPP47_TSMP11 MPP( 47, 0x1, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP47_TDM_DRX MPP( 47, 0x2, 0, 0, 0, 0, 0, 1, 1 )#define MPP47_LCD_VSYNC MPP( 47, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP48_GPIO MPP( 48, 0x0, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP48_TSMP12 MPP( 48, 0x1, 1, 1, 0, 0, 0, 1, 1 ) -#define MPP48_TDM_DTX MPP( 48, 0x2, 0, 1, 0, 0, 0, 1, 1 ) +#define MPP48_TSMP12 MPP( 48, 0x1, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP48_TDM_DTX MPP( 48, 0x2, 0, 0, 0, 0, 0, 1, 1 )#define MPP48_LCD_D16 MPP( 22, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP49_GPIO MPP( 49, 0x0, 1, 1, 0, 0, 0, 1, 0 )#define MPP49_GPO MPP( 49, 0x0, 0, 1, 0, 0, 0, 0, 1 ) -#define MPP49_TSMP9 MPP( 49, 0x1, 1, 1, 0, 0, 0, 1, 0 ) -#define MPP49_TDM_CH0_RX_QL MPP( 49, 0x2, 0, 1, 0, 0, 0, 1, 1 ) -#define MPP49_PTP_CLK MPP( 49, 0x5, 1, 0, 0, 0, 0, 1, 0 ) -#define MPP49_PEX0_CLKREQ MPP( 49, 0xa, 0, 1, 0, 0, 0, 0, 1 ) +#define MPP49_TSMP9 MPP( 49, 0x1, 0, 0, 0, 0, 0, 1, 0 ) +#define MPP49_TDM_CH0_RX_QL MPP( 49, 0x2, 0, 0, 0, 0, 0, 1, 1 ) +#define MPP49_PTP_CLK MPP( 49, 0x5, 0, 0, 0, 0, 0, 1, 0 ) +#define MPP49_PEX0_CLKREQ MPP( 49, 0xa, 0, 0, 0, 0, 0, 0, 1 )#define MPP49_LCD_D17 MPP( 49, 0xb, 0, 0, 0, 0, 0, 0, 1 )#define MPP_MAX 49
arch/arm/mach-mv78xx0/mpp.h +113 -113
423 lines not on this page · raw message
arch/arm/plat-orion/mpp.c +1 -2
@@ -64,8 +64,7 @@ void __init orion_mpp_conf(unsigned int gpio_mode |=GPIO_INPUT_OK ;if (*mpp_list &MPP_OUTPUT_MASK ) gpio_mode |=GPIO_OUTPUT_OK ; -if (sel !=0 ) - gpio_mode =0 ; +orion_gpio_set_valid (num, gpio_mode); }
Greg KH
maintainerPATCH 59/95 OMAP: 4430SDP/Panda: use gpio_free_array to free HDMI gpios
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tomi Valkeinen <[email protected]>
commit 575753e3bea3b67eef8e454fb87f719e3f7da599 upstream.
Instead of freeing the GPIOs individually, use gpio_free_array().
--- arch/arm/mach-omap2/board-4430sdp.c | 3 +-- arch/arm/mach-omap2/board-omap4panda.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
arch/arm/mach-omap2/board-4430sdp.c +1 -2
@@ -628,8 +628,7 @@ static int sdp4430_panel_enable_hdmi(strstatic void sdp4430_panel_disable_hdmi (struct omap_dss_device *dssdev) { -gpio_free (HDMI_GPIO_LS_OE ); -gpio_free (HDMI_GPIO_HPD ); +gpio_free_array (sdp4430_hdmi_gpios,ARRAY_SIZE (sdp4430_hdmi_gpios)); }static struct nokia_dsi_panel_data dsi1_panel = {
arch/arm/mach-omap2/board-omap4panda.c +1 -2
@@ -512,8 +512,7 @@ static int omap4_panda_panel_enable_hdmistatic void omap4_panda_panel_disable_hdmi (struct omap_dss_device *dssdev) { -gpio_free (HDMI_GPIO_LS_OE ); -gpio_free (HDMI_GPIO_HPD ); +gpio_free_array (panda_hdmi_gpios,ARRAY_SIZE (panda_hdmi_gpios)); }static struct omap_dss_device omap4_panda_hdmi_device = {
Greg KH
maintainerPATCH 60/95 OMAP: 4430SDP/Panda: rename HPD GPIO to CT_CP_HPD
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tomi Valkeinen <[email protected]>
commit 3932a32fcf5393f8be70ac99dc718ad7ad0a415b upstream.
The GPIO 60 on 4430sdp and Panda is not HPD GPIO, as currently marked in the board files, but CT_CP_HPD, which is used to enable/disable HPD functionality.
This patch renames the GPIO.
--- arch/arm/mach-omap2/board-4430sdp.c | 4 ++-- arch/arm/mach-omap2/board-omap4panda.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/mach-omap2/board-4430sdp.c +2 -2
@@ -52,7 +52,7 @@#define ETH_KS8851_QUART 138#define OMAP4_SFH7741_SENSOR_OUTPUT_GPIO 184#define OMAP4_SFH7741_ENABLE_GPIO 188 -#define HDMI_GPIO_HPD 60/* Hot plug pin for HDMI */ +#define HDMI_GPIO_CT_CP_HPD 60/* HPD mode enable/disable */ #define HDMI_GPIO_LS_OE 41/* Level shifter for HDMI */ #define DISPLAY_SEL_GPIO 59/* LCD2/PicoDLP switch */ #define DLP_POWER_ON_GPIO 40
@@ -610,7 +610,7 @@ static void sdp4430_hdmi_mux_init(void) }static struct gpio sdp4430_hdmi_gpios[] = { - {HDMI_GPIO_HPD ,GPIOF_OUT_INIT_HIGH ,"hdmi_gpio_hpd" }, + {HDMI_GPIO_CT_CP_HPD ,GPIOF_OUT_INIT_HIGH ,"hdmi_gpio_ct_cp_hpd" }, {HDMI_GPIO_LS_OE ,GPIOF_OUT_INIT_HIGH ,"hdmi_gpio_ls_oe" }, };
arch/arm/mach-omap2/board-omap4panda.c +2 -2
@@ -51,7 +51,7 @@#define GPIO_HUB_NRESET 62#define GPIO_WIFI_PMENA 43#define GPIO_WIFI_IRQ 53 -#define HDMI_GPIO_HPD 60/* Hot plug pin for HDMI */ +#define HDMI_GPIO_CT_CP_HPD 60/* HPD mode enable/disable */ #define HDMI_GPIO_LS_OE 41/* Level shifter for HDMI */ /* wl127x BT, FM, GPS connectivity chip */
@@ -494,7 +494,7 @@ static void omap4_panda_hdmi_mux_init(vo }static struct gpio panda_hdmi_gpios[] = { - {HDMI_GPIO_HPD ,GPIOF_OUT_INIT_HIGH ,"hdmi_gpio_hpd" }, + {HDMI_GPIO_CT_CP_HPD ,GPIOF_OUT_INIT_HIGH ,"hdmi_gpio_ct_cp_hpd" }, {HDMI_GPIO_LS_OE ,GPIOF_OUT_INIT_HIGH ,"hdmi_gpio_ls_oe" }, };
Greg KH
maintainerPATCH 61/95 OMAPDSS: remove wrong HDMI HPD muxing
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tomi Valkeinen <[email protected]>
commit 7bb122d155f742fe2d79849090c825be7b4a247e upstream.
"hdmi_hpd" pin is muxed to INPUT and PULLUP, but the pin is not currently used, and in the future when it is used, the pin is used as a GPIO and is board specific, not an OMAP4 wide thing.
So remove the muxing for now.
--- arch/arm/mach-omap2/board-4430sdp.c | 4 ---- arch/arm/mach-omap2/board-omap4panda.c | 4 ---- 2 files changed, 8 deletions(-)
arch/arm/mach-omap2/board-4430sdp.c +0 -4
@@ -597,12 +597,8 @@ static void __init omap_sfh7741prox_initstatic void sdp4430_hdmi_mux_init (void ) { -/* PAD0_HDMI_HPD_PAD1_HDMI_CEC */ -omap_mux_init_signal ("hdmi_hpd" , -OMAP_PIN_INPUT_PULLUP );omap_mux_init_signal ("hdmi_cec" ,OMAP_PIN_INPUT_PULLUP ); -/* PAD0_HDMI_DDC_SCL_PAD1_HDMI_DDC_SDA */ omap_mux_init_signal ("hdmi_ddc_scl" ,OMAP_PIN_INPUT_PULLUP ); omap_mux_init_signal("hdmi_ddc_sda",
arch/arm/mach-omap2/board-omap4panda.c +0 -4
@@ -481,12 +481,8 @@ int __init omap4_panda_dvi_init(void)static void omap4_panda_hdmi_mux_init (void ) { -/* PAD0_HDMI_HPD_PAD1_HDMI_CEC */ -omap_mux_init_signal ("hdmi_hpd" , -OMAP_PIN_INPUT_PULLUP );omap_mux_init_signal ("hdmi_cec" ,OMAP_PIN_INPUT_PULLUP ); -/* PAD0_HDMI_DDC_SCL_PAD1_HDMI_DDC_SDA */ omap_mux_init_signal ("hdmi_ddc_scl" ,OMAP_PIN_INPUT_PULLUP ); omap_mux_init_signal("hdmi_ddc_sda",
Greg KH
maintainerPATCH 62/95 OMAP: 4430SDP/Panda: setup HDMI GPIO muxes
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tomi Valkeinen <[email protected]>
commit 78a1ad8f12db70b8b0a4548b90704de08ee216ce upstream.
The HDMI GPIO pins LS_OE and CT_CP_HPD are not currently configured. This patch configures them as output pins.
--- arch/arm/mach-omap2/board-4430sdp.c | 3 +++ arch/arm/mach-omap2/board-omap4panda.c | 3 +++ 2 files changed, 6 insertions(+)
arch/arm/mach-omap2/board-4430sdp.c +3 -0
@@ -824,6 +824,9 @@ static void omap_4430sdp_display_init(vosdp4430_hdmi_mux_init ();sdp4430_picodlp_init ();omap_display_init (&sdp4430_dss_data); + +omap_mux_init_gpio (HDMI_GPIO_LS_OE ,OMAP_PIN_OUTPUT ); +omap_mux_init_gpio (HDMI_GPIO_CT_CP_HPD ,OMAP_PIN_OUTPUT ); }#ifdef CONFIG_OMAP_MUX
arch/arm/mach-omap2/board-omap4panda.c +3 -0
@@ -541,6 +541,9 @@ void omap4_panda_display_init(void)omap4_panda_hdmi_mux_init ();omap_display_init (&omap4_panda_dss_data); + +omap_mux_init_gpio (HDMI_GPIO_LS_OE ,OMAP_PIN_OUTPUT ); +omap_mux_init_gpio (HDMI_GPIO_CT_CP_HPD ,OMAP_PIN_OUTPUT ); }static void __init omap4_panda_init (void )
Greg KH
maintainerPATCH 63/95 OMAP: 4430SDP/Panda: add HDMI HPD gpio
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tomi Valkeinen <[email protected]>
commit aa74274b464d4aa24703963ac89a0ee942d5d267 upstream.
Both Panda and 4430SDP use GPIO 63 as HDMI hot-plug-detect. Configure this GPIO in the board files.
--- arch/arm/mach-omap2/board-4430sdp.c | 3 +++ arch/arm/mach-omap2/board-omap4panda.c | 3 +++ 2 files changed, 6 insertions(+)
arch/arm/mach-omap2/board-4430sdp.c +3 -0
@@ -54,6 +54,7 @@#define OMAP4_SFH7741_ENABLE_GPIO 188#define HDMI_GPIO_CT_CP_HPD 60/* HPD mode enable/disable */ #define HDMI_GPIO_LS_OE 41/* Level shifter for HDMI */ +#define HDMI_GPIO_HPD 63/* Hotplug detect */ #define DISPLAY_SEL_GPIO 59/* LCD2/PicoDLP switch */ #define DLP_POWER_ON_GPIO 40
@@ -608,6 +609,7 @@ static void sdp4430_hdmi_mux_init(void)static struct gpio sdp4430_hdmi_gpios[] = { {HDMI_GPIO_CT_CP_HPD ,GPIOF_OUT_INIT_HIGH ,"hdmi_gpio_ct_cp_hpd" }, {HDMI_GPIO_LS_OE ,GPIOF_OUT_INIT_HIGH ,"hdmi_gpio_ls_oe" }, + {HDMI_GPIO_HPD ,GPIOF_DIR_IN ,"hdmi_gpio_hpd" }, };static int sdp4430_panel_enable_hdmi (struct omap_dss_device *dssdev)
@@ -827,6 +829,7 @@ static void omap_4430sdp_display_init(voomap_mux_init_gpio (HDMI_GPIO_LS_OE ,OMAP_PIN_OUTPUT );omap_mux_init_gpio (HDMI_GPIO_CT_CP_HPD ,OMAP_PIN_OUTPUT ); +omap_mux_init_gpio (HDMI_GPIO_HPD ,OMAP_PIN_INPUT_PULLDOWN ); }#ifdef CONFIG_OMAP_MUX
arch/arm/mach-omap2/board-omap4panda.c +3 -0
@@ -53,6 +53,7 @@#define GPIO_WIFI_IRQ 53#define HDMI_GPIO_CT_CP_HPD 60/* HPD mode enable/disable */ #define HDMI_GPIO_LS_OE 41/* Level shifter for HDMI */ +#define HDMI_GPIO_HPD 63/* Hotplug detect */ /* wl127x BT, FM, GPS connectivity chip */ static int wl1271_gpios[] = {46 ,-1 ,-1 };
@@ -492,6 +493,7 @@ static void omap4_panda_hdmi_mux_init(vostatic struct gpio panda_hdmi_gpios[] = { {HDMI_GPIO_CT_CP_HPD ,GPIOF_OUT_INIT_HIGH ,"hdmi_gpio_ct_cp_hpd" }, {HDMI_GPIO_LS_OE ,GPIOF_OUT_INIT_HIGH ,"hdmi_gpio_ls_oe" }, + {HDMI_GPIO_HPD ,GPIOF_DIR_IN ,"hdmi_gpio_hpd" }, };static int omap4_panda_panel_enable_hdmi (struct omap_dss_device *dssdev)
@@ -544,6 +546,7 @@ void omap4_panda_display_init(void)omap_mux_init_gpio (HDMI_GPIO_LS_OE ,OMAP_PIN_OUTPUT );omap_mux_init_gpio (HDMI_GPIO_CT_CP_HPD ,OMAP_PIN_OUTPUT ); +omap_mux_init_gpio (HDMI_GPIO_HPD ,OMAP_PIN_INPUT_PULLDOWN ); }static void __init omap4_panda_init (void )
Greg KH
maintainerPATCH 64/95 OMAPDSS: HDMI: PHY burnout fix
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tomi Valkeinen <[email protected]>
commit c49d005b6cc8491fad5b24f82805be2d6bcbd3dd upstream.
A hardware bug in the OMAP4 HDMI PHY causes physical damage to the board if the HDMI PHY is kept powered on when the cable is not connected.
This patch solves the problem by adding hot-plug-detection into the HDMI IP driver. This is not a real HPD support in the sense that nobody else than the IP driver gets to know about the HPD events, but is only meant to fix the HW bug.
The strategy is simple: If the display device is turned off by the user, the PHY power is set to OFF. When the display device is turned on by the user, the PHY power is set either to LDOON or TXON, depending on whether the HDMI cable is connected.
The reason to avoid PHY OFF when the display device is on, but the cable is disconnected, is that when the PHY is turned OFF, the HDMI IP is not "ticking" and thus the DISPC does not receive pixel clock from the HDMI IP. This would, for example, prevent any VSYNCs from happening, and would thus affect the users of omapdss. By using LDOON when the cable is disconnected we'll avoid the HW bug, but keep the HDMI working as usual from the user's point of view.
--- arch/arm/mach-omap2/board-4430sdp.c | 5 ++ arch/arm/mach-omap2/board-omap4panda.c | 5 ++ drivers/video/omap2/dss/hdmi.c | 3 + drivers/video/omap2/dss/ti_hdmi.h | 4 + drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c | 68 ++++++++++++++++++++++++++++-- include/video/omapdss.h | 5 ++ 6 files changed, 86 insertions(+), 4 deletions(-)
arch/arm/mach-omap2/board-4430sdp.c +5 -0
@@ -742,6 +742,10 @@ static void sdp4430_lcd_init(void)pr_err ("%s: Could not get lcd2_reset_gpio\n" , __func__); } +static struct omap_dss_hdmi_data sdp4430_hdmi_data = { + .hpd_gpio =HDMI_GPIO_HPD , +}; +static struct omap_dss_device sdp4430_hdmi_device = { .name ="hdmi" , .driver_name ="hdmi_panel" ,
@@ -749,6 +753,7 @@ static struct omap_dss_device sdp4430_hd .platform_enable = sdp4430_panel_enable_hdmi, .platform_disable = sdp4430_panel_disable_hdmi, .channel = OMAP_DSS_CHANNEL_DIGIT, + .data = &sdp4430_hdmi_data, };static struct picodlp_panel_data sdp4430_picodlp_pdata = {
arch/arm/mach-omap2/board-omap4panda.c +5 -0
@@ -513,6 +513,10 @@ static void omap4_panda_panel_disable_hdgpio_free_array (panda_hdmi_gpios,ARRAY_SIZE (panda_hdmi_gpios)); } +static struct omap_dss_hdmi_data omap4_panda_hdmi_data = { + .hpd_gpio =HDMI_GPIO_HPD , +}; +static struct omap_dss_device omap4_panda_hdmi_device = { .name ="hdmi" , .driver_name ="hdmi_panel" ,
@@ -520,6 +524,7 @@ static struct omap_dss_device omap4_pan .platform_enable = omap4_panda_panel_enable_hdmi, .platform_disable = omap4_panda_panel_disable_hdmi, .channel = OMAP_DSS_CHANNEL_DIGIT, + .data = &omap4_panda_hdmi_data, };static struct omap_dss_device *omap4_panda_dss_devices[] = {
drivers/video/omap2/dss/hdmi.c +3 -0
@@ -490,6 +490,7 @@ bool omapdss_hdmi_detect(void)int omapdss_hdmi_display_enable (struct omap_dss_device *dssdev) { +struct omap_dss_hdmi_data *priv = dssdev->data;int r =0 ;DSSDBG ("ENTER hdmi_display_enable\n" );
@@ -502,6 +503,8 @@ int omapdss_hdmi_display_enable(struct o goto err0; } + hdmi.ip_data.hpd_gpio = priv->hpd_gpio; + r =omap_dss_start_device (dssdev);if (r) {DSSERR ("failed to start device\n" );
drivers/video/omap2/dss/ti_hdmi.h +4 -0
@@ -121,6 +121,10 @@ struct hdmi_ip_data {const struct ti_hdmi_ip_ops *ops;struct hdmi_config cfg;struct hdmi_pll_info pll_data; + +/* ti_hdmi_4xxx_ip private data. These should be in a separate struct */ +int hpd_gpio; +bool phy_tx_enabled; };int ti_hdmi_4xxx_phy_enable (struct hdmi_ip_data *ip_data);void ti_hdmi_4xxx_phy_disable (struct hdmi_ip_data *ip_data);
drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c +64 -4
98 lines not on this page · raw message
include/video/omapdss.h +5 -0
@@ -575,6 +575,11 @@ struct omap_dss_device {int (*get_backlight)(struct omap_dss_device *dssdev); }; +struct omap_dss_hdmi_data +{ +int hpd_gpio; +}; +struct omap_dss_driver {struct device_driver driver;
Greg KH
maintainerPATCH 65/95 OMAPDSS: HDMI: hot plug detect fix
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Rob Clark <[email protected]>
commit ca888a7958b3d808e4efd08ceff88913f4212c69 upstream.
The "OMAPDSS: HDMI: PHY burnout fix" commit switched the HDMI driver over to using a GPIO for plug detect. Unfortunately the ->detect() method was not also updated, causing HDMI to no longer work for the omapdrm driver (because it would actually check if a connection was detected before attempting to enable display).
--- drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c +1 -8
@@ -479,14 +479,7 @@ int ti_hdmi_4xxx_read_edid(struct hdmi_ibool ti_hdmi_4xxx_detect (struct hdmi_ip_data *ip_data) { -int r; - -void __iomem *base =hdmi_core_sys_base (ip_data); - -/* HPD */ - r =REG_GET (base,HDMI_CORE_SYS_SYS_STAT ,1 ,1 ); - -return r ==1 ; +return gpio_get_value (ip_data->hpd_gpio); } static void hdmi_core_init(struct hdmi_core_video_config *video_cfg,
Greg KH
maintainerPATCH 66/95 ARM: 7345/1: errata: update workaround for A9 erratum #743622
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Will Deacon <[email protected]>
commit efbc74ace95338484f8d732037b99c7c77098fce upstream.
Erratum #743622 affects all r2 variants of the Cortex-A9 processor, so ensure that the workaround is applied regardless of the revision.
--- arch/arm/Kconfig | 2 +- arch/arm/mm/proc-v7.S | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-)
arch/arm/Kconfig +1 -1
@@ -1272,7 +1272,7 @@ config ARM_ERRATA_743622 depends on CPU_V7 help This option enables the workaround for the 743622 Cortex-A9 - (r2p0..r2p2) erratum. Under very rare conditions, a faulty + (r2p*) erratum. Under very rare conditions, a faulty optimisation in the Cortex-A9 Store Buffer may lead to data corruption. This workaround sets a specific bit in the diagnostic register of the Cortex-A9 which disables the Store Buffer
arch/arm/mm/proc-v7.S +1 -3
@@ -352,9 +352,7 @@ __v7_setup: mcreq p15, 0, r10, c15, c0, 1 @ write diagnostic register #endif #ifdef CONFIG_ARM_ERRATA_743622 - teq r6, #0x20 @ present in r2p0 - teqne r6, #0x21 @ present in r2p1 - teqne r6, #0x22 @ present in r2p2 + teq r5, #0x00200000 @ only present in r2p* mrceq p15, 0, r10, c15, c0, 1 @ read diagnostic register orreq r10, r10, #1 << 6 @ set bit #6 mcreq p15, 0, r10, c15, c0, 1 @ write diagnostic register
Greg KH
maintainerPATCH 67/95 ARM: 7354/1: perf: limit sample_period to half max_period in non-sampling mode
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Will Deacon <[email protected]>
commit 5727347180ebc6b4a866fcbe00dcb39cc03acb37 upstream.
On ARM, the PMU does not stop counting after an overflow and therefore IRQ latency affects the new counter value read by the kernel. This is significant for non-sampling runs where it is possible for the new value to overtake the previous one, causing the delta to be out by up to max_period events.
Commit a737823d ("ARM: 6835/1: perf: ensure overflows aren't missed due to IRQ latency") attempted to fix this problem by allowing interrupt handlers to pass an overflow flag to the event update function, causing the overflow calculation to assume that the counter passed through zero when going from prev to new. Unfortunately, this doesn't work when overflow occurs on the perf_task_tick path because we have the flag cleared and end up computing a large negative delta.
This patch removes the overflow flag from armpmu_event_update and instead limits the sample_period to half of the max_period for non-sampling profiling runs.
--- arch/arm/include/asm/pmu.h | 2 +- arch/arm/kernel/perf_event.c | 22 +++++++++++----------- arch/arm/kernel/perf_event_v6.c | 2 +- arch/arm/kernel/perf_event_v7.c | 2 +- arch/arm/kernel/perf_event_xscale.c | 4 ++-- 5 files changed, 16 insertions(+), 16 deletions(-)
arch/arm/include/asm/pmu.h +1 -1
@@ -125,7 +125,7 @@ int __init armpmu_register(struct arm_pmu64 armpmu_event_update (struct perf_event *event,struct hw_perf_event *hwc, -int idx,int overflow); +int idx); int armpmu_event_set_period(struct perf_event *event, struct hw_perf_event *hwc,
arch/arm/kernel/perf_event.c +11 -11
@@ -187,7 +187,7 @@ armpmu_event_set_period(struct perf_evenu64 armpmu_event_update (struct perf_event *event,struct hw_perf_event *hwc, -int idx,int overflow) +int idx) {struct arm_pmu *armpmu =to_arm_pmu (event->pmu);u64 delta, prev_raw_count, new_raw_count;
@@ -200,13 +200,7 @@ again: new_raw_count) != prev_raw_count) goto again; - new_raw_count &= armpmu->max_period; - prev_raw_count &= armpmu->max_period; - -if (overflow) - delta = armpmu->max_period - prev_raw_count + new_raw_count +1 ; -else - delta = new_raw_count - prev_raw_count; + delta = (new_raw_count - prev_raw_count) & armpmu->max_period;local64_add (delta, &event->count);local64_sub (delta, &hwc->period_left);
@@ -223,7 +217,7 @@ armpmu_read(struct perf_event *event)if (hwc->idx <0 )return ; -armpmu_event_update (event, hwc, hwc->idx,0 ); +armpmu_event_update (event, hwc, hwc->idx); } static void
@@ -239,7 +233,7 @@ armpmu_stop(struct perf_event *event, inif (!(hwc->state &PERF_HES_STOPPED )) { armpmu->disable (hwc, hwc->idx);barrier ();/* why? */ -armpmu_event_update (event, hwc, hwc->idx,0 ); +armpmu_event_update (event, hwc, hwc->idx); hwc->state |=PERF_HES_STOPPED |PERF_HES_UPTODATE ; } }
@@ -519,7 +513,13 @@ __hw_perf_event_init(struct perf_event * hwc->config_base |= (unsigned long )mapping;if (!hwc->sample_period) { - hwc->sample_period = armpmu->max_period; +/* +* For non-sampling runs, limit the sample_period to half +* of the counter width. That way, the new counter value +* is far less likely to overtake the previous one unless +* you have some serious IRQ latency issues. +*/ + hwc->sample_period = armpmu->max_period >>1 ; hwc->last_period = hwc->sample_period;local64_set (&hwc->period_left, hwc->sample_period); }
arch/arm/kernel/perf_event_v6.c +1 -1
@@ -520,7 +520,7 @@ armv6pmu_handle_irq(int irq_num,continue ; hwc = &event->hw; -armpmu_event_update (event, hwc, idx,1 ); +armpmu_event_update (event, hwc, idx); data.period = event->hw.last_period;if (!armpmu_event_set_period (event, hwc, idx))continue ;
arch/arm/kernel/perf_event_v7.c +1 -1
@@ -1032,7 +1032,7 @@ static irqreturn_t armv7pmu_handle_irq(icontinue ; hwc = &event->hw; -armpmu_event_update (event, hwc, idx,1 ); +armpmu_event_update (event, hwc, idx); data.period = event->hw.last_period;if (!armpmu_event_set_period (event, hwc, idx))continue ;
arch/arm/kernel/perf_event_xscale.c +2 -2
@@ -257,7 +257,7 @@ xscale1pmu_handle_irq(int irq_num, voidcontinue ; hwc = &event->hw; -armpmu_event_update (event, hwc, idx,1 ); +armpmu_event_update (event, hwc, idx); data.period = event->hw.last_period;if (!armpmu_event_set_period (event, hwc, idx))continue ;
@@ -594,7 +594,7 @@ xscale2pmu_handle_irq(int irq_num, voidcontinue ; hwc = &event->hw; -armpmu_event_update (event, hwc, idx,1 ); +armpmu_event_update (event, hwc, idx); data.period = event->hw.last_period;if (!armpmu_event_set_period (event, hwc, idx))continue ;
Greg KH
maintainerPATCH 68/95 ARM: 7355/1: perf: clear overflow flag when disabling counter on ARMv7 PMU
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Will Deacon <[email protected]>
commit 99c1745b9c76910e195889044f914b4898b7c9a5 upstream.
When disabling a counter on an ARMv7 PMU, we should also clear the overflow flag in case an overflow occurred whilst stopping the counter. This prevents a spurious overflow being picked up later and leading to either false accounting or a NULL dereference.
--- arch/arm/kernel/perf_event_v7.c | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/kernel/perf_event_v7.c +5 -0
@@ -878,6 +878,11 @@ static inline int armv7_pmnc_disable_int counter =ARMV7_IDX_TO_COUNTER (idx); asmvolatile ("mcr p15, 0, %0, c9, c14, 2" : :"r" (BIT (counter))); +isb (); +/* Clear the overflow flag in case an interrupt is pending. */ + asmvolatile ("mcr p15, 0, %0, c9, c12, 3" : :"r" (BIT (counter))); +isb (); +return idx; }
Greg KH
maintainerPATCH 69/95 ARM: 7356/1: perf: check that we have an event in the PMU IRQ handlers
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Will Deacon <[email protected]>
commit f6f5a30c834135c9f2fa10400c59ebbdd9188567 upstream.
The PMU IRQ handlers in perf assume that if a counter has overflowed then perf must be responsible. In the paranoid world of crazy hardware, this could be false, so check that we do have a valid event before attempting to dereference NULL in the interrupt path.
--- arch/arm/kernel/perf_event_v6.c | 20 ++------------------ arch/arm/kernel/perf_event_v7.c | 4 ++++ arch/arm/kernel/perf_event_xscale.c | 6 ++++++ 3 files changed, 12 insertions(+), 18 deletions(-)
arch/arm/kernel/perf_event_v6.c +2 -18
@@ -463,23 +463,6 @@ armv6pmu_enable_event(struct hw_perf_everaw_spin_unlock_irqrestore (&events->pmu_lock, flags); } -static int counter_is_active (unsigned long pmcr,int idx) -{ -unsigned long mask =0 ; -if (idx ==ARMV6_CYCLE_COUNTER ) - mask =ARMV6_PMCR_CCOUNT_IEN ; -else if (idx ==ARMV6_COUNTER0 ) - mask =ARMV6_PMCR_COUNT0_IEN ; -else if (idx ==ARMV6_COUNTER1 ) - mask =ARMV6_PMCR_COUNT1_IEN ; - -if (mask) -return pmcr & mask; - -WARN_ONCE (1 ,"invalid counter number (%d)\n" , idx); -return 0 ; -} -static irqreturn_t armv6pmu_handle_irq (int irq_num,void *dev)
@@ -509,7 +492,8 @@ armv6pmu_handle_irq(int irq_num,struct perf_event *event = cpuc->events[idx];struct hw_perf_event *hwc; -if (!counter_is_active (pmcr, idx)) +/* Ignore if we don't have an event. */ +if (!event)continue ;/*
arch/arm/kernel/perf_event_v7.c +4 -0
@@ -1029,6 +1029,10 @@ static irqreturn_t armv7pmu_handle_irq(istruct perf_event *event = cpuc->events[idx];struct hw_perf_event *hwc; +/* Ignore if we don't have an event. */ +if (!event) +continue ; +/* * We have a single interrupt for all counters. Check that * each counter has overflowed before we process it.
arch/arm/kernel/perf_event_xscale.c +6 -0
@@ -253,6 +253,9 @@ xscale1pmu_handle_irq(int irq_num, voidstruct perf_event *event = cpuc->events[idx];struct hw_perf_event *hwc; +if (!event) +continue ; +if (!xscale1_pmnc_counter_has_overflowed (pmnc, idx))continue ;
@@ -590,6 +593,9 @@ xscale2pmu_handle_irq(int irq_num, voidstruct perf_event *event = cpuc->events[idx];struct hw_perf_event *hwc; +if (!event) +continue ; +if (!xscale2_pmnc_counter_has_overflowed (pmnc, idx))continue ;
Greg KH
maintainerPATCH 70/95 ARM: 7357/1: perf: fix overflow handling for xscale2 PMUs
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Will Deacon <[email protected]>
commit 3f31ae121348afd9ed39700ea2a63c17cd7eeed1 upstream.
xscale2 PMUs indicate overflow not via the PMU control register, but by a separate overflow FLAG register instead.
This patch fixes the xscale2 PMU code to use this register to detect to overflow and ensures that we clear any pending overflow when disabling a counter.
--- arch/arm/kernel/perf_event_xscale.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
arch/arm/kernel/perf_event_xscale.c +8 -2
@@ -596,7 +596,7 @@ xscale2pmu_handle_irq(int irq_num, voidif (!event)continue ; -if (!xscale2_pmnc_counter_has_overflowed (pmnc, idx)) +if (!xscale2_pmnc_counter_has_overflowed (of_flags, idx))continue ; hwc = &event->hw;
@@ -667,7 +667,7 @@ xscale2pmu_enable_event(struct hw_perf_estatic void xscale2pmu_disable_event (struct hw_perf_event *hwc,int idx) { -unsigned long flags, ien, evtsel; +unsigned long flags, ien, evtsel, of_flags;struct pmu_hw_events *events = cpu_pmu->get_hw_events (); ien =xscale2pmu_read_int_enable ();
@@ -676,26 +676,31 @@ xscale2pmu_disable_event(struct hw_perf_switch (idx) {case XSCALE_CYCLE_COUNTER : ien &= ~XSCALE2_CCOUNT_INT_EN ; + of_flags =XSCALE2_CCOUNT_OVERFLOW ;break ;case XSCALE_COUNTER0 : ien &= ~XSCALE2_COUNT0_INT_EN ; evtsel &= ~XSCALE2_COUNT0_EVT_MASK ; evtsel |=XSCALE_PERFCTR_UNUSED <<XSCALE2_COUNT0_EVT_SHFT ; + of_flags =XSCALE2_COUNT0_OVERFLOW ;break ;case XSCALE_COUNTER1 : ien &= ~XSCALE2_COUNT1_INT_EN ; evtsel &= ~XSCALE2_COUNT1_EVT_MASK ; evtsel |=XSCALE_PERFCTR_UNUSED <<XSCALE2_COUNT1_EVT_SHFT ; + of_flags =XSCALE2_COUNT1_OVERFLOW ;break ;case XSCALE_COUNTER2 : ien &= ~XSCALE2_COUNT2_INT_EN ; evtsel &= ~XSCALE2_COUNT2_EVT_MASK ; evtsel |=XSCALE_PERFCTR_UNUSED <<XSCALE2_COUNT2_EVT_SHFT ; + of_flags =XSCALE2_COUNT2_OVERFLOW ;break ;case XSCALE_COUNTER3 : ien &= ~XSCALE2_COUNT3_INT_EN ; evtsel &= ~XSCALE2_COUNT3_EVT_MASK ; evtsel |=XSCALE_PERFCTR_UNUSED <<XSCALE2_COUNT3_EVT_SHFT ; + of_flags =XSCALE2_COUNT3_OVERFLOW ;break ;default :WARN_ONCE (1 ,"invalid counter number (%d)\n" , idx);
@@ -705,6 +710,7 @@ xscale2pmu_disable_event(struct hw_perf_raw_spin_lock_irqsave (&events->pmu_lock, flags);xscale2pmu_write_event_select (evtsel);xscale2pmu_write_int_enable (ien); +xscale2pmu_write_overflow_flags (of_flags);raw_spin_unlock_irqrestore (&events->pmu_lock, flags); }
Greg KH
maintainerPATCH 71/95 media: staging: lirc_serial: Fix init/exit order
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ben Hutchings <[email protected]>
commit 9105b8b200410383d0854bbe237ee385d7d33ba6 upstream.
Currently the module init function registers a platform_device and only then allocates its IRQ and I/O region. This allows allocation to race with the device's suspend() function. Instead, allocate resources in the platform driver's probe() function and free them in the remove() function.
The module exit function removes the platform device before the character device that provides access to it. Change it to reverse the order of initialisation.
--- drivers/staging/media/lirc/lirc_serial.c | 56 +++++++++++-------------------- 1 file changed, 21 insertions(+), 35 deletions(-)
drivers/staging/media/lirc/lirc_serial.c +21 -35
@@ -836,7 +836,7 @@ static int hardware_init_port(void)return 0 ; } -static int init_port (void ) +static int __devinit lirc_serial_probe (struct platform_device *dev) {int i, nlow, nhigh, result;
@@ -913,6 +913,18 @@ static int init_port(void)return 0 ; } +static int __devexit lirc_serial_remove(struct platform_device *dev) +{ +free_irq (irq, (void *)&hardware); + +if (iommap !=0 ) +release_mem_region (iommap,8 << ioshift); +else +release_region (io,8 ); + +return 0 ; +} +static int set_use_inc (void *data) {unsigned long flags;
@@ -1076,16 +1088,6 @@ static struct lirc_driver driver = {static struct platform_device *lirc_serial_dev; -static int __devinit lirc_serial_probe (struct platform_device *dev) -{ -return 0 ; -} - -static int __devexit lirc_serial_remove(struct platform_device *dev) -{ -return 0 ; -} -static int lirc_serial_suspend (struct platform_device *dev,pm_message_t state) {
@@ -1188,10 +1190,6 @@ static int __init lirc_serial_init_modul {int result; - result =lirc_serial_init (); -if (result) -return result; -switch (type) {case LIRC_HOMEBREW :case LIRC_IRDEO :
@@ -1211,8 +1209,7 @@ static int __init lirc_serial_init_modulbreak ;#endif default : - result = -EINVAL ; - goto exit_serial_exit; +return -EINVAL ; }if (!softcarrier) {switch (type) {
@@ -1228,37 +1225,26 @@ static int __init lirc_serial_init_modul } } - result =init_port (); -if (result <0 ) - goto exit_serial_exit; + result =lirc_serial_init (); +if (result) +return result; + driver.features = hardware[type].features; driver.dev = &lirc_serial_dev->dev; driver.minor =lirc_register_driver (&driver);if (driver.minor <0 ) { printk(KERN_ERR LIRC_DRIVER_NAME ": register_chrdev failed!\n"); - result = -EIO ; - goto exit_release; +lirc_serial_exit (); +return -EIO ; }return 0 ; -exit_release: -release_region (io,8 ); -exit_serial_exit: -lirc_serial_exit (); -return result; } static void __exit lirc_serial_exit_module(void) { -lirc_serial_exit (); - -free_irq (irq, (void *)&hardware); - -if (iommap !=0 ) -release_mem_region (iommap,8 << ioshift); -else -release_region (io,8 );lirc_unregister_driver (driver.minor); +lirc_serial_exit ();dprintk ("cleaned up module\n" ); }
Greg KH
maintainerPATCH 72/95 media: staging: lirc_serial: Free resources on failure paths of lirc_serial_probe()
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ben Hutchings <[email protected]>
commit c8e57e1b766c2321aa76ee5e6878c69bd2313d62 upstream.
Failure to allocate the I/O region leaves the IRQ allocated. A later failure leaves them both allocated.
--- drivers/staging/media/lirc/lirc_serial.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-)
drivers/staging/media/lirc/lirc_serial.c +16 -3
@@ -875,11 +875,14 @@ static int __devinit lirc_serial_probe(s ": or compile the serial port driver as module and\n"); printk(KERN_WARNING LIRC_DRIVER_NAME ": make sure this module is loaded first\n"); -return -EBUSY ; + result = -EBUSY ; + goto exit_free_irq; } -if (hardware_init_port () <0 ) -return -EINVAL ; +if (hardware_init_port () <0 ) { + result = -EINVAL ; + goto exit_release_region; + }/* Initialize pulse/space widths */ init_timing_params (duty_cycle, freq);
@@ -911,6 +914,16 @@ static int __devinit lirc_serial_probe(sdprintk ("Interrupt %d, port %04x obtained\n" , irq, io);return 0 ; + +exit_release_region: +if (iommap !=0 ) +release_mem_region (iommap,8 << ioshift); +else +release_region (io,8 ); +exit_free_irq: +free_irq (irq, (void *)&hardware); + +return result; } static int __devexit lirc_serial_remove(struct platform_device *dev)
Greg KH
maintainerPATCH 73/95 media: staging: lirc_serial: Fix deadlock on resume failure
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ben Hutchings <[email protected]>
commit 1ff1d88e862948ae5bfe490248c023ff8ac2855d upstream.
A resume function cannot remove the device it is resuming!
--- drivers/staging/media/lirc/lirc_serial.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/media/lirc/lirc_serial.c +1 -3
@@ -1127,10 +1127,8 @@ static int lirc_serial_resume(struct pla {unsigned long flags; -if (hardware_init_port () <0 ) { -lirc_serial_exit (); +if (hardware_init_port () <0 )return -EINVAL ; - }spin_lock_irqsave (&hardware[type].lock, flags);/* Enable Interrupt */
Greg KH
maintainerPATCH 74/95 media: staging: lirc_serial: Do not assume error codes returned by request_irq()
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ben Hutchings <[email protected]>
commit affc9a0d59ac49bd304e2137bd5e4ffdd6fdfa52 upstream.
lirc_serial_probe() must fail if request_irq() returns an error, even if it isn't EBUSY or EINVAL,
--- drivers/staging/media/lirc/lirc_serial.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-)
drivers/staging/media/lirc/lirc_serial.c +9 -12
@@ -843,18 +843,15 @@ static int __devinit lirc_serial_probe(s result =request_irq (irq, irq_handler, (share_irq ?IRQF_SHARED :0 ),LIRC_DRIVER_NAME , (void *)&hardware); - -switch (result) { -case -EBUSY : - printk(KERN_ERR LIRC_DRIVER_NAME ": IRQ %d busy\n", irq); -return -EBUSY ; -case -EINVAL : - printk(KERN_ERR LIRC_DRIVER_NAME - ": Bad irq number or handler\n"); -return -EINVAL ; -default : -break ; - }; +if (result <0 ) { +if (result == -EBUSY ) + printk(KERN_ERR LIRC_DRIVER_NAME ": IRQ %d busy\n", + irq); +else if (result == -EINVAL ) + printk(KERN_ERR LIRC_DRIVER_NAME +": Bad irq number or handler\n" ); +return result; + }/* Reserve io region. */ /*
Greg KH
maintainerPATCH 75/95 Input: ALPS - fix touchpad detection when buttons are pressed
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Akio Idehara <[email protected]>
commit 99c90ab31fad855b9da9dee3a5aa6c27f263e9d6 upstream.
ALPS touchpad detection fails if some buttons of ALPS are pressed. The reason is that the "E6" query response byte is different from what is expected.
This was tested on a Toshiba Portege R500.
--- drivers/input/mouse/alps.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/input/mouse/alps.c +5 -2
@@ -421,7 +421,9 @@ static const struct alps_model_info *alp/* * First try "E6 report". -* ALPS should return 0,0,10 or 0,0,100 +* ALPS should return 0,0,10 or 0,0,100 if no buttons are pressed. +* The bits 0-2 of the first byte will be 1s if some buttons are +* pressed. */ param[0 ] =0 ; if (ps2_command(ps2dev, param, PSMOUSE_CMD_SETRES) ||
@@ -437,7 +439,8 @@ static const struct alps_model_info *alppsmouse_dbg (psmouse,"E6 report: %2.2x %2.2x %2.2x" , param[0 ], param[1 ], param[2 ]); -if (param[0 ] !=0 || param[1 ] !=0 || (param[2 ] !=10 && param[2 ] !=100 )) +if ((param[0 ] &0xf8 ) !=0 || param[1 ] !=0 || + (param[2 ] !=10 && param[2 ] !=100 ))return NULL ;/*
Greg KH
maintainerPATCH 76/95 hwmon: (pmbus_core) Fix maximum number of POUT alarm attributes
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Guenter Roeck <[email protected]>
commit 7cb3c44fb1f7999e4c53b6a52de6bc25da6de079 upstream.
There are up to three POUT alarm attributes, not two, since cap_alarm was added.
--- drivers/hwmon/pmbus/pmbus_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/hwmon/pmbus/pmbus_core.c +2 -1
@@ -54,7 +54,8 @@lcrit_alarm, crit_alarm */ #define PMBUS_IOUT_BOOLEANS_PER_PAGE 3/* alarm, lcrit_alarm, crit_alarm */ -#define PMBUS_POUT_BOOLEANS_PER_PAGE 2/* alarm, crit_alarm */ +#define PMBUS_POUT_BOOLEANS_PER_PAGE 3/* cap_alarm, alarm, crit_alarm +*/ #define PMBUS_MAX_BOOLEANS_PER_FAN 2/* alarm, fault */ #define PMBUS_MAX_BOOLEANS_PER_TEMP 4/* min_alarm, max_alarm, lcrit_alarm, crit_alarm */
Greg KH
maintainerPATCH 77/95 hwmon: (jc42) Add support for ST Microelectronics STTS2002 and STTS3000
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jean Delvare <[email protected]>
commit 4de86126a712ba83fa038d277c8282f7ed466a4b upstream.
These are fully compatible with Jedec JC 42.4 as far as I can see.
--- Documentation/hwmon/jc42 | 6 ++++++ drivers/hwmon/Kconfig | 3 ++- drivers/hwmon/jc42.c | 10 ++++++++++ 3 files changed, 18 insertions(+), 1 deletion(-)
Documentation/hwmon/jc42 +6 -0
@@ -48,6 +48,12 @@ Supported chips: Datasheets: http://www.st.com/stonline/products/literature/ds/13447/stts424.pdf http://www.st.com/stonline/products/literature/ds/13448/stts424e02.pdf + * ST Microelectronics STTS2002, STTS3000 + Prefix: 'stts2002', 'stts3000' + Addresses scanned: I2C 0x18 - 0x1f + Datasheets: + http://www.st.com/internet/com/TECHNICAL_RESOURCES/TECHNICAL_LITERATURE/DATASHEET/CD00225278.pdf + http://www.st.com/internet/com/TECHNICAL_RESOURCES/TECHNICAL_LITERATURE/DATA_BRIEF/CD00270920.pdf * JEDEC JC 42.4 compliant temperature sensor chips Prefix: 'jc42' Addresses scanned: I2C 0x18 - 0x1f
drivers/hwmon/Kconfig +2 -1
@@ -498,7 +498,8 @@ config SENSORS_JC42 temperature sensors, which are used on many DDR3 memory modules for mobile devices and servers. Support will include, but not be limited to, ADT7408, CAT34TS02, CAT6095, MAX6604, MCP9805, MCP98242, MCP98243, - MCP9843, SE97, SE98, STTS424(E), TSE2002B3, and TS3000B3. + MCP9843, SE97, SE98, STTS424(E), STTS2002, STTS3000, TSE2002B3, and + TS3000B3. This driver can also be built as a module. If so, the module will be called jc42.
drivers/hwmon/jc42.c +10 -0
@@ -113,6 +113,12 @@ static const unsigned short normal_i2c[]#define STTS424E_DEVID 0x0000#define STTS424E_DEVID_MASK 0xfffe +#define STTS2002_DEVID 0x0300 +#define STTS2002_DEVID_MASK 0xffff + +#define STTS3000_DEVID 0x0200 +#define STTS3000_DEVID_MASK 0xffff +static u16 jc42_hysteresis[] = {0 ,1500 ,3000 ,6000 };struct jc42_chips {
@@ -133,6 +139,8 @@ static struct jc42_chips jc42_chips[] = { NXP_MANID, SE98_DEVID, SE98_DEVID_MASK }, { STM_MANID, STTS424_DEVID, STTS424_DEVID_MASK }, { STM_MANID, STTS424E_DEVID, STTS424E_DEVID_MASK }, + { STM_MANID, STTS2002_DEVID, STTS2002_DEVID_MASK }, + { STM_MANID, STTS3000_DEVID, STTS3000_DEVID_MASK }, };/* Each client has this additional data */
@@ -171,6 +179,8 @@ static const struct i2c_device_id jc42_i { "se97b", 0 }, { "se98", 0 }, { "stts424", 0 }, + { "stts2002", 0 }, + { "stts3000", 0 }, { "tse2002b3", 0 }, { "ts3000b3", 0 }, { }
Greg KH
maintainerPATCH 78/95 hwmon: (jc42) Add support for AT30TS00, TS3000GB2, TSE2002GB2, and MCP9804
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Guenter Roeck <[email protected]>
commit 1bd612a25855f4cc9345052b53d7da697dba6358 upstream.
Also update IDT datasheet locations.
--- Documentation/hwmon/jc42 | 20 ++++++++++++++------ drivers/hwmon/Kconfig | 6 +++--- drivers/hwmon/jc42.c | 20 ++++++++++++++++++-- 3 files changed, 35 insertions(+), 11 deletions(-)
Documentation/hwmon/jc42 +14 -6
@@ -7,21 +7,29 @@ Supported chips: Addresses scanned: I2C 0x18 - 0x1f Datasheets: http://www.analog.com/static/imported-files/data_sheets/ADT7408.pdf - * IDT TSE2002B3, TS3000B3 - Prefix: 'tse2002b3', 'ts3000b3' + * Atmel AT30TS00 + Prefix: 'at30ts00' Addresses scanned: I2C 0x18 - 0x1f Datasheets: - http://www.idt.com/products/getdoc.cfm?docid=18715691 - http://www.idt.com/products/getdoc.cfm?docid=18715692 + http://www.atmel.com/Images/doc8585.pdf + * IDT TSE2002B3, TSE2002GB2, TS3000B3, TS3000GB2 + Prefix: 'tse2002', 'ts3000' + Addresses scanned: I2C 0x18 - 0x1f + Datasheets: + http://www.idt.com/sites/default/files/documents/IDT_TSE2002B3C_DST_20100512_120303152056.pdf + http://www.idt.com/sites/default/files/documents/IDT_TSE2002GB2A1_DST_20111107_120303145914.pdf + http://www.idt.com/sites/default/files/documents/IDT_TS3000B3A_DST_20101129_120303152013.pdf + http://www.idt.com/sites/default/files/documents/IDT_TS3000GB2A1_DST_20111104_120303151012.pdf * Maxim MAX6604 Prefix: 'max6604' Addresses scanned: I2C 0x18 - 0x1f Datasheets: http://datasheets.maxim-ic.com/en/ds/MAX6604.pdf - * Microchip MCP9805, MCP98242, MCP98243, MCP9843 - Prefixes: 'mcp9805', 'mcp98242', 'mcp98243', 'mcp9843' + * Microchip MCP9804, MCP9805, MCP98242, MCP98243, MCP9843 + Prefixes: 'mcp9804', 'mcp9805', 'mcp98242', 'mcp98243', 'mcp9843' Addresses scanned: I2C 0x18 - 0x1f Datasheets: + http://ww1.microchip.com/downloads/en/DeviceDoc/22203C.pdf http://ww1.microchip.com/downloads/en/DeviceDoc/21977b.pdf http://ww1.microchip.com/downloads/en/DeviceDoc/21996a.pdf http://ww1.microchip.com/downloads/en/DeviceDoc/22153c.pdf
drivers/hwmon/Kconfig +3 -3
@@ -497,9 +497,9 @@ config SENSORS_JC42 If you say yes here, you get support for JEDEC JC42.4 compliant temperature sensors, which are used on many DDR3 memory modules for mobile devices and servers. Support will include, but not be limited - to, ADT7408, CAT34TS02, CAT6095, MAX6604, MCP9805, MCP98242, MCP98243, - MCP9843, SE97, SE98, STTS424(E), STTS2002, STTS3000, TSE2002B3, and - TS3000B3. + to, ADT7408, AT30TS00, CAT34TS02, CAT6095, MAX6604, MCP9804, MCP9805, + MCP98242, MCP98243, MCP9843, SE97, SE98, STTS424(E), STTS2002, + STTS3000, TSE2002B3, TSE2002GB2, TS3000B3, and TS3000GB2. This driver can also be built as a module. If so, the module will be called jc42.
drivers/hwmon/jc42.c +18 -2
@@ -64,6 +64,7 @@ static const unsigned short normal_i2c[]/* Manufacturer IDs */ #define ADT_MANID 0x11d4/* Analog Devices */ +#define ATMEL_MANID 0x001f/* Atmel */ #define MAX_MANID 0x004d/* Maxim */ #define IDT_MANID 0x00b3/* IDT */ #define MCP_MANID 0x0054/* Microchip */
@@ -77,15 +78,25 @@ static const unsigned short normal_i2c[]#define ADT7408_DEVID 0x0801#define ADT7408_DEVID_MASK 0xffff +/* Atmel */ +#define AT30TS00_DEVID 0x8201 +#define AT30TS00_DEVID_MASK 0xffff +/* IDT */ #define TS3000B3_DEVID 0x2903/* Also matches TSE2002B3 */ #define TS3000B3_DEVID_MASK 0xffff +#define TS3000GB2_DEVID 0x2912/* Also matches TSE2002GB2 */ +#define TS3000GB2_DEVID_MASK 0xffff +/* Maxim */ #define MAX6604_DEVID 0x3e00#define MAX6604_DEVID_MASK 0xffff/* Microchip */ +#define MCP9804_DEVID 0x0200 +#define MCP9804_DEVID_MASK 0xfffc +#define MCP98242_DEVID 0x2000#define MCP98242_DEVID_MASK 0xfffc
@@ -129,8 +140,11 @@ struct jc42_chips {static struct jc42_chips jc42_chips[] = { {ADT_MANID ,ADT7408_DEVID ,ADT7408_DEVID_MASK }, + {ATMEL_MANID ,AT30TS00_DEVID ,AT30TS00_DEVID_MASK }, {IDT_MANID ,TS3000B3_DEVID ,TS3000B3_DEVID_MASK }, + {IDT_MANID ,TS3000GB2_DEVID ,TS3000GB2_DEVID_MASK }, {MAX_MANID ,MAX6604_DEVID ,MAX6604_DEVID_MASK }, + {MCP_MANID ,MCP9804_DEVID ,MCP9804_DEVID_MASK }, {MCP_MANID ,MCP98242_DEVID ,MCP98242_DEVID_MASK }, {MCP_MANID ,MCP98243_DEVID ,MCP98243_DEVID_MASK }, {MCP_MANID ,MCP9843_DEVID ,MCP9843_DEVID_MASK },
@@ -167,10 +181,12 @@ static struct jc42_data *jc42_update_devstatic const struct i2c_device_id jc42_id[] = { {"adt7408" ,0 }, + {"at30ts00" ,0 }, {"cat94ts02" ,0 }, {"cat6095" ,0 }, {"jc42" ,0 }, {"max6604" ,0 }, + {"mcp9804" ,0 }, {"mcp9805" ,0 }, {"mcp98242" ,0 }, {"mcp98243" ,0 },
@@ -181,8 +197,8 @@ static const struct i2c_device_id jc42_i { "stts424", 0 }, { "stts2002", 0 }, { "stts3000", 0 }, - { "tse2002b3", 0 }, - { "ts3000b3", 0 }, + { "tse2002", 0 }, + { "ts3000", 0 }, { } };MODULE_DEVICE_TABLE (i2c, jc42_id);
Greg KH
maintainerPATCH 79/95 hwmon: (zl6100) Maintain delay parameter in driver instance data
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Guenter Roeck <[email protected]>
commit 7ad6307ad6968ce25cecf209d4822d4c722be030 upstream.
A global delay parameter has the side effect of being overwritten with 0 if a single ZL2004 or ZL6105 is instantiated. If other chips supported by the same driver are in the system, this will result in access errors for those chips.
To solve the problem, keep a per-instance copy of the delay parameter, and do not change the original parameter.
--- drivers/hwmon/pmbus/zl6100.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/hwmon/pmbus/zl6100.c +6 -4
@@ -33,6 +33,7 @@ enum chips { zl2004, zl2006, zl2008, zl2struct zl6100_data {int id;ktime_t access;/* chip access time */ +int delay;/* Delay between chip accesses in uS */ struct pmbus_driver_info info; };
@@ -49,10 +50,10 @@ MODULE_PARM_DESC(delay, "Delay between c/* Some chips need a delay between accesses */ static inline void zl6100_wait (const struct zl6100_data *data) { -if (delay) { +if (data->delay) {s64 delta =ktime_us_delta (ktime_get (), data->access); -if (delta < delay) -udelay (delay - delta); +if (delta < data->delay) +udelay (data->delay - delta); } }
@@ -184,8 +185,9 @@ static int zl6100_probe(struct i2c_clien* can be cleared later for additional chips if tests show that it * is not needed (in other words, better be safe than sorry). */ + data->delay = delay;if (data->id == zl2004 || data->id == zl6105) - delay =0 ; + data->delay =0 ;/* * Since there was a direct I2C device access above, wait before
Greg KH
maintainerPATCH 80/95 carl9170: Fix memory accounting when sta is in power-save mode.
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Nicolas Cavallari <[email protected]>
commit 992d52529d7840236d3059b51c15d5eb9e81a869 upstream.
On Access Point mode, when transmitting a packet, if the destination station is in powersave mode, we abort transmitting the packet to the device queue, but we do not reclaim the allocated memory. Given enough packets, we can go in a state where there is no packet on the device queue, but we think the device has no memory left, so no packet gets transmitted, connections breaks and the AP stops working.
This undo the allocation done in the TX path when the station is in power-save mode.
--- drivers/net/wireless/ath/carl9170/tx.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/wireless/ath/carl9170/tx.c +1 -0
@@ -1251,6 +1251,7 @@ static bool carl9170_tx_ps_drop(struct aatomic_dec (&ar->tx_ampdu_upload); tx_info->flags |=IEEE80211_TX_STAT_TX_FILTERED ; +carl9170_release_dev_space (ar, skb);carl9170_tx_status (ar, skb, false);return true; }
Greg KH
maintainerPATCH 81/95 carl9170: fix frame delivery if sta is in powersave mode
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christian Lamparter <[email protected]>
commit 9926a67557532acb6cddb1c1add02952175b5c72 upstream.
Nicolas Cavallari discovered that carl9170 has some serious problems delivering data to sleeping stations.
It turns out that the driver was not honoring two important flags (IEEE80211_TX_CTL_POLL_RESPONSE and IEEE80211_TX_CTL_CLEAR_PS_FILT) which are set on frames that should be sent although the receiving station is still in powersave mode.
--- drivers/net/wireless/ath/carl9170/tx.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/carl9170/tx.c +5 -3
@@ -1234,6 +1234,7 @@ static bool carl9170_tx_ps_drop(struct a {struct ieee80211_sta *sta;struct carl9170_sta_info *sta_info; +struct ieee80211_tx_info *tx_info;rcu_read_lock (); sta =__carl9170_get_tx_sta (ar, skb);
@@ -1241,12 +1242,13 @@ static bool carl9170_tx_ps_drop(struct a goto out_rcu; sta_info = (void *) sta->drv_priv; -if (unlikely (sta_info->sleeping)) { -struct ieee80211_tx_info *tx_info; + tx_info =IEEE80211_SKB_CB (skb); +if (unlikely (sta_info->sleeping) && + !(tx_info->flags & (IEEE80211_TX_CTL_POLL_RESPONSE | +IEEE80211_TX_CTL_CLEAR_PS_FILT ))) {rcu_read_unlock (); - tx_info =IEEE80211_SKB_CB (skb);if (tx_info->flags &IEEE80211_TX_CTL_AMPDU )atomic_dec (&ar->tx_ampdu_upload);
Greg KH
maintainerPATCH 82/95 drm/radeon/kms: set SX_MISC in the r6xx blit code (v2)
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Marek Olšák <[email protected]>
commit cf00790dea6f210ddd01a6656da58c7c9a4ea0e4 upstream.
Mesa may set it to 1, causing all primitives to be killed.
v2: also update the r7xx code
--- drivers/gpu/drm/radeon/r600_blit_shaders.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/radeon/r600_blit_shaders.c +8 -0
@@ -314,6 +314,10 @@ const u32 r6xx_default_state[] =0x00000000 ,/* VGT_VTX_CNT_EN */ 0xc0016900 , +0x000000d4 , +0x00000000 ,/* SX_MISC */ + +0xc0016900 ,0x000002c8 , 0x00000000, /* VGT_STRMOUT_BUFFER_EN */
@@ -626,6 +630,10 @@ const u32 r7xx_default_state[] =0x00000000 ,/* VGT_VTX_CNT_EN */ 0xc0016900 , +0x000000d4 , +0x00000000 ,/* SX_MISC */ + +0xc0016900 ,0x000002c8 , 0x00000000, /* VGT_STRMOUT_BUFFER_EN */
Greg KH
maintainerPATCH 83/95 net/usbnet: avoid recursive locking in usbnet_stop()
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sebastian Siewior <[email protected]>
commit 4231d47e6fe69f061f96c98c30eaf9fb4c14b96d upstream.
|kernel BUG at kernel/rtmutex.c:724! |[<c029599c>] (rt_spin_lock_slowlock+0x108/0x2bc) from [<c01c2330>] (defer_bh+0x1c/0xb4) |[<c01c2330>] (defer_bh+0x1c/0xb4) from [<c01c3afc>] (rx_complete+0x14c/0x194) |[<c01c3afc>] (rx_complete+0x14c/0x194) from [<c01cac88>] (usb_hcd_giveback_urb+0xa0/0xf0) |[<c01cac88>] (usb_hcd_giveback_urb+0xa0/0xf0) from [<c01e1ff4>] (musb_giveback+0x34/0x40) |[<c01e1ff4>] (musb_giveback+0x34/0x40) from [<c01e2b1c>] (musb_advance_schedule+0xb4/0x1c0) |[<c01e2b1c>] (musb_advance_schedule+0xb4/0x1c0) from [<c01e2ca8>] (musb_cleanup_urb.isra.9+0x80/0x8c) |[<c01e2ca8>] (musb_cleanup_urb.isra.9+0x80/0x8c) from [<c01e2ed0>] (musb_urb_dequeue+0xec/0x108) |[<c01e2ed0>] (musb_urb_dequeue+0xec/0x108) from [<c01cbb90>] (unlink1+0xbc/0xcc) |[<c01cbb90>] (unlink1+0xbc/0xcc) from [<c01cc2ec>] (usb_hcd_unlink_urb+0x54/0xa8) |[<c01cc2ec>] (usb_hcd_unlink_urb+0x54/0xa8) from [<c01c2a84>] (unlink_urbs.isra.17+0x2c/0x58) |[<c01c2a84>] (unlink_urbs.isra.17+0x2c/0x58) from [<c01c2b44>] (usbnet_terminate_urbs+0x94/0x10c) |[<c01c2b44>] (usbnet_terminate_urbs+0x94/0x10c) from [<c01c2d68>] (usbnet_stop+0x100/0x15c) |[<c01c2d68>] (usbnet_stop+0x100/0x15c) from [<c020f718>] (__dev_close_many+0x94/0xc8)
defer_bh() takes the lock which is hold during unlink_urbs(). The safe walk suggest that the skb will be removed from the list and this is done by defer_bh() so it seems to be okay to drop the lock here.
--- drivers/net/usb/usbnet.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/usb/usbnet.c +2 -0
@@ -589,6 +589,7 @@ static int unlink_urbs (struct usbnet *d entry = (struct skb_data *) skb->cb; urb = entry->urb; +spin_unlock_irqrestore (&q->lock, flags);// during some PM-driven resume scenarios, // these (async) unlinks complete immediately retval =usb_unlink_urb (urb);
@@ -596,6 +597,7 @@ static int unlink_urbs (struct usbnet *dnetdev_dbg (dev->net,"unlink urb err, %d\n" , retval); else count++; +spin_lock_irqsave (&q->lock, flags); }spin_unlock_irqrestore (&q->lock, flags);return count;
Greg KH
maintainerPATCH 84/95 x86/amd: iommu_set_device_table() must not be __init
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jan Beulich <[email protected]>
commit 6b7f000eb6a0b81d7a809833edb7a457eedf8512 upstream.
This function is called from enable_iommus(), which in turn is used from amd_iommu_resume().
--- drivers/iommu/amd_iommu_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/amd_iommu_init.c +1 -1
@@ -268,7 +268,7 @@ static void iommu_set_exclusion_range(st }/* Programs the physical address of the device table into the IOMMU hardware */ -static void __init iommu_set_device_table (struct amd_iommu *iommu) +static void iommu_set_device_table (struct amd_iommu *iommu) {u64 entry;
Greg KH
maintainerPATCH 85/95 dm ioctl: do not leak argv if target message only contains whitespace
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jesper Juhl <[email protected]>
commit 902c6a96a7cb9c50d2a8aed1788efad0a5d8f04c upstream.
If 'argc' is zero we jump to the 'out:' label, but this leaks the (unused) memory that 'dm_split_args()' allocated for 'argv' if the string being split consisted entirely of whitespace. Jump to the 'out_argv:' label instead to free up that memory.
--- drivers/md/dm-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/dm-ioctl.c +1 -1
@@ -1437,7 +1437,7 @@ static int target_message(struct dm_ioctif (!argc) {DMWARN ("Empty message received." ); - goto out; + goto out_argv; } table =dm_get_live_table (md);
Greg KH
maintainerPATCH 86/95 dm io: fix discard support
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Milan Broz <[email protected]>
commit 0c535e0d6f463365c29623350dbd91642363c39b upstream.
This patch fixes a crash by recognising discards in dm_io.
Currently dm_mirror can send REQ_DISCARD bios if running over a discard-enabled device and without support in dm_io the system crashes badly.
BUG: unable to handle kernel paging request at 00800000 IP: __bio_add_page.part.17+0xf5/0x1e0 ... bio_add_page+0x56/0x70 dispatch_io+0x1cf/0x240 [dm_mod] ? km_get_page+0x50/0x50 [dm_mod] ? vm_next_page+0x20/0x20 [dm_mod] ? mirror_flush+0x130/0x130 [dm_mirror] dm_io+0xdc/0x2b0 [dm_mod]
...
Introduced in 2.6.38-rc1 by commit 5fc2ffeabb9ee0fc0e71ff16b49f34f0ed3d05b4 (dm raid1: support discard).
--- drivers/md/dm-io.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-)
drivers/md/dm-io.c +16 -7
@@ -296,6 +296,8 @@ static void do_region(int rw, unsigned runsigned offset;unsigned num_bvecs;sector_t remaining = where->count; +struct request_queue *q =bdev_get_queue (where->bdev); +sector_t discard_sectors;/* * where->count may be zero if rw holds a flush and we need to
@@ -305,9 +307,12 @@ static void do_region(int rw, unsigned r/* * Allocate a suitably sized-bio. */ - num_bvecs =dm_sector_div_up (remaining, - (PAGE_SIZE >>SECTOR_SHIFT )); - num_bvecs =min_t (int,bio_get_nr_vecs (where->bdev), num_bvecs); +if (rw &REQ_DISCARD ) + num_bvecs =1 ; +else + num_bvecs =min_t (int,bio_get_nr_vecs (where->bdev), +dm_sector_div_up (remaining, (PAGE_SIZE >>SECTOR_SHIFT ))); + bio =bio_alloc_bioset (GFP_NOIO , num_bvecs, io->client->bios); bio->bi_sector = where->sector + (where->count - remaining); bio->bi_bdev = where->bdev;
@@ -315,10 +320,14 @@ static void do_region(int rw, unsigned r bio->bi_destructor = dm_bio_destructor;store_io_and_region_in_bio (bio, io, region); -/* -* Try and add as many pages as possible. -*/ -while (remaining) { +if (rw &REQ_DISCARD ) { + discard_sectors =min_t (sector_t, q->limits.max_discard_sectors, remaining); + bio->bi_size = discard_sectors <<SECTOR_SHIFT ; + remaining -= discard_sectors; + }else while (remaining) { +/* +* Try and add as many pages as possible. +*/ dp->get_page (dp, &page, &len, &offset); len =min (len,to_bytes (remaining));if (!bio_add_page (bio, page, len, offset))
Greg KH
maintainerPATCH 87/95 dm flakey: fix crash on read when corrupt_bio_byte not set
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mike Snitzer <[email protected]>
commit 1212268fd9816e3b8801e57b896fceaec71969ad upstream.
The following BUG is hit on the first read that is submitted to a dm flakey test device while the device is "down" if the corrupt_bio_byte feature wasn't requested when the device's table was loaded.
Example DM table that will hit this BUG:
0 2097152 flakey 8:0 2048 0 30
This bug was introduced by commit a3998799fb4df0b0af8271a7d50c4269032397aa (dm flakey: add corrupt_bio_byte feature) in v3.1-rc1.
BUG: unable to handle kernel paging request at ffff8801cfce3fff IP: [<ffffffffa008c233>] corrupt_bio_data+0x6e/0xae [dm_flakey] PGD 1606063 PUD 0 Oops: 0002 [#1] SMP ... Call Trace: <IRQ> [<ffffffffa008c2b5>] flakey_end_io+0x42/0x48 [dm_flakey] [<ffffffffa00dca98>] clone_endio+0x54/0xb6 [dm_mod] [<ffffffff81130587>] bio_endio+0x2d/0x2f [<ffffffff811c819a>] req_bio_endio+0x96/0x9f [<ffffffff811c94b9>] blk_update_request+0x1dc/0x3a9 [<ffffffff812f5ee2>] ? rcu_read_unlock+0x21/0x23 [<ffffffff811c96a6>] blk_update_bidi_request+0x20/0x6e [<ffffffff811c9713>] blk_end_bidi_request+0x1f/0x5d [<ffffffff811c978d>] blk_end_request+0x10/0x12 [<ffffffff8128f450>] scsi_io_completion+0x1e5/0x4b1 [<ffffffff812882a9>] scsi_finish_command+0xec/0xf5 [<ffffffff8128f830>] scsi_softirq_done+0xff/0x108 [<ffffffff811ce284>] blk_done_softirq+0x84/0x98 [<ffffffff81048d19>] __do_softirq+0xe3/0x1d5 [<ffffffff8138f83f>] ? _raw_spin_lock+0x62/0x69 [<ffffffff810997cf>] ? handle_irq_event+0x4c/0x61 [<ffffffff8139833c>] call_softirq+0x1c/0x30 [<ffffffff81003b37>] do_softirq+0x4b/0xa3 [<ffffffff81048a39>] irq_exit+0x53/0xca [<ffffffff81398acd>] do_IRQ+0x9d/0xb4 [<ffffffff81390333>] common_interrupt+0x73/0x73
...
--- drivers/md/dm-flakey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/dm-flakey.c +1 -1
@@ -323,7 +323,7 @@ static int flakey_end_io(struct dm_targe* Corrupt successful READs while in down state. * If flags were specified, only corrupt those that match. */ -if (!error && bio_submitted_while_down && +if (fc->corrupt_bio_byte && !error && bio_submitted_while_down && (bio_data_dir (bio) ==READ ) && (fc->corrupt_bio_rw ==READ ) &&all_corrupt_bio_flags_match (bio, fc))corrupt_bio_data (bio, fc);
Greg KH
maintainerPATCH 88/95 dm thin metadata: remove incorrect close_device on creation error paths
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mike Snitzer <[email protected]>
commit 1f3db25d8be4ac50b897b39609802183ea68a514 upstream.
The __open_device() error paths in __create_thin() and __create_snap() incorrectly call __close_device() even if td was not initialized by __open_device(). Remove this.
Also document __open_device() return values, remove a redundant td->changed = 1 in __create_thin(), and insert an additional safeguard against creating an already-existing device.
--- drivers/md/dm-thin-metadata.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-)
drivers/md/dm-thin-metadata.c +17 -5
@@ -789,6 +789,11 @@ int dm_pool_metadata_close(struct dm_pooreturn 0 ; } +/* +* __open_device: Returns @td corresponding to device with id @dev, +* creating it if @create is set and incrementing @td->open_count. +* On failure, @td is undefined. +*/ static int __open_device (struct dm_pool_metadata *pmd,dm_thin_id dev,int create,struct dm_thin_device **td)
@@ -799,10 +804,16 @@ static int __open_device(struct dm_pool_struct disk_device_details details_le;/* -* Check the device isn't already open. +* If the device is already open, return it. */ list_for_each_entry (td2, &pmd->thin_devices, list)if (td2->id == dev) { +/* +* May not create an already-open device. +*/ +if (create) +return -EEXIST ; + td2->open_count++; *td = td2;return 0 ;
@@ -817,6 +828,9 @@ static int __open_device(struct dm_pool_if (r != -ENODATA || !create)return r; +/* +* Create new device. +*/ changed =1 ; details_le.mapped_blocks =0 ; details_le.transaction_id =cpu_to_le64 (pmd->trans_id);
@@ -882,12 +896,10 @@ static int __create_thin(struct dm_pool_ r =__open_device (pmd, dev,1 , &td);if (r) { -__close_device (td);dm_btree_remove (&pmd->tl_info, pmd->root, &key, &pmd->root);dm_btree_del (&pmd->bl_info, dev_root);return r; } - td->changed =1 ;__close_device (td);return r;
@@ -967,14 +979,14 @@ static int __create_snap(struct dm_pool_ goto bad; r =__set_snapshot_details (pmd, td, origin, pmd->time); +__close_device (td); +if (r) goto bad; -__close_device (td);return 0 ; bad: -__close_device (td);dm_btree_remove (&pmd->tl_info, pmd->root, &key, &pmd->root);dm_btree_remove (&pmd->details_info, pmd->details_root, &key, &pmd->details_root);
Greg KH
maintainerPATCH 89/95 dm thin metadata: unlock superblock in init_pmd error path
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Joe Thornber <[email protected]>
commit 4469a5f387fdde956894137751a41473618a4a52 upstream.
If dm_sm_disk_create() fails the superblock must be unlocked.
--- drivers/md/dm-thin-metadata.c | 1 + 1 file changed, 1 insertion(+)
drivers/md/dm-thin-metadata.c +1 -0
@@ -385,6 +385,7 @@ static int init_pmd(struct dm_pool_metad data_sm =dm_sm_disk_create (tm, nr_blocks);if (IS_ERR (data_sm)) {DMERR ("sm_disk_create failed" ); +dm_tm_unlock (tm, sblock); r =PTR_ERR (data_sm); goto bad; }
Greg KH
maintainerPATCH 90/95 dm thin metadata: decrement counter after removing mapped block
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Joe Thornber <[email protected]>
commit af63bcb817cf708f53bcae6edc2e3fb7dd7d8051 upstream.
Correct the number of mapped sectors shown on a thin device's status line by decrementing td->mapped_blocks in __remove() each time a block is removed.
--- drivers/md/dm-thin-metadata.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/md/dm-thin-metadata.c +2 -0
@@ -1224,6 +1224,8 @@ static int __remove(struct dm_thin_devicif (r)return r; + td->mapped_blocks--; + td->changed =1 ; pmd->need_commit =1 ;return 0 ;
Greg KH
maintainerPATCH 91/95 dm raid: set MD_CHANGE_DEVS when rebuilding
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jonathan E Brassow <[email protected]>
commit 3aa3b2b2b1edb813dc5342d0108befc39541542d upstream.
The 'rebuild' parameter is used to rebuild individual devices in an array (e.g. resynchronize a RAID1 device or recalculate a parity device in higher RAID). The MD_CHANGE_DEVS flag must be set when this parameter is given in order to write out the superblocks and make the change take immediate effect. The code that handles new devices in super_load already sets MD_CHANGE_DEVS and 'FirstUse'. (The 'FirstUse' flag was being set as a special case for rebuilds in super_init_validation.)
Add a condition for rebuilds in super_load to take care of both flags without the special case in 'super_init_validation'.
--- drivers/md/dm-raid.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/md/dm-raid.c +10 -6
@@ -667,7 +667,14 @@ static int super_load(struct md_rdev *rdreturn ret; sb =page_address (rdev->sb_page); -if (sb->magic !=cpu_to_le32 (DM_RAID_MAGIC )) { + +/* +* Two cases that we want to write new superblocks and rebuild: +* 1) New device (no matching magic number) +* 2) Device specified for rebuild (!In_sync w/ offset == 0) +*/ +if ((sb->magic !=cpu_to_le32 (DM_RAID_MAGIC )) || + (!test_bit (In_sync, &rdev->flags) && !rdev->recovery_offset)) {super_sync (rdev->mddev, rdev);set_bit (FirstUse, &rdev->flags);
@@ -744,11 +751,8 @@ static int super_init_validation(struct*/ rdev_for_each (r, t, mddev) {if (!test_bit (In_sync, &r->flags)) { -if (!test_bit (FirstUse, &r->flags)) -DMERR ("Superblock area of " -"rebuild device %d should have been " -"cleared." , r->raid_disk); -set_bit (FirstUse, &r->flags); +DMINFO ("Device %d specified for rebuild: " +"Clearing superblock" , r->raid_disk); rebuilds++; }else if (test_bit (FirstUse, &r->flags)) new_devs++;
Greg KH
maintainerPATCH 92/95 dm raid: fix flush support
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jonathan E Brassow <[email protected]>
commit 0ca93de9b789e0eb05e103f0c04de72df13da73a upstream.
Fix dm-raid flush support.
Both md and dm have support for flush, but the dm-raid target forgot to set the flag to indicate that flushes should be passed on. (Important for data integrity e.g. with writeback cache enabled.)
--- drivers/md/dm-raid.c | 1 + 1 file changed, 1 insertion(+)
drivers/md/dm-raid.c +1 -0
@@ -974,6 +974,7 @@ static int raid_ctr(struct dm_target *tiINIT_WORK (&rs->md.event_work, do_table_event); ti->private = rs; + ti->num_flush_requests =1 ;mutex_lock (&rs->md.reconfig_mutex); ret =md_run (&rs->md);
Greg KH
maintainerPATCH 93/95 cs5535-mfgpt: dont call __init function from __devinit
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Danny Kukawka <[email protected]>
commit 474de3bbadd9cb75ffc32cc759c40d868343d46c upstream.
Fix scan_timers() to be __devinit and not __init since the function get called from cs5535_mfgpt_probe which is __devinit.
--- drivers/misc/cs5535-mfgpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/cs5535-mfgpt.c +1 -1
@@ -262,7 +262,7 @@ static void __init reset_all_timers(void* In other cases (such as with VSAless OpenFirmware), the system firmware * leaves timers available for us to use. */ -static int __init scan_timers (struct cs5535_mfgpt_chip *mfgpt) +static int __devinit scan_timers (struct cs5535_mfgpt_chip *mfgpt) {struct cs5535_mfgpt_timer timer = { .chip = mfgpt };unsigned long flags;
Greg KH
maintainerPATCH 94/95 mfd: Fix cs5535 section mismatch
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christian Gmeiner <[email protected]>
commit 97e43c983c721a47546e6db3b7711dcd912a6481 upstream.
Silence following warnings:
WARNING: drivers/mfd/cs5535-mfd.o(.data+0x20): Section mismatch in reference from the variable cs5535_mfd_drv to the function .devinit.text:cs5535_mfd_probe()
The variable cs5535_mfd_drv references
the function __devinit cs5535_mfd_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
WARNING: drivers/mfd/cs5535-mfd.o(.data+0x28): Section mismatch in reference from the variable cs5535_mfd_drv to the function .devexit.text:cs5535_mfd_remove()
The variable cs5535_mfd_drv references
the function __devexit cs5535_mfd_remove()
If the reference is valid then annotate the
variable with __exit* (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
Rename the variable from *_drv to *_driver so modpost ignore the OK references to __devinit/__devexit functions.
--- drivers/mfd/cs5535-mfd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/mfd/cs5535-mfd.c +3 -3
@@ -179,7 +179,7 @@ static struct pci_device_id cs5535_mfd_p };MODULE_DEVICE_TABLE (pci, cs5535_mfd_pci_tbl); -static struct pci_driver cs5535_mfd_drv = { +static struct pci_driver cs5535_mfd_driver = { .name =DRV_NAME , .id_table = cs5535_mfd_pci_tbl, .probe = cs5535_mfd_probe,
@@ -188,12 +188,12 @@ static struct pci_driver cs5535_mfd_drvstatic int __init cs5535_mfd_init (void ) { -return pci_register_driver (&cs5535_mfd_drv); +return pci_register_driver (&cs5535_mfd_driver); } static void __exit cs5535_mfd_exit(void) { -pci_unregister_driver (&cs5535_mfd_drv); +pci_unregister_driver (&cs5535_mfd_driver); }module_init (cs5535_mfd_init);
Greg KH
maintainerPATCH 95/95 spi-topcliff-pch: rename pch_spi_pcidev to pch_spi_pcidev_driver
In reply to Greg KH3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Danny Kukawka <[email protected]>
commit c88db233251b026fda775428f0250c760553e216 upstream.
Rename static struct pci_driver pch_spi_pcidev to pch_spi_pcidev_driver to get rid of warnings from modpost checks.
--- drivers/spi/spi-topcliff-pch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/spi/spi-topcliff-pch.c +3 -3
@@ -1717,7 +1717,7 @@ static int pch_spi_resume(struct pci_dev#endif -static struct pci_driver pch_spi_pcidev = { +static struct pci_driver pch_spi_pcidev_driver = { .name ="pch_spi" , .id_table = pch_spi_pcidev_id, .probe = pch_spi_probe,
@@ -1733,7 +1733,7 @@ static int __init pch_spi_init(void)if (ret)return ret; - ret =pci_register_driver (&pch_spi_pcidev); + ret =pci_register_driver (&pch_spi_pcidev_driver);if (ret)return ret;
@@ -1743,7 +1743,7 @@ module_init(pch_spi_init); static void __exit pch_spi_exit(void) { -pci_unregister_driver (&pch_spi_pcidev); +pci_unregister_driver (&pch_spi_pcidev_driver);platform_driver_unregister (&pch_spi_pd_driver); }module_exit (pch_spi_exit);