Skip to contentSkip to conversation

ASoC: dmaengine_pcm: Reset pointer position when starting a stream

PATCH Applied Lars-Peter Clausen 3 participants 6 messages Mar 5, 2012 – Mar 12, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ASoC: dmaengine_pcm: Reset pointer position when starting a stream

From: Mika Westerberg <[email protected]>

Otherwise a wrong position will be reported after restarting a stream and the first few samples might be skipped.

---
 sound/soc/soc-dmaengine-pcm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/soc-dmaengine-pcm.c +1 -0
index 0526cf8..4420b70 100644
@@ -142,6 +142,7 @@ static int dmaengine_pcm_prepare_and_submit(struct snd_pcm_substream *substream)
 
 	direction = snd_pcm_substream_to_dma_direction(substream);
 
+	prtd->pos = 0;
 	desc = chan->device->device_prep_dma_cyclic(chan,
 		substream->runtime->dma_addr,
 		snd_pcm_lib_buffer_bytes(substream),
Signature · 1 line
1.7.9.1
#1 lore raw

PATCH 2/2 ASoC: ep93xx-pcm: Use dmaengine PCM helper functions

---
 sound/soc/ep93xx/Kconfig      |    1 +
 sound/soc/ep93xx/ep93xx-pcm.c |  148 ++++++-----------------------------------
 2 files changed, 23 insertions(+), 126 deletions(-)
sound/soc/ep93xx/Kconfig +1 -0
index 91a28de..88143db 100644
@@ -1,6 +1,7 @@
 config SND_EP93XX_SOC
 	tristate "SoC Audio support for the Cirrus Logic EP93xx series"
 	depends on ARCH_EP93XX && SND_SOC
+	select SND_SOC_DMAENGINE_PCM
 	help
 	  Say Y or M if you want to add support for codecs attached to
 	  the EP93xx I2S or AC97 interfaces.
sound/soc/ep93xx/ep93xx-pcm.c +22 -126

201 lines not on this page · raw message

Signature · 1 line
1.7.9.1
#3 lore raw
Quoted 9 lines · Mark Brown
Quoted 6 lines · Lars-Peter Clausen

From: Mika Westerberg <[email protected]>

Otherwise a wrong position will be reported after restarting a stream and the first few samples might be skipped.

I can't apply this without a signoff from Mika.

Mika, can we get your sign off for this patch?

Thanks,
- Lars

#4 lore raw
Quoted 4 lines · Lars-Peter Clausen
Quoted 3 lines · Mark Brown
Quoted 2 lines · Lars-Peter Clausen

From: Mika Westerberg <[email protected]>

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

Otherwise a wrong position will be reported after restarting a stream and the first few samples might be skipped.

I can't apply this without a signoff from Mika.

Mika, can we get your sign off for this patch?

Sorry for the delay, I've been travelling. Here it is