i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
A message that is not in the archive (sent off-list or not yet received): http://lists.denx.de/pipermail/u-boot/2012-March/#119207
PATCH v3 1/1 i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
This is needed to support Freescale-supplied userspaces.
At the moment, both the IPU and VPU libraries provided by Freescale in the "imx-lib" package contain routines which scrape the system revision from /proc/cpuinfo. In the VPU library, this information is used to load the proper firmware, allowing a single binary to be used across various i.MX processors.
V3 removes the conditional surrounding get_board_rev() as requested by Marek.
--- board/freescale/mx6qsabrelite/mx6qsabrelite.c | 5 +++++ include/configs/mx6qsabrelite.h | 1 + 2 files changed, 6 insertions(+), 0 deletions(-)
board/freescale/mx6qsabrelite/mx6qsabrelite.c +5 -0
@@ -215,6 +215,11 @@ int board_mmc_init(bd_t *bis) }#endif +u32 get_board_rev (void ) +{ +return 0x63000 ; +} +#ifdef CONFIG_MXC_SPI iomux_v3_cfg_t ecspi1_pads[] = { /* SS1 */
include/configs/mx6qsabrelite.h +1 -0
@@ -33,6 +33,7 @@#define CONFIG_CMDLINE_TAG #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_INITRD_TAG +#define CONFIG_REVISION_TAG /* Size of malloc() pool */ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 2 * 1024 * 1024)
Signature · 1 line
1.7.9
PATCH v3 1/1 i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
Dear Eric Nelson,
Quoted 10 lines
This is needed to support Freescale-supplied userspaces.
At the moment, both the IPU and VPU libraries provided by Freescale in the "imx-lib" package contain routines which scrape the system revision from
/proc/cpuinfo. In the VPU library, this information is used to load the proper firmware, allowing a single binary to be used across various i.MX processors.V3 removes the conditional surrounding
get_board_rev()as requested by Marek.
Best regards,
Marek Vasut
PATCH v3 1/1 i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
In reply to Eric NelsonQuoted 8 lines · Eric Nelson
This is needed to support Freescale-supplied userspaces.
At the moment, both the IPU and VPU libraries provided by Freescale in the "imx-lib" package contain routines which scrape the system revision from
/proc/cpuinfo. In the VPU library, this information is used to load the proper firmware, allowing a single binary to be used across various i.MX processors.
Hi Eric,
Quoted 2 lines
V3 removes the conditional surrounding
get_board_rev()as requested by Marek.
This lines are your changelog and should be not in the commit message. They must be after the "---" line.
Quoted 28 lines
Signed-off-by Eric Nelson <[email protected]>--- board/freescale/mx6qsabrelite/mx6qsabrelite.c | 5 +++++ include/configs/mx6qsabrelite.h | 1 + 2 files changed, 6 insertions(+), 0 deletions(-)board/freescale/mx6qsabrelite/mx6qsabrelite.c +5
-0@@ -215,6 +215,11 @@ int board_mmc_init(bd_t *bis) }#endif +u32 get_board_rev (void ) +{ +return 0x63000 ; +} +#ifdef CONFIG_MXC_SPI iomux_v3_cfg_t ecspi1_pads[] = { /* SS1 */include/configs/mx6qsabrelite.h +0
-0
include/configs/mx6qsabrelite.h line 39
Quoted 7 lines
include/configs/mx6qsabrelite.h +1
-0@@ -33,6 +33,7 @@#define CONFIG_CMDLINE_TAG #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_INITRD_TAG +#define CONFIG_REVISION_TAG /* Size of malloc() pool */ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 2 * 1024 * 1024)
Apart of that:
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH v3 1/1 i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
Quoted 10 lines · Stefano Babic
Quoted 8 lines · Eric Nelson
This is needed to support Freescale-supplied userspaces.
At the moment, both the IPU and VPU libraries provided by Freescale in the "imx-lib" package contain routines which scrape the system revision from
/proc/cpuinfo. In the VPU library, this information is used to load the proper firmware, allowing a single binary to be used across various i.MX processors.
Quoted 9 lines
Hi Eric,
Quoted 2 lines
V3 removes the conditional surrounding
get_board_rev()as requested by Marek.This lines are your changelog and should be not in the commit message. They must be after the "---" line.
Thanks Stefano,
Do you want me to re-send?
PATCH v3 1/1 i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
Quoted 3 lines · Eric Nelson
Thanks Stefano,
Do you want me to re-send?
No, sorry, you do not need it - I fix it myself.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH v3 1/1 i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
In reply to Eric NelsonQuoted 8 lines · Eric Nelson
This is needed to support Freescale-supplied userspaces.
At the moment, both the IPU and VPU libraries provided by Freescale in the "imx-lib" package contain routines which scrape the system revision from
/proc/cpuinfo. In the VPU library, this information is used to load the proper firmware, allowing a single binary to be used across various i.MX processors.
Quoted 5 lines
V3 removes the conditional surrounding
get_board_rev()as requested by Marek.Signed-off-by Eric Nelson <[email protected]>---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================