fbdump: Make fbdump available only to x86/x86_64/arm architectures

PATCH New Markos Chandras 2 participants 8 messages Mar 14, 2012

Share & tools

Markos Chandras

author

2012-03-14 10:02 UTC #0 lore raw

PATCH 1/1 fbdump: Make fbdump available only to x86/x86_64/arm architectures

fbdump uses the ioperm() syscall which is only implemented in x86/x86_64. The rest of the architectures map ioperm() to sys_ni_syscall which is the default function for the unimplemented syscalls. Moreover, ARM has its own ioperm() implementation in uClibc.

Signed-off-by Markos Chandras <[email protected]>

---
 package/fbdump/Config.in |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

package/fbdump/Config.in +2 -1

index fb4aee6..2f8040f 100644
@@ -1,3 +1,4 @@
+if BR2_i386 || BR2_x86_64 || BR2_arm
 config BR2_PACKAGE_FBDUMP
 	bool "fbdump (Framebuffer Capture Tool)"
 	help

@@ -5,4 +6,4 @@ config BR2_PACKAGE_FBDUMP
 	  framebuffer  device and write them out as a PPM file. Currently,
 	  most packed-pixel framebuffer formats and the vga16 framebuffer
 	  are supported.
-
+endif

Signature · 1 line

1.7.1

Thomas Petazzoni

2012-03-14 10:37 UTC #1 lore raw

PATCH 1/1 fbdump: Make fbdump available only to x86/x86_64/arm architectures

Hello,

Le Wed, 14 Mar 2012 10:02:14 +0000,
Markos Chandras <[email protected]> a ?crit :

Quoted 5 lines

fbdump uses the ioperm() syscall which is only implemented in x86/x86_64. The rest of the architectures map ioperm() to sys_ni_syscall which is the default function for the unimplemented syscalls. Moreover, ARM has its own ioperm() implementation in uClibc.

Is ioperm() on ARM only available if uClibc is used, and not when glibc is used?

Quoted 10 lines

package/fbdump/Config.in +1 -0

index fb4aee6..2f8040f 100644
@@ -1,3 +1,4 @@
+if BR2_i386 || BR2_x86_64 || BR2_arm
 config BR2_PACKAGE_FBDUMP
 	bool "fbdump (Framebuffer Capture Tool)"
 	help

package/fbdump/Config.in config BR2_PACKAGE_FBDUMP · line 9

Quoted 5 lines

package/fbdump/Config.in +1 -1

@@ -5,4 +6,4 @@ config BR2_PACKAGE_FBDUMP
 	  framebuffer  device and write them out as a PPM file. Currently,
 	  most packed-pixel framebuffer formats and the vga16 framebuffer
 	  are supported.
-
+endif

I would prefer:

config BR2_PACKAGE_FBDUMP

	bool "fbdump (Framebuffer Capture Tool)"
	depends on BR_i386 || BR2_x86_64 || BR2_arm

because that's what we do for all other packages.

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Markos Chandras

author

2012-03-14 10:43 UTC #2 lore raw

PATCH 1/1 fbdump: Make fbdump available only to x86/x86_64/arm architectures

Quoted 32 lines · Thomas Petazzoni

Hello,
Le Wed, 14 Mar 2012 10:02:14 +0000,
Markos Chandras <[email protected]> a ?crit :
Quoted 5 lines
fbdump uses the ioperm() syscall which is only implemented in x86/x86_64. The rest of the architectures map ioperm() to sys_ni_syscall which is the default function for the unimplemented syscalls. Moreover, ARM has its own ioperm() implementation in uClibc.
Is ioperm() on ARM only available if uClibc is used, and not when glibc is used?
Quoted 10 lines
package/fbdump/Config.in +1 -0
index fb4aee6..2f8040f 100644
@@ -1,3 +1,4 @@
+if BR2_i386 || BR2_x86_64 || BR2_arm
 config BR2_PACKAGE_FBDUMP
 	bool "fbdump (Framebuffer Capture Tool)"
 	help
package/fbdump/Config.in config BR2_PACKAGE_FBDUMP · line 9
Quoted 5 lines
package/fbdump/Config.in +1 -1
@@ -5,4 +6,4 @@ config BR2_PACKAGE_FBDUMP
 	  framebuffer  device and write them out as a PPM file. Currently,
 	  most packed-pixel framebuffer formats and the vga16 framebuffer
 	  are supported.
-
+endif
I would prefer:

Quoted 7 lines

config BR2_PACKAGE_FBDUMP
	bool "fbdump (Framebuffer Capture Tool)"
	depends on BR_i386 || BR2_x86_64 || BR2_arm
because that's what we do for all other packages.
Thomas

Hi Thomas,

Thanks for your suggestion. I fixed and resent my patch.

Signature · 1 line

markos

Thomas Petazzoni

2012-03-14 11:02 UTC #3 lore raw

PATCH 1/1 fbdump: Make fbdump available only to x86/x86_64/arm architectures

Le Wed, 14 Mar 2012 10:43:17 +0000,
Markos Chandras <[email protected]> a ?crit :

Quoted 1 line

Thanks for your suggestion. I fixed and resent my patch.

And what about my question about ioperm() on ARM?

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Markos Chandras

author

2012-03-14 11:33 UTC #4 lore raw

PATCH 1/1 fbdump: Make fbdump available only to x86/x86_64/arm architectures

Quoted 8 lines · Thomas Petazzoni

Le Wed, 14 Mar 2012 10:43:17 +0000,
Markos Chandras <[email protected]> a ?crit :
Quoted 1 line
Thanks for your suggestion. I fixed and resent my patch.
And what about my question about ioperm() on ARM?
Thomas

Sorry I overlooked your question. Yes it seems this is the case. I didn't actually test that but I grep'd the glibc git tree and I see that it is not defined for ARM.

Signature · 1 line

markos

Markos Chandras

author

2012-03-14 11:48 UTC #5 lore raw

PATCH 1/1 fbdump: Make fbdump available only to x86/x86_64/arm architectures

In reply to Thomas Petazzoni

Quoted 8 lines · Thomas Petazzoni

Le Wed, 14 Mar 2012 10:43:17 +0000,
Markos Chandras <[email protected]> a ?crit :
Quoted 1 line
Thanks for your suggestion. I fixed and resent my patch.
And what about my question about ioperm() on ARM?
Thomas

Actually I don't think glibc supports ARM at all. From glibc's README file

"The GNU C Library supports these configurations for using Linux kernels:

    i[34567]86-*-linux-gnu
    x86_64-*-linux-gnu
    powerpc-*-linux-gnu
    powerpc64-*-linux-gnu
    s390-*-linux-gnu
    s390x-*-linux-gnu
    ia64-*-linux-gnu
    sparc*-*-linux-gnu
    sparc64*-*-linux-gnu"

Signature · 1 line

markos

Thomas Petazzoni

2012-03-14 11:55 UTC #6 lore raw

PATCH 1/1 fbdump: Make fbdump available only to x86/x86_64/arm architectures

Le Wed, 14 Mar 2012 11:48:45 +0000,
Markos Chandras <[email protected]> a ?crit :

Quoted 4 lines

Actually I don't think glibc supports ARM at all. From glibc's README file
"The GNU C Library supports these configurations for using Linux kernels:

Quoted 9 lines

    i[34567]86-*-linux-gnu
    x86_64-*-linux-gnu
    powerpc-*-linux-gnu
    powerpc64-*-linux-gnu
    s390-*-linux-gnu
    s390x-*-linux-gnu
    ia64-*-linux-gnu
    sparc*-*-linux-gnu
    sparc64*-*-linux-gnu"

It might be in glibc-ports, so that's why you don't see it in the main glibc README. But definitely, glibc runs on ARM, PowerPC. Millions of devices are using it as we are speaking :-)

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Markos Chandras

author

2012-03-14 13:56 UTC #7 lore raw

PATCH 1/1 fbdump: Make fbdump available only to x86/x86_64/arm architectures

Quoted 17 lines · Thomas Petazzoni

Le Wed, 14 Mar 2012 11:48:45 +0000,
Markos Chandras <[email protected]> a ?crit :
Quoted 4 lines
Actually I don't think glibc supports ARM at all. From glibc's README file
"The GNU C Library supports these configurations for using Linux kernels:
Quoted 9 lines
    i[34567]86-*-linux-gnu
    x86_64-*-linux-gnu
    powerpc-*-linux-gnu
    powerpc64-*-linux-gnu
    s390-*-linux-gnu
    s390x-*-linux-gnu
    ia64-*-linux-gnu
    sparc*-*-linux-gnu
    sparc64*-*-linux-gnu"

Quoted 5 lines

It might be in glibc-ports, so that's why you don't see it in the main glibc README. But definitely, glibc runs on ARM, PowerPC. Millions of devices are using it as we are speaking :-)
Thomas

Yeah I was talking for the official glibc git tree. I have no idea if this function is supported in glibc-ports or not.

Signature · 1 line

markos