Skip to contentSkip to conversation

usb: xhci: fix section mismatch in linux-next

PATCH In review Gerard Snitselaar 2 participants 3 messages Mar 16, 2012 – Mar 17, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: xhci: fix section mismatch in linux-next

xhci_unregister_pci() is called in xhci_hcd_init().

---
 drivers/usb/host/xhci-pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/xhci-pci.c +1 -1
index ef98b38..0d7b851 100644
@@ -326,7 +326,7 @@ int __init xhci_register_pci(void)
 	return pci_register_driver(&xhci_pci_driver);
 }
 
-void __exit xhci_unregister_pci(void)
+void xhci_unregister_pci(void)
 {
 	pci_unregister_driver(&xhci_pci_driver);
 }
Signature · 1 line
1.7.7.6
#1 lore raw

This looks fine. Does it need to be applied to stable as well, or is this just a "nice to have" that should be queued for 3.4?

Sarah Sharp

Quoted 23 lines · Gerard Snitselaar

xhci_unregister_pci() is called in xhci_hcd_init().

---
 drivers/usb/host/xhci-pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/xhci-pci.c +1 -1
index ef98b38..0d7b851 100644
@@ -326,7 +326,7 @@ int __init xhci_register_pci(void)
 	return pci_register_driver(&xhci_pci_driver);
 }
 
-void __exit xhci_unregister_pci(void)
+void xhci_unregister_pci(void)
 {
 	pci_unregister_driver(&xhci_pci_driver);
 }
Signature · 1 line
1.7.7.6
#2 lore raw
Quoted 5 lines · Sarah Sharp

This looks fine. Does it need to be applied to stable as well, or is this just a "nice to have" that should be queued for 3.4?

Sarah Sharp

Hi Sarah, it is only a problem in linux-next because that code path was added to xhci_hcd_init() by 3429e91a which isn't in stable.

Quoted 24 lines · Gerard Snitselaar
Quoted 23 lines

xhci_unregister_pci() is called in xhci_hcd_init().

---
 drivers/usb/host/xhci-pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/xhci-pci.c +1 -1
index ef98b38..0d7b851 100644
@@ -326,7 +326,7 @@ int __init xhci_register_pci(void)
 	return pci_register_driver(&xhci_pci_driver);
 }
 
-void __exit xhci_unregister_pci(void)
+void xhci_unregister_pci(void)
 {
 	pci_unregister_driver(&xhci_pci_driver);
 }
Signature · 1 line
1.7.7.6