Skip to contentSkip to conversation

aio: change a stray spin_unlock_bh() to spin_unlock()

PATCH In review Dan Carpenter 2 participants 2 messages Mar 20, 2012

Subsystems (3)
VFS Kernel janitors Aio
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 aio: change a stray spin_unlock_bh() to spin_unlock()

We missed this spin_unlock_bh() when we removed the _bh from the other locks in cb22bbe9f7 "aio: aio_nr_lock is taken only synchronously now"

Signed-off-by Dan Carpenter <[email protected]>
fs/aio.c +1 -1
index 7b6b9d5..4f71627 100644
@@ -280,7 +280,7 @@ static struct kioctx *ioctx_alloc(unsigned nr_events)
 	spin_lock(&aio_nr_lock);
 	if (aio_nr + nr_events > aio_max_nr ||
 	    aio_nr + nr_events < aio_nr) {
-		spin_unlock_bh(&aio_nr_lock);
+		spin_unlock(&aio_nr_lock);
 		goto out_cleanup;
 	}
 	aio_nr += ctx->max_reqs;
maintainer
#1 lore raw
Quoted 2 lines · Dan Carpenter

We missed this spin_unlock_bh() when we removed the _bh from the other locks in cb22bbe9f7 "aio: aio_nr_lock is taken only synchronously now"

Nice catch; folded into the offending commit