Skip to contentSkip to conversation

x86, build: remove unused include

PATCH In review Andreas Bießmann 2 participants 4 messages Feb 15, 2012 – Mar 22, 2012 x86

lore
Share & tools
lore

Andreas Bießmann

author
#0 lore raw

PATCH 1/1 x86, build: remove unused include

Commit 079f85e624189292d1c818b47764916bf8cf84a8 removed necessity for sys/sysmacros.h include but missed to remove the include.

Still requiring sys/sysmacros.h for build tool breaks cross compiling x86 kernel on non linux style systems which may not offer sys/sysmacros.h.

Signed-off-by Andreas Bießmann <[email protected]>
---
 arch/x86/boot/tools/build.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/x86/boot/tools/build.c +0 -1
index 4e9bd6b..52628cd 100644
@@ -29,7 +29,6 @@
 #include <stdarg.h>
 #include <sys/types.h>
 #include <sys/stat.h>
-#include <sys/sysmacros.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <sys/mman.h>
Signature · 1 line
1.7.9
author
#1 lore raw
Quoted 17 lines · Andreas Bießmann

Commit 079f85e624189292d1c818b47764916bf8cf84a8 removed necessity for sys/sysmacros.h include but missed to remove the include.

Still requiring sys/sysmacros.h for build tool breaks cross compiling x86 kernel on non linux style systems which may not offer sys/sysmacros.h.

Signed-off-by Andreas Bießmann <[email protected]>
---
 arch/x86/boot/tools/build.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/x86/boot/tools/build.c +0 -0
index 4e9bd6b..52628cd 100644

arch/x86/boot/tools/build.c line 34

Quoted 7 lines
arch/x86/boot/tools/build.c +0 -1
@@ -29,7 +29,6 @@
 #include <stdarg.h>
 #include <sys/types.h>
 #include <sys/stat.h>
-#include <sys/sysmacros.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <sys/mman.h>

are there any objections against that patch? could anyone take it if not?

reviewer
#2 lore raw
Quoted 12 lines · Andreas Bießmann
Quoted 11 lines · Andreas Bießmann

Commit 079f85e624189292d1c818b47764916bf8cf84a8 removed necessity for sys/sysmacros.h include but missed to remove the include.

Still requiring sys/sysmacros.h for build tool breaks cross compiling x86 kernel on non linux style systems which may not offer sys/sysmacros.h.

Signed-off-by Andreas Bießmann <[email protected]>
---
 arch/x86/boot/tools/build.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Quoted 15 lines

arch/x86/boot/tools/build.c line 34

Quoted 13 lines
arch/x86/boot/tools/build.c +0 -1
index 4e9bd6b..52628cd 100644
@@ -29,7 +29,6 @@
 #include <stdarg.h>
 #include <sys/types.h>
 #include <sys/stat.h>
-#include <sys/sysmacros.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <sys/mman.h>

are there any objections against that patch? could anyone take it if not?

An equivalent patch has been in tip:x86/build for a while and was just pulled upstream by Linus.

Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.
author
#3 lore raw
Quoted 7 lines · H. Peter Anvin
Quoted 3 lines · Andreas Bießmann
Quoted 2 lines · Andreas Bießmann

Commit 079f85e624189292d1c818b47764916bf8cf84a8 removed necessity for sys/sysmacros.h include but missed to remove the include.

An equivalent patch has been in tip:x86/build for a while and was just pulled upstream by Linus.

sorry for the noise, I did only search for my patch in history and did not check the file.

regards

Andreas Bießmann