Skip to contentSkip to conversation

MAKEALL: display SPL size if present

PATCH Superseded Scott Wood 4 participants 5 messages Jan 5, 2012 – Mar 26, 2012

lore
Share & tools
lore

Scott Wood

author
#0 lore raw

PATCH 1/1 MAKEALL: display SPL size if present

This makes it easier to detect changes in the SPL portion, as can currently be done for the main U-Boot image.

---
 MAKEALL |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
MAKEALL +5 -0
index f735af6..395e982 100755
@@ -508,6 +508,11 @@ build_target() {
 
 	${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \
 				| tee -a ${LOG_DIR}/$target.MAKELOG
+
+	if [ -e ${BUILD_DIR}/spl/u-boot-spl ]; then
+		${CROSS_COMPILE}size ${BUILD_DIR}/spl/u-boot-spl \
+					| tee -a ${LOG_DIR}/$target.MAKELOG
+	fi
 }
 build_targets() {
 	for t in "$@" ; do
Signature · 1 line
1.7.7.rc3.4.g8d714
#1 lore raw

PATCH 1/1 MAKEALL: display SPL size if present

Dear Scott Wood,

Quoted 13 lines · In message <[email protected]> you wrote:

This makes it easier to detect changes in the SPL portion, as can currently be done for the main U-Boot image.

---
 MAKEALL |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
MAKEALL +0 -0
index f735af6..395e982 100755

MAKEALL build_target() { · line 515

Quoted 8 lines
MAKEALL +5 -0
@@ -508,6 +508,11 @@ build_target() {
 
 	${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \
 				| tee -a ${LOG_DIR}/$target.MAKELOG
+
+	if [ -e ${BUILD_DIR}/spl/u-boot-spl ]; then
+		${CROSS_COMPILE}size ${BUILD_DIR}/spl/u-boot-spl \
+					| tee -a ${LOG_DIR}/$target.MAKELOG
+	fi

Can we please combine this into a single call to "size"?

Thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
...computer hardware progress is so fast. No other  technology  since
civilization  began  has seen six orders of magnitude in performance-
price gain in 30 years.                             - Fred Brooks, Jr.
author
#2 lore raw

PATCH v2 1/1 MAKEALL: display SPL size if present

This makes it easier to detect changes in the SPL portion, as can currently be done for the main U-Boot image.

---
v2: Only invoke size once.

 MAKEALL |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)
MAKEALL +6 -2
index 0f2b4a1..c33be1d 100755
@@ -511,8 +511,12 @@ build_target() {
 
 	TOTAL_CNT=$((TOTAL_CNT + 1))
 
-	${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \
-				| tee -a ${LOG_DIR}/$target.MAKELOG
+	OBJS=${BUILD_DIR}/u-boot
+	if [ -e ${BUILD_DIR}/spl/u-boot-spl ]; then
+		OBJS="${OBJS} ${BUILD_DIR}/spl/u-boot-spl"
+	fi
+
+	${CROSS_COMPILE}size ${OBJS} | tee -a ${LOG_DIR}/$target.MAKELOG
 }
 build_targets() {
 	for t in "$@" ; do
Signature · 1 line
1.7.7.rc3.4.g8d714
#4 lore raw

PATCH v2 1/1 MAKEALL: display SPL size if present

In reply to Scott Wood

Hello Scott,

Quoted 9 lines · On Mon, 20 Feb 2012 16:56:25 -0600 Scott Wood <[email protected]> wrote:

This makes it easier to detect changes in the SPL portion, as can currently be done for the main U-Boot image.

---
v2: Only invoke size once.

 MAKEALL |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

Applied to u-boot-staging/agust at denx.de. Thanks.

Anatolij