Skip to contentSkip to conversation

Fix IPv4 multicast over network namespaces

PATCH In review Benjamin LaHaise 2 participants 3 messages Mar 27, 2012 – Mar 28, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix IPv4 multicast over network namespaces

When using multicast over a local bridge feeding a number of LXC guests using veth, the LXC guests are unable to get a response from other guests when pinging 224.0.0.1. Multicast packets did not appear to be getting delivered to the network namespaces of the guest hosts, and further inspection showed that the incoming route was pointing to the loopback device of the host, not the guest. This lead to the wrong network namespace being picked up by sockets (like ICMP). Fix this by using the correct network namespace when creating the inbound route entry.

---
 net/ipv4/route.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv4/route.c +1 -1
index 12ccf88..3b110a4 100644
@@ -2042,7 +2042,7 @@ static int ip_route_input_mc(struct sk_buff *skb, __be32 daddr, __be32 saddr,
 		if (err < 0)
 			goto e_err;
 	}
-	rth = rt_dst_alloc(init_net.loopback_dev,
+	rth = rt_dst_alloc(dev_net(dev)->loopback_dev,
 			   IN_DEV_CONF_GET(in_dev, NOPOLICY), false);
 	if (!rth)
 		goto e_nobufs;
Signature · 1 line
1.7.4.1
maintainer
#1 lore raw

From: Benjamin LaHaise <[email protected]>
Date: Tue, 27 Mar 2012 12:12:28 -0400

Quoted 8 lines

When using multicast over a local bridge feeding a number of LXC guests using veth, the LXC guests are unable to get a response from other guests when pinging 224.0.0.1. Multicast packets did not appear to be getting delivered to the network namespaces of the guest hosts, and further inspection showed that the incoming route was pointing to the loopback device of the host, not the guest. This lead to the wrong network namespace being picked up by sockets (like ICMP). Fix this by using the correct network namespace when creating the inbound route entry.

No signoff.

No proper subsystem prefix in Subject line (should be "ipv4: " here)

And third you've been warned about this repeatedly in your previous patch postings.

Therefore I'm not applying this.

#2 lore raw
Quoted 1 line · David Miller

No signoff.

My apologies. Doing this manually clearly isn't working, so I've switched to a script to try to catch this.

Quoted 1 line

No proper subsystem prefix in Subject line (should be "ipv4: " here)

I'm trying to get this right, and it looks like I botched this again, for that I am truely sorry.

-ben

Quoted 4 lines

And third you've been warned about this repeatedly in your previous patch postings.

Therefore I'm not applying this.

Signature · 1 line
"Thought is the essence of where you are now."