md:Add the judgement about the size of suspend_lo and suspend_hi.
From 7b8db5f9559feef49859056407a7cee656bcfc45 Mon Sep 17 00:00:00 2001
From: majianpeng <[email protected]>
Date: Wed, 28 Mar 2012 19:43:58 +0800
Subject: [PATCH] md:Add the judgement about the size of suspend_lo and
suspend_hi.
Signed-off-by majianpeng <[email protected]>
--- drivers/md/md.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/md/md.c +4 -0
@@ -4364,6 +4364,8 @@ suspend_lo_store(struct mddev *mddev, const char *buf, size_t len)return -EINVAL ;if (buf == e || (*e && *e !='\n' ))return -EINVAL ; +if (new > mddev->suspend_hi) +return -EINVAL ; mddev->suspend_lo = new;if (new >= old)
@@ -4398,6 +4400,8 @@ suspend_hi_store(struct mddev *mddev, const char *buf, size_t len)return -EINVAL ;if (buf == e || (*e && *e !='\n' ))return -EINVAL ; +if (new < mddev->suspend_lo) +return -EINVAL ; mddev->suspend_hi = new;if (new <= old)
Signature · 6 lines
1.7.5.4 -------------- majianpeng 2012-03-28
Quoted 7 lines · On Wed, 28 Mar 2012 19:49:38 +0800 "majianpeng" <[email protected]> wrote:
Quoted 1 line
From
7b8db5f9559feef49859056407a7cee656bcfc45Mon Sep 17 00:00:00 2001From: majianpeng <[email protected]>
Date: Wed, 28 Mar 2012 19:43:58 +0800
Subject: [PATCH] md:Add the judgement about the size ofsuspend_loand
suspend_hi.
you patches could use a little more text explaining them too.
In this case I think it is wrong. There is no reason at all why lo should always be less than or equal to hi. Imposing that is an unnecessary burden.
Not applied.
Thanks,
NeilBrown
Quoted 27 lines
Signed-off-by majianpeng <[email protected]>--- drivers/md/md.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)drivers/md/md.c +4
-0@@ -4364,6 +4364,8 @@ suspend_lo_store(struct mddev *mddev, const char *buf, size_t len)return -EINVAL ;if (buf == e || (*e && *e !='\n' ))return -EINVAL ; +if (new > mddev->suspend_hi) +return -EINVAL ; mddev->suspend_lo = new;if (new >= old)@@ -4398,6 +4400,8 @@ suspend_hi_store(struct mddev *mddev, const char *buf, size_t len)return -EINVAL ;if (buf == e || (*e && *e !='\n' ))return -EINVAL ; +if (new < mddev->suspend_lo) +return -EINVAL ; mddev->suspend_hi = new;if (new <= old)