Skip to contentSkip to conversation

Add ofono package + dependency libraries

PATCH Superseded Marek Belisko 4 participants 11 messages Mar 26, 2012 – Mar 31, 2012

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Marek Belisko

author
#0 lore raw

v2 cover Add ofono package + dependency libraries

Following patches add ofono package + new libcap-ng and broadband mobile provider info packages. Ofono bluetooth support is optional and selectable via config.

Marek Belisko (3):
Add libcap-ng package.
Add mobile-broadband-provider-info package.
Add ofono package.

 package/Config.in                                  |    3 ++
 package/libcap-ng/Config.in                        |   10 ++++++++
 package/libcap-ng/libcap-ng.mk                     |   12 +++++++++
 package/mobile-broadband-provider-info/Config.in   |    6 ++++
 .../mobile_broadband_provider_info.mk              |   14 +++++++++++
 package/ofono/Config.in                            |   20 ++++++++++++++++
 package/ofono/ofono.mk                             |   25 ++++++++++++++++++++
 7 files changed, 90 insertions(+), 0 deletions(-)
 create mode 100644 package/libcap-ng/Config.in
 create mode 100644 package/libcap-ng/libcap-ng.mk
 create mode 100644 package/mobile-broadband-provider-info/Config.in
 create mode 100644 package/mobile-broadband-provider-info/mobile_broadband_provider_info.mk
 create mode 100644 package/ofono/Config.in
 create mode 100644 package/ofono/ofono.mk
Signature · 1 line
1.7.5.4
author
#1 lore raw

PATCH v2 1/3 Add libcap-ng package.

Signed-off-by Marek Belisko <[email protected]>
---
 package/Config.in              |    1 +
 package/libcap-ng/Config.in    |   10 ++++++++++
 package/libcap-ng/libcap-ng.mk |   12 ++++++++++++
 3 files changed, 23 insertions(+), 0 deletions(-)
 create mode 100644 package/libcap-ng/Config.in
 create mode 100644 package/libcap-ng/libcap-ng.mk
package/Config.in +1 -0
index b394f18..2dc7e1f 100644
@@ -377,6 +377,7 @@ source "package/argp-standalone/Config.in"
 source "package/boost/Config.in"
 source "package/libatomic_ops/Config.in"
 source "package/libcap/Config.in"
+source "package/libcap-ng/Config.in"
 source "package/libdaemon/Config.in"
 source "package/libelf/Config.in"
 source "package/libevent/Config.in"
package/libcap-ng/Config.in new file +10 -0
new file mode 100644
index 0000000..d1663cd
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBCAP_NG
+	bool "libcap-ng"
+	help
+	  The libcap-ng library is intended to make programming with
+	  posix capabilities much easier than the traditional libcap
+	  library. It includes utilities that can analyse all currently
+	  running applications and print out any capabilities and whether
+	  or not it has an open ended bounding set.
+
+	  http://people.redhat.com/sgrubb/libcap-ng/
package/libcap-ng/libcap-ng.mk new file +12 -0
new file mode 100644
index 0000000..6ea5de4
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libcap-ng
+#
+#############################################################
+
+LIBCAP_NG_VERSION = 0.6.6
+LIBCAP_NG_SITE = http://people.redhat.com/sgrubb/libcap-ng/
+LIBCAP_NG_SOURCE = libcap-ng-$(LIBCAP_NG_VERSION).tar.gz
+LIBCAP_NG_INSTALL_STAGING = YES
+
+$(eval $(call AUTOTARGETS))
Signature · 1 line
1.7.5.4
#2 lore raw

PATCH v2 1/3 Add libcap-ng package.

Quoted 45 lines · Marek Belisko
Signed-off-by Marek Belisko <[email protected]>

---

?package/Config.in ? ? ? ? ? ? ?| ? ?1 +
?package/libcap-ng/Config.in ? ?| ? 10 ++++++++++
?package/libcap-ng/libcap-ng.mk | ? 12 ++++++++++++

?3 files changed, 23 insertions(+), 0 deletions(-) ?create mode 100644 package/libcap-ng/Config.in ?create mode 100644 package/libcap-ng/libcap-ng.mk

package/Config.in +0 -0
index b394f18..2dc7e1f 100644
@@ -377,6 +377,7 @@ source "package/argp-standalone/Config.in"

?source "package/boost/Config.in"
?source "package/libatomic_ops/Config.in"
?source "package/libcap/Config.in"
+source "package/libcap-ng/Config.in"
?source "package/libdaemon/Config.in"
?source "package/libelf/Config.in"
?source "package/libevent/Config.in"

package/libcap-ng/Config.in new file +10 -0
new file mode 100644
index 0000000..d1663cd
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBCAP_NG
+ ? ? ? bool "libcap-ng"
+ ? ? ? help
+ ? ? ? ? The libcap-ng library is intended to make programming with
+ ? ? ? ? posix capabilities much easier than the traditional libcap
+ ? ? ? ? library. It includes utilities that can analyse all currently
+ ? ? ? ? running applications and print out any capabilities and whether
+ ? ? ? ? or not it has an open ended bounding set.
+
+ ? ? ? ? http://people.redhat.com/sgrubb/libcap-ng/
package/libcap-ng/libcap-ng.mk new file +2 -0
new file mode 100644
index 0000000..6ea5de4
@@ -0,0 +1,12 @@
+#############################################################
+#

package/libcap-ng/libcap-ng.mk line 12

Quoted 10 lines
package/libcap-ng/libcap-ng.mk new file +10 -0
+# libcap-ng
+#
+#############################################################
+
+LIBCAP_NG_VERSION = 0.6.6
+LIBCAP_NG_SITE = http://people.redhat.com/sgrubb/libcap-ng/
+LIBCAP_NG_SOURCE = libcap-ng-$(LIBCAP_NG_VERSION).tar.gz
+LIBCAP_NG_INSTALL_STAGING = YES
+
+$(eval $(call AUTOTARGETS))

Have you tried to download the package without LIBCAP_NG_SITE?

Yegor

#3 lore raw

PATCH v2 1/3 Add libcap-ng package.

Quoted 51 lines · Yegor Yefremov
Quoted 49 lines · Marek Belisko
Signed-off-by Marek Belisko <[email protected]>

---

?package/Config.in ? ? ? ? ? ? ?| ? ?1 +
?package/libcap-ng/Config.in ? ?| ? 10 ++++++++++
?package/libcap-ng/libcap-ng.mk | ? 12 ++++++++++++

?3 files changed, 23 insertions(+), 0 deletions(-) ?create mode 100644 package/libcap-ng/Config.in ?create mode 100644 package/libcap-ng/libcap-ng.mk

package/Config.in +0 -0
index b394f18..2dc7e1f 100644
@@ -377,6 +377,7 @@ source "package/argp-standalone/Config.in"

?source "package/boost/Config.in"
?source "package/libatomic_ops/Config.in"
?source "package/libcap/Config.in"
+source "package/libcap-ng/Config.in"
?source "package/libdaemon/Config.in"
?source "package/libelf/Config.in"
?source "package/libevent/Config.in"

package/libcap-ng/Config.in new file +10 -0
new file mode 100644
index 0000000..d1663cd
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBCAP_NG
+ ? ? ? bool "libcap-ng"
+ ? ? ? help
+ ? ? ? ? The libcap-ng library is intended to make programming with
+ ? ? ? ? posix capabilities much easier than the traditional libcap
+ ? ? ? ? library. It includes utilities that can analyse all currently
+ ? ? ? ? running applications and print out any capabilities and whether
+ ? ? ? ? or not it has an open ended bounding set.
+
+ ? ? ? ? http://people.redhat.com/sgrubb/libcap-ng/
package/libcap-ng/libcap-ng.mk new file +6 -0
new file mode 100644
index 0000000..6ea5de4
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libcap-ng
+#
+#############################################################
+
Quoted 8 lines

package/libcap-ng/libcap-ng.mk line 12

Quoted 6 lines
package/libcap-ng/libcap-ng.mk new file +6 -0
+LIBCAP_NG_VERSION = 0.6.6
+LIBCAP_NG_SITE = http://people.redhat.com/sgrubb/libcap-ng/
+LIBCAP_NG_SOURCE = libcap-ng-$(LIBCAP_NG_VERSION).tar.gz
+LIBCAP_NG_INSTALL_STAGING = YES
+
+$(eval $(call AUTOTARGETS))

Have you tried to download the package without LIBCAP_NG_SITE?

Guess yes? Why?

Quoted 2 lines

Yegor

marek

Signature · 10 lines
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
#4 lore raw

PATCH v2 1/3 Add libcap-ng package.

Quoted 61 lines · Belisko Marek
Quoted 51 lines · Yegor Yefremov
Quoted 49 lines · Marek Belisko
Signed-off-by Marek Belisko <[email protected]>

---

?package/Config.in ? ? ? ? ? ? ?| ? ?1 +
?package/libcap-ng/Config.in ? ?| ? 10 ++++++++++
?package/libcap-ng/libcap-ng.mk | ? 12 ++++++++++++

?3 files changed, 23 insertions(+), 0 deletions(-) ?create mode 100644 package/libcap-ng/Config.in ?create mode 100644 package/libcap-ng/libcap-ng.mk

package/Config.in +0 -0
index b394f18..2dc7e1f 100644
@@ -377,6 +377,7 @@ source "package/argp-standalone/Config.in"

?source "package/boost/Config.in"
?source "package/libatomic_ops/Config.in"
?source "package/libcap/Config.in"
+source "package/libcap-ng/Config.in"
?source "package/libdaemon/Config.in"
?source "package/libelf/Config.in"
?source "package/libevent/Config.in"

package/libcap-ng/Config.in new file +10 -0
new file mode 100644
index 0000000..d1663cd
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBCAP_NG
+ ? ? ? bool "libcap-ng"
+ ? ? ? help
+ ? ? ? ? The libcap-ng library is intended to make programming with
+ ? ? ? ? posix capabilities much easier than the traditional libcap
+ ? ? ? ? library. It includes utilities that can analyse all currently
+ ? ? ? ? running applications and print out any capabilities and whether
+ ? ? ? ? or not it has an open ended bounding set.
+
+ ? ? ? ? http://people.redhat.com/sgrubb/libcap-ng/
package/libcap-ng/libcap-ng.mk new file +6 -0
new file mode 100644
index 0000000..6ea5de4
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libcap-ng
+#
+#############################################################
+
Quoted 8 lines

package/libcap-ng/libcap-ng.mk line 12

Quoted 6 lines
package/libcap-ng/libcap-ng.mk new file +6 -0
+LIBCAP_NG_VERSION = 0.6.6
+LIBCAP_NG_SITE = http://people.redhat.com/sgrubb/libcap-ng/
+LIBCAP_NG_SOURCE = libcap-ng-$(LIBCAP_NG_VERSION).tar.gz
+LIBCAP_NG_INSTALL_STAGING = YES
+
+$(eval $(call AUTOTARGETS))

Have you tried to download the package without LIBCAP_NG_SITE?

Quoted 1 line

Guess yes? Why?

AFAIK if you have package file named like packagename-version.tar.gz, then this will be tried automatically. See vsftpd for example.

Sorry I meant LIBCAP_NG_SOURCE not SITE :-(

Yegor

#5 lore raw

PATCH v2 1/3 Add libcap-ng package.

Quoted 62 lines · Yegor Yefremov
Quoted 61 lines · Belisko Marek
Quoted 59 lines · Yegor Yefremov
Quoted 45 lines · Marek Belisko
Signed-off-by Marek Belisko <[email protected]>

---

?package/Config.in ? ? ? ? ? ? ?| ? ?1 +
?package/libcap-ng/Config.in ? ?| ? 10 ++++++++++
?package/libcap-ng/libcap-ng.mk | ? 12 ++++++++++++

?3 files changed, 23 insertions(+), 0 deletions(-) ?create mode 100644 package/libcap-ng/Config.in ?create mode 100644 package/libcap-ng/libcap-ng.mk

package/Config.in +0 -0
index b394f18..2dc7e1f 100644
@@ -377,6 +377,7 @@ source "package/argp-standalone/Config.in"

?source "package/boost/Config.in"
?source "package/libatomic_ops/Config.in"
?source "package/libcap/Config.in"
+source "package/libcap-ng/Config.in"
?source "package/libdaemon/Config.in"
?source "package/libelf/Config.in"
?source "package/libevent/Config.in"

package/libcap-ng/Config.in new file +10 -0
new file mode 100644
index 0000000..d1663cd
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBCAP_NG
+ ? ? ? bool "libcap-ng"
+ ? ? ? help
+ ? ? ? ? The libcap-ng library is intended to make programming with
+ ? ? ? ? posix capabilities much easier than the traditional libcap
+ ? ? ? ? library. It includes utilities that can analyse all currently
+ ? ? ? ? running applications and print out any capabilities and whether
+ ? ? ? ? or not it has an open ended bounding set.
+
+ ? ? ? ? http://people.redhat.com/sgrubb/libcap-ng/
package/libcap-ng/libcap-ng.mk new file +2 -0
new file mode 100644
index 0000000..6ea5de4
@@ -0,0 +1,12 @@
+#############################################################
+#

package/libcap-ng/libcap-ng.mk line 12

Quoted 10 lines
package/libcap-ng/libcap-ng.mk new file +10 -0
+# libcap-ng
+#
+#############################################################
+
+LIBCAP_NG_VERSION = 0.6.6
+LIBCAP_NG_SITE = http://people.redhat.com/sgrubb/libcap-ng/
+LIBCAP_NG_SOURCE = libcap-ng-$(LIBCAP_NG_VERSION).tar.gz
+LIBCAP_NG_INSTALL_STAGING = YES
+
+$(eval $(call AUTOTARGETS))

Have you tried to download the package without LIBCAP_NG_SITE?

Quoted 4 lines
Quoted 1 line

Guess yes? Why?

AFAIK if you have package file named like packagename-version.tar.gz, then this will be tried automatically. See vsftpd for example.

Yes you're right. Will update. Thanks for review.

Quoted 4 lines

Sorry I meant LIBCAP_NG_SOURCE not SITE :-(

Yegor

marek

Signature · 10 lines
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
author
#6 lore raw

PATCH v2 2/3 Add mobile-broadband-provider-info package.

In reply to Marek Belisko
Signed-off-by Marek Belisko <[email protected]>
---
 package/Config.in                                  |    1 +
 package/mobile-broadband-provider-info/Config.in   |    6 ++++++
 .../mobile_broadband_provider_info.mk              |   14 ++++++++++++++
 3 files changed, 21 insertions(+), 0 deletions(-)
 create mode 100644 package/mobile-broadband-provider-info/Config.in
 create mode 100644 package/mobile-broadband-provider-info/mobile_broadband_provider_info.mk
package/Config.in +1 -0
index 2dc7e1f..cd41eb9 100644
@@ -424,6 +424,7 @@ endmenu
 endmenu
 
 menu "Miscellaneous"
+source "package/mobile-broadband-provider-info/Config.in"
 source "package/shared-mime-info/Config.in"
 endmenu
package/mobile-broadband-provider-info/Config.in new file +6 -0
new file mode 100644
index 0000000..dda7105
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_MOBILE_BROADBAND_PROVIDER_INFO
+	bool "mobile-broadband-provider-info"
+	help
+	  Mobile broadband provider database.
+
+	  http://live.gnome.org/NetworkManager/MobileBroadband/ServiceProviders
package/mobile-broadband-provider-info/mobile_broadband_provider_info.mk new file +14 -0
new file mode 100644
index 0000000..9204bd9
@@ -0,0 +1,14 @@
+#############################################################
+#
+# mobile broadband provider info
+#
+#############################################################
+MOBILE_BROADBAND_PROVIDER_INFO_VERSION = master
+MOBILE_BROADBAND_PROVIDER_INFO_SITE = git://git.gnome.org/mobile-broadband-provider-info
+MOBILE_BROADBAND_PROVIDER_INFO_INSTALL_STAGING = YES
+MOBILE_BROADBAND_PROVIDER_INFO_DEPENDENCIES = host-pkg-config
+
+MOBILE_BROADBAND_PROVIDER_INFO_AUTORECONF=YES
+
+$(eval $(call AUTOTARGETS))
+
Signature · 1 line
1.7.5.4
#7 lore raw

PATCH v2 2/3 Add mobile-broadband-provider-info package.

package/mobile-broadband-provider-info/mobile_broadband_provider_info.mk line 7

Quoted 2 lines · On Monday 26 March 2012 22:12:35 Marek Belisko wrote:
package/mobile-broadband-provider-info/mobile_broadband_provider_info.mk new file +2 -0
+MOBILE_BROADBAND_PROVIDER_INFO_VERSION = master
+MOBILE_BROADBAND_PROVIDER_INFO_SITE = git://git.gnome.org/mobile-broadband-provider-info

Please use an explicit commit ID rather than 'master', otherwise the
build is not reproducible.

Also, I prefer the http method for git access, because some firewalls
block git traffic. (Actually, ideally the git method should be updated to try http if the git access method fails...)

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
author
#8 lore raw

PATCH v2 3/3 Add ofono package.

In reply to Marek Belisko
Signed-off-by Marek Belisko <[email protected]>
---
 package/Config.in       |    1 +
 package/ofono/Config.in |   20 ++++++++++++++++++++
 package/ofono/ofono.mk  |   25 +++++++++++++++++++++++++
 3 files changed, 46 insertions(+), 0 deletions(-)
 create mode 100644 package/ofono/Config.in
 create mode 100644 package/ofono/ofono.mk
package/Config.in +1 -0
index cd41eb9..4dfbce4 100644
@@ -201,6 +201,7 @@ source "package/memtester/Config.in"
 source "package/minicom/Config.in"
 source "package/mtd/Config.in"
 source "package/ntfs-3g/Config.in"
+source "package/ofono/Config.in"
 source "package/open2300/Config.in"
 source "package/openocd/Config.in"
 source "package/parted/Config.in"
package/ofono/Config.in new file +20 -0
new file mode 100644
index 0000000..b10e42d
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_OFONO
+	bool "ofono"
+	select BR2_PACKAGE_LIBCAP_NG
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_MOBILE_BROADBAND_PROVIDER_INFO
+	help
+	  oFono.org is a place to bring developers together around designing an
+	  infrastructure for building mobile telephony (GSM/UMTS) applications.
+
+if BR2_PACKAGE_OFONO
+
+config BR2_PACKAGE_OFONO_BLUETOOTH
+        bool "ofono with bluetooth support"
+	select BR2_PACKAGE_BLUEZ_UTILS
+        help
+	  Enable bluetooh support.
+endif
+
+
package/ofono/ofono.mk new file +25 -0
new file mode 100644
index 0000000..e408a61
@@ -0,0 +1,25 @@
+#############################################################
+#
+# ofono
+#
+#############################################################
+OFONO_VERSION = 1.5
+OFONO_SITE = git://git.kernel.org/pub/scm/network/ofono/ofono.git
+
+OFONO_DEPENDENCIES = host-pkg-config libglib2 dbus libcap-ng mobile-broadband-provider-info
+
+OFONO_CONF_OPT = --disable-test --disable-bluetooth
+
+OFONO_AUTORECONF = YES
+
+ifneq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),y)
+	OFONO_CONF_OPT += --disable-udev
+endif
+
+ifeq ($(BR2_PACKAGE_OFONO_BLUETOOTH),y)
+	OFONO_CONF_OPT += --enable-bluetooth
+	OFONO_DEPENDENCIES += bluez_utils
+endif
+
+$(eval $(call AUTOTARGETS))
+
Signature · 1 line
1.7.5.4
#9 lore raw

PATCH v2 3/3 Add ofono package.

On Monday 26 March 2012 22:12:36 Marek Belisko wrote:
[snip]

package/ofono/Config.in line 6

Quoted 12 lines
package/ofono/Config.in new file +6 -0
new file mode 100644
index 0000000..b10e42d
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_OFONO
+	bool "ofono"
+	select BR2_PACKAGE_LIBCAP_NG
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_MOBILE_BROADBAND_PROVIDER_INFO

Missing
depends on BR2_USE_WCHAR # gettext/libglib2

which also means you need a comment in case we don't have WCHAR.

package/ofono/Config.in line 9

Quoted 3 lines
package/ofono/Config.in new file +3 -0
+	helpimplies
+	  oFono.org is a place to bring developers together around designing an
+	  infrastructure for building mobile telephony (GSM/UMTS) applications.

This doesn't really explain what the package does. Also, a link to a
website is convenient.

package/ofono/Config.in line 18

Quoted 9 lines
package/ofono/Config.in new file +9 -0
+
+if BR2_PACKAGE_OFONO
+
+config BR2_PACKAGE_OFONO_BLUETOOTH
+        bool "ofono with bluetooth support"
+	select BR2_PACKAGE_BLUEZ_UTILS
+        help
+	  Enable bluetooh support.
+endif

There's some funky whitespace here. Also a type: bluetooh -> bluetooth

package/ofono/Config.in line 20

Quoted 2 lines
package/ofono/Config.in new file +2 -0
+
+

No empty lines at the end of the file please.

package/ofono/ofono.mk line 7

Quoted 13 lines
package/ofono/ofono.mk new file +7 -0
new file mode 100644
index 0000000..e408a61
@@ -0,0 +1,25 @@
+#############################################################
+#
+# ofono
+#
+#############################################################
+OFONO_VERSION = 1.5
+OFONO_SITE = git://git.kernel.org/pub/scm/network/ofono/ofono.git

Why not use the tar from $(BR2_KERNEL_MIRROR)/linux/network/ofono ?

package/ofono/ofono.mk line 11

Quoted 4 lines
package/ofono/ofono.mk new file +4 -0
+
+OFONO_DEPENDENCIES = host-pkg-config libglib2 dbus libcap-ng mobile-broadband-provider-info
+
+OFONO_CONF_OPT = --disable-test --disable-bluetooth

The --disable-bluetooth should be in the else of the OFONO_BLUETOOTH
option.

package/ofono/ofono.mk line 13

Quoted 2 lines
package/ofono/ofono.mk new file +2 -0
+
+OFONO_AUTORECONF = YES

Not needed if you use the tar.

package/ofono/ofono.mk line 17

Quoted 4 lines
package/ofono/ofono.mk new file +4 -0
+
+ifneq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),y)
+	OFONO_CONF_OPT += --disable-udev
+endif

It's better to use --enable-udev explicitly in the positive case, and
you probably need to add udev to DEPENDENCIES anyway.

Also it's more logical to check for BR2_PACKAGE_UDEV.

Regards,
Arnout

Quoted 9 lines
package/ofono/ofono.mk new file +8 -0
+
+ifeq ($(BR2_PACKAGE_OFONO_BLUETOOTH),y)
+	OFONO_CONF_OPT += --enable-bluetooth
+	OFONO_DEPENDENCIES += bluez_utils
+endif
+
+$(eval $(call AUTOTARGETS))
+
Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#10 lore raw

PATCH v2 3/3 Add ofono package.

Quoted 44 lines · Arnout Vandecappelle

On Monday 26 March 2012 22:12:36 Marek Belisko wrote:
[snip]

package/ofono/Config.in line 6

Quoted 12 lines
package/ofono/Config.in new file +6 -0
new file mode 100644
index 0000000..b10e42d
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_OFONO
+ ? ? bool "ofono"
+ ? ? select BR2_PACKAGE_LIBCAP_NG
+ ? ? select BR2_PACKAGE_DBUS
+ ? ? select BR2_PACKAGE_LIBGLIB2
+ ? ? select BR2_PACKAGE_MOBILE_BROADBAND_PROVIDER_INFO

?Missing
? ? ? ?depends on BR2_USE_WCHAR # gettext/libglib2

?which also means you need a comment in case we don't have WCHAR.

package/ofono/Config.in line 9

Quoted 3 lines
package/ofono/Config.in new file +3 -0
+ ? ? helpimplies
+ ? ? ? oFono.org is a place to bring developers together around designing an
+ ? ? ? infrastructure for building mobile telephony (GSM/UMTS) applications.

?This doesn't really explain what the package does. ?Also, a link to a website is convenient.

package/ofono/Config.in line 18

Quoted 9 lines
package/ofono/Config.in new file +9 -0
+
+if BR2_PACKAGE_OFONO
+
+config BR2_PACKAGE_OFONO_BLUETOOTH
+ ? ? ? ?bool "ofono with bluetooth support"
+ ? ? select BR2_PACKAGE_BLUEZ_UTILS
+ ? ? ? ?help
+ ? ? ? Enable bluetooh support.
+endif

?There's some funky whitespace here. ?Also a type: bluetooh -> bluetooth

package/ofono/Config.in line 20

Quoted 2 lines
package/ofono/Config.in new file +2 -0
+
+

?No empty lines at the end of the file please.

Quoted 15 lines

package/ofono/ofono.mk line 7

Quoted 13 lines
package/ofono/ofono.mk new file +7 -0
new file mode 100644
index 0000000..e408a61
@@ -0,0 +1,25 @@
+#############################################################
+#
+# ofono
+#
+#############################################################
+OFONO_VERSION = 1.5
+OFONO_SITE = git://git.kernel.org/pub/scm/network/ofono/ofono.git

?Why not use the tar from $(BR2_KERNEL_MIRROR)/linux/network/ofono ?

Ok will do.

Quoted 11 lines

package/ofono/ofono.mk line 11

Quoted 5 lines
package/ofono/ofono.mk new file +4 -0
+
+OFONO_DEPENDENCIES = host-pkg-config libglib2 dbus libcap-ng mobile-broadband-provider-info
+
+OFONO_CONF_OPT = --disable-test --disable-bluetooth

?The --disable-bluetooth should be in the else of the OFONO_BLUETOOTH option.

package/ofono/ofono.mk line 13

Quoted 2 lines
package/ofono/ofono.mk new file +2 -0
+
+OFONO_AUTORECONF = YES

When switch to tar version without this line it can' t configure because ./configure doesn't exist (just bootstrap)

Quoted 10 lines

?Not needed if you use the tar.

package/ofono/ofono.mk line 17

Quoted 4 lines
package/ofono/ofono.mk new file +4 -0
+
+ifneq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),y)
+ ? ? OFONO_CONF_OPT += --disable-udev
+endif

?It's better to use --enable-udev explicitly in the positive case, and you probably need to add udev to DEPENDENCIES anyway.

ofono have by default udev enabled. For systems where udev isn't available could be also used (just need to created /dev entry for modem by hand). What about something like that:
+ifeq ($(BR2_PACKAGE_UDEV),y)
+ OFONO_CONF_OPT += --enable-udev
+ OFONO_DEPENDENCIES += udev
+else
+ OFONO_CONF_OPT += --disable-udev
+endif

For target with udev it will be used otherwise not.

Quoted 17 lines

?Also it's more logical to check for BR2_PACKAGE_UDEV.

?Regards,
?Arnout

package/ofono/ofono.mk line 25

Quoted 9 lines
package/ofono/ofono.mk new file +8 -0
+
+ifeq ($(BR2_PACKAGE_OFONO_BLUETOOTH),y)
+ ? ? OFONO_CONF_OPT += --enable-bluetooth
+ ? ? OFONO_DEPENDENCIES += bluez_utils
+endif
+
+$(eval $(call AUTOTARGETS))
+
Quoted 7 lines

--
Arnout Vandecappelle ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? arnout at mind be Senior Embedded Software Architect ? ? ? ? ? ? ? ? +32-16-286540 Essensium/Mind ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium ? ? ? ? ? ? ? ?BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: ?7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

regards,

marek

Signature · 10 lines
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com