Skip to contentSkip to conversation

fcoe: remove a stray unlock

PATCH New Dan Carpenter 1 participant 1 message Mar 29, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fcoe: remove a stray unlock

We moved the locking in dd060e74fb "[SCSI] fcoe: remove frame dropping code from fcoe_percpu_clean" but this unlock was missed.

drivers/scsi/fcoe/fcoe.c +2 -3
index 335e851..c2d8a8c 100644
@@ -2274,10 +2274,9 @@ static void fcoe_percpu_clean(struct fc_lport *lport)
 			continue;
 
 		skb = dev_alloc_skb(0);
-		if (!skb) {
-			spin_unlock_bh(&pp->fcoe_rx_list.lock);
+		if (!skb)
 			continue;
-		}
+
 		skb->destructor = fcoe_percpu_flush_done;
 
 		spin_lock_bh(&pp->fcoe_rx_list.lock);