ARM: ux300: Fix unimplementable regulation constraints
Subsystems (2)
PATCH 1/1 ARM: ux300: Fix unimplementable regulation constraints
It doesn't make sense to grant permission to change the status of a regulator that is also set as always on and similarly it doesn't make sense to allow a driver to change the voltage of a regulator which can only be set to a single voltage.
--- arch/arm/mach-u300/i2c.c | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-)
arch/arm/mach-u300/i2c.c +1 -8
@@ -146,9 +146,6 @@ static struct ab3100_platform_data ab3100_plf_data = { .min_uV = 1800000, .max_uV = 1800000, .valid_modes_mask = REGULATOR_MODE_NORMAL, - .valid_ops_mask = -REGULATOR_CHANGE_VOLTAGE | - REGULATOR_CHANGE_STATUS, .always_on = 1, .boot_on = 1, },
@@ -160,9 +157,6 @@ static struct ab3100_platform_data ab3100_plf_data = { .min_uV = 2500000, .max_uV = 2500000, .valid_modes_mask = REGULATOR_MODE_NORMAL, - .valid_ops_mask = -REGULATOR_CHANGE_VOLTAGE | - REGULATOR_CHANGE_STATUS, .always_on = 1, .boot_on = 1, },
@@ -230,8 +224,7 @@ static struct ab3100_platform_data ab3100_plf_data = { .max_uV = 1800000, .valid_modes_mask = REGULATOR_MODE_NORMAL, .valid_ops_mask = -REGULATOR_CHANGE_VOLTAGE | - REGULATOR_CHANGE_STATUS, + REGULATOR_CHANGE_VOLTAGE, .always_on = 1, .boot_on = 1, },
Signature · 1 line
1.7.9.1
PATCH 1/1 ARM: ux300: Fix unimplementable regulation constraints
Quoted 6 lines · Mark Brown
It doesn't make sense to grant permission to change the status of a regulator that is also set as always on and similarly it doesn't make sense to allow a driver to change the voltage of a regulator which can only be set to a single voltage.
Signed-off-by Mark Brown <[email protected]>
Most probably correct.
Do you want me to funnel this to ARM-SoC or will you carry it in the regulator tree?
Thanks,
Linus Walleij
PATCH 1/1 ARM: ux300: Fix unimplementable regulation constraints
Quoted 7 lines · Linus Walleij
On Sat, Mar 31, 2012 at 6:44 PM, Mark Brown
Quoted 4 lines
It doesn't make sense to grant permission to change the status of a regulator that is also set as always on and similarly it doesn't make sense to allow a driver to change the voltage of a regulator which can only be set to a single voltage.
Quoted 5 lines
Most probably correct.
Acked-by Linus Walleij <[email protected]>Do you want me to funnel this to ARM-SoC or will you carry it in the regulator tree?
May as well send it via ARM-SoC, there's no interdependency with the
regulator tree here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120401/7def962b/attachment.sig>
PATCH 1/1 ARM: ux300: Fix unimplementable regulation constraints
Quoted 6 lines · Mark Brown
Quoted 2 lines · Linus Walleij
Do you want me to funnel this to ARM-SoC or will you carry it in the regulator tree?
May as well send it via ARM-SoC, there's no interdependency with the regulator tree here.
OK I'll push this for the -rc:s.
Thanks,
Linus Walleij