md/raid1:Using 1 instead of update.

PATCH In review majianpeng 2 participants 2 messages Apr 1, 2012 – Apr 2, 2012 MD RAID

Share & tools

majianpeng

author

2012-04-01 02:36 UTC #0 lore raw

PATCH 1/1 md/raid1:Using 1 instead of update.

From 6991dc532e4d655fb509ba1dbe7a9869b0cd33d9 Mon Sep 17 00:00:00 2001
From: majianpeng <[email protected]>
Date: Sun, 1 Apr 2012 10:31:52 +0800
Subject: [PATCH] md/raid1:Using 1 instead of update.
If update == 0 and then set R1BIO_WriteError,so did not exec md_do_sync().

Signed-off-by majianpeng <[email protected]>

---
 drivers/md/raid1.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/md/raid1.c +1 -1

index 4a40a20..def1ed1 100644
@@ -1554,7 +1554,7 @@ static void end_sync_write(struct bio *bio, int error)
 			reschedule_retry(r1_bio);
 		else {
 			put_buf(r1_bio);
-			md_done_sync(mddev, s, uptodate);
+			md_done_sync(mddev, s, 1);
 		}
 	}
 }

Signature · 6 lines

1.7.5.4

 				
--------------
majianpeng
2012-04-01

NeilBrown

2012-04-02 02:01 UTC #1 lore raw

Quoted 17 lines · On Sun, 1 Apr 2012 10:36:32 +0800 "majianpeng" <[email protected]> wrote:

Quoted 1 line
From 6991dc532e4d655fb509ba1dbe7a9869b0cd33d9 Mon Sep 17 00:00:00 2001
From: majianpeng <[email protected]>
Date: Sun, 1 Apr 2012 10:31:52 +0800
Subject: [PATCH] md/raid1:Using 1 instead of update.
If update == 0 and then set R1BIO_WriteError,so did not exec md_do_sync().
Signed-off-by majianpeng <[email protected]>
---
 drivers/md/raid1.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/md/raid1.c +0 -0
index 4a40a20..def1ed1 100644

drivers/md/raid1.c static void end_sync_write(struct bio *bio, int error) · line 1560

Quoted 8 lines

drivers/md/raid1.c +1 -1

@@ -1554,7 +1554,7 @@ static void end_sync_write(struct bio *bio, int error)
 			reschedule_retry(r1_bio);
 		else {
 			put_buf(r1_bio);
-			md_done_sync(mddev, s, uptodate);
+			md_done_sync(mddev, s, 1);
 		}
 	}
 }

Again, I think this hurts readability - it is less obvious that it is correct.

So I'll leave it as it is.

Thanks,
NeilBrown