Don't apply 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 to stable please.

DISCUSSION Konrad Rzeszutek Wilk 4 participants 10 messages Apr 2, 2012 – Apr 3, 2012 Stable branch

Share & tools

Konrad Rzeszutek Wilk

author

2012-04-02 22:51 UTC #0 lore raw

Hey Greg,

The git commit 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 has CC [email protected] but it breaks Xen - we are working to fix it in 3.4, but the fix for it does some architectual changes (136d249ef7dbf0fefa292082cc40be1ea864cbd6) that I don't know if you are comfortable putting in stable tree.

Suresh Siddha

2012-04-02 23:00 UTC #1 lore raw

Quoted 6 lines · Konrad Rzeszutek Wilk

Hey Greg,
The git commit 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 has CC [email protected] but it breaks Xen - we are working to fix it in 3.4, but the fix for it does some architectual changes (136d249ef7dbf0fefa292082cc40be1ea864cbd6) that I don't know if you are comfortable putting in stable tree.

I am Ok if the commit '9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655' is not applied to stable.

thanks,
suresh

Greg KH

maintainer

2012-04-02 23:27 UTC #2 lore raw

In reply to Konrad Rzeszutek Wilk

Quoted 7 lines · Konrad Rzeszutek Wilk

Hey Greg,
The git commit 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 has CC [email protected] but it breaks Xen - we are working to fix it in 3.4, but the fix for it does some architectual changes (136d249ef7dbf0fefa292082cc40be1ea864cbd6) that I don't know if you are comfortable putting in stable tree.

I have no idea what that git commit id referrs to, as it's not in Linus's tree at the moment.

Care to give me a subject? diffstat? Some kind of hint?

And note, you forgot to send this to the [email protected] list, where the other stable kernel maintainers live, please do so next time.

thanks,

greg k-h

Suresh Siddha

2012-04-02 23:41 UTC #3 lore raw

Quoted 9 lines · Greg KH

Quoted 7 lines · Konrad Rzeszutek Wilk
Hey Greg,
The git commit 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 has CC [email protected] but it breaks Xen - we are working to fix it in 3.4, but the fix for it does some architectual changes (136d249ef7dbf0fefa292082cc40be1ea864cbd6) that I don't know if you are comfortable putting in stable tree.

Quoted 4 lines

I have no idea what that git commit id referrs to, as it's not in Linus's tree at the moment.
Care to give me a subject? diffstat? Some kind of hint?

Greg, Konrad is referring to:

commit 73d63d038ee9f769f5e5b46792d227fe20e442c5

Author: Suresh Siddha <[email protected]>
Date:   Mon Mar 12 11:36:33 2012 -0700

x86/ioapic: Add register level checks to detect bogus io-apic entries

With out this commit, if the bios lists bogus io-apic's, then we will see some error messages ("Unable to reset IRR for apic")during linux boot which are benign. But as this patch breaks Xen, I am ok if these don't get applied to 'stable'. Also I think it is Ingo who added the 'stable' tag. Ingo, are you ok with this?

For the mainline, we have queued more patches to fix the Xen breakage.

thanks,
suresh

Quoted 7 lines

And note, you forgot to send this to the [email protected] list, where the other stable kernel maintainers live, please do so next time.
thanks,
greg k-h

Greg KH

maintainer

2012-04-02 23:49 UTC #4 lore raw

Quoted 10 lines · Suresh Siddha

Quoted 9 lines · Greg KH
Quoted 7 lines · Konrad Rzeszutek Wilk
Hey Greg,
The git commit 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 has CC [email protected] but it breaks Xen - we are working to fix it in 3.4, but the fix for it does some architectual changes (136d249ef7dbf0fefa292082cc40be1ea864cbd6) that I don't know if you are comfortable putting in stable tree.

Quoted 8 lines

Quoted 4 lines
I have no idea what that git commit id referrs to, as it's not in Linus's tree at the moment.
Care to give me a subject? diffstat? Some kind of hint?
Greg, Konrad is referring to:
commit 73d63d038ee9f769f5e5b46792d227fe20e442c5

Ok, then where did the 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 number come from? And where was I supposed to be able to determine what it is pointing to?

Come on people...

Quoted 10 lines

Author: Suresh Siddha <[email protected]>
Date:   Mon Mar 12 11:36:33 2012 -0700
x86/ioapic: Add register level checks to detect bogus io-apic entries
With out this commit, if the bios lists bogus io-apic's, then we will see some error messages ("Unable to reset IRR for apic")during linux boot which are benign. But as this patch breaks Xen, I am ok if these don't get applied to 'stable'. Also I think it is Ingo who added the 'stable' tag. Ingo, are you ok with this?

What stable trees did this already go into in the releases today?

You need to tell me what I need to revert here, SPECIFICALLY, and in what tree, if needed, otherwise I have no idea what is going on, sorry, I can't read minds.

Quoted 1 line

For the mainline, we have queued more patches to fix the Xen breakage.

And what is that supposed to mean to me?

Again, help me out here, this is making no sense at all.

How am I supposed to "not apply" a patch that I have never heard of? And how am I supposed to "not apply" a patch that I have already applied?

How about you all start over from the beginning and tell me EXACTLY what you want me to do here, because I sure as heck don't know what is going on...

confused,

greg k-h

Konrad Rzeszutek Wilk

author

2012-04-03 13:04 UTC #5 lore raw

Quoted 16 lines · Greg KH

Quoted 15 lines · Suresh Siddha
Quoted 13 lines · Greg KH
Quoted 7 lines · Konrad Rzeszutek Wilk
Hey Greg,
The git commit 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 has CC [email protected] but it breaks Xen - we are working to fix it in 3.4, but the fix for it does some architectual changes (136d249ef7dbf0fefa292082cc40be1ea864cbd6) that I don't know if you are comfortable putting in stable tree.
I have no idea what that git commit id referrs to, as it's not in Linus's tree at the moment.
Care to give me a subject? diffstat? Some kind of hint?

Quoted 7 lines

Quoted 3 lines
Greg, Konrad is referring to:
commit 73d63d038ee9f769f5e5b46792d227fe20e442c5
Ok, then where did the 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 number come from? And where was I supposed to be able to determine what it is pointing to?

Hm, somehow that is the git commit I saw, but it probably was b/c it got cherrypicked in my testing tree.

Quoted 8 lines

Come on people...
Quoted 5 lines
Author: Suresh Siddha <[email protected]>
Date:   Mon Mar 12 11:36:33 2012 -0700
x86/ioapic: Add register level checks to detect bogus io-apic entries

Quoted 7 lines

Quoted 5 lines
With out this commit, if the bios lists bogus io-apic's, then we will see some error messages ("Unable to reset IRR for apic")during linux boot which are benign. But as this patch breaks Xen, I am ok if these don't get applied to 'stable'. Also I think it is Ingo who added the 'stable' tag. Ingo, are you ok with this?
What stable trees did this already go into in the releases today?

None. That is why I am sending this advance warning so you don't put it in.

Quoted 11 lines

You need to tell me what I need to revert here, SPECIFICALLY, and in what tree, if needed, otherwise I have no idea what is going on, sorry, I can't read minds.
Quoted 1 line
For the mainline, we have queued more patches to fix the Xen breakage.
And what is that supposed to mean to me?
Again, help me out here, this is making no sense at all.

Quoted 7 lines

How am I supposed to "not apply" a patch that I have never heard of? And how am I supposed to "not apply" a patch that I have already applied?
How about you all start over from the beginning and tell me EXACTLY what you want me to do here, because I sure as heck don't know what is going on...

Heh.

The patch titled "x86/ioapic: Add register level checks to detect bogus io-apic entries" (git commit 73d63d038ee9f769f5e5b46792d227fe20e442c5) that is in v3.4-rc1, even thought it has cc: [email protected], should _NOT_ be applied to the stable tree.

Quoted 4 lines

confused,
greg k-h

Konrad Rzeszutek Wilk

author

2012-04-03 13:28 UTC #6 lore raw

In reply to Greg KH

Quoted 5 lines

Quoted 5 lines
Author: Suresh Siddha <[email protected]>
Date:   Mon Mar 12 11:36:33 2012 -0700
x86/ioapic: Add register level checks to detect bogus io-apic entries

Quoted 7 lines

Quoted 5 lines
With out this commit, if the bios lists bogus io-apic's, then we will see some error messages ("Unable to reset IRR for apic")during linux boot which are benign. But as this patch breaks Xen, I am ok if these don't get applied to 'stable'. Also I think it is Ingo who added the 'stable' tag. Ingo, are you ok with this?
What stable trees did this already go into in the releases today?

I see it in v3.2.x as:
273fb19 x86/ioapic: Add register level checks to detect bogus io-apic entries

And in 3.0.x:
c2ec63e x86/ioapic: Add register level checks to detect bogus io-apic entries

But I don't see it in 3.1.x tree?

Quoted 4 lines

You need to tell me what I need to revert here, SPECIFICALLY, and in what tree, if needed, otherwise I have no idea what is going on, sorry, I can't read minds.

Teck Choon Giam

2012-04-03 14:26 UTC #7 lore raw

Quoted 11 lines · Konrad Rzeszutek Wilk

Quoted 11 lines
Quoted 10 lines
Author: Suresh Siddha <[email protected]>
Date: ï¿½ Mon Mar 12 11:36:33 2012 -0700
ï¿½ ï¿½ x86/ioapic: Add register level checks to detect bogus io-apic entries
With out this commit, if the bios lists bogus io-apic's, then we will see some error messages ("Unable to reset IRR for apic")during linux boot which are benign. But as this patch breaks Xen, I am ok if these don't get applied to 'stable'. Also I think it is Ingo who added the 'stable' tag. Ingo, are you ok with this?

Quoted 7 lines

Quoted 1 line
What stable trees did this already go into in the releases today?
I see it in v3.2.x as:
273fb19 x86/ioapic: Add register level checks to detect bogus io-apic entries
And in 3.0.x:
c2ec63e x86/ioapic: Add register level checks to detect bogus io-apic entries

And does this also affect 3.3.x? I haven't test but guess it will?

# git log | grep -B 5 'x86/ioapic: Add register level checks to detect
bogus io-apic entries'

commit a998dc2fa76f496d2944f0602b920d1d10d7467d

Author: Suresh Siddha <[email protected]>
Date:   Mon Mar 12 11:36:33 2012 -0700

x86/ioapic: Add register level checks to detect bogus io-apic entries

Thanks.

Kindest regards,
Giam Teck Choon

Quoted 11 lines

But I don't see it in 3.1.x tree?
Quoted 4 lines
You need to tell me what I need to revert here, SPECIFICALLY, and in what tree, if needed, otherwise I have no idea what is going on, sorry, I can't read minds.
--
To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected]
More majordomo info at ï¿½http://vger.kernel.org/majordomo-info.html

Konrad Rzeszutek Wilk

author

2012-04-03 14:31 UTC #8 lore raw

Quoted 15 lines · Teck Choon Giam

Quoted 13 lines · Konrad Rzeszutek Wilk
Quoted 12 lines
Quoted 10 lines
Author: Suresh Siddha <[email protected]>
Date: ï¿½ Mon Mar 12 11:36:33 2012 -0700
ï¿½ ï¿½ x86/ioapic: Add register level checks to detect bogus io-apic entries
With out this commit, if the bios lists bogus io-apic's, then we will see some error messages ("Unable to reset IRR for apic")during linux boot which are benign. But as this patch breaks Xen, I am ok if these don't get applied to 'stable'. Also I think it is Ingo who added the 'stable' tag. Ingo, are you ok with this?
What stable trees did this already go into in the releases today?

Quoted 7 lines

Quoted 5 lines
I see it in v3.2.x as:
273fb19 x86/ioapic: Add register level checks to detect bogus io-apic entries
And in 3.0.x:
c2ec63e x86/ioapic: Add register level checks to detect bogus io-apic entries
And does this also affect 3.3.x? I haven't test but guess it will?

Yup!

Quoted 10 lines

# git log | grep -B 5 'x86/ioapic: Add register level checks to detect
bogus io-apic entries'
commit a998dc2fa76f496d2944f0602b920d1d10d7467d
Author: Suresh Siddha <[email protected]>
Date:   Mon Mar 12 11:36:33 2012 -0700
x86/ioapic: Add register level checks to detect bogus io-apic entries

Greg, please also revert this one.

Teck Choon Giam

2012-04-03 14:56 UTC #9 lore raw

Quoted 29 lines · Konrad Rzeszutek Wilk

Quoted 15 lines · Teck Choon Giam
Quoted 13 lines · Konrad Rzeszutek Wilk
Quoted 12 lines
Quoted 10 lines
Author: Suresh Siddha <[email protected]>
Date: ï¿½ Mon Mar 12 11:36:33 2012 -0700
ï¿½ ï¿½ x86/ioapic: Add register level checks to detect bogus io-apic entries
With out this commit, if the bios lists bogus io-apic's, then we will see some error messages ("Unable to reset IRR for apic")during linux boot which are benign. But as this patch breaks Xen, I am ok if these don't get applied to 'stable'. Also I think it is Ingo who added the 'stable' tag. Ingo, are you ok with this?
What stable trees did this already go into in the releases today?
Quoted 7 lines
Quoted 5 lines
I see it in v3.2.x as:
273fb19 x86/ioapic: Add register level checks to detect bogus io-apic entries
And in 3.0.x:
c2ec63e x86/ioapic: Add register level checks to detect bogus io-apic entries
And does this also affect 3.3.x? ï¿½I haven't test but guess it will?
Yup!
Quoted 4 lines
# git log | grep -B 5 'x86/ioapic: Add register level checks to detect
bogus io-apic entries'

Quoted 8 lines

Quoted 6 lines
commit a998dc2fa76f496d2944f0602b920d1d10d7467d
Author: Suresh Siddha <[email protected]>
Date: ï¿½ Mon Mar 12 11:36:33 2012 -0700
ï¿½ ï¿½ x86/ioapic: Add register level checks to detect bogus io-apic entries
Greg, please also revert this one.

I will include the various tree commit id as below:

linux-3.0.y:
commit c2ec63edaf48c90c3495eeb0b75bb05102fbf71a

Author: Suresh Siddha <[email protected]>
Date:   Mon Mar 12 11:36:33 2012 -0700

x86/ioapic: Add register level checks to detect bogus io-apic entries

linux-3.1.y: Don't have such commit and I guess it is due to EOL before Mar 12

linux-3.2.y:
commit 273fb194e86b795b08a724c7646d0f694949070b

Author: Suresh Siddha <[email protected]>
Date:   Mon Mar 12 11:36:33 2012 -0700

x86/ioapic: Add register level checks to detect bogus io-apic entries

linux-3.3.y:
commit a998dc2fa76f496d2944f0602b920d1d10d7467d

Author: Suresh Siddha <[email protected]>
Date:   Mon Mar 12 11:36:33 2012 -0700

x86/ioapic: Add register level checks to detect bogus io-apic entries

Thanks.

Kindest regards,
Giam Teck Choon