bootm: fix usage of lmb_reserve()
PATCH 1/1 bootm: fix usage of lmb_reserve()
From: Andreas Bie?mann <[email protected]>
commit 44f074c771c4b70d250b0d7ed2f7513488c678bb brakes compiling avr32 boards which do not have CONFIG_LMB. This patch re-add the empty lmb_reserve() define to opt-out respective code parts in do_bootm() and do_bootm_subcommand().
This patch fixes errors like this:
---8<---cmd_bootm.c: In function 'do_bootm_subcommand':
cmd_bootm.c:518: error: 'bootm_headers_t' has no member named 'lmb' cmd_bootm.c: In function 'do_bootm':
cmd_bootm.c:665: error: 'bootm_headers_t' has no member named 'lmb' --->8---
--- common/cmd_bootm.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
common/cmd_bootm.c +2 -0
@@ -186,6 +186,8 @@ static void boot_start_lmb(bootm_headers_t *images) board_lmb_reserve(&images->lmb); }#else +/* we want to opt-out access to images.lmb by precompiler !*/ +# define lmb_reserve (lmb, base, size)static inline void boot_start_lmb (bootm_headers_t *images) { }#endif
Signature · 1 line
1.7.9.1
PATCH 1/1 bootm: fix usage of lmb_reserve()
Hi,
Quoted 6 lines · Andreas Bie?mann
From: Andreas Bie?mann <[email protected]>
commit
44f074c771c4b70d250b0d7ed2f7513488c678bbbrakes compiling avr32 boards which do not haveCONFIG_LMB. This patch re-add the emptylmb_reserve()define to opt-out respective code parts indo_bootm()anddo_bootm_subcommand().
Quoted 7 lines
This patch fixes errors like this:
---8<---cmd_bootm.c: In function 'do_bootm_subcommand':
cmd_bootm.c:518: error: 'bootm_headers_t' has no member named 'lmb'cmd_bootm.c: In function 'do_bootm':
cmd_bootm.c:665: error: 'bootm_headers_t' has no member named 'lmb' --->8---
again days to late and about half an hour unnecessary work ... should really check ML more often.
http://patchwork.ozlabs.org/patch/149924/ was before.
Quoted 10 lines
Signed-off-by Andreas Bie?mann <[email protected]>--- common/cmd_bootm.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)common/cmd_bootm.c +0
-0
common/cmd_bootm.c static void boot_start_lmb(bootm_headers_t *images) · line 189
Quoted 4 lines
common/cmd_bootm.c +1
-0@@ -186,6 +186,8 @@ static void boot_start_lmb(bootm_headers_t *images) board_lmb_reserve(&images->lmb); }#else +/* we want to opt-out access to images.lmb by precompiler !*/
I would like to have some comment like this in the other patch.
regards
Andreas Bie?mann
PATCH 1/1 bootm: fix usage of lmb_reserve()
Dear Andreas Bie?mann,
Quoted 35 lines
Hi,
Quoted 7 lines · Andreas Bie?mann
From: Andreas Bie?mann <[email protected]>
commit
44f074c771c4b70d250b0d7ed2f7513488c678bbbrakes compiling avr32 boards which do not haveCONFIG_LMB. This patch re-add the emptylmb_reserve()define to opt-out respective code parts indo_bootm()anddo_bootm_subcommand().Quoted 7 lines
This patch fixes errors like this:
---8<---cmd_bootm.c: In function 'do_bootm_subcommand':
cmd_bootm.c:518: error: 'bootm_headers_t' has no member named 'lmb'cmd_bootm.c: In function 'do_bootm':
cmd_bootm.c:665: error: 'bootm_headers_t' has no member named 'lmb' --->8---again days to late and about half an hour unnecessary work ... should really check ML more often.
http://patchwork.ozlabs.org/patch/149924/ was before.
Quoted 12 lines
Signed-off-by Andreas Bie?mann <[email protected]>---
common/cmd_bootm.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)common/cmd_bootm.c +0
-0@@ -186,6 +186,8 @@ static void boot_start_lmb(bootm_headers_t *images)
Quoted 8 lines
common/cmd_bootm.c static void boot_start_lmb(bootm_headers_t *images) · line 189
Quoted 6 lines
common/cmd_bootm.c +1
-0board_lmb_reserve(&images->lmb); }#else +/* we want to opt-out access to images.lmb by precompiler !*/ I would like to have some comment like this in the other patch.
Errr ... I believe we should have a subsequent fix that removes the aftereffect of the macro altogether.
Quoted 4 lines
regards
Andreas Bie?mann
Best regards,
Marek Vasut